From 909d4702f22c2976e96bcac309043de02aeba62e Mon Sep 17 00:00:00 2001 From: Davmunrey <108531295+Davmunrey@users.noreply.github.com> Date: Sun, 15 Nov 2026 22:19:46 +0000 Subject: [PATCH] test(javascript): cover array holes, nested spreads and an empty spread before an argument in kill signals Review follow-up: firstRuntimeArgument has separate paths for an array hole, a nested array spread and an empty spread followed by another argument. child.kill(...[, "SIGINT"]) sends SIGTERM, child.kill(...[...["SIGINT"]]) sends SIGINT and child.kill(...[], "SIGKILL") sends SIGKILL; the case now pins all three. --- .../javascriptSemanticAnalysis.native_bindings.test.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/domain/javascript/javascriptSemanticAnalysis.native_bindings.test.ts b/src/domain/javascript/javascriptSemanticAnalysis.native_bindings.test.ts index dc6b9f2832..4ff9b2b07c 100644 --- a/src/domain/javascript/javascriptSemanticAnalysis.native_bindings.test.ts +++ b/src/domain/javascript/javascriptSemanticAnalysis.native_bindings.test.ts @@ -212,6 +212,9 @@ describe("JavaScript semantic analysis: child-process signals", () => { const child = spawn("/bin/tool"); child.kill(...[]); child.kill(...["SIGINT"]); + child.kill(...[, "SIGINT"]); + child.kill(...[...["SIGINT"]]); + child.kill(...[], "SIGKILL"); child.kill(...signals); const literals = ["SIGINT"]; child.kill(...literals); @@ -238,6 +241,9 @@ describe("JavaScript semantic analysis: child-process signals", () => { ).toEqual([ "SIGTERM", "SIGINT", + "SIGTERM", + "SIGINT", + "SIGKILL", null, null, "SIGTERM",