mirror of
https://github.com/morluto/rea.git
synced 2026-11-18 20:53:00 +00:00
fix(javascript): report version-comparison coverage unknown when a source graph cannot tell (#11206)
* fix(javascript): report version-comparison coverage unknown when a source graph cannot tell * refactor(javascript): name the unavailable-graph coverage mapping once * fix(javascript): give the version change graph and its edges the same unknown coverage * fix(javascript): report export-shape comparison coverage unknown when a source graph cannot tell (#11218) * fix(javascript): report export-shape comparison coverage unknown when a source graph cannot tell * test(javascript): keep unknown export-shape coverage beside a truncated projection * fix(javascript): read runtime-reconciliation input coverage once and report unknown when a static graph cannot tell (#11230) * fix(javascript): read runtime-reconciliation input coverage once and report unknown when a static graph cannot tell * fix(javascript): keep a known input truncation beside unknown reconciliation coverage * fix(javascript): report export-shape source omission counts unknown when a side has no projection (#11261) compare_export_shapes reported left/right_omitted_fields and omitted_property_coverage as 0 for a side whose export selection recovered no return-shape projection (missing, ambiguous or unavailable), while the sibling source_omitted_variants already reported null. Add Known<T> (src/domain/known.ts) and read each side's source coverage once through it; the counts are now null (unknown) with a limitation naming why. The runtime-reconciliation graph's omission sum and its parallel 'omissions known' flag become one Known<number> via sumKnownCounts (no output change).
This commit is contained in:
1 parent
8b7829e385
commit
90ce8bae4a
15 files changed
+665
-169
No files matched your search
@@ -5,6 +5,7 @@ import { javascriptSourceRangeSchema } from "./javascriptSourceCoordinates.js";
|
||||
import { evidenceSchema } from "../evidence.js";
|
||||
import { prefixedDigestSchema } from "../digests.js";
|
||||
import { nonEmptyTextSchema } from "../textSchemas.js";
|
||||
import { applicationCoverageStatusSchema } from "./javascriptApplicationEvidenceSchemas.js";
|
||||
|
||||
const evidenceIdSchema = prefixedDigestSchema("ev");
|
||||
const graphIdSchema = prefixedDigestSchema("jag");
|
||||
@@ -175,6 +176,15 @@ export const projectedExportReturnShapesSchema = z
|
||||
});
|
||||
});
|
||||
|
||||
/** A side's source omission count; null when the side has no return-shape projection. */
|
||||
const sourceOmissionCountSchema = z
|
||||
.int()
|
||||
.min(0)
|
||||
.nullable()
|
||||
.describe(
|
||||
"Null (unknown) when the side's export selection recovered no return-shape projection; zero only when the projection omitted none.",
|
||||
);
|
||||
|
||||
const exportCandidateSchema = z.strictObject({
|
||||
node_id: nodeIdSchema,
|
||||
module_path: nonEmptyTextSchema,
|
||||
@@ -283,19 +293,18 @@ export const javaScriptExportShapeComparisonResultSchema = z.strictObject({
|
||||
}),
|
||||
changes: z.array(javaScriptExportShapeComparisonChangeSchema),
|
||||
coverage: z.strictObject({
|
||||
status: z.enum(["complete-within-inputs", "partial", "truncated"]),
|
||||
left_graph_status: z.enum([
|
||||
"complete",
|
||||
/**
|
||||
* `unknown` when either source graph's coverage is unknown or
|
||||
* unavailable; `truncated` and `partial` are known gaps.
|
||||
*/
|
||||
status: z.enum([
|
||||
"complete-within-inputs",
|
||||
"partial",
|
||||
"truncated",
|
||||
"unknown",
|
||||
"unavailable",
|
||||
]),
|
||||
right_graph_status: z.enum([
|
||||
"complete",
|
||||
"partial",
|
||||
"unknown",
|
||||
"unavailable",
|
||||
]),
|
||||
left_graph_status: applicationCoverageStatusSchema,
|
||||
right_graph_status: applicationCoverageStatusSchema,
|
||||
paired_variants: z.int().min(0),
|
||||
unpaired_left_variants: z.int().min(0),
|
||||
unpaired_right_variants: z.int().min(0),
|
||||
@@ -303,10 +312,10 @@ export const javaScriptExportShapeComparisonResultSchema = z.strictObject({
|
||||
omitted_right_variants: z.int().min(0),
|
||||
left_source_omitted_variants: z.int().min(0).nullable(),
|
||||
right_source_omitted_variants: z.int().min(0).nullable(),
|
||||
left_omitted_fields: z.int().min(0),
|
||||
right_omitted_fields: z.int().min(0),
|
||||
left_omitted_property_coverage: z.int().min(0),
|
||||
right_omitted_property_coverage: z.int().min(0),
|
||||
left_omitted_fields: sourceOmissionCountSchema,
|
||||
right_omitted_fields: sourceOmissionCountSchema,
|
||||
left_omitted_property_coverage: sourceOmissionCountSchema,
|
||||
right_omitted_property_coverage: sourceOmissionCountSchema,
|
||||
omitted_candidates: z.int().min(0),
|
||||
omitted_changes: z.int().min(0),
|
||||
}),
|
||||
|
||||
Reference in new issue
Block a user