mirror of
https://github.com/morluto/rea.git
synced 2026-11-22 06:25:44 +00:00
fix(javascript): preserve Webpack slots outside finite writes (#13006)
* fix(javascript): preserve Webpack slots outside finite writes * test(javascript): verify finite Webpack cache writes preserve other slots * test(javascript): separate cache slot controls from external identity
This commit is contained in:
1 parent
e66a27c2f2
commit
91a68a8b7c
3 files changed
+95
-14
No files matched your search
@@ -1,3 +1,4 @@
|
||||
import { createHash } from "node:crypto";
|
||||
import { expect } from "vitest";
|
||||
|
||||
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
||||
@@ -140,3 +141,55 @@ for (const surface of ["CLI", "stdio MCP"] as const) {
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
for (const surface of ["CLI", "stdio MCP"] as const) {
|
||||
cliTest(
|
||||
`retains a Webpack external outside the finite written slots through ${surface}`,
|
||||
async ({ cli }) => {
|
||||
const root = await createTestTempDirectory("rea-webpack-slot-coverage-");
|
||||
const source = `(() => {
|
||||
const table = {
|
||||
1: module => { module.exports = require("electron"); },
|
||||
2: (module, exports, load) => {
|
||||
const electron = load(1);
|
||||
new electron.BrowserWindow({});
|
||||
electron.ipcMain.handle("ready", () => {});
|
||||
}
|
||||
};
|
||||
function load(key) {
|
||||
const module = { exports: {} };
|
||||
table[key](module, module.exports, load);
|
||||
return module.exports;
|
||||
}
|
||||
load.m = table;
|
||||
const key = flag ? 3 : "4";
|
||||
load.m[key] = module => { module.exports = {}; };
|
||||
load(2);
|
||||
})();`;
|
||||
await writeFixtureFiles(root, { "main.cjs": source });
|
||||
const application = await analyzeJavaScriptDirectory(surface, cli, root);
|
||||
expect(application.summary).toMatchObject({ browser_windows: 1 });
|
||||
const windows = application.graph.nodes
|
||||
.filter(({ kind }) => kind === "browser-window")
|
||||
.flatMap(({ observations }) => observations);
|
||||
expect(windows).toContainEqual(
|
||||
expect.objectContaining({
|
||||
evidence: expect.objectContaining({
|
||||
state: "observed",
|
||||
artifact: expect.objectContaining({
|
||||
available: true,
|
||||
sha256: createHash("sha256").update(source).digest("hex"),
|
||||
}),
|
||||
location: expect.objectContaining({
|
||||
available: true,
|
||||
value: expect.objectContaining({
|
||||
source: "main.cjs",
|
||||
start: expect.objectContaining({ line: 6 }),
|
||||
}),
|
||||
}),
|
||||
}),
|
||||
}),
|
||||
);
|
||||
},
|
||||
);
|
||||
}
|
||||
Reference in new issue
Block a user