diff --git a/src/inspector/JavaScriptRuntimeScope.cancellation.test.ts b/src/inspector/JavaScriptRuntimeScope.cancellation.test.ts index 13c9a80857..886d6d16b2 100644 --- a/src/inspector/JavaScriptRuntimeScope.cancellation.test.ts +++ b/src/inspector/JavaScriptRuntimeScope.cancellation.test.ts @@ -81,7 +81,10 @@ import { AnalysisCancelledError } from "../domain/analysisErrorCore.js"; import { listElectronTargetsInputSchema } from "../domain/javascript/electronObservation.js"; import { V8InspectorProvider } from "./V8InspectorProvider.js"; import { startFakeCdpBrowser } from "../../tests/fixtures/fakeCdpBrowser.js"; -import { startFakeV8Inspector } from "../../tests/fixtures/inspector/fakeV8Inspector.js"; +import { + nodeDiscoveryTargetUrl, + startFakeV8Inspector, +} from "../../tests/fixtures/inspector/fakeV8Inspector.js"; import { createNodeDiscoveryTempDirectory } from "../../tests/fixtures/temporaryDirectory.js"; import { isRecord } from "../kernel/isRecord.js"; @@ -118,8 +121,8 @@ it("stops Inspector target authorization after the current stat settles", async await writeFile(extraPath, "// second inert target file\n"); fileAccess.extraPath = extraPath; const fake = await startFakeV8Inspector({ - targetUrl: pathToFileURL(path).href, - additionalTargets: [{ url: pathToFileURL(extraPath).href }], + targetUrl: nodeDiscoveryTargetUrl(path), + additionalTargets: [{ url: nodeDiscoveryTargetUrl(extraPath) }], additionalTargetCount: 1, }); fixtures.push(fake); diff --git a/tests/boundary/inspector/javascriptRuntimeObservation.test.ts b/tests/boundary/inspector/javascriptRuntimeObservation.test.ts index ef6d2c4328..e5f5e8004e 100644 --- a/tests/boundary/inspector/javascriptRuntimeObservation.test.ts +++ b/tests/boundary/inspector/javascriptRuntimeObservation.test.ts @@ -29,7 +29,10 @@ import { } from "../../../src/domain/evidence.js"; import { javascriptRuntimeReconciliationResultSchema } from "../../../src/domain/javascript/javascriptRuntimeReconciliationSchemas.js"; import { parseRuntimeCapture } from "../../../src/domain/javascript/javascriptRuntimeReconciliationCaptureParsing.js"; -import { startFakeV8Inspector } from "../../fixtures/inspector/fakeV8Inspector.js"; +import { + nodeDiscoveryTargetUrl, + startFakeV8Inspector, +} from "../../fixtures/inspector/fakeV8Inspector.js"; import { startFakeCdpBrowser } from "../../fixtures/fakeCdpBrowser.js"; import { createNodeDiscoveryTempDirectory } from "../../fixtures/temporaryDirectory.js"; @@ -274,8 +277,8 @@ test("lists all connectable targets on the selected endpoint across directories" const fixture = await runtimeFixture(); const outside = await temporaryFile("outside.js"); const fake = await startFakeV8Inspector({ - targetUrl: pathToFileURL(fixture.entry).href, - additionalTargets: [{ url: pathToFileURL(outside).href }], + targetUrl: nodeDiscoveryTargetUrl(fixture.entry), + additionalTargets: [{ url: nodeDiscoveryTargetUrl(outside) }], additionalTargetCount: 205, }); try { @@ -396,6 +399,45 @@ test("preserves attachment facts and refuses attached or unconnectable Inspector } }); +// Node reports the raw pathname: spaces and % stay literal, and quotes or +// backslashes become underscores that cannot identify the original path. +test.skipIf(process.platform === "win32")( + "resolves discovery paths with spaces and percent signs but not quote spellings", + async () => { + const root = await createNodeDiscoveryTempDirectory("rea-v8-spelling-"); + const spaced = join(root, "with space %41.js"); + const quoted = join(root, 'with "quote".js'); + await writeFile(spaced, "export {};\n"); + await writeFile(quoted, "export {};\n"); + expect(nodeDiscoveryTargetUrl(spaced)).toBe(`file://${spaced}`); + expect(nodeDiscoveryTargetUrl(quoted)).toBe( + `file://${join(root, "with _quote_.js")}`, + ); + const fake = await startFakeV8Inspector({ + targetUrl: nodeDiscoveryTargetUrl(spaced), + additionalTargets: [{ url: nodeDiscoveryTargetUrl(quoted) }], + }); + try { + const result = await new V8InspectorProvider().listTargets({ + inspector_endpoint: fake.endpoint, + }); + if (!result.ok) throw result.error; + expect(result.value.targets.map(({ location }) => location)).toEqual( + expect.arrayContaining([ + expect.objectContaining({ kind: "file", file_path: spaced }), + { + kind: "unresolved", + reported_url: nodeDiscoveryTargetUrl(quoted), + reason: "unverifiable-file-location", + }, + ]), + ); + } finally { + await fake.close(); + } + }, +); + test("captures complete metadata with two enable commands", async () => { const fixture = await runtimeFixture(); const outside = await temporaryFile("secret.js"); diff --git a/tests/fixtures/inspector/fakeV8Inspector.ts b/tests/fixtures/inspector/fakeV8Inspector.ts index 0b8f4129b5..42261e4404 100644 --- a/tests/fixtures/inspector/fakeV8Inspector.ts +++ b/tests/fixtures/inspector/fakeV8Inspector.ts @@ -2,6 +2,14 @@ import { createServer } from "node:http"; import { WebSocket, WebSocketServer } from "ws"; +/** + * Spell a script pathname the way Node's `/json/list` reports a target URL: + * `file://` plus the raw pathname, with quotes and backslashes replaced by + * underscores. It is not a WHATWG file URL, so spaces and `%` stay literal. + */ +export const nodeDiscoveryTargetUrl = (path: string): string => + `file://${path.replace(/["\\]/gu, "_")}`; + interface InspectorCommand { readonly id: number; readonly method: string;