test: remove duplicate result assertions before throwing guards

src/application/binary/AnalysisProviderRegistry.test.ts

@@ -139,7 +139,6 @@ describe("analysis provider registry: binding failures and cancellation", () =>
     const unsupported = await new AnalysisProviderRegistry([
       candidate("alpha", { available: false }).provider,
     ]).select(ARTIFACT_TARGET, "alpha");
-    expect(unsupported.ok).toBe(false);
     if (unsupported.ok)
       throw new Error("expected unsupported target rejection");
     expect(unsupported.error).toBeInstanceOf(ProviderSelectionError);
@@ -181,7 +180,6 @@ describe("analysis provider registry: binding failures and cancellation", () =>
       });
     }
     const explicit = await automatic.select(ARTIFACT_TARGET, "alpha");
-    expect(explicit.ok).toBe(false);
     if (explicit.ok) throw new Error("expected provider selection rejection");
     expect(explicit.error).toBeInstanceOf(ProviderSelectionError);
     if (explicit.error instanceof ProviderSelectionError)
@@ -213,7 +211,6 @@ describe("analysis provider registry: binding failures and cancellation", () =>
     const explicit = await new AnalysisProviderRegistry([
       failed.provider,
     ]).select(DATABASE_TARGET, "failed");
-    expect(explicit.ok).toBe(false);
     if (explicit.ok) throw new Error("expected provider selection rejection");
     expect(explicit.error).toBeInstanceOf(ProviderSelectionError);
     if (explicit.error instanceof ProviderSelectionError)

src/application/binary/AnalysisSnapshotCache.test.ts

@@ -230,7 +230,6 @@ describe("analysis snapshot cache partitioning", () => {
       ANALYSIS_SNAPSHOT_PROFILE,
       createEvidenceBundle([evidence]),
     );
-    expect(exported.ok).toBe(true);
     if (!exported.ok) throw new Error("snapshot export failed");
     const tampered = structuredClone(exported.value);
     const tamperedEntry = tampered.entries[0];