diff --git a/src/domain/javascript/javascriptSemanticAnalysis.response_certainty.test.ts b/src/domain/javascript/javascriptSemanticAnalysis.response_certainty.test.ts new file mode 100644 index 0000000000..ad597f4f3b --- /dev/null +++ b/src/domain/javascript/javascriptSemanticAnalysis.response_certainty.test.ts @@ -0,0 +1,29 @@ +import { expect, it } from "vitest"; +import { analyzeJavaScriptSemantics } from "./javascriptSemanticAnalysis.js"; + +const consumers = (source: string) => + analyzeJavaScriptSemantics(source).requestOperations.filter( + ({ kind }) => kind === "response-consumer", + ); + +it.each([ + 'let response = await fetch("data:text/plain,original"); response = {text: () => "replacement"}; response.text();', + 'async function load(response) { response.text(); response = await fetch("data:text/plain,original"); }', +])( + "qualifies a response candidate when its request does not prove the receiver: %s", + (source) => { + const result = consumers(source); + expect(result).toMatchObject([{ endpoint: null, resolution: "partial" }]); + expect(result[0]?.linkedRequestIds).toHaveLength(1); + }, +); + +it("keeps a response whose request definitely reaches the read complete", () => { + expect( + consumers( + 'async function load(response) { response = await fetch("data:text/plain,original"); response.text(); }', + ), + ).toMatchObject([ + { endpoint: "data:text/plain,original", resolution: "complete" }, + ]); +}); diff --git a/src/domain/javascript/javascriptSemanticDataEffects.ts b/src/domain/javascript/javascriptSemanticDataEffects.ts index 9d86ae2253..1d88a37615 100644 --- a/src/domain/javascript/javascriptSemanticDataEffects.ts +++ b/src/domain/javascript/javascriptSemanticDataEffects.ts @@ -443,8 +443,7 @@ const collectResponseConsumers = ( .sort(compareUnicodeCodePoints), endpoint: soleWrite ? (uniqueRequest?.operation.endpoint ?? null) : null, fields: [], - resolution: - uniqueRequest === undefined || otherKinds ? "partial" : "complete", + resolution: !soleWrite || otherKinds ? "partial" : "complete", }); }); return output; diff --git a/src/domain/javascript/javascriptSemanticResponseAssignments.test.ts b/src/domain/javascript/javascriptSemanticResponseAssignments.test.ts index 73b39fbdee..d89a76eb20 100644 --- a/src/domain/javascript/javascriptSemanticResponseAssignments.test.ts +++ b/src/domain/javascript/javascriptSemanticResponseAssignments.test.ts @@ -29,7 +29,10 @@ it.each([ (operation) => operation.kind === "response-consumer", ); expect(consumers).toHaveLength(1); - expect(consumers[0]).toMatchObject({ endpoint, resolution: "complete" }); + expect(consumers[0]).toMatchObject({ + endpoint, + resolution: endpoint === null ? "partial" : "complete", + }); expect(consumers[0]?.linkedRequestIds).toEqual([request?.requestId]); }, ); @@ -43,7 +46,7 @@ it("does not prove an incoming response was initialized by a conditional request (operation) => operation.kind === "response-consumer", ), ).toEqual([ - expect.objectContaining({ endpoint: null, resolution: "complete" }), + expect.objectContaining({ endpoint: null, resolution: "partial" }), ]); });