perf(javascript): cache callable result syntax by AST identity (#7508)

Cache direct return/yield source expressions by immutable AST identity for all existing static and semantic consumers. Weak keys bound retention to AST lifetime; mutable analysis facts and Evidence remain unchanged. Refs #6311; full CastleIO analysis still times out.

Validation: 225 focused tests; baseline cache-regression controls; build, serial check:fast and test discovery passed. CastleIO direct-syntax facts equal with 78,272 warm lookups reduced from 2.72-2.81s to 13.0-13.4ms. Complete sourcemap-codec CLI analyses retained byte-identical Evidence; no end-to-end speedup or token reduction claimed.

CI: source 20,888 passed / 15 skipped; seven built-dependent shards, static, docs, package builds, Linux native baseline and real JS recovery CLI/MCP passed. Shard 6 Hermes path-preview failures both reproduce on exact main b9d1a61dd; Portable tests fails downstream. Greptile 5/5, no findings; Codex quota exhausted. Authorized admin bypass for unrelated baseline CI and unchecked human readiness; no human review attestation made.
This commit is contained in:
gensokyo-dev authored and GitHub committed 2026-10-27 22:53:42 +08:00
1 parent 7f90549916
commit a95b83c2b0
2 files changed
+85 -2

No files matched your search

@@ -10,15 +10,25 @@ export interface SemanticCallableResultExpression {
readonly delegated: boolean;
}
// Syntax is immutable across the static and semantic passes. These are source
// expressions, independent of changing binding, mutation or invocation facts.
// Weak keys keep retained results within the lifetime of their parsed AST.
const resultExpressions = new WeakMap<
t.Node,
readonly SemanticCallableResultExpression[]
>();
/** Collect direct result syntax without executing or evaluating a callable. */
export const semanticCallableResultExpressions = (
callable: t.Node,
): readonly SemanticCallableResultExpression[] => {
const cached = resultExpressions.get(callable);
if (cached !== undefined) return cached;
if (
t.isArrowFunctionExpression(callable) &&
!t.isBlockStatement(callable.body)
)
return [
) {
const result: readonly SemanticCallableResultExpression[] = [
{
node: callable.body,
site: callable.body,
@@ -26,6 +36,9 @@ export const semanticCallableResultExpressions = (
delegated: false,
},
];
resultExpressions.set(callable, result);
return result;
}
if (!t.isFunction(callable)) return [];
const output: SemanticCallableResultExpression[] = [];
const pending = childNodes(callable.body).reverse();
@@ -49,6 +62,7 @@ export const semanticCallableResultExpressions = (
});
for (const child of childNodes(node).reverse()) pending.push(child);
}
resultExpressions.set(callable, output);
return output;
};