refactor(domain): compare snapshot targets through one target identity key (#11341)

* refactor(domain): compare snapshot targets through one target identity key

* fix(domain): refuse snapshot targets whose kind their format cannot have
This commit is contained in:
morluto authored and GitHub committed 2026-11-16 03:07:22 +08:00
1 parent 15dc40e2bf
commit aba42b47b9
7 files changed
+301 -76

No files matched your search

+53 -1
View File
@@ -1,5 +1,8 @@
import type { DolHeader } from "./gamecubeDol.js";
import type { ZipPackageFormat } from "./zipPackageFormat.js";
import {
ZIP_PACKAGE_FORMATS,
type ZipPackageFormat,
} from "./zipPackageFormat.js";
/** Provider-neutral CPU families detected from headers or explicitly selected raw loads. */
export const BINARY_ARCHITECTURES = [
@@ -336,6 +339,55 @@ export type BinaryTarget =
readonly format: "plist" | "javascript" | "source-map";
});
/** The kind of every target variant that may carry `Format`. */
type TargetKindOf<Format> = BinaryTarget extends infer Target
? Target extends { readonly format: infer Formats; readonly kind: infer Kind }
? Format extends Formats
? Kind
: never
: never
: never;
/**
* The one kind each target format has. A target, snapshot or identity whose
* kind disagrees with its format is malformed.
*/
export const BINARY_TARGET_FORMAT_KINDS = {
"analysis-database": "database",
"mach-o": "executable",
"mach-o-universal": "executable",
elf: "executable",
pe: "executable",
"dos-mz": "executable",
"dos-com": "executable",
"raw-binary": "executable",
"gamecube-dol": "executable",
...(Object.fromEntries(
ZIP_PACKAGE_FORMATS.map((format) => [format, "archive"]),
) as Record<ZipPackageFormat, "archive">),
asar: "archive",
ines: "archive",
"godot-pck": "archive",
unityfs: "archive",
wxapkg: "archive",
uimage: "archive",
dmg: "archive",
pkg: "archive",
"intel-hex": "archive",
srec: "archive",
"esp-image": "archive",
uf2: "archive",
dfuse: "archive",
"esp-flash-image": "archive",
fit: "archive",
"ntfs-mft": "archive",
plist: "artifact",
javascript: "artifact",
"source-map": "artifact",
} as const satisfies {
readonly [Format in BinaryTarget["format"]]: TargetKindOf<Format>;
};
/** Caller inputs that select how an ESP flash dump is read. */
export interface EspFlashTargetSelection {
/** The caller selected the format, so the table scan runs without a bootloader. */