refactor(provider): declare deep capabilities from source (#892)

scripts/lib/catalog-builders.mjs

@@ -96,6 +96,21 @@ export const toolFamilyCatalog = (sources) => {
 
 /** Build provider identities with their sorted capability names. */
 export const providerCatalog = (sources) => {
+  const contractsByName = new Map(
+    sources.toolContracts.TOOL_CONTRACTS.map((contract) => [
+      contract.name,
+      contract,
+    ]),
+  );
+  const declaredContracts = (providerId, operations) =>
+    operations.map((operation) => {
+      const contract = contractsByName.get(operation);
+      if (contract === undefined)
+        throw new TypeError(
+          `Provider ${providerId} declares an unknown analyst operation: ${operation}`,
+        );
+      return contract;
+    });
   const {
     applicationContracts,
     reconciliationContracts,
@@ -105,15 +120,21 @@ export const providerCatalog = (sources) => {
   return [
     {
       identity: sources.hopperProvider.HOPPER_PROVIDER_IDENTITY,
-      contracts: sources.hopperProvider.HOPPER_PROVIDER_TOOL_CONTRACTS,
+      contracts: declaredContracts(
+        "hopper",
+        sources.hopperProvider.HOPPER_OPERATIONS,
+      ),
     },
     {
       identity: sources.ghidraProvider.GHIDRA_PROVIDER_IDENTITY,
-      contracts: sources.ghidraProvider.GHIDRA_PROVIDER_TOOL_CONTRACTS,
+      contracts: declaredContracts(
+        "ghidra",
+        sources.ghidraProvider.GHIDRA_OPERATIONS,
+      ),
     },
     {
       identity: sources.idaProvider.IDA_PROVIDER_IDENTITY,
-      contracts: sources.idaProvider.IDA_PROVIDER_TOOL_CONTRACTS,
+      contracts: declaredContracts("ida", sources.idaProvider.IDA_OPERATIONS),
     },
     {
       identity: sources.nativeProvider.NATIVE_MACOS_PROVIDER_IDENTITY,

scripts/lib/catalog-core.mjs

@@ -59,8 +59,8 @@ const SOURCE_PATHS = {
     "dist/contracts/javascriptRecoveryToolContracts.js",
   javascriptRecoveryProvider: "dist/javascript/recovery/WakaruRelease.js",
   supportedClients: "dist/application/SupportedClients.js",
-  hopperProvider: "dist/hopper/HopperProvider.js",
-  ghidraProvider: "dist/ghidra/GhidraProvider.js",
+  hopperProvider: "dist/hopper/HopperProviderCapabilities.js",
+  ghidraProvider: "dist/ghidra/GhidraProviderCapabilities.js",
   idaProvider: "dist/ida/IdaProviderCapabilities.js",
   nativeProvider: "dist/native/NativeMacOSProviderMetadata.js",
   artifactProviders: "dist/application/InvestigationProviders.js",

scripts/lib/module-boundaries.d.mts

@@ -7,7 +7,8 @@ export interface ModuleBoundaryViolation {
   readonly boundary:
     | "pure-layer"
     | "application-composition"
-    | "provider-construction";
+    | "provider-construction"
+    | "provider-generated-catalog";
 }
 
 /** Check resolved source ownership, including type imports and reexports. */

scripts/lib/module-boundaries.mjs

@@ -13,6 +13,13 @@ const MIGRATED_PROVIDER_ROOTS = new Set([
   "inspector",
   "javascript",
 ]);
+const PROVIDER_ROOTS = new Set([
+  ...MIGRATED_PROVIDER_ROOTS,
+  "artifacts",
+  "browser",
+  "dotnet",
+  "native",
+]);
 
 const repositoryPath = (root, path) =>
   relative(root, path).replaceAll("\\", "/");
@@ -53,6 +60,11 @@ const failedBoundary = (file, target) => {
   if (!file.startsWith("src/") || !target.startsWith("src/")) return undefined;
   const layer = file.split("/")[1];
   const targetLayer = target.split("/")[1];
+  if (
+    PROVIDER_ROOTS.has(layer) &&
+    /^src\/generatedMcpToolCatalog\.(?:js|ts)$/u.test(target)
+  )
+    return "provider-generated-catalog";
   if (PURE_LAYERS.has(layer)) {
     if (
       (/^src\/[^/]+\//u.test(target) && !PURE_LAYERS.has(targetLayer)) ||