fix(javascript): complete large-ASAR analysis with file-local projection (#1055)

src/application/javascript/JavaScriptSemanticGraphChildProcessProjection.ts

@@ -5,10 +5,9 @@ import type {
   JavaScriptSemanticChildProcessSpawn,
 } from "../../domain/javascript/javascriptSemanticIr.js";
 import {
-  addSemanticGraphNode,
+  retainSemanticGraphNode,
   addSemanticGraphRelation,
   addSemanticGraphUnknown,
-  constructSemanticGraphNode,
 } from "./JavaScriptSemanticGraphConstruction.js";
 import { unknownSemanticEvidence } from "./JavaScriptSemanticGraphEvidence.js";
 import {
@@ -53,31 +52,23 @@ const addChildProcessNode = (
   context: SemanticFlowProjectionContext,
   spawn: JavaScriptSemanticChildProcessSpawn,
 ): JavaScriptSemanticGraphNode | null =>
-  addSemanticGraphNode(
-    context.state,
-    constructSemanticGraphNode(
-      context.file,
-      {
-        kind: "child-process",
-        roleKey: spawn.processId,
-        location: spawn.location,
-        label: spawn.command ?? spawn.method,
-        functionNodeId:
-          spawn.ownerCallableId === null
-            ? null
-            : (context.callableNodes.get(spawn.ownerCallableId)?.node_id ??
-              null),
-        properties: {
-          argv_count: spawn.argvCount,
-          command: spawn.command,
-          environment_supplied: spawn.environmentSupplied,
-          method: spawn.method,
-          stdio_mode: spawn.stdioMode,
-        },
-      },
-      context.state,
-    ),
-  );
+  retainSemanticGraphNode(context.state, context.file, {
+    kind: "child-process",
+    roleKey: spawn.processId,
+    location: spawn.location,
+    label: spawn.command ?? spawn.method,
+    functionNodeId:
+      spawn.ownerCallableId === null
+        ? null
+        : (context.callableNodes.get(spawn.ownerCallableId)?.node_id ?? null),
+    properties: {
+      argv_count: spawn.argvCount,
+      command: spawn.command,
+      environment_supplied: spawn.environmentSupplied,
+      method: spawn.method,
+      stdio_mode: spawn.stdioMode,
+    },
+  });
 
 const projectSpawn = (
   context: SemanticFlowProjectionContext,
@@ -141,21 +132,14 @@ const addStdioNode = (
   spawn: JavaScriptSemanticChildProcessSpawn,
   child: JavaScriptSemanticGraphNode,
 ): JavaScriptSemanticGraphNode | null =>
-  addSemanticGraphNode(
-    context.state,
-    constructSemanticGraphNode(
-      context.file,
-      {
-        kind: "stdio",
-        roleKey: `stdio:${spawn.processId}`,
-        location: spawn.location,
-        label: spawn.stdioMode,
-        functionNodeId: child.function_node_id,
-        properties: { mode: spawn.stdioMode },
-      },
-      context.state,
-    ),
-  );
+  retainSemanticGraphNode(context.state, context.file, {
+    kind: "stdio",
+    roleKey: `stdio:${spawn.processId}`,
+    location: spawn.location,
+    label: spawn.stdioMode,
+    functionNodeId: child.function_node_id,
+    properties: { mode: spawn.stdioMode },
+  });
 
 const projectInteraction = (
   context: SemanticFlowProjectionContext,
@@ -204,52 +188,38 @@ const addChildListenerNode = (
   context: SemanticFlowProjectionContext,
   interaction: JavaScriptSemanticChildProcessInteraction,
 ): JavaScriptSemanticGraphNode | null =>
-  addSemanticGraphNode(
-    context.state,
-    constructSemanticGraphNode(
-      context.file,
-      {
-        kind: "listener",
-        roleKey: interaction.interactionId,
-        location: interaction.listenerLocation ?? interaction.location,
-        label: interaction.eventName,
-        functionNodeId:
-          interaction.ownerCallableId === null
-            ? null
-            : (context.callableNodes.get(interaction.ownerCallableId)
-                ?.node_id ?? null),
-        properties: {
-          event_name: interaction.eventName,
-          method: interaction.method,
-        },
-      },
-      context.state,
-    ),
-  );
+  retainSemanticGraphNode(context.state, context.file, {
+    kind: "listener",
+    roleKey: interaction.interactionId,
+    location: interaction.listenerLocation ?? interaction.location,
+    label: interaction.eventName,
+    functionNodeId:
+      interaction.ownerCallableId === null
+        ? null
+        : (context.callableNodes.get(interaction.ownerCallableId)?.node_id ??
+          null),
+    properties: {
+      event_name: interaction.eventName,
+      method: interaction.method,
+    },
+  });
 
 const addSignalNode = (
   context: SemanticFlowProjectionContext,
   interaction: JavaScriptSemanticChildProcessInteraction,
 ): JavaScriptSemanticGraphNode | null =>
-  addSemanticGraphNode(
-    context.state,
-    constructSemanticGraphNode(
-      context.file,
-      {
-        kind: "signal",
-        roleKey: interaction.interactionId,
-        location: interaction.location,
-        label: interaction.signalName,
-        functionNodeId:
-          interaction.ownerCallableId === null
-            ? null
-            : (context.callableNodes.get(interaction.ownerCallableId)
-                ?.node_id ?? null),
-        properties: { signal_name: interaction.signalName },
-      },
-      context.state,
-    ),
-  );
+  retainSemanticGraphNode(context.state, context.file, {
+    kind: "signal",
+    roleKey: interaction.interactionId,
+    location: interaction.location,
+    label: interaction.signalName,
+    functionNodeId:
+      interaction.ownerCallableId === null
+        ? null
+        : (context.callableNodes.get(interaction.ownerCallableId)?.node_id ??
+          null),
+    properties: { signal_name: interaction.signalName },
+  });
 
 const addChildUnknown = (input: ChildUnknownInput): void => {
   const { context, node, location, relationKinds, detail, candidateNodeIds } =