From bd70cf94ffa82dc52c1d0b31132992932f852474 Mon Sep 17 00:00:00 2001 From: RRFZ <247457381+Plastic-time@users.noreply.github.com> Date: Thu, 19 Nov 2026 20:12:28 -0500 Subject: [PATCH] perf(desktop): compare complete RGBA pixels in the screenshot readiness check (#12633) --- scripts/verify/baselines/raw-buffer-read.json | 1 - src/domain/pngVisualDiff.test.ts | 7 +++++++ src/domain/pngVisualDiff.ts | 6 ++---- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/scripts/verify/baselines/raw-buffer-read.json b/scripts/verify/baselines/raw-buffer-read.json index 73cf8ee492..1a8e6b97f8 100644 --- a/scripts/verify/baselines/raw-buffer-read.json +++ b/scripts/verify/baselines/raw-buffer-read.json @@ -7,7 +7,6 @@ "src/domain/native/elfPointerRelocations.ts": 6, "src/domain/native/nativeAotPe.ts": 10, "src/domain/native/readBinaryContainer.ts": 1, - "src/domain/pngVisualDiff.ts": 2, "src/ghidra/extensions/GhidraExtensions.ts": 1, "src/il2cpp/Il2cppBinaryImage.ts": 2, "src/il2cpp/Il2cppBinaryRegistration.ts": 8, diff --git a/src/domain/pngVisualDiff.test.ts b/src/domain/pngVisualDiff.test.ts index 7ad2d4daf2..2b07d5f14b 100644 --- a/src/domain/pngVisualDiff.test.ts +++ b/src/domain/pngVisualDiff.test.ts @@ -199,6 +199,13 @@ describe("PNG visual diff", () => { }); describe("isOneColourPng", () => { + it("accepts a single pixel and detects an alpha change at the row boundary", () => { + const pixel = [15, 35, 55, 75]; + expect(isOneColourPng(png(1, 1, pixel).toString("base64"))).toBe(true); + const pixels = [...pixel, ...pixel, 15, 35, 55, 76, ...pixel]; + expect(isOneColourPng(png(2, 2, pixels).toString("base64"))).toBe(false); + }); + it("tells a one-colour frame from a drawn one, and an unreadable one from both", () => { const base64 = (pixels: readonly number[]) => png(2, 2, pixels).toString("base64"); diff --git a/src/domain/pngVisualDiff.ts b/src/domain/pngVisualDiff.ts index 4b9250b06c..1b8ca1808e 100644 --- a/src/domain/pngVisualDiff.ts +++ b/src/domain/pngVisualDiff.ts @@ -117,10 +117,8 @@ export const isOneColourPng = (dataBase64: string): boolean | undefined => { } catch { return undefined; } - const first = rgba.readUInt32BE(0); - for (let offset = 4; offset < rgba.length; offset += 4) - if (rgba.readUInt32BE(offset) !== first) return false; - return true; + // A uniform frame matches itself shifted by one RGBA pixel. + return rgba.subarray(4).equals(rgba.subarray(0, -4)); }; const parsePng = (