From c1de510702d2e9678f9d7b82d2303809e348fa7c Mon Sep 17 00:00:00 2001 From: morluto <76467478+morluto@users.noreply.github.com> Date: Thu, 19 Nov 2026 19:48:03 -0500 Subject: [PATCH] fix(javascript): retain read proof across inactive destructuring defaults (#12613) fix(javascript): retain destructuring proof across inactive defaults --- ...vaScriptSemanticGraphDestructuring.test.ts | 54 ++++++++++++++++++- .../javascript/javascriptSemanticObjects.ts | 27 ++++++---- .../javascriptSemanticReferenceSources.ts | 2 +- .../javascriptDestructuringEvidence.test.ts | 2 +- 4 files changed, 73 insertions(+), 12 deletions(-) diff --git a/src/application/javascript/JavaScriptSemanticGraphDestructuring.test.ts b/src/application/javascript/JavaScriptSemanticGraphDestructuring.test.ts index 00c1577220..43fb5f89ea 100644 --- a/src/application/javascript/JavaScriptSemanticGraphDestructuring.test.ts +++ b/src/application/javascript/JavaScriptSemanticGraphDestructuring.test.ts @@ -768,7 +768,11 @@ it.each([ "Object.setPrototypeOf(config, { *[Symbol.iterator]() { yield 2; } }); const [selected] = config;", "candidate", ], - ["earlier default", "const [value = 0, selected] = config;", "candidate"], + [ + "earlier inactive default", + "const [value = 0, selected] = config;", + "resolved", + ], [ "earlier setter", "let selected; const target = { set value(_) { config[1] = 2; } }; [target.value, selected] = config;", @@ -2061,6 +2065,12 @@ it.each([ ["items", "0"], "candidate", ], + [ + "a defined own object property skips a default", + 'let touched=0;const box={first:false,items:["one"]};const {first:used=(touched=1),items:[selected]}=box;box.items[0]="later";', + ["items", "0"], + "resolved", + ], [ "second nested iterator after an effectful first default", 'const box={first:[undefined],items:["one"]};const {first:[used=(box.items[0]="default")],items:[selected]}=box;box.items[0]="later";', @@ -2207,6 +2217,48 @@ it.each([ ["0", "0"], "candidate", ], + [ + "a defined scalar skips a default before an inner array", + 'let touched=0;const pairs=[0,["first"]];const [unused=(touched=1),[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "resolved", + ], + [ + "null skips a default and keeps the next inner array read", + 'const pairs=[null,["first"]];const [unused="default",[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "resolved", + ], + [ + "a present inner array skips its fallback", + 'const pairs=[[0],["first"]];const [[unused]=[],[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "resolved", + ], + [ + "an unknown value may activate the default before an inner array", + 'const pairs=[unknown(),["first"]];const [unused="default",[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "candidate", + ], + [ + "void activates the default before an inner array", + 'const pairs=[void 0,["first"]];const [unused="default",[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "candidate", + ], + [ + "an earlier replacement may activate the default", + 'const pairs=[0,["first"]];pairs[0]=undefined;const [unused="default",[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "candidate", + ], + [ + "a default inside a destructuring assignment", + 'const pairs=[0,["first"]];let unused,selected;[unused="default",[selected]]=pairs;pairs[1][0]="later";', + ["1", "0"], + "candidate", + ], [ "prior ordinary default", 'const pairs=[undefined,["first"]];const [unused=(pairs[1][0]="earlier"),[selected]]=pairs;', diff --git a/src/domain/javascript/javascriptSemanticObjects.ts b/src/domain/javascript/javascriptSemanticObjects.ts index 26f3db9150..45ee036614 100644 --- a/src/domain/javascript/javascriptSemanticObjects.ts +++ b/src/domain/javascript/javascriptSemanticObjects.ts @@ -20,7 +20,10 @@ import { import { traverseJavaScriptValueAst } from "./javascriptSemanticTraversal.js"; import { range } from "./javascriptStaticAnalysisHelpers.js"; import { createSemanticReadPresenceQuery } from "./javascriptSemanticReadPresence.js"; -import { semanticArrayPatternCanResumeAfterClose } from "./javascriptSemanticReferenceSources.js"; +import { + isLexicalPatternDeclaration, + semanticArrayPatternCanResumeAfterClose, +} from "./javascriptSemanticReferenceSources.js"; /** Recover bounded static property reads, writes, spreads, and destructuring. */ export const collectJavaScriptSemanticObjects = ( @@ -140,10 +143,10 @@ const collectMember = ( ); }; -/** An empty object pattern still applies RequireObjectCoercible to its input. */ -const isKnownCoercibleReceiver = (node: t.Node | undefined): boolean => +/** A proved own slot yields its initializer's result, even if that result is null. */ +const isKnownDefinedSource = (node: t.Node | undefined): boolean => node !== undefined && - ((t.isLiteral(node) && !t.isNullLiteral(node)) || + (t.isLiteral(node) || t.isObjectMethod(node) || staticJavaScriptTruthiness(node) === true); @@ -203,10 +206,15 @@ const collectDestructuring = ( // contributes no binding once the shared slot check has run. if (next.pattern === undefined) continue; const occurrence = unwrapJavaScriptExpression(next.pattern).node; - const plainObjectPath = - next.plainObjectPath === true && !t.isAssignmentPattern(occurrence); - if (t.isAssignmentPattern(occurrence)) ownSlot = undefined; - const pattern = t.isAssignmentPattern(occurrence) + const hasDefault = t.isAssignmentPattern(occurrence); + const plainObjectPath = next.plainObjectPath === true && !hasDefault; + if ( + hasDefault && + (!isKnownDefinedSource(selected) || + !isLexicalPatternDeclaration(state.parentsByNode.get(root), state)) + ) + ownSlot = undefined; + const pattern = hasDefault ? unwrapJavaScriptExpression(occurrence.left).node : occurrence; if (t.isObjectPattern(pattern)) { @@ -217,7 +225,8 @@ const collectDestructuring = ( !t.isObjectExpression(selected) && (rootArray || pattern.properties.length !== 0 || - !isKnownCoercibleReceiver(selected))) + t.isNullLiteral(selected) || + !isKnownDefinedSource(selected))) ) ownSlot = undefined; for (const property of pattern.properties.toReversed()) { diff --git a/src/domain/javascript/javascriptSemanticReferenceSources.ts b/src/domain/javascript/javascriptSemanticReferenceSources.ts index a87867b2a8..ff2badbe62 100644 --- a/src/domain/javascript/javascriptSemanticReferenceSources.ts +++ b/src/domain/javascript/javascriptSemanticReferenceSources.ts @@ -91,7 +91,7 @@ const semanticArrayIteratorMayHaveReturnAt = ( ambientPathMayObserveAt(state, pattern, path, "contents"), ); -const isLexicalPatternDeclaration = ( +export const isLexicalPatternDeclaration = ( owner: t.Node | undefined, state: JavaScriptSemanticAnalysisState, ): owner is t.VariableDeclarator => { diff --git a/tests/boundary/cli/javascriptDestructuringEvidence.test.ts b/tests/boundary/cli/javascriptDestructuringEvidence.test.ts index d51b4957bc..4a2a11b05f 100644 --- a/tests/boundary/cli/javascriptDestructuringEvidence.test.ts +++ b/tests/boundary/cli/javascriptDestructuringEvidence.test.ts @@ -143,7 +143,7 @@ cliTest( const { 0: [numericInnerElement] } = numericSource; numericSource[0][0] = "later"; const nestedPairs = [["read-time"], ["sibling"]]; - const [[innerElement], [siblingInnerElement]] = nestedPairs; + const [[innerElement] = ["fallback"], [siblingInnerElement]] = nestedPairs; nestedPairs[0][0] = "later"; nestedPairs[1][0] = "later"; const spreadSource = [...["prefix"], "read-time"];