From c6046d4f29a9d757c65eca37b2357b97fc59c2b2 Mon Sep 17 00:00:00 2001 From: gensokyo-dev Date: Sat, 14 Nov 2026 08:24:09 +0000 Subject: [PATCH] test(adb): drop prose checks for the push guidance fix The testing guide asks for structured facts rather than frozen sentences or banned phrases. The existing mutatesDevice declarations and push receipt assertions already cover the behavior; the doc-comment correction stays. Co-Authored-By: gensokyo-dev Co-Authored-By: Claude Opus 5.5 --- src/adb/AdbProvider.test.ts | 4 ---- src/contracts/toolEffects.test.ts | 8 -------- 2 files changed, 12 deletions(-) diff --git a/src/adb/AdbProvider.test.ts b/src/adb/AdbProvider.test.ts index c73b079999..5d950e0490 100644 --- a/src/adb/AdbProvider.test.ts +++ b/src/adb/AdbProvider.test.ts @@ -1378,10 +1378,6 @@ exit 1`, line.includes("not device-side verified"), ), ).toBe(!verified); - // The device-mutation fact is reported whatever the digest verdict. - expect(result.value.limitations).toContain( - "Push writes a private snapshot of the caller's file to the device", - ); // Unrecognized checksum output stays inspectable instead of being dropped. expect(result.value.rawResult).toEqual( !verified && exit === 0 diff --git a/src/contracts/toolEffects.test.ts b/src/contracts/toolEffects.test.ts index 90a0bd4388..15a57d7164 100644 --- a/src/contracts/toolEffects.test.ts +++ b/src/contracts/toolEffects.test.ts @@ -28,14 +28,6 @@ describe("tool effects", () => { ); }); - it("never advertises one tool as the only device-mutating operation", () => { - // Several tools declare mutatesDevice, so an exclusive claim misleads callers. - const exclusive = TOOL_CONTRACTS.filter(({ description }) => - /\bonly\b[^.!?]*\bmutat/iu.test(description), - ).map(({ name }) => name); - expect(exclusive).toEqual([]); - }); - it("marks foreign execution and device mutation as destructive", () => { const destructive = TOOL_CONTRACTS.filter( ({ effects }) => effects.executesForeignCode || effects.mutatesDevice,