mirror of
https://github.com/morluto/rea.git
synced 2026-11-20 13:45:30 +00:00
fix(javascript): qualify releases after resource method mutation (#10166)
* fix(javascript): qualify releases after resource method mutation * fix(javascript): qualify releases after opaque receiver mutation * fix(javascript): preserve release ordering and mutation facts * fix(javascript): order mutations of fresh resource receivers * fix(javascript): match release mutations to captured receivers * fix(javascript): check delegated release method identity * fix(javascript): track paths back to native resource prototypes * fix(javascript): respect native release member ownership * fix(javascript): retain shared prototype effects across calls * fix(javascript): order release effects after definite acquisition * fix(javascript): preserve prototype effects across receiver replacement * fix(javascript): preserve native release identity across proven effects * fix(javascript): preserve shared prototype uncertainty after opaque calls --------- Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
This commit is contained in:
1 parent
2191896f3b
commit
caab34d0de
8 files changed
+812
-56
No files matched your search
@@ -1,3 +1,4 @@
|
||||
import { builtinResourceReleases } from "./javascriptBuiltinResourceMethods.js";
|
||||
import * as t from "@babel/types";
|
||||
import { semanticKnownSymbolKey } from "./javascriptSemanticPropertyKeys.js";
|
||||
import {
|
||||
@@ -35,6 +36,7 @@ import {
|
||||
clearSemanticValueCaches,
|
||||
evaluateSemanticBinding,
|
||||
evaluateSemanticExpression,
|
||||
evaluateSemanticExpressionProvenance,
|
||||
} from "./javascriptSemanticValues.js";
|
||||
import { semanticContainer } from "./javascriptSemanticSlots.js";
|
||||
import {
|
||||
@@ -1388,14 +1390,18 @@ export function* collectSemanticMemberMutationsSteps(
|
||||
// Stored receiver projections preserve their raw capture authority.
|
||||
// Initializer origins retain the normalized mutation traversal below.
|
||||
retainsInitializers = receiver?.retainsOrigin !== false;
|
||||
// A direct receiver keeps its alias capture. Projected receivers
|
||||
// select their child at the member read, after capturing the root.
|
||||
const receiverAt =
|
||||
current.path.length > 1
|
||||
? (current.memberReadAt ?? current.originAt)
|
||||
: current.originAt;
|
||||
if (effect === "escape")
|
||||
recordBindingEffect(binding.escapedPaths, {
|
||||
path,
|
||||
node: mutation,
|
||||
receiverInitializers,
|
||||
...(current.originAt === undefined
|
||||
? {}
|
||||
: { receiverAt: current.memberReadAt ?? current.originAt }),
|
||||
...(receiverAt === undefined ? {} : { receiverAt }),
|
||||
});
|
||||
else
|
||||
recordBindingEffect(binding.memberWrites, {
|
||||
@@ -1403,9 +1409,7 @@ export function* collectSemanticMemberMutationsSteps(
|
||||
path,
|
||||
node: mutation,
|
||||
receiverInitializers,
|
||||
...(current.originAt === undefined
|
||||
? {}
|
||||
: { receiverAt: current.memberReadAt ?? current.originAt }),
|
||||
...(receiverAt === undefined ? {} : { receiverAt }),
|
||||
...(assignedSources === undefined ? {} : { assignedSources }),
|
||||
});
|
||||
clearSemanticValueCaches(state);
|
||||
@@ -2420,6 +2424,34 @@ const observableMutationPaths = (
|
||||
const selected = pendingExpressions.pop();
|
||||
if (selected === undefined) break;
|
||||
const { expression, observer } = selected;
|
||||
if (
|
||||
t.isCallExpression(expression) ||
|
||||
t.isOptionalCallExpression(expression)
|
||||
) {
|
||||
// Retain possible resource slots from provenance alone. Final built-in
|
||||
// admission depends on the mutations this pass is still collecting.
|
||||
if (
|
||||
evaluateSemanticExpressionProvenance(
|
||||
expression.callee,
|
||||
state,
|
||||
).origins.some(({ specifier, importedPath }) => {
|
||||
const identity = semanticRequireExportsIdentity(
|
||||
specifier,
|
||||
importedPath[0] === "default"
|
||||
? importedPath.slice(1)
|
||||
: importedPath,
|
||||
);
|
||||
return (
|
||||
identity.path.length === 1 &&
|
||||
builtinResourceReleases(
|
||||
identity.specifier,
|
||||
identity.path[0]!,
|
||||
) !== undefined
|
||||
);
|
||||
})
|
||||
)
|
||||
(observer.origins ??= new Set()).add("opaque");
|
||||
}
|
||||
if (t.isFunction(expression))
|
||||
// Keep own-member writes precise without replacing the existing
|
||||
// links to references handed to a function's eventual caller.
|
||||
|
||||
Reference in new issue
Block a user