fix(javascript): honor effective symbolic descriptor values (#7222)

Resolve ordered descriptor values at the shared JavaScript fact owner and preserve uncertain intrinsic writes instead of stale exports. Normalize ordinary method values and reuse canonical primitive, prototype, ambient identity and ordering facts across consumers.

384 selected tests, format/static/docs checks, all final CI jobs and reviews pass. Actual Node controls cover 35 bundles; one possibly repeated factory explicitly stays unknown. Shipped Obsidian selected-source complete Evidence matches base/fixed CLI and MCP, with coverage and resource measurements in the PR.

Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
This commit is contained in:
SII-YDDandgensokyo-dev authored and GitHub committed 2026-10-27 03:08:00 +08:00
1 parent d54f5b07b4
commit d4c511ae6e
12 files changed
+1117 -102

No files matched your search

@@ -6,7 +6,11 @@ import {
indexJavaScriptBindingsSteps,
indexJavaScriptBindingsWithReceiversSteps,
} from "./javascriptSemanticAnalysis.js";
import { completeSemanticSteps } from "./javascriptSemanticTraversal.js";
import {
completeSemanticSteps,
traverseJavaScriptAst,
} from "./javascriptSemanticTraversal.js";
import { createGlobalReferenceReader } from "./javascriptSemanticAmbientWrites.js";
import { parseJavaScriptSource } from "./javascriptSourceParser.js";
it("keeps wrapper module aliases distinct from global-object module properties", () => {
@@ -240,3 +244,96 @@ it("indexes unknown-key stores of fresh objects in linear stored-value work", ()
// earlier value from every later store grows at least quadratically.
expect(work(64)).toBeLessThan(3 * work(32));
});
it.each([
[
"before and after a direct replacement",
"inspect(Object.defineProperty);Object.defineProperty=()=>{};inspect(Object.defineProperty);",
["unmodified", "replacement"],
],
[
"an unrelated property",
"Object.assign=()=>{};inspect(Object.defineProperty);",
["unmodified"],
],
[
"a conditional replacement",
"if(flag)Object.defineProperty=()=>{};inspect(Object.defineProperty);",
["unknown"],
],
[
"a replaced parent",
"Object=input;inspect(Object.defineProperty);",
["unknown"],
],
[
"a lexical shadow",
"const Object={defineProperty(){}};inspect(Object.defineProperty);",
["unrelated"],
],
[
"an unproven alias write",
"const copy=Object;copy.defineProperty=()=>{};inspect(Object.defineProperty);",
["unknown"],
],
[
"a later write in a possibly repeated activation",
"function run(){inspect(Object.defineProperty);Object.defineProperty=()=>{};}",
["unknown"],
],
[
"competing unconditional replacements before a read",
"function run(){Object.defineProperty=()=>{};Object.defineProperty=()=>{};inspect(Object.defineProperty);}",
["replacement"],
],
[
"a repeated activation with a later write",
"function run(){inspect(Object.defineProperty);Object.defineProperty=()=>{};}run();run();",
["unknown"],
],
[
"a replaced global namespace",
"globalThis={Object:{}};globalThis.Object.defineProperty=()=>{};inspect(Object.defineProperty);",
["unknown"],
],
[
"a namespaced replacement read directly",
"globalThis.Object.defineProperty=()=>{};inspect(Object.defineProperty);",
["replacement"],
],
[
"a direct replacement read through the namespace",
"Object.defineProperty=()=>{};inspect(globalThis.Object.defineProperty);",
["replacement"],
],
[
"a namespaced global",
"inspect(globalThis.Object.defineProperty);globalThis.Object.defineProperty=()=>{};inspect(globalThis.Object.defineProperty);",
["unmodified", "replacement"],
],
])(
"retains ordered global-reference facts for %s",
(_label, source, expected) => {
const parsed = parseJavaScriptSource(source, "app.cjs");
if (parsed === null) throw new Error("Expected global-reference fixture");
const state = completeSemanticSteps(
indexJavaScriptBindingsSteps(parsed.program),
);
const read = createGlobalReferenceReader(state, [
"Object",
"defineProperty",
]);
const statuses: string[] = [];
traverseJavaScriptAst(parsed.program, {
enter(node) {
if (
t.isCallExpression(node) &&
t.isIdentifier(node.callee, { name: "inspect" }) &&
t.isNode(node.arguments[0])
)
statuses.push(read(node.arguments[0]).status);
},
});
expect(statuses).toEqual(expected);
},
);