mirror of
https://github.com/morluto/rea.git
synced 2026-11-22 06:25:44 +00:00
fix(javascript): link a response body reader only to a settled fetch (#8028)
* fix(javascript): link a response body reader only to a settled fetch
`collectResponseConsumers` treated any `.json()`/`.text()`/`.arrayBuffer()` on a
binding holding a request result as a response consumer, and gave it the
request's endpoint at `resolution: "complete"`. That holds only for a settled
`fetch`.
Measured on Node 24.22.1:
await fetch(u) -> Response json/text/arrayBuffer = function
fetch(u) unawaited -> Promise json = undefined; pending.json() THROWS TypeError
http.get(u) -> ClientRequest json/text/arrayBuffer = undefined
http.request(u) -> ClientRequest json = undefined; request.text() THROWS TypeError
new WebSocket(u) -> WebSocket socket.json() THROWS TypeError
await http.get(u) -> ClientRequest (await does not help)
So four shapes emitted a resolved "this endpoint's body is read here" fact for a
call that throws before any body is read: an un-awaited fetch, `http.get`,
`http.request`, and a `WebSocket` handshake.
Link only requests that settle to a `Response`: a `fetch` call whose value is
awaited through expression wrappers. A binding that also holds a request kind
without a body reader keeps the consumer a candidate (`partial`) rather than a
proven one, and a binding with no settled fetch emits no consumer at all, which
matches the `collectReleases` / `forkRejectsStdioArray` precedent — the receiver
provably has no such member, so there is no fact to report.
* chore: retrigger title and readiness checks after the title was corrected
This commit is contained in:
1 parent
a97f827469
commit
d5ba7cec60
2 files changed
+119
-2
No files matched your search
@@ -0,0 +1,84 @@
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { analyzeJavaScriptSemantics } from "./javascriptSemanticAnalysis.js";
|
||||
|
||||
/**
|
||||
* Only `fetch` resolves to a `Response`, and only once its promise settles.
|
||||
* `http.request`/`http.get` return a `ClientRequest` and `new WebSocket` a
|
||||
* socket; neither exposes `json`/`text`/`arrayBuffer`, and an un-awaited
|
||||
* `fetch` returns a `Promise`. In every one of those the call throws at the call
|
||||
* site instead of reading a body, so it is not a response consumer.
|
||||
*/
|
||||
const consumersFor = (source: string) =>
|
||||
analyzeJavaScriptSemantics(source)
|
||||
.requestOperations.filter(({ kind }) => kind === "response-consumer")
|
||||
.map(({ method, endpoint, resolution }) => ({
|
||||
method,
|
||||
endpoint,
|
||||
resolution,
|
||||
}));
|
||||
|
||||
it.each([
|
||||
[
|
||||
"an un-awaited fetch",
|
||||
`async function f(){ const res = fetch("https://api.test/x"); return res.json(); }`,
|
||||
],
|
||||
[
|
||||
"an http.get request",
|
||||
`import http from "node:http";
|
||||
function f(){ const req = http.get("https://api.test/x"); return req.json(); }`,
|
||||
],
|
||||
[
|
||||
"an http.request request",
|
||||
`import http from "node:http";
|
||||
function f(){ const req = http.request("https://api.test/x"); return req.text(); }`,
|
||||
],
|
||||
[
|
||||
"a WebSocket handshake",
|
||||
`function f(){ const ws = new WebSocket("wss://api.test/x"); return ws.json(); }`,
|
||||
],
|
||||
])("emits no response consumer for %s", (_name, source) => {
|
||||
expect(consumersFor(source)).toEqual([]);
|
||||
});
|
||||
|
||||
it.each([
|
||||
["json", "json"],
|
||||
["text", "text"],
|
||||
["arrayBuffer", "arrayBuffer"],
|
||||
] as const)("keeps the settled fetch body reader for %s", (_name, method) => {
|
||||
expect(
|
||||
consumersFor(
|
||||
`async function f(){ const res = await fetch("https://api.test/x"); return res.${method}(); }`,
|
||||
),
|
||||
).toEqual([
|
||||
{
|
||||
method,
|
||||
endpoint: "https://api.test/x",
|
||||
resolution: "complete",
|
||||
},
|
||||
]);
|
||||
});
|
||||
|
||||
it("keeps a settled fetch reader through a wrapper expression", () => {
|
||||
expect(
|
||||
consumersFor(
|
||||
`async function f(){ const res = await fetch("https://api.test/x"); return (res).json(); }`,
|
||||
),
|
||||
).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("keeps the fetch candidate when the binding also holds another request", () => {
|
||||
// The mixed binding keeps its fetch link, so the consumer stays a candidate
|
||||
// rather than losing the endpoint entirely.
|
||||
const consumers = consumersFor(`
|
||||
import http from "node:http";
|
||||
async function f(){
|
||||
let res = await fetch("https://api.test/x");
|
||||
res = await http.get("https://api.test/y");
|
||||
return res.json();
|
||||
}
|
||||
`);
|
||||
expect(consumers).toEqual([
|
||||
{ method: "json", endpoint: null, resolution: "partial" },
|
||||
]);
|
||||
});
|
||||
Reference in new issue
Block a user