refactor(binary): group session selection and snapshot ownership (#886)

src/application/binary/AnalysisSnapshotCache.test.ts

@@ -0,0 +1,115 @@
+import { describe, expect, it } from "vitest";
+
+import { createAnalysisProfile } from "../../domain/analysisProfile.js";
+import {
+  ANALYSIS_SNAPSHOT_PROFILE,
+  ANALYSIS_SNAPSHOT_PROVIDER,
+  ANALYSIS_SNAPSHOT_TARGET,
+} from "../../domain/analysisSnapshot.fixture.js";
+import { createEvidence } from "../../domain/evidence.js";
+import { createEvidenceBundle } from "../../domain/evidenceBundle.js";
+import { ok } from "../../domain/result.js";
+import { createAnalysisExecution } from "../AnalysisProvider.js";
+import { AnalysisSnapshotCache } from "./AnalysisSnapshotCache.js";
+
+describe("analysis snapshot cache partitioning", () => {
+  it("returns detached data only from the exact provider/profile partition", () => {
+    const cache = new AnalysisSnapshotCache();
+    const execution = createAnalysisExecution(
+      "main",
+      ANALYSIS_SNAPSHOT_PROVIDER,
+      {
+        analysisProfile: ANALYSIS_SNAPSHOT_PROFILE,
+        rawResult: "main",
+        subject: {
+          path: ANALYSIS_SNAPSHOT_TARGET.path,
+          sha256: ANALYSIS_SNAPSHOT_TARGET.sha256,
+          format: ANALYSIS_SNAPSHOT_TARGET.format,
+          ...(ANALYSIS_SNAPSHOT_TARGET.architecture === undefined
+            ? {}
+            : { architecture: ANALYSIS_SNAPSHOT_TARGET.architecture }),
+        },
+      },
+    );
+    cache.record({
+      target: ANALYSIS_SNAPSHOT_TARGET,
+      profile: ANALYSIS_SNAPSHOT_PROFILE,
+      operation: "address_name",
+      parameters: { address: "0x1000", document: "fixture" },
+      execution,
+    });
+    const evidence = createEvidence(
+      ANALYSIS_SNAPSHOT_TARGET,
+      ANALYSIS_SNAPSHOT_PROVIDER,
+      {
+        operation: "address_name",
+        parameters: { address: "0x1000", document: "fixture" },
+        result: "main",
+        rawResult: "main",
+        analysisProfile: ANALYSIS_SNAPSHOT_PROFILE,
+      },
+    );
+    const exported = cache.export(
+      ANALYSIS_SNAPSHOT_TARGET,
+      ANALYSIS_SNAPSHOT_PROFILE,
+      createEvidenceBundle([evidence]),
+    );
+    expect(exported.ok).toBe(true);
+    if (!exported.ok) throw new Error("snapshot export failed");
+    const tampered = structuredClone(exported.value);
+    const tamperedEntry = tampered.entries[0];
+    if (tamperedEntry === undefined)
+      throw new Error("exported snapshot entry missing");
+    tamperedEntry.execution.result = "changed without Evidence";
+    let mergedEvidence = false;
+    expect(
+      new AnalysisSnapshotCache().import(tampered, undefined, () => {
+        mergedEvidence = true;
+        return ok(0);
+      }).ok,
+    ).toBe(false);
+    expect(mergedEvidence).toBe(false);
+    const entry = exported.value.entries[0];
+    if (entry === undefined) throw new Error("exported snapshot entry missing");
+    Reflect.set(entry.execution, "provider", {
+      id: "forged",
+      name: "Forged",
+      version: "9",
+    });
+    entry.execution.limitations.push("forged");
+
+    expect(
+      cache.lookup(
+        ANALYSIS_SNAPSHOT_TARGET,
+        ANALYSIS_SNAPSHOT_PROFILE,
+        "address_name",
+        { address: "0x1000", document: "fixture" },
+      ),
+    ).toMatchObject({
+      provider: ANALYSIS_SNAPSHOT_PROVIDER,
+      analysisProfile: ANALYSIS_SNAPSHOT_PROFILE,
+      limitations: [expect.stringContaining("local REA analysis snapshot")],
+    });
+    const changedProfile = createAnalysisProfile(ANALYSIS_SNAPSHOT_PROVIDER, {
+      loader: "configured-override",
+    });
+    expect(
+      cache.lookup(ANALYSIS_SNAPSHOT_TARGET, changedProfile, "address_name", {
+        address: "0x1000",
+        document: "fixture",
+      }),
+    ).toBeUndefined();
+    const changedProviderProfile = createAnalysisProfile(
+      { id: "other", name: "Other", version: "1" },
+      { loader: "mach-o-arm64" },
+    );
+    expect(
+      cache.lookup(
+        ANALYSIS_SNAPSHOT_TARGET,
+        changedProviderProfile,
+        "address_name",
+        { address: "0x1000", document: "fixture" },
+      ),
+    ).toBeUndefined();
+  });
+});