mirror of
https://github.com/morluto/rea.git
synced 2026-11-19 21:23:45 +00:00
refactor(errors): read cleanup completion from dependencies instead of pushing it to dependents (#10744)
* refactor(errors): read cleanup completion from dependencies instead of pushing it to dependents AnalysisError.cleanupIncomplete becomes a getter over the error's own unresolved state and its bound dependencies. The WeakRef dependents graph and resolveCleanup's push propagation are removed, and subclasses mark their initial state through markCleanupIncomplete instead of overriding a public mutable field. * fix(errors): settle bound dependencies before binding more A composite whose dependencies had released but whose status was never read stayed incomplete when a later dependency was bound. * refactor(errors): let errors read a lease group's release instead of resolving them (#10759) AnalysisCleanupLeaseGroup no longer calls resolveCleanup() on its error. The error holds the group as a release claim and reads cleanupReleased when asked, so completion follows the lease owner without a push. * chore(verify): count resolveCleanup and bindCleanupDependencies calls so they only shrink (#10763) * refactor(errors): let errors read a lease group's release instead of resolving them AnalysisCleanupLeaseGroup no longer calls resolveCleanup() on its error. The error holds the group as a release claim and reads cleanupReleased when asked, so completion follows the lease owner without a push. * chore(verify): count resolveCleanup and bindCleanupDependencies calls so they only shrink
This commit is contained in:
1 parent
570658e941
commit
dd7597a108
10 files changed
+305
-32
No files matched your search
@@ -4,7 +4,6 @@ import type { AnalysisErrorOptions } from "./analysisErrorBase.js";
|
||||
/** Publication failure retaining its input/output target and cleanup state. */
|
||||
export class WebScriptExportError extends ArtifactOperationError {
|
||||
override readonly userMessage: string;
|
||||
override cleanupIncomplete: boolean;
|
||||
|
||||
constructor(
|
||||
reason: ArtifactOperationError["reason"],
|
||||
@@ -22,7 +21,8 @@ export class WebScriptExportError extends ArtifactOperationError {
|
||||
...(options.residualPaths ?? []),
|
||||
]),
|
||||
]);
|
||||
this.cleanupIncomplete =
|
||||
options.cleanup !== undefined || (options.residualPaths?.length ?? 0) > 0;
|
||||
this.markCleanupIncomplete(
|
||||
options.cleanup !== undefined || (options.residualPaths?.length ?? 0) > 0,
|
||||
);
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user