From e8d22ec9eb6341a51ef9b09fc7b8e44a95fc3fd3 Mon Sep 17 00:00:00 2001 From: morluto <76467478+morluto@users.noreply.github.com> Date: Wed, 14 Oct 2026 09:54:58 +0800 Subject: [PATCH] fix(browser): carry unknown XML ancestry through metadata contracts --- src/browser/CdpCaptureDocuments.test.ts | 14 +++++++++++++- src/browser/CdpCaptureDocuments.ts | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/browser/CdpCaptureDocuments.test.ts b/src/browser/CdpCaptureDocuments.test.ts index 3629516051..fe67f90aa8 100644 --- a/src/browser/CdpCaptureDocuments.test.ts +++ b/src/browser/CdpCaptureDocuments.test.ts @@ -139,7 +139,19 @@ describe("CDP DOM string and namespace validity", () => { { field: "attributeValue", index: 20 }, ] as const)( "omits a node when its $field string index is invalid ($index)", - ({ field, index, malformedString }) => { + ({ + field, + index, + malformedString, + }: { + readonly field: + | "nodeName" + | "nodeValue" + | "attributeName" + | "attributeValue"; + readonly index: number; + readonly malformedString?: boolean; + }) => { const strings: unknown[] = [ origin + "/app", "#document", diff --git a/src/browser/CdpCaptureDocuments.ts b/src/browser/CdpCaptureDocuments.ts index da7eb80192..8aeee7e9a7 100644 --- a/src/browser/CdpCaptureDocuments.ts +++ b/src/browser/CdpCaptureDocuments.ts @@ -561,7 +561,7 @@ interface DomMetadataOptions { readonly nodeName: string; readonly allowedOrigins: ReadonlySet; readonly svgElement: boolean; - readonly xmlDocument: boolean; + readonly xmlDocument: boolean | undefined; readonly xlinkHref: string | undefined; }