fix(javascript): preserve runtime path bytes and Electron ownership (#4941)

* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
2026-11-11 01:13:39 +00:00 · 2026-10-20 17:25:19 +08:00
1 parent d532b18123
commit e9fc8fb30c
@@ -0,0 +1,127 @@
+import { runInNewContext } from "node:vm";
+import { expect, it } from "vitest";
+
+import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
+
+const prefix = "const {app,BrowserWindow}=require('electron');";
+const cases = [
+  {
+    name: "assigned native setter callee",
+    body: "let change;(change=app.setAppPath)('/changed');",
+    possible: true,
+    calls: [1],
+  },
+  {
+    name: "assigned local setter callee",
+    body: "let change;(change=()=>{})('/changed');",
+    possible: false,
+    calls: [0],
+  },
+  {
+    name: "assigned native app receiver",
+    body: "let runtime;(runtime=app).setAppPath('/changed');",
+    possible: true,
+    calls: [1],
+  },
+  {
+    name: "assigned local app receiver",
+    body: "let runtime;(runtime={setAppPath(){}}).setAppPath('/changed');",
+    possible: false,
+    calls: [0],
+  },
+  {
+    name: "logical-or assigned app receiver",
+    body: "let runtime=flag?{setAppPath(){}}:null;(runtime||=app).setAppPath('/changed');",
+    possible: true,
+    calls: [1, 0],
+  },
+  {
+    name: "logical-and assigned app receiver",
+    body: "let runtime=flag?app:null;(runtime&&=app)?.setAppPath('/changed');",
+    possible: true,
+    calls: [0, 1],
+  },
+  {
+    name: "nullish assigned app receiver",
+    body: "let runtime=flag?{setAppPath(){}}:null;(runtime??=app).setAppPath('/changed');",
+    possible: true,
+    calls: [1, 0],
+  },
+  {
+    name: "definite local setter replacement",
+    body: "app.setAppPath=()=>{};app.setAppPath('/changed');",
+    possible: false,
+    calls: [0],
+  },
+  {
+    name: "unchanged native setter",
+    body: "app.setAppPath('/changed');",
+    possible: true,
+    calls: [1],
+  },
+  {
+    name: "conditional setter replacement",
+    body: "if(flag)app.setAppPath=()=>{};app.setAppPath('/changed');",
+    possible: true,
+    calls: [1, 0],
+  },
+  {
+    name: "setter captured before replacement",
+    body: "const change=app.setAppPath;app.setAppPath=()=>{};change('/changed');",
+    possible: true,
+    calls: [1],
+  },
+  {
+    name: "setter captured after replacement",
+    body: "app.setAppPath=()=>{};const change=app.setAppPath;change('/changed');",
+    possible: false,
+    calls: [0],
+  },
+  {
+    name: "setter invoked before replacement",
+    body: "app.setAppPath('/changed');app.setAppPath=()=>{};",
+    possible: true,
+    calls: [1],
+  },
+];
+
+it.each(cases)(
+  "selects the app-path callable for $name",
+  ({ body, possible, calls }) => {
+    const source = `${prefix}${body}new BrowserWindow().loadFile('index.html');`;
+    for (const [index, expected] of calls.entries()) {
+      let changed = 0;
+      const rendered: string[] = [];
+      // Record JavaScript member/capture behavior without executing Electron.
+      runInNewContext(source, {
+        flag: index === 1,
+        require: () => ({
+          app: {
+            setAppPath() {
+              changed += 1;
+            },
+          },
+          BrowserWindow: class {
+            loadFile(file: string) {
+              rendered.push(file);
+            }
+          },
+        }),
+      });
+      expect(changed).toBe(expected);
+      expect(rendered).toEqual(["index.html"]);
+    }
+    const analysis = analyzeJavaScriptStaticSource(source);
+    expect(analysis.parse_error_count).toBe(0);
+    expect(analysis.electron.app_path_changes ?? []).toEqual(
+      possible
+        ? [
+            expect.objectContaining({
+              module_key: null,
+              location: expect.any(Object),
+            }),
+          ]
+        : [],
+    );
+  },
+);