fix(javascript): preserve runtime path bytes and Electron ownership (#4941)

* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
2026-11-15 11:13:21 +00:00 · 2026-10-20 17:25:19 +08:00
1 parent d532b18123
commit e9fc8fb30c
@@ -0,0 +1,141 @@
+import { runInNewContext } from "node:vm";
+
+import { expect, it } from "vitest";
+
+import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
+
+const cases = [
+  [
+    "native source spread",
+    "Object.assign(exports,...[{change:app.setAppPath,app}]);",
+    true,
+  ],
+  [
+    "native target spread",
+    "Object.assign(...[exports,{change:app.setAppPath,app}]);",
+    true,
+  ],
+  [
+    "native call",
+    "Object.assign.call(null,exports,{change:app.setAppPath,app});",
+    true,
+  ],
+  [
+    "native apply",
+    "Object.assign.apply(null,[exports,{change:app.setAppPath,app}]);",
+    true,
+  ],
+  [
+    "captured intrinsic before replacement",
+    "const publish=Object.assign;Object.assign=()=>{};publish(exports,{change:app.setAppPath,app});",
+    true,
+  ],
+  [
+    "replaced intrinsic",
+    "Object.assign=()=>{};Object.assign(exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "replaced call",
+    "Object.assign.call=()=>{};Object.assign.call(null,exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "replaced apply",
+    "Object.assign.apply=()=>{};Object.assign.apply(null,[exports,{change:app.setAppPath,app}]);",
+    false,
+  ],
+  [
+    "replaced Function call",
+    "Function.prototype.call=()=>{};Object.assign.call(null,exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "replaced Function apply",
+    "Function.prototype.apply=()=>{};Object.assign.apply(null,[exports,{change:app.setAppPath,app}]);",
+    false,
+  ],
+  [
+    "native exports",
+    "Object.assign(exports,{change:app.setAppPath,app});",
+    true,
+  ],
+  [
+    "native module exports",
+    "Object.assign(module.exports,{change:app.setAppPath,app});",
+    true,
+  ],
+  [
+    "detached before",
+    "module.exports={};Object.assign(exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "detached after",
+    "Object.assign(exports,{change:app.setAppPath,app});module.exports={};",
+    false,
+  ],
+  [
+    "reconnected",
+    "exports=module.exports={};Object.assign(exports,{change:app.setAppPath,app});",
+    true,
+  ],
+  [
+    "local exports",
+    "const exports={};Object.assign(exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "local Object",
+    "const Object={assign(){}};Object.assign(exports,{change:app.setAppPath,app});",
+    false,
+  ],
+  [
+    "local setter",
+    "app.setAppPath=()=>{};Object.assign(exports,{change:app.setAppPath,app});",
+    false,
+  ],
+] as const;
+
+it.each(cases)(
+  "retains an Object.assign-published setter for %s",
+  (_name, body, possible) => {
+    const defining = `const{app}=require('electron');${body}`;
+    let changed = 0;
+    const module = { exports: {} };
+    runInNewContext(defining, {
+      module,
+      exports: module.exports,
+      require: () => ({ app: { setAppPath: () => changed++ } }),
+    });
+    expect(changed).toBe(0);
+    runInNewContext(
+      "if(typeof change==='function')change.call(app,'./lib');",
+      module.exports,
+    );
+    expect(changed).toBe(possible ? 1 : 0);
+    const analysis = analyzeJavaScriptStaticSource(defining);
+    expect(analysis.parse_error_count).toBe(0);
+    expect((analysis.electron.app_path_changes ?? []).length > 0).toBe(
+      possible,
+    );
+  },
+);
+
+it("retains native source uncertainty when an array iterator is overwritten", () => {
+  const defining =
+    "const{app}=require('electron');const sources=[{change:app.setAppPath,app}];sources[Symbol.iterator]=function*(){yield{change(){},app}};Object.assign(exports,...sources);";
+  let changed = 0;
+  const module = { exports: {} };
+  runInNewContext(defining, {
+    module,
+    exports: module.exports,
+    require: () => ({ app: { setAppPath: () => changed++ } }),
+  });
+  runInNewContext("change.call(app,'./lib');", module.exports);
+  expect(changed).toBe(0);
+  // The static owner does not execute this custom iterator; it must retain the
+  // native origin still present in the source rather than silently drop it.
+  const analysis = analyzeJavaScriptStaticSource(defining);
+  expect((analysis.electron.app_path_changes ?? []).length).toBeGreaterThan(0);
+});