mirror of
https://github.com/morluto/rea.git
synced 2026-11-12 01:41:21 +00:00
fix(javascript): preserve runtime path bytes and Electron ownership (#4941)
* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
This commit is contained in:
ShuaixinHuang authored and GitHub committed
1 parent
d532b18123
commit
e9fc8fb30c
149 files changed
+16881
-988
No files matched your search
@@ -0,0 +1,223 @@
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
import * as t from "@babel/types";
|
||||
import { parseJavaScriptSource } from "./javascriptSourceParser.js";
|
||||
import { indexJavaScriptBindingsWithReceiversSteps } from "./javascriptSemanticAnalysis.js";
|
||||
import { semanticProjectedSourcesAtRead } from "./javascriptSemanticProjectedSources.js";
|
||||
|
||||
const shapes = [
|
||||
{
|
||||
before: "const old={child:{inner:INITIAL}};const box={...old};",
|
||||
shared: "old.child={inner:box.child.inner};",
|
||||
fresh: "old.child={inner:INITIAL};",
|
||||
write: "old.child.inner.SLOT=NEXT;",
|
||||
read: "box.child.inner.READ",
|
||||
},
|
||||
{
|
||||
before: "const old={child:{inner:INITIAL}};const {...box}=old;",
|
||||
shared: "old.child={inner:box.child.inner};",
|
||||
fresh: "old.child={inner:INITIAL};",
|
||||
write: "old.child.inner.SLOT=NEXT;",
|
||||
read: "box.child.inner.READ",
|
||||
},
|
||||
{
|
||||
before: "const old=[{inner:INITIAL}];const box=[...old];",
|
||||
shared: "old[0]={inner:box[0].inner};",
|
||||
fresh: "old[0]={inner:INITIAL};",
|
||||
write: "old[0].inner.SLOT=NEXT;",
|
||||
read: "box[0].inner.READ",
|
||||
},
|
||||
{
|
||||
before: "const old=[{inner:INITIAL}];const [...box]=old;",
|
||||
shared: "old[0]={inner:box[0].inner};",
|
||||
fresh: "old[0]={inner:INITIAL};",
|
||||
write: "old[0].inner.SLOT=NEXT;",
|
||||
read: "box[0].inner.READ",
|
||||
},
|
||||
{
|
||||
before: "const old={child:[INITIAL]};const box={...old};",
|
||||
shared: "old.child=[box.child[0]];",
|
||||
fresh: "old.child=[INITIAL];",
|
||||
write: "old.child[0].SLOT=NEXT;",
|
||||
read: "box.child[0].READ",
|
||||
},
|
||||
] as const;
|
||||
const values = [
|
||||
{
|
||||
initial: "{make:()=>({})}",
|
||||
next: "()=>module",
|
||||
slot: "make",
|
||||
read: "make().require('./shared.cjs')",
|
||||
host: false,
|
||||
},
|
||||
{
|
||||
initial: "{make:()=>module}",
|
||||
next: "()=>({})",
|
||||
slot: "make",
|
||||
read: "make().require('./shared.cjs')",
|
||||
host: true,
|
||||
},
|
||||
{
|
||||
initial: "{loader:{}}",
|
||||
next: "module",
|
||||
slot: "loader",
|
||||
read: "loader.require('./shared.cjs')",
|
||||
host: false,
|
||||
},
|
||||
{
|
||||
initial: "{loader:module}",
|
||||
next: "{}",
|
||||
slot: "loader",
|
||||
read: "loader.require('./shared.cjs')",
|
||||
host: true,
|
||||
},
|
||||
{
|
||||
initial: "{load:()=>({})}",
|
||||
next: "module.require",
|
||||
slot: "load",
|
||||
read: "load('./shared.cjs')",
|
||||
host: false,
|
||||
},
|
||||
{
|
||||
initial: "{load:module.require}",
|
||||
next: "()=>({})",
|
||||
slot: "load",
|
||||
read: "load('./shared.cjs')",
|
||||
host: true,
|
||||
},
|
||||
] as const;
|
||||
|
||||
it.each(
|
||||
shapes.flatMap((shape) =>
|
||||
values.flatMap((value) =>
|
||||
[true, false].map((shared) => ({
|
||||
source: (
|
||||
shape.before +
|
||||
(shared ? shape.shared : shape.fresh) +
|
||||
shape.write +
|
||||
shape.read +
|
||||
";"
|
||||
)
|
||||
.replaceAll("INITIAL", value.initial)
|
||||
.replaceAll("NEXT", value.next)
|
||||
.replaceAll("SLOT", value.slot)
|
||||
.replaceAll("READ", value.read),
|
||||
expression: shape.read.replaceAll("READ", value.read),
|
||||
// The public module/delegate owner retains unknown after the copy's child
|
||||
// escapes into the new parent. Factory result selection can exclude it.
|
||||
expected: shared ? !value.host || value.slot !== "make" : value.host,
|
||||
})),
|
||||
),
|
||||
),
|
||||
)(
|
||||
"distinguishes shared and newly allocated descendant receivers: $source",
|
||||
({ source, expression, expected }) => {
|
||||
const result = analyzeJavaScriptStaticSource(source);
|
||||
expect(result.parse_error_count).toBe(0);
|
||||
expect(
|
||||
result.references.filter(
|
||||
(reference) => reference.expression === expression,
|
||||
),
|
||||
).toEqual(
|
||||
expected
|
||||
? [expect.objectContaining({ kind: "require", specifier: null })]
|
||||
: [],
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
it.each(["module", "{}"])(
|
||||
"selects the later write to a shared projected receiver: %s",
|
||||
(next) => {
|
||||
const parsed = parseJavaScriptSource(
|
||||
`const old={child:{inner:{loader:module}}};const box={...old};old.child={inner:box.child.inner};old.child.inner.loader=${next};box.child.inner.loader.require('./shared.cjs');`,
|
||||
"shared-child.cjs",
|
||||
);
|
||||
if (parsed === null) throw new Error("Expected parsed fixture");
|
||||
const steps = indexJavaScriptBindingsWithReceiversSteps(parsed.program);
|
||||
let step = steps.next();
|
||||
while (!step.done) step = steps.next();
|
||||
const index = step.value;
|
||||
const effects = index.indexMemberMutationFactsSteps();
|
||||
let effect = effects.next();
|
||||
while (!effect.done) effect = effects.next();
|
||||
const binding = [...index.bindings.bindingsById.values()].find(
|
||||
(candidate) => candidate.name === "old",
|
||||
);
|
||||
let capture: t.Node | undefined;
|
||||
let assignment: t.AssignmentExpression | undefined;
|
||||
t.traverseFast(parsed.program, (node) => {
|
||||
if (t.isSpreadElement(node)) capture = node.argument;
|
||||
if (t.isAssignmentExpression(node)) assignment = node;
|
||||
});
|
||||
if (
|
||||
binding === undefined ||
|
||||
capture === undefined ||
|
||||
assignment === undefined
|
||||
)
|
||||
throw new Error("Missing selected receiver");
|
||||
const statement = parsed.program.body.at(-1)!;
|
||||
if (!t.isExpressionStatement(statement))
|
||||
throw new Error("Missing receiver use");
|
||||
const use = statement.expression;
|
||||
expect(
|
||||
semanticProjectedSourcesAtRead(
|
||||
binding,
|
||||
capture,
|
||||
["child", "inner", "loader"],
|
||||
index.bindings,
|
||||
true,
|
||||
use,
|
||||
[{ at: capture, depth: 1 }],
|
||||
),
|
||||
).toEqual([{ node: assignment.right, path: [] }]);
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
"old.child={inner:flag?box.child.inner:{make:()=>({})}};",
|
||||
"old.child={get inner(){return box.child.inner}};",
|
||||
"old.child={...box.child};",
|
||||
])(
|
||||
"retains a possible shared receiver when identity is incomplete: %s",
|
||||
(replacement) => {
|
||||
const expression = "box.child.inner.make().require('./shared.cjs')";
|
||||
const result = analyzeJavaScriptStaticSource(
|
||||
`const old={child:{inner:{make:()=>({})}}};const box={...old};${replacement}old.child.inner.make=()=>module;${expression};`,
|
||||
);
|
||||
expect(result.parse_error_count).toBe(0);
|
||||
expect(result.references).toContainEqual(
|
||||
expect.objectContaining({ kind: "require", specifier: null, expression }),
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
it.each([16, 600])(
|
||||
"bounds descendant receiver alternatives before expanding %i selections",
|
||||
(count) => {
|
||||
const properties = Array.from(
|
||||
{ length: count },
|
||||
(_, index) => `p${index}:{make:()=>({})}`,
|
||||
).join(",");
|
||||
const expression = "box.child.inner.make().require('./shared.cjs')";
|
||||
const result = analyzeJavaScriptStaticSource(
|
||||
`const old={child:{inner:{make:()=>({})}}};const box={...old};old.child={${properties}};old.child[key].make=()=>module;${expression};`,
|
||||
);
|
||||
expect(result.parse_error_count).toBe(0);
|
||||
const limited = result.limitations.some((limitation) =>
|
||||
limitation.includes(
|
||||
"Alias selection expansion was conservatively bounded",
|
||||
),
|
||||
);
|
||||
expect(limited).toBe(count === 600);
|
||||
const selected = result.references.filter(
|
||||
(reference) => reference.expression === expression,
|
||||
);
|
||||
expect(selected).toEqual(
|
||||
count === 600
|
||||
? [expect.objectContaining({ kind: "require", specifier: null })]
|
||||
: [],
|
||||
);
|
||||
},
|
||||
);
|
||||
Reference in new issue
Block a user