mirror of
https://github.com/morluto/rea.git
synced 2026-10-29 10:55:57 +00:00
fix(javascript): preserve runtime path bytes and Electron ownership (#4941)
* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
This commit is contained in:
ShuaixinHuang authored and GitHub committed
1 parent
d532b18123
commit
e9fc8fb30c
149 files changed
+16881
-988
No files matched your search
@@ -0,0 +1,166 @@
|
||||
import { posix } from "node:path";
|
||||
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
|
||||
it.each(["/other", "relative"])(
|
||||
"keeps a shadowed source-directory parameter dynamic: %s",
|
||||
(directory) => {
|
||||
const actual = posix.resolve("/runtime/base", directory, "decoy.cjs");
|
||||
expect(actual).not.toBe("/source/app/decoy.cjs");
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
const path = require('node:path');
|
||||
const {BrowserWindow, utilityProcess} = require('electron');
|
||||
function build(__dirname) {
|
||||
new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,__dirname,'decoy.cjs')}});
|
||||
utilityProcess.fork(path.resolve(runtimeBase,__dirname,'decoy.cjs'));
|
||||
}
|
||||
build(${JSON.stringify(directory)});
|
||||
`);
|
||||
expect(analysis.role_paths).toEqual([]);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: null, preload_resolution_context: null },
|
||||
]);
|
||||
expect(analysis.electron.utility_processes).toMatchObject([
|
||||
{ module_path: null, module_resolution_context: null },
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
const localResolvers = [
|
||||
[
|
||||
"local object",
|
||||
"const helper = {resolve(first) {return first;}};",
|
||||
"helper.resolve",
|
||||
],
|
||||
[
|
||||
"familiar name",
|
||||
"const path = {resolve(first) {return first;}};",
|
||||
"path.resolve",
|
||||
],
|
||||
[
|
||||
"shadowed require",
|
||||
"const require = () => ({resolve(first) {return first;}}); const helper = require('node:path');",
|
||||
"helper.resolve",
|
||||
],
|
||||
[
|
||||
"replaced Node method",
|
||||
"const helper = require('node:path'); helper.resolve = first => first;",
|
||||
"helper.resolve",
|
||||
],
|
||||
[
|
||||
"ambiguous owner",
|
||||
"const helper = flag ? require('node:path') : {resolve(first) {return first;}};",
|
||||
"helper.resolve",
|
||||
],
|
||||
] as const;
|
||||
|
||||
it.each(localResolvers)(
|
||||
"keeps %s resolve calls dynamic",
|
||||
(_name, setup, callee) => {
|
||||
const expression = `${callee}(runtimePath, __dirname, "decoy.cjs")`;
|
||||
const native = new Function(
|
||||
"require",
|
||||
"runtimePath",
|
||||
"__dirname",
|
||||
"flag",
|
||||
`{ ${setup} return ${expression}; }`,
|
||||
);
|
||||
expect(
|
||||
native(
|
||||
() => ({ ...posix }),
|
||||
"/actual/runtime.cjs",
|
||||
"/fixture/app",
|
||||
false,
|
||||
),
|
||||
).toBe("/actual/runtime.cjs");
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
import {BrowserWindow, utilityProcess} from 'electron';
|
||||
${setup}
|
||||
new BrowserWindow({webPreferences:{preload:${expression}}});
|
||||
utilityProcess.fork(${expression});
|
||||
`);
|
||||
expect(analysis.role_paths).toEqual([]);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: null, preload_resolution_context: null },
|
||||
]);
|
||||
expect(analysis.electron.utility_processes).toMatchObject([
|
||||
{ module_path: null, module_resolution_context: null },
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
const nodeResolvers = [
|
||||
["require", "const helper = require('node:path');", "helper.resolve"],
|
||||
[
|
||||
"destructured alias",
|
||||
"const {resolve: select} = require('path');",
|
||||
"select",
|
||||
],
|
||||
[
|
||||
"POSIX namespace",
|
||||
"const helper = require('node:path');",
|
||||
"helper.posix.resolve",
|
||||
],
|
||||
[
|
||||
"POSIX alias",
|
||||
"const {posix: helper} = require('node:path');",
|
||||
"helper.resolve",
|
||||
],
|
||||
[
|
||||
"POSIX module",
|
||||
"const helper = require('node:path/posix');",
|
||||
"helper.resolve",
|
||||
],
|
||||
["default import", "import helper from 'node:path';", "helper.resolve"],
|
||||
[
|
||||
"namespace import",
|
||||
"import * as helper from 'node:path';",
|
||||
"helper.posix.resolve",
|
||||
],
|
||||
["named import", "import {resolve as select} from 'node:path';", "select"],
|
||||
] as const;
|
||||
|
||||
it("does not treat a constructed Node resolver as a path call", () => {
|
||||
expect(() => Reflect.construct(posix.resolve, ["/app", "decoy.cjs"])).toThrow(
|
||||
TypeError,
|
||||
);
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
const helper = require('node:path');
|
||||
const {BrowserWindow} = require('electron');
|
||||
new BrowserWindow({webPreferences:{preload:new helper.resolve(runtimePath,__dirname,'decoy.cjs')}});
|
||||
`);
|
||||
expect(analysis.role_paths).toEqual([]);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: null },
|
||||
]);
|
||||
});
|
||||
|
||||
it.each(nodeResolvers)(
|
||||
"retains proven Node %s right-to-left anchoring",
|
||||
(_name, setup, callee) => {
|
||||
expect(
|
||||
posix.resolve("/actual/runtime.cjs", "/fixture/app", "decoy.cjs"),
|
||||
).toBe("/fixture/app/decoy.cjs");
|
||||
const expression = `${callee}(runtimePath, __dirname, "decoy.cjs")`;
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
const {BrowserWindow, utilityProcess} = require('electron');
|
||||
${setup}
|
||||
new BrowserWindow({webPreferences:{preload:${expression}}});
|
||||
utilityProcess.fork(${expression});
|
||||
`);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{
|
||||
preload_path: "decoy.cjs",
|
||||
preload_resolution_context: "filesystem-expression",
|
||||
},
|
||||
]);
|
||||
expect(analysis.electron.utility_processes).toMatchObject([
|
||||
{
|
||||
module_path: "decoy.cjs",
|
||||
module_resolution_context: "filesystem-expression",
|
||||
},
|
||||
]);
|
||||
},
|
||||
);
|
||||
Reference in new issue
Block a user