From ec7d09176ba48280b9a69c3ce2518bc7a9575d43 Mon Sep 17 00:00:00 2001 From: RRFZ <247457381+Plastic-time@users.noreply.github.com> Date: Mon, 9 Nov 2026 08:46:39 -0500 Subject: [PATCH] fix(mcp): retain partial Playwright trace Evidence on failed imports (#9543) --- .../playwrightTrace.ts | 7 +++- .../applications/playwrightTrace.test.ts | 41 +++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/src/server/registerApplicationTools/playwrightTrace.ts b/src/server/registerApplicationTools/playwrightTrace.ts index 279ff9cd71..7732cdb895 100644 --- a/src/server/registerApplicationTools/playwrightTrace.ts +++ b/src/server/registerApplicationTools/playwrightTrace.ts @@ -42,8 +42,13 @@ export const registerPlaywrightTraceTool = ( contract.name, () => service.inspect(input, context.mcpReq.signal), ); + // A failed import can carry partial Evidence; retain it for views. if (!result.ok) - return server.delivery.toCallToolResult(result, contract); + return server.delivery.toPartialErrorToolResult( + result.error, + contract.returnsTargetContent, + options.recordEvidence, + ); return deliverApplicationEvidence( server, options, diff --git a/tests/acceptance/applications/playwrightTrace.test.ts b/tests/acceptance/applications/playwrightTrace.test.ts index 1e045cbba6..2f1c64fd5f 100644 --- a/tests/acceptance/applications/playwrightTrace.test.ts +++ b/tests/acceptance/applications/playwrightTrace.test.ts @@ -8,6 +8,7 @@ import { playwrightTracePathFixture, } from "../../fixtures/playwrightTrace.js"; import { connectLocalToolsMcp } from "../../fixtures/localToolsMcp.js"; +import { parseMcpToolError } from "../../fixtures/mcpToolError.js"; import { advertisedMcpToolSchemas } from "../../fixtures/advertisedMcpTool.js"; import { parseEvidence, type Evidence } from "../../../src/domain/evidence.js"; import { playwrightTraceSchema } from "../../../src/domain/playwrightTrace/playwrightTrace.js"; @@ -431,3 +432,43 @@ cliTest( expect(requests).toBe(0); }, ); + +cliTest( + "retains partial MCP Evidence when a trace stream fails after earlier streams were read", + async () => { + const fixture = await playwrightTraceFixture({ level: 0 }); + const bytes = await readFile(fixture.path); + // A stored network byte breaks only that member's ZIP CRC. + const offset = bytes.indexOf(Buffer.from('"method":"GET"')); + expect(offset).toBeGreaterThan(0); + bytes[offset + 10] = 80; + await writeFile(fixture.path, bytes); + const { call } = await connectLocalToolsMcp({ + REA_MCP_TOOL_FAMILIES: "application,session", + PLAYWRIGHT_BROWSERS_PATH: "/rea-no-browser-required", + }); + const failed = parseMcpToolError( + await call("inspect_playwright_trace", { + path: fixture.path, + detail: "complete", + }), + ); + const reference = failed.error.details?.partial_observation; + expect(reference).toEqual({ + kind: "retained-evidence", + evidence_id: expect.any(String), + }); + const { evidence_id } = reference as { evidence_id: string }; + const page = await call("inspect_analysis_view", { + source: { kind: "retained-evidence", evidence_id }, + view: { kind: "playwright-trace", collection: "events", fields: [] }, + }); + expect(page.isError, JSON.stringify(page.content)).not.toBe(true); + expect( + parseEvidence(page.structuredContent).normalized_result, + ).toMatchObject({ + coverage: { total: 20, exhausted: true }, + source_coverage: { interpretation: "partial" }, + }); + }, +);