mirror of
https://github.com/morluto/rea.git
synced 2026-11-20 05:32:44 +00:00
fix(javascript): acquire nested iterators from stored receivers (#12542)
* fix(javascript): acquire nested iterators from stored receivers * fix(javascript): preserve stored iterator branches and pattern timing
This commit is contained in:
1 parent
4892615ecb
commit
f5573a0064
8 files changed
+490
-65
No files matched your search
@@ -1484,3 +1484,169 @@ it.each([
|
||||
).toMatchObject({ resolution });
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
[
|
||||
"native replacement before acquisition",
|
||||
closeNextObject,
|
||||
"none=(box.items=[0,box.next]),items:[used]",
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"native replacement after acquisition",
|
||||
closeNextObject,
|
||||
"items:[used],none=(box.items=[0,box.next])",
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"native replacement with no close hook",
|
||||
"",
|
||||
"none=(box.items=[0,box.next]),items:[used]",
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"custom replacement before acquisition",
|
||||
"",
|
||||
"none=(box.items={child:box.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}}),items:[used]",
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"custom replacement after acquisition",
|
||||
"",
|
||||
"items:[used],none=(box.items={child:box.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}})",
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"replacement's iterator updated before acquisition",
|
||||
"",
|
||||
"none=(box.items=[0,box.next]), second=(box.items[Symbol.iterator]=function(){delete this[1].mode;return [0].values();}),items:[used]",
|
||||
"candidate",
|
||||
],
|
||||
] as const)(
|
||||
"captures the nested iterator receiver for %s",
|
||||
(_name, hook, pattern, resolution) => {
|
||||
const graph = graphForJavaScript(`
|
||||
const box={items:[0],next:{mode:"before"}};
|
||||
${hook}
|
||||
const {${pattern},next:{mode:selected}}=box;
|
||||
`);
|
||||
const selected = graph.nodes.find(
|
||||
(n) => n.kind === "binding" && n.label === "selected",
|
||||
);
|
||||
expect(
|
||||
graph.relations.find(
|
||||
(r) =>
|
||||
r.relation === "destructures" &&
|
||||
r.target_node_id === selected?.node_id,
|
||||
),
|
||||
).toMatchObject({ resolution });
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
["two native arms", "flag ? [0,box.next] : [0]", "resolved"],
|
||||
[
|
||||
"a possible custom arm",
|
||||
"flag ? [0,box.next] : {child:box.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}}",
|
||||
"candidate",
|
||||
],
|
||||
[
|
||||
"an inactive custom arm",
|
||||
"false ? {child:box.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}} : [0,box.next]",
|
||||
"resolved",
|
||||
],
|
||||
] as const)(
|
||||
"retains conditional stored acquisition for %s",
|
||||
(_name, store, resolution) => {
|
||||
const graph = graphForJavaScript(`
|
||||
const box={items:[0],next:{mode:"before"}};
|
||||
const {none=(box.items=${store}),items:[used],next:{mode:selected}}=box;
|
||||
`);
|
||||
const binding = graph.nodes.find(
|
||||
(n) => n.kind === "binding" && n.label === "selected",
|
||||
);
|
||||
expect(
|
||||
graph.relations.find(
|
||||
(r) =>
|
||||
r.target_node_id === binding?.node_id &&
|
||||
r.relation === "destructures",
|
||||
),
|
||||
).toMatchObject({ resolution });
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
["native close", closeNextObject, "[0,box.next]", "", "resolved"],
|
||||
[
|
||||
"custom acquisition",
|
||||
"",
|
||||
"{child:box.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}}",
|
||||
"",
|
||||
"resolved",
|
||||
],
|
||||
[
|
||||
"an ordinary prior write",
|
||||
closeNextObject,
|
||||
"[0,box.next]",
|
||||
'write=(box.next.mode="alternate"),',
|
||||
"candidate",
|
||||
],
|
||||
] as const)(
|
||||
"orders sibling reads around stored %s",
|
||||
(_name, hook, store, earlier, before) => {
|
||||
const graph = graphForJavaScript(`
|
||||
const box={items:[0],next:{mode:"initial"}};
|
||||
${hook}
|
||||
const {none=(box.items=${store}),${earlier}next:{mode:before},items:[used],next:{mode:after}}=box;
|
||||
`);
|
||||
for (const [name, resolution] of [
|
||||
["before", before],
|
||||
["after", "candidate"],
|
||||
]) {
|
||||
const binding = graph.nodes.find(
|
||||
(n) => n.kind === "binding" && n.label === name,
|
||||
);
|
||||
expect(
|
||||
graph.relations.find(
|
||||
(r) =>
|
||||
r.target_node_id === binding?.node_id &&
|
||||
r.relation === "destructures",
|
||||
),
|
||||
).toMatchObject({ resolution });
|
||||
}
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
["ordinary property receiver", "box.parent", "candidate"],
|
||||
["parenthesized property receiver", '((box)["parent"])', "candidate"],
|
||||
["unknown receiver key", "box[key]", undefined],
|
||||
] as const)(
|
||||
"recovers a stored nested iterator for %s",
|
||||
(_name, source, resolution) => {
|
||||
const graph = graphForJavaScript(`
|
||||
const box={parent:{items:[0],next:{mode:"before"}}};
|
||||
const replacement={child:box.parent.next,[Symbol.iterator](){delete this.child.mode;return [0].values();}};
|
||||
const {none=(box.parent.items=replacement),items:[used],next:{mode:selected}}=${source};
|
||||
`);
|
||||
const binding = graph.nodes.find(
|
||||
(n) => n.kind === "binding" && n.label === "selected",
|
||||
);
|
||||
const relation = graph.relations.find(
|
||||
(r) =>
|
||||
r.target_node_id === binding?.node_id && r.relation === "destructures",
|
||||
);
|
||||
expect(relation?.resolution).toBe(resolution);
|
||||
if (relation === undefined)
|
||||
expect(
|
||||
graph.unknowns.some(({ relation_kinds }) =>
|
||||
relation_kinds.includes("destructures"),
|
||||
),
|
||||
).toBe(true);
|
||||
else
|
||||
expect(
|
||||
graph.nodes.find(({ node_id }) => node_id === relation.source_node_id)
|
||||
?.properties.property_path,
|
||||
).toEqual(["parent", "next", "mode"]);
|
||||
},
|
||||
);
|
||||
Reference in new issue
Block a user