feat(evm): add retained interface summary delivery (#2308)

Add opt-in EVM MCP summary delivery and retained/portable function and text views. Keep existing complete defaults, provider arguments and original full Evidence identities and records usable. Require retention before selected analysis; preserve inferred candidates, nulls, diagnostics, provenance and explicit unknowns.

Verify old schemas, historical Evidence migration, 64 focused feature checks, 30 affected MCP checks after latest-main rebase, 59 real EVM CLI/MCP cases and six shared-domain artifact workflows. Repeated SDK delivery is smaller; all real model trials and mixed token/time outcomes, limitation failures and resource qualification gaps remain documented without a uniform performance claim.

Refs #2016

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

src/application/analysisView/AnalysisViewService.ts

@@ -102,6 +102,38 @@ export interface AnalysisViewRetention {
   readonly recordEvidence: EvidenceWriter["recordEvidence"] | undefined;
 }
 
+/** Fail before analysis when selected delivery cannot keep its complete source. */
+export const requireAnalysisViewRetention = (
+  operation: string,
+  retention: AnalysisViewRetention,
+): Result<
+  {
+    readonly evidenceById: EvidenceLookup;
+    readonly recordEvidence: EvidenceWriter["recordEvidence"];
+  },
+  AnalysisError
+> => {
+  if (
+    retention.recordEvidence === undefined ||
+    retention.evidenceById === undefined
+  )
+    return err(
+      new AnalysisCapabilityUnavailableError(
+        ANALYSIS_VIEW_PROVIDER.id,
+        operation,
+        "summary detail requires a server session that retains Evidence for later views",
+        {
+          userMessage:
+            "This server does not retain Evidence. Select detail complete to receive the complete analysis inline.",
+        },
+      ),
+    );
+  return ok({
+    evidenceById: retention.evidenceById,
+    recordEvidence: retention.recordEvidence,
+  });
+};
+
 /**
  * Retain complete analysis Evidence in the session, then project its summary
  * view from the retained record. Callers page or select the rest through
@@ -111,29 +143,16 @@ export const summarizeRetainedAnalysis = (
   evidence: Evidence,
   retention: AnalysisViewRetention,
 ): Result<Evidence, AnalysisError> => {
-  if (
-    retention.recordEvidence === undefined ||
-    retention.evidenceById === undefined
-  )
-    return err(
-      new AnalysisCapabilityUnavailableError(
-        ANALYSIS_VIEW_PROVIDER.id,
-        evidence.operation,
-        "summary detail requires a server session that retains Evidence for later views",
-        {
-          userMessage:
-            "This server does not retain Evidence. Select detail complete to receive the complete analysis inline.",
-        },
-      ),
-    );
-  const recorded = retention.recordEvidence(evidence);
+  const ready = requireAnalysisViewRetention(evidence.operation, retention);
+  if (!ready.ok) return ready;
+  const recorded = ready.value.recordEvidence(evidence);
   if (!recorded.ok) return recorded;
   return inspectAnalysisViewValidated(
     {
       source: { kind: "retained-evidence", evidence_id: evidence.evidence_id },
       view: { kind: "summary" },
     },
-    retention.evidenceById,
+    ready.value.evidenceById,
   );
 };