Commit Graph
5374 Commits
Author SHA1 Message Date
morluto 0aee26def4 fix(desktop): share state and window admission with exported verifiers (#12154)
* fix(desktop): share state view admission with the exported verifier

Refs #12133

* fix(desktop): share keyfile syntax with exported state readers

Refs #12141

* fix(desktop): share X11 window property interpretation

Refs #12140
2026-11-18 22:01:30 -05:00
morluto 461cedd73c fix(evidence): recognize misplaced snapshots across bundle readers (#12151)
* fix(evidence): recognize misplaced snapshots across bundle readers

Refs #12126

* docs(evidence): explain recovery for misplaced snapshots
2026-11-18 22:01:18 -05:00
ShuaixinHuangandmorluto b1a390fcee fix(desktop): honor clean env launch prefixes (#12117)
* fix(desktop): honor clean env launch prefixes

* fix(desktop): retain process ownership across env prefixes

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 02:10:50 +00:00
ShuaixinHuangandShuaixinHuang b7059f8866 fix(ci): scope the short SAZ redaction assertion to source data (#12115)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 21:09:23 -05:00
Akshad Jogiandmorluto ae25050dff feat(native): surface inferred prototype instruction conflicts (#8161)
* feat(native): surface inferred prototype instruction conflicts

- Add evidence-backed x86-32 stack-read and stdcall cleanup diagnostics in ReaGhidraBridge.java without rewriting signatures or function bodies.

- Carry prototype conflicts through native API schemas, analysis summaries and retained dossier views so CLI and MCP share the observations.

- Update Ghidra analysis profile digests, documentation and MCP boundary tests for the new diagnostic contract.

* fix(native): follow framed paths and retain zero cleanup conflicts

- Traverse decoded entry-frame paths in ReaGhidraBridge.java instead of stopping at an address-ordered early return, so later reachable reads remain visible.

- Detect explicit, implicit and partial EBP writes and use decoded operands with p-code loads, preventing stale-frame warnings and recognizing real Ghidra stack reads.

- Compare immediate return cleanup with inferred stdcall stack bytes even when either side is zero, and allow zero in the native API contract.

- Add real Ghidra instruction probes and MCP/CI regressions for the reported cases and document the bounded checks.

* fix(native): attribute frame reads before register writes

- Check a decoded stack read before invalidating EBP in ReaGhidraBridge.java so instructions that read and replace the frame still report the conflict.

- Match each candidate operand's address p-code to its LOAD pointer so a POP from ESP into an EBP destination cannot masquerade as an argument read.

- Cover both decoded instruction cases in ReaPrototypeConflictProbe.java and await verifier-owned scratch cleanup on success and failure.

* fix(ghidra): recompute raw profile digests after rebase

- Recompute the 6502 and disabled-analyzer raw-binary profile digests in GhidraRawProfileDigest.test.ts so the pinned values commit to the merged shared policy on current main.

* fix(native): locate the entry frame by address and own verifier cleanup

- Find PUSH EBP; MOV EBP, ESP from the function entry address in ReaGhidraBridge.java so an owned block below the entry cannot hide a reachable argument read.

- Run analyzeHeadless in its own process group and stop that group before removing scratch in verify-ghidra-prototype-conflicts.mjs, so the JVM and decompiler children are addressed as one owned family.

- Cover the lower-owned-block case in ReaPrototypeConflictProbe.java with an entry frame preceded by a decoded lower block.

* fix(native): size prototype fixture and own Ghidra cleanup

- Allocate the instruction fixture through the lower-block offset in verify-ghidra-prototype-conflicts.mjs so the entry frame and decoded block exist for the probe.

- Check the detached process group instead of the leader exit code before cleaning up, so lingering decompiler children receive SIGTERM and SIGKILL before scratch removal.

* fix(native): own Ghidra probe cleanup with shared process owner

- Use REA's ProviderProcessSupervisor and token-verified cleanup in verify-ghidra-prototype-conflicts.mjs so the JVM and descendants are stopped before scratch removal, including failed launches.

- Preserve the source-owned x86 fixture with an entry frame and lower block while asserting verified cleanup.

- Build the pinned verifier dependency graph in the Ghidra bridge CI job and extend its timeout before running the real probe.

* fix(native): end verifier waits on interrupt before cleanup

- Install SIGINT and SIGTERM handlers before spawning Ghidra and abort the wait, so Ctrl-C no longer leaves the detached process group running.

- Keep cleanup handlers installed until the shared process owner reports verified cleanup, then remove scratch only after the process family is stopped.

* fix(native): preserve verifier cleanup interruption errors

- Keep interrupt handlers installed through process cleanup and workspace deletion, then check cancellation before reporting success.

- Preserve and report the failing cleanup step instead of replacing it with an interruption or deleting a tree that may still be unsafe.

* fix(native): retain probe failures across verifier cleanup

- Record the probe error before cleanup so a late SIGINT or SIGTERM cannot replace its stack and captured Ghidra diagnostics.

- Prefer the earlier probe failure when cleanup also fails, while preserving cleanup diagnostics and temporary state for diagnosis.

* test(kuna): raise caller matrix verifier budget for parallel CI

- The multi-target verifier spawn used a 10s timeout while sibling verifier cases use 25s.

- Under 8-way sharded CI load this intermittently exceeded 10s and produced ETIMEDOUT, failing shard 1/8 and portable tests.

- Raise to 30s to match the existing verifier budget and avoid load flakes.

* ci: retrigger checks after transient Ghidra SDK download 403

- The ghidra_bridge lane failed in upstream's untouched SDK acquisition step: curl returned 403 with 0 bytes downloaded in 0.046s from the GitHub release CDN.

- Push an empty commit to start a fresh run because rerunning on the upstream repository requires admin rights.

* fix(native): keep the cleanup lease on combined verifier failures

- Run the prototype-conflict probe through withVerifierFixture so a probe failure and a failed release surface as one AggregateError that keeps the probe error as its cause and attaches the retained fixture as cleanupLeases, instead of throwing the probe error alone and dropping the cleanup owner.

- Report the failed cleanup step and retained project only when the fixture was not released, and keep interrupt handlers installed until release finishes.

* test(native): use shared MCP prototype test deadlines

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 01:55:13 +00:00
170429eb7d feat(ghidra): admit plain MIPS32 PIC shared images (#2362)
* feat(ghidra): admit plain MIPS32 PIC shared images

Add an elf32-dyn-o32-arch32r2-standard-v1 lane for ET_DYN images without
an ASE flag (shared libraries and ET_DYN executables), beside the MIPS16
lane. It reuses the complete dynamic-relocation inspection and admits
R_MIPS_NONE, symbol-bearing R_MIPS_REL32 and the TLS loader slots
DTPMOD32/DTPREL32/TPREL32, which stay unapplied with a limitation.

Ghidra's default moves an image linked at 0 to 0x10000 and then shifts
only nonzero local GOT entries, so page-zero GOT entries (how GNU-ld
libraries call static functions) keep unshifted values and calls through
them decompile to wrong addresses. The lane imports at the image's own
ELF image base instead (lowest PT_LOAD in the first 20 headers, as Ghidra
computes it), commits it in the analysis profile and requires the bridge
handshake to report it. Images with a prelink trailer are refused.

verify:ghidra:mips32-shared checks LE, BE and soft-float LLD fixtures laid
out like GNU ld output against an independent readelf oracle: every
REL32, local GOT entry (including a zero page entry), global GOT entry
(EXTERNAL or lazy-binding stub) and unapplied TLS slot, plus named calls
in the decompilation, snapshot round trip and CLI evidence.

Refs #2338

* style(ghidra): format link-base regression scenarios

* test(ghidra): require zero-valued local GOT coverage

* test(ghidra): cover TPREL32 in the shared lane and drop duplicated session suites

Add an initial-exec TLS variable so the MIPS32 shared fixture declares
R_MIPS_TLS_TPREL32 beside DTPMOD32/DTPREL32, and require all three slots
to stay UNSUPPORTED with unchanged bytes. Remove the soft-float and
mutation handshake suites that the main reconciliation duplicated in
GhidraSessionValues.test.ts.

* test(ghidra): read the section table in the MIPS32 shared-library oracle

parseMipsReadelf now confirms the fixture's section types from readelf -S
(main added -S to the executable, relocatable and PSP oracles). Request it in
the shared-library oracle too.

* test(ghidra): follow main's verifier contracts in the MIPS32 shared lane

Main made the Ghidra installation probe asynchronous behind the shared
inspectVerifierGhidraInstallation helper, and analyze_function now returns a
summary unless detail "complete" is requested. Use both, as the other MIPS
lanes do.

* refactor(ghidra): keep Ghidra's image-base rule out of shared ELF parsing

The shared MIPS ELF reader computed Ghidra's ElfHeader.getImageBase rule
(lowest PT_LOAD address among the first 20 program headers) and the domain
type described it as Ghidra's base. Record source facts instead: every
PT_LOAD virtual address with its program-header index, plus the Android
prelink trailer. ghidraMipsElfImageBase in GhidraMipsProfile now applies
Ghidra's rule to those facts. The committed elf_image_base is unchanged.

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
2026-11-19 01:51:37 +00:00
f10d557f06 fix(cli): deliver complete TOON beyond the string limit (#12074)
* fix(cli): deliver complete TOON beyond the string limit

* fix(cli): own cancellation through TOON delivery

* test(cli): await TOON stage acknowledgements

* fix(cli): build TOON cancellations through domain factory

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 20:40:21 -05:00
ShuaixinHuangandmorluto bd5c985b3f fix(desktop): honor env working directories in launch commands (#12111)
* fix(desktop): honor env working directories in launch commands

* fix(desktop): create the replay working directory before launch

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 01:31:34 +00:00
Aurelio Bernalandmorluto 9b1ffa1f7d fix(ghidra): protect only unapplied relocation destinations, not their whole block (#11996)
Since #10483, an unapplied loader relocation in a non-writable block made
that whole block volatile. TLS slots are such relocations and sit in .got
beside the entries Ghidra did apply, so in any shared object or PIE with
initial-exec or dynamic TLS every GOT-indirect call decompiled as pointer
arithmetic instead of a named call.

Mark each unapplied destination volatile through its data item's Mutability
setting, creating an undefined item of the relocation's length where nothing
is defined. Fall back to the whole block only when an instruction or a data
item starting before the destination occupies it. Eligibility, limitations,
the read-only path, permissions and source FileBytes are unchanged.

The loader-relocation fixture now reads an initial-exec TLS variable whose
R_X86_64_TPOFF64 slot shares .got with the applied entries. The probe
requires that block and its applied entries to stay non-volatile and both
unapplied destinations to have volatile data items; on the previous bridge
it fails at applied_got_relocations_not_volatile.

Rename loader_relocation_semantics to
volatile-unapplied-relocation-destinations to state the new behavior.

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 20:30:01 -05:00
458f583e14 fix(desktop): check retained reader JSON numbers (#11833)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 09:17:12 +08:00
26bec6f653 fix(artifacts): name no slice in trace-dylib-resolution Evidence (#11838)
trace_dylib_resolution Evidence named the slice the session happened to
open, not what was traced. On Apple silicon, `rea trace-dylib-resolution
/bin/ls --architecture x86_64` returned a subject selecting the arm64e
slice (offset 65536, architecture "arm64") while its parameters and
roots said x86_64. Whole-file traces of universal images and app bundle
traces also carried that host slice.

Root cause: the artifact provider built the execution without a
subject, and bindExecutionTarget binds such an execution, like any
subject that names the target's own bytes without a selection, to the
open target's selection. A provider had no way to state that an
observation covers the whole file.

EvidenceSubjectTarget.selection now accepts null, meaning the
observation selects nothing even though a session opened one slice.
bindExecutionTarget already inherited a selection only when none was
stated; its comment now says so. The trace states selection: null. This
matches inspect-binary-hardening and the other whole-file inspectors,
which already record no selection for a universal image.

Validation (macOS arm64, Node 24.22.1):
- New CLI boundary regression: a universal arm64 + x86_64 tool, traced
  whole and with --architecture x86_64, has a subject with no
  architecture or selection and the expected roots. Before this change
  the subject carried the opened slice.
- dylibResolutionCli and dylibResolutionMcp: 44 passed, 2 skipped.
- Suites that exercise subject binding (binarySession,
  analysisEvidenceAdapterParity, artifactMcp, bundleResourceRootCliMcp,
  appleBundleTraversalCoverage, AppBundleResourceRoot,
  ArtifactComparisonEvidence): 144 passed, 1 skipped.
- evidence, BinarySession and ArtifactProvider unit tests: 186 passed.
- Real /bin/ls trace with --architecture x86_64: subject selection and
  architecture null, roots [x86_64]. Format, typecheck, lint and
  architecture guards pass.

Not changed: inspect-macho, inspect-signature and
inspect-native-dispatch-metadata also record the opened slice for a
universal image; whether each examines only that slice was not checked.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 09:07:16 +08:00
morluto 55a50f53f9 fix(elf): reject undersized interpreter ranges before provider admission (#12113)
fix(ghidra): reject empty RISC-V PIE interpreter ranges
2026-11-18 20:04:59 -05:00
ShuaixinHuang af20de3509 feat(native): resolve RISC-V ELF initializer pointers (#12109) 2026-11-18 19:45:05 -05:00
Abhay Tiwari 8d226251a7 feat(ghidra): admit RISC-V position-independent executables (#4487) (#4811)
* feat(ghidra): admit RISC-V position-independent executables (#4487)

Admit little-endian RISC-V ELF32 and ELF64 position-independent executables
(ET_DYN with PT_INTERP) into the pinned generic Ghidra lane.

- Collect `PT_INTERP` during the existing validated ELF table walk in
  `validateElfDeclaredRanges` and record `hasInterpreter` in target metadata,
  supporting arbitrary table offsets and extended program counts without duplicate scanning.
- Admit ET_DYN images when `hasInterpreter` is present under lane identities
  `elf32-pie-le-double-float-generic-v1` and `elf64-pie-le-double-float-generic-v1`.
- Preserve refusal for non-PIE ET_DYN targets (shared libraries without PT_INTERP)
  explaining that shared libraries require separate load verification.
- Record load model facts (`load_model: "pie"`, `expected_default_image_base: "0x10000"`
  or `"0x100000"`, `has_interpreter: true`) in `riscv_elf` analysis profile parameters.
- Record default image base analysis coordinates limitation for PIE targets.
- Update `docs/ghidra-riscv.md` with PIE admission boundary and evidence semantics.
- Add unit tests for PT_INTERP collection, high-offset program headers, and PIE profile resolution.
- Add PIE fixture generation capability to `tests/conformance/ghidra/riscv-fixture.mjs` and
  pass `-Wl,-pie` to ensure bare-metal drivers generate ET_DYN.
- Extend `scripts/verify-real-ghidra-riscv.mjs` to test both ET_EXEC and ET_DYN.

Fixes #4487

* fix(ghidra): check structured facts and rethrow typed errors in PIE tests

* style: format GhidraRiscvProfile.test.ts

* fix(ghidra): restrict PIE admission to verified double-float RISC-V lanes
2026-11-18 19:44:40 -05:00
ShuaixinHuang 0c83de1642 fix(desktop): preserve ELF filesystem lookup bytes (#12108) 2026-11-18 19:24:16 -05:00
ShuaixinHuangandShuaixinHuang 229fc6aae8 fix(ci): synchronize CDP handshake and attach deadlines (#12110)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 19:23:46 -05:00
RRFZ 2076b7bf88 refactor(desktop): inject HostFileReader port into build solve and witness (#11880)
refactor(desktop): inject HostFileReader port into build solve and witness workflows
2026-11-18 19:22:40 -05:00
morluto 21829964ef fix(kuna): recover explicit direct-call destinations (#12106)
* fix(kuna): recover explicit direct-call destinations

* fix(kuna): preserve call evidence on decompile failure
2026-11-18 19:07:02 -05:00
morluto b44d949bfe feat(kuna): verify release 1.1000 (#12107) 2026-11-18 18:52:55 -05:00
Nianze Wu c6033aaaca fix(desktop): bound exported XML selector traversal (#12105) 2026-11-18 18:41:18 -05:00
e3713bea60 feat(rust): read cargo-auditable dependencies from WebAssembly modules (#5069)
* feat(rust): read cargo-auditable dependencies from WebAssembly modules

cargo-auditable embeds the same zlib-compressed `.dep-v0` JSON in a
WebAssembly custom section for wasm32 targets, but inspect_rust_binary
rejected every module as an unsupported target because only ELF, PE and
thin Mach-O containers were recognized.

Walk the section framing of version 1 core modules to locate the
`.dep-v0` custom-section payload and the data section, where rustc keeps
its constant /rustc/<hash>/ paths. Rust lookups now read one
format-neutral layout, so native and WebAssembly images share a single
dependency-section owner. WebAssembly declares no container word size, so
`bits` is null for that format only; the Evidence subject format is
`file`, as for inspect_wasm_artifact.

Truncated sections, invalid LEB128 sizes, custom-section names that run
past their section or are not UTF-8, duplicate `.dep-v0` sections and a
second data section are malformed. Components, such as wasm32-wasip2
output, embed core modules and are refused as unsupported, like universal
Mach-O containers, rather than inspected through one selected module.

* fix(rust): bound the WebAssembly section walk

The WebAssembly reader visited every section synchronously, and the format
sets no section count. A 256 MiB input of three-byte custom sections with
empty names walked about 89 million sections and held the event loop for
about 7.4 seconds, delaying cancellation and other MCP requests; empty type
sections took about 1.9 seconds.

Refuse a module with more than 65,536 sections with a typed cpu resource
constraint that reports maximum_wasm_sections, as the Go header search
reports its work budget. Producer output holds a few dozen sections, and the
same inputs are now refused within tens of milliseconds.

* fix(rust): accept WebAssembly Evidence in retained dependency views

Retained Rust views compared the parent subject with a Mach-O-only format
mapping, so WebAssembly Evidence, whose subject format is file, was refused
as a different artifact. The report domain now owns the subject format next
to the architecture mapping, and the service and the view both use it. The
real CLI/MCP view workflow now also covers a WebAssembly module.

* fix(rust): name the WebAssembly section-walk allowance in recovery

Fixed-allowance recovery mapped every Rust resource other than capacity and
transport to the parser allowance, so the section-walk refusal said host
memory does not raise it. Each Rust resource now maps to its own allowance,
and the cpu bound is a fixed work allowance. The MCP error contract test
checks that the refusal is not retryable and names that allowance.

* fix(rust): require WebAssembly container facts in reports

The report schema tied a null word size to WebAssembly, but it accepted a
wasm report that named a native architecture or big-endian byte order, and
a native report that named the wasm architecture. Retained views parse
imported Evidence with this schema, so such a contradictory report was
accepted. The architecture is now wasm exactly when the container is
WebAssembly, and a WebAssembly report must be little-endian.

* docs(rust): record the WebAssembly dependency-metadata feature

Feature work now carries a spec, plan and task list under docs/specs.
This adds that record for reading cargo-auditable metadata from
WebAssembly core modules and indexes it. The record states that it was
written during review and lists the verification that remains open.

* fix(rust): bind section names to containers and share the LEB128 reader

The report schema accepted a dependency section name that does not belong
to the report's container, such as a WebAssembly report naming the Mach-O
section. rustDependencySectionName now owns that name for the reader and
the schema, which refuses a mismatch for every container.

The WebAssembly reader decoded section sizes with its own loop. It now
uses the shared readLeb128, and an integer cut off by the end of the file
is truncated rather than malformed.

* fix(rust): classify a cut-off WebAssembly integer by its boundary

The reader called an unfinished LEB128 integer truncated whenever its
limit equalled the file length. A name length cut off inside the final
section was therefore truncated, and the same bytes followed by another
section were malformed. Each caller now states whether the file or the
enclosing section bounds the integer.

* fix(rust): report a duplicate WebAssembly dependency section first

The section walk kept two .dep-v0 matches but walked on, so a module with
two dependency sections and more than 65,536 sections after them was
refused for the section bound instead of the duplicate it had already
established. The walk now ends at the second match.

* test(rust): assert WebAssembly container facts instead of limitation prose

The CLI acceptance test matched an English limitation sentence. It now
checks format, architecture, bits and byte order on the parsed report.

* fix(rust): state container word size as 32 | 64 | null

Output contract: inspect_rust_binary bits, including the summary view, is
32 | 64 | null. Null is valid only for WebAssembly and is not a number.
ELF, PE and Mach-O reports stay 32 or 64. The schema description, guide,
feature record and skill state that, and CLI renderers keep null instead
of substituting a word size.

---------

Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-18 18:29:31 -05:00
morluto e09d6273a1 fix(native): preserve caller-selected paths in binary sessions (#12102)
* fix(mcp): preserve caller-selected binary session paths

* test(mcp): verify caller paths across snapshot replay

* test(mcp): separate session alias and snapshot replay coverage

* fix(evidence): preserve selected paths across binary workflows

* fix(evidence): retain authentication admission for caller aliases
2026-11-18 18:27:29 -05:00
IvenKooandmorluto 27db243533 fix(static): keep quoted sample text out of the tech-debt marker scan (#11712)
fix(static): read comments instead of quoted text in the tech-debt scan

`npm run scan:todos` matched raw text, so a marker quoted inside a sample
string counted as debt: on `main` at a10037ef1 the only finding is the
JavaScript sample in
`tests/boundary/filesystem/mcpClientValidationGuard.test.ts`, and the
`Deep static checks` lane is red for every PR that runs it.

Decide what a comment is before counting a marker. JavaScript and TypeScript
are parsed with `@babel/parser`, whose comment ranges also survive a quote
inside a regex literal; `bridge/**/*.py` and `bridge/**/*.java` use a small
scanner that skips quoted and triple-quoted strings. Markers are matched per
occurrence, so a quoted marker earlier on the line no longer consumes a real
one, and an unparsable file stays conservative: every marker counts.

Fixes #11717.

Verified: `npm run scan:todos` exits 0 on this tree; the extended
`tests/boundary/process/scanTodos.test.ts` (3 tests) covers a clean tree, a
quoted sample with a real marker on the same line, and comments in
TypeScript, Python and Java. `check:fast` passes.

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 17:54:40 -05:00
00a3f4d2b9 fix(process): preserve Darwin snapshot and cleanup failures (#12100)
* fix(process): preserve Darwin opening snapshot failures

* fix(process): retain the exact Darwin helper cleanup owner

Transfer the failed helper-root capability across repeated prepare failures. Reuse that same owner for retirement and reader close so stale cleanup cannot remove a replacement helper.

Co-authored-by: Anandumv <anandumv@gmail.com>
Co-authored-by: nextjohnp7 <nextjohnp7@gmail.com>

* test(process): isolate retained cleanup and compiler acknowledgements

---------

Co-authored-by: Anandumv <anandumv@gmail.com>
Co-authored-by: nextjohnp7 <nextjohnp7@gmail.com>
2026-11-18 17:34:25 -05:00
86cf8942de feat(ghidra)!: import recognized DOS COM files with ComLoader (#12086)
* feat(ghidra)!: import recognized DOS COM files with ComLoader

Select Ghidra 12.2 ComLoader for an admitted .com image and do not pass a
base address, so the file stays at 0000:0100. Images ComLoader rejects use
the explicit BinaryLoader import at 1000:0100 and record the typed reason.

BREAKING CHANGE: A DOS COM file that ComLoader accepts now loads at linear
0x100 instead of 0x10100. Read load_address. The BinaryLoader fallback
remains at 1000:0100.

* fix(ghidra): score COM dollar-strings in one pass

ComLoader's printable-run walk restarts at every offset, so a 64 KiB image
of printable bytes blocked profile resolution. The same capped count now
skips a run once an earlier start has seen every later dollar sign.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): align COM import facts with the image Ghidra receives

Mismatch load-image coordinates follow the measured loader and address.
A dotfile named .com keeps that suffix on the snapshot, and selection
uses that snapshot name. The COM fallback verifier owns its MCP
connection before connect.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* style(ghidra): format COM snapshot and verifier files

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): keep measured COM facts and required MZ coordinates

DOS MZ and a verified COM image keep load_segment and entry required.
A COM mismatch emits a known loader or load address on its own, and
omits the segment and entry only when that pair is not a known layout.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): require the verified COM layout and document both entries

A verified COM image is either ComLoader at 0000:0100 or BinaryLoader at
1000:0100 with a fallback reason. The DOS guide queries 0x100 only for
the ComLoader entry and 0x10100 for the fallback.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): attest COM imports against the committed loader

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-18 16:40:18 -05:00
David Muñoz Reyandmorluto 1920525900 fix(kuna): stop calling executable-segment data sections definite data (#10686)
* fix(kuna): stop calling executable-segment data sections definite data

An address in a Mach-O section whose attributes declare no instructions
was refused as "data that Kuna lists, not a procedure", even when the
section sits in an executable segment. In #8352 a direct call targets
`_placed_in_const` in `__TEXT,__const` (segment initprot r-x), Ghidra
decodes and decompiles it, and REA's own procedure_callees reports the
call, yet the Kuna refusal asserted it categorically as data.

The Mach-O layout now records, for each data placement, whether its
enclosing segment's initial protection includes VM_PROT_EXECUTE. For such
placements the refusal keeps the section declaration and the
classification, but says REA's Kuna lane does not treat the entry as a
procedure and that the declaration alone does not prove the bytes are
not code; its remediation adds the Ghidra provider as a decoding route.
address_name's limitation is qualified the same way. Non-executable
segments and the Mach-O header keep the existing wording. Procedure
tools still refuse these entries; making them followable is left open.

Validation: kunaMachoInventory and kunaInventoryPlacement boundary tests
cover the executable `__TEXT,__const` entry, its remediation and
address_name limitation, and an unchanged `__DATA` control. The full
Kuna boundary directory shows the same 11 environment-related failures
on unchanged main as on this branch; check:fast passes.

Refs morluto/rea#8352

* fix(kuna): keep the executable-segment caveat when a refused name is shared by data entries

Review follow-up: a name that several data entries share took a grouped refusal that still said "they are data, not procedures" and offered no Ghidra route, even when one entry lies in an executable segment. The grouped message and remediation now come from KunaInventoryPlacement beside the single-entry ones: with an executable placement they keep the caveat and the Ghidra route, and otherwise the wording is unchanged.

Tests: a shared-name case with and without an executable-segment entry fails before this change and passes after; the Mach-O inventory tests pass. Five process-lifecycle Kuna test files fail identically with and without this change in this environment.

* fix(kuna): qualify omitted executable-segment inventory entries

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 16:33:55 -05:00
5c59bdc8a6 feat(ghidra)!: verify the bridge on Ghidra 12.2 (#12081)
* feat(ghidra)!: verify the bridge on Ghidra 12.2

Admit 12.x from minor 2 upward, with 12.2 and JDK 25 as the verified
pair. The bridge now calls the four-argument storage API added in 12.2,
so 12.1.x cannot compile it and is no longer accepted.

BREAKING CHANGE: Ghidra 12.1.x is rejected. Use Ghidra 12.2 or another
12.x build at or above minor 2, and a JDK inside that installation's
declared range (25 or newer for the verified 12.2 build).

* docs(ghidra): point remaining lanes at Ghidra 12.2

The Windows, 6502, and m68k prerequisites still named 12.1.4 and JDK 21,
which the verified-build check now rejects. The bridge compile lane names
the 12.2 jars it actually compiles against.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): admit the JDK the verified install declares

The Java home framing probe still reported JDK 21 while the verified
installation fixture now declares a minimum of 25, so doctor admission
failed before the path framing was checked.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): derive admitted install fixtures from the verified release

Boundary hosts and assertions still named Ghidra 12.1.4 after admission
moved to 12.2, so list_procedures evidence and completed property reads
disagreed with the install the provider actually reported.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): record the exact 12.2 Clang switch-recovery defect

Ghidra 12.2 stays the verified build. Sessions and decompiler results on
that exact version name upstream issue 9996 and the 12.2.1 fix commit.
Other version strings, including 12.2.1, do not carry the limitation.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): check switch-defect facts instead of the warning sentence

The policy test keeps the structured defect record and checks that the
owning formatter delivers its id, commit, release, and scope fields.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): name the Playwright launch boundary the lifecycle catalog checks

Main retitled that case with a platform placeholder. The coverage catalog
still required the old literal, so the merged full suite reported a missing
title.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): point the lifecycle catalog at main's launch title

The merged suite uses main's platform-specific Playwright launch test.
The coverage catalog now names that title, and this branch keeps main's
test body so the merge stays clean.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): cover the platform launch title on this branch

The lifecycle catalog names main's platform launch title. This branch
now has that quoted test too, so the check passes before and after the
merge.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): record the exact 12.2 masked byte-switch defect

Ghidra 12.2 leaves an AArch64 and-0xff byte-offset switch unrecovered.
Exact 12.2 sessions now cite open upstream issue 10154, and the AArch64
lane expects that jump table to stay unrecovered.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): keep one platform launch environment check

The second launch test repeated the selected environment check. The
remaining test is the parameterized title, and the launcher forwards
SYSTEMROOT on win32 so that assertion holds.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): keep the open switch defect on admitted builds

The exact-version check cleared ghidra-10154 on every build except 12.2.
That defect stays on admitted releases until one is known to fix it.
ghidra-9996 still clears after the exact 12.2 build.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* style(docs): format the Ghidra testing-lane table

The AArch64 jump-table row wrapped past the formatter width and failed
static checks.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(ghidra): give the masked switch its full byte range

The unrecovered oracle now uses 256 readable table bytes, and the same
object must still recover its compare-bounded switch.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* docs(website): point Ghidra setup at 12.2 and JDK 25

The public setup pages still told new users to install Ghidra 12.1.4 and
JDK 21, which this release rejects. Changed setup sentences are extracted
and left untranslated so those editions use the English page.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* docs(website): keep catalog edits to the changed setup strings

The catalog check compares active message ids, not a full rewrite.
Restore the previous catalogs and update only the Ghidra 12.2 setup
strings, leaving their translations empty.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): apply the closed switch defect from the parsed patch

12.2, 12.2.0, and 12.2.0 with a suffix all precede 12.2.1, so they keep
ghidra-9996. The masked-switch table lists all 256 byte entries.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(ghidra): share the AArch64 switch fixture compiler invocation

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-18 16:06:51 -05:00
635a87a4f4 fix(verify): scrub ambient npm install-policy from verifier child npm environments (#10474)
* fix(verify): scrub ambient npm install-policy from verifier child npm environments

* fix(verify): keep caller npm policy for script-enabled commands

---------

Co-authored-by: LexLuthorPrimero <1@voidmail.io>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:33:46 -05:00
morluto b60836a157 ci: retire the automated PR readiness check (#12095)
* ci: retire the automated PR readiness check

* ci: remove the retired readiness module declaration
2026-11-18 15:27:23 -05:00
Ahmedandmorluto dc6799d488 fix(android): report method disassembly failure as unavailable body (#12090)
* fix(android): report method disassembly failure as unavailable body

Catch JADX bridge get_method_body failures in inspectMethod and project as an unavailable body with disassembly_failed marker, avoiding generic execution_failure with irrelevant rea doctor remediation.

Fixes #10482

* fix(android): preserve method identity when disassembly is unavailable

* fix(android): retain method identity when smali generation fails

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:23:34 -05:00
486470ec9b fix(desktop): preserve cancellation after ELF lookup refusals (#11804)
* fix(desktop): resolve needed origins before library deduplication

* fix(desktop): resolve library paths through filesystem

* fix(desktop): retain package ownership of required library links

* fix(desktop): traverse hard-linked dependencies once

* fix(ci): isolate expensive capacity regressions from parallel workers

(cherry picked from commit a1f762d1139f51d97130f8c20cfb12d567cced72)

* fix(desktop): preserve complete library lookup semantics

* fix(desktop): retain required directory alias owners

* fix(desktop): preserve ownership across complete library link routes

* fix(desktop): share merged-system ownership lookup for link entries

* test(mcp): observe cleanup failures at their current delivery boundary

* fix(mcp): preserve workflow completion progress through delivery

* test(setup): keep the Windows Kimi profile fixture on a supported profile

The Windows-only case at `clientConfigurationEnvironment.test.ts:226` wrote
`rea_mcp_input_schema_profile: "full"`. That profile was retired: the reader
now refuses it ("REA_MCP_INPUT_SCHEMA_PROFILE accepts only \"compact\" …"),
so `configureClientConfiguration` returned `failed/readback` before writing
and the case failed on every Windows run, including main's own
`Windows capability and package lane`.

The case has no Windows dependency — it passes an explicit `configPath` and
the Kimi write dialect is the same everywhere — so it now runs on every
platform, which is what let the stale value rot unnoticed. The fixture keeps
the lowercase explicit key the case is about, with the supported value.

Verified on `main` `d6bcfc10`: the same fixture driven through
`configureClientConfiguration(..., "win32")` on this host reproduced
`{"status":"failed","reason":"readback"}` with the retired value and now
returns `{"status":"configured"}` with `compact`. The file's 75 cases pass
here (66 run, 9 platform-conditioned skips) and `check:fast` passes.

* test(ci): restore verifier and MCP contract regressions

* test(captures): assert adapter-owned input issue field names

* fix(ghidra): avoid Java probes for missing installations

* fix(desktop): retain all selected leaf ownership spellings

* fix(desktop): retain link target ownership contexts

* fix(desktop): retain successful lookup retries and cancellation

* fix(desktop): preserve library probe failures and cancellation

* fix(desktop): preserve cancellation after lookup refusals

* docs(desktop): clarify library lookup error precedence

* fix(desktop): check library budget before absolute path lookup

* fix(desktop): report each unowned library path once

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: g0at <50488370+g1at@users.noreply.github.com>
Co-authored-by: IvenKooLab <276572622@qq.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:18:59 -05:00
93fb79e3b8 fix(ci): preserve conformance subprocess cleanup ownership (#12025)
* fix(ci): preserve conformance subprocess cleanup ownership

* test(ci): use a token-observable conformance child

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 15:08:58 -05:00
morluto a51ce1390d test(browser): track the platform-specific lifecycle coverage case (#12093) 2026-11-18 15:06:43 -05:00
ShuaixinHuangandShuaixinHuang 6d66f3a8ee fix(artifacts): preserve PyInstaller retirement and map identity (#11830)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:57 -05:00
ShuaixinHuangandShuaixinHuang 0db5f93df6 fix(protobuf): preserve descriptor string identity (#11834)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:49 -05:00
ShuaixinHuangandShuaixinHuang e7ed93004a fix(apk): preserve ambiguous v1 certificate identity (#11835)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:59:41 -05:00
phexussandmorluto fd9989eadb fix(artifacts): keep virtual directory identities distinct from file content (#8574)
A virtual directory node was identified from the SHA-256 of its canonical
listing JSON through the same function as raw file bytes. A regular file
containing exactly that JSON (for example an empty directory's
{"children":[],"kind":"directory"}) received the same artifact ID, the
directory node overwrote the file node, and extraction of the valid
archive failed with an integrity mismatch.

Derive virtual node identities in a separate domain and validate node IDs
by representation. Inventory Evidence retained with the earlier virtual
identity is still accepted.

Fixes #8551

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:59:33 -05:00
ShuaixinHuangandmorluto ad02201d0b fix(zip): corroborate member extents before claiming complete coverage (#11855)
* fix(zip): corroborate local member extent claims

* fix(zip): verify descriptors of contained records

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:59:28 -05:00
ShuaixinHuangandShuaixinHuang 1290ab401c fix(elf): resolve extended symbol section references (#11924)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:29 -05:00
ShuaixinHuangandShuaixinHuang 954bcd6082 fix(verify): preserve Linux descendant records with multiline names (#11949)
* fix(verify): preserve Linux descendant records with multiline names

* fix(verify): load the stat parser without changing stderr

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:21 -05:00
ShuaixinHuangandShuaixinHuang 40f9269284 fix(ci): use the test deadline for conformance fixture commands (#12022)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:07 -05:00
ShuaixinHuangandShuaixinHuang f4efc293dd fix(ci): retry GitHub file reads after gateway timeouts (#11987)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:58:02 -05:00
ShuaixinHuangandShuaixinHuang e39a53d5cd fix(windows): preserve opaque ANSI shortcut path identity (#11923)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:47 -05:00
ShuaixinHuangandShuaixinHuang c4f9ead498 fix(verify): honor an explicit conformance source root (#11943)
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
2026-11-18 14:56:35 -05:00
David Muñoz ReyandDayan Kijege 53977802b3 test(process): count zombie descendants as stopped in cleanup checks (#12091)
Where PID 1 does not reap orphans promptly, a killed descendant stays a zombie for a while. Signal 0 still reaches a zombie, and a raw process table still lists it, so four boundary tests decided a stopped process was alive although cleanup had worked.

The stop assertions in artifactVerifierCleanupOwner and desktopBuildOwnedCommand now use processHasStopped. The run-token sweep in ownedCommand reads the product's liveProcesses view, which drops zombie rows. The testing guide says to assert a stop this way and not with signal 0.

Ported onto current main from morluto/rea#11837. The helper and the first eight cases landed in morluto/rea#12034, so this keeps the four that remained.

Co-authored-by: Dayan Kijege <dayanusa7@gmail.com>
2026-11-18 14:48:37 -05:00
ShuaixinHuang 75482a9ef9 fix(ota): merge partition info without discarding integrity claims (#11836) 2026-11-18 14:47:46 -05:00
ShuaixinHuang 004c43e32a fix(maven): preserve qualified property keys in metadata (#11860)
fix(maven): preserve qualified property keys
2026-11-18 14:47:42 -05:00
mengzhe ganandmorluto 82e16b4dda fix(setup): write the recommended tool call timeout into dsh registrations (#4043)
* fix(setup): write the recommended tool call timeout into dsh registrations

rea setup --client dsh wrote registrations without toolCallTimeoutMs, so
DeepSeek Harness applied its 60-second default while a native provider
startup alone can exceed it. Setup now derives the deadline from the same
provider allowance plus operation headroom used for Kimi and Codex,
preserves a positive caller-selected value, and doctor reports a
registration without a usable timeout as stale.

ProviderRequestBudgetResolver declares an optional budgetSettings read
set, so the fail-closed budget gate rejects unresolved Cordis expressions
only for settings the derivation may read plus the timeout inputs; an
unrelated expression such as GHIDRA_INSTALL_DIR still refreshes, and an
expression in REA_IDA_MCP_CONFIG fails closed.

* test(setup): record the dsh tool call deadline in the NUL repair fixture

The NUL refusal scenario rewrites a valid dsh registration and expects
doctor to report it healthy. That fixture omitted toolCallTimeoutMs,
which doctor now reports stale, so the repaired registration records the
deadline a current dsh registration carries.

* test(setup): separate dsh timeout repair coverage

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-18 14:31:34 -05:00
morluto 30006cfd24 test: align Cutter and loader fixtures with current contracts (#12088)
* test(cutter): preserve discovery limitations in authority fixture

* test(javascript): distinguish wrapper collisions from syntax recovery
2026-11-18 13:23:24 -05:00
Ali RazaandClaude Opus 5.5 f64433c93e fix(sqlite): refuse one-byte files instead of reporting an empty schema (#8727)
* fix(sqlite): refuse one-byte files instead of reporting an empty schema

* test(sqlite): assert refusal facts instead of the full error sentence

The one-byte and corrupt-input acceptance tests froze the sentence that
SqliteDatabaseWorkerExecution builds from fixed wording, SQLite's
diagnostic and the selected path. Share one helper that keeps the code,
issue path, reason and single-issue shape exact, and checks the
diagnostic and selected path separately, so rewording the sentence no
longer breaks either regression.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-18 13:11:23 -05:00