* refactor(errors): compose multi-part provider cleanup failures through one owner
CdpBrowserProvider, CdpElectronProvider, FridaInstrumentationManager and
PlaywrightBrowserScenarioProvider each built the same composite by hand: a
ProviderCleanupError listing the parts' resources, an AggregateError cause,
and bindCleanupDependencies over the parts. providerCleanupErrorFromFailures
in src/domain/analysisErrorCleanup.ts now owns that composition. `causes`
keeps non-AnalysisError failures in the aggregate cause without making them
own completion, as the CDP providers did; `message` keeps the aggregate
messages Frida and Playwright used.
Tests: helper unit tests, new close-composition tests for both CDP providers,
and a Playwright test with two failed cleanup retries. They pass on the base
revision and on this change, and fail when the helper drops the dependency
binding, the extra causes or the message.
Lowers the cleanup-dependency-binding baseline to 43 files / 73 sites.
Refs #11859
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* style(test): format the Playwright cleanup test with oxfmt
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(errors): assert cleanup composition facts instead of reason prose
Follows docs/development/testing.md: the close-composition tests now check
provider, operation, resources, aggregate causes and completion, not the
explanatory reason or aggregate message. A harmless wording change passes;
a lost binding, lost cause or wrong operation still fails.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Anant Mandanka <anant.mandanka@renaissancejewel.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Route the 26 raw Buffer reads in GgufHeader and the 2 in
SafetensorsHeader through BinaryReader. Add u8, i8, i16, i32, i64,
f32 and f64 accessors to BinaryReader, with the same range checks as
u16/u32/word, since GGUF metadata stores signed and floating scalars.
Every migrated site reads an exact-size buffer from
ModelHeaderReader.take(), so outputs and errors are unchanged.
Shrink the raw-buffer-read baseline from 102 files / 711 sites to
100 / 683.
Refs #11865
* fix(artifacts): verify FAT identities before Bun and Node SEA claims
* fix(node-sea): bound thin Mach-O header reads to their slice
* fix(bun): exclude rejected FAT slices from trailer fallback
The XML plist reader replaced every literal CR and CRLF with LF before
parsing. CoreFoundation keeps them, so REA reported a different string than
plutil for the same file, and two keys that differ only in their line ending
collapsed into one repeated key.
The document is now parsed as written. Source spans for integer, real, date
and data literals already count CR, CRLF and LF as one line break each.
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
* fix(ci): count named artifact transfers in job timings
* fix(ci): cover named artifact timings against their workflows
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
CoreFoundation reads some XML plists that strict XML rejects, such as
documents with a double hyphen in a comment or a control character in a
string. inspect_plist refused them although plutil -lint accepts them,
and the outcome depended on how file(1) described the bytes.
When REA's XML reader refuses a document's syntax, inspection now takes
the existing plutil conversion route. The result keeps format xml and a
limitation names REA's reason. A document plutil also rejects stays
refused with its diagnostic, and plist structure errors in well-formed
XML are still refused without conversion.
Fixes#12234