* feat(artifacts): inspect NES 2.0 container headers and regions
Problem: the iNES lane refused every header whose byte 7 bits 2-3 select
NES 2.0, so NES 2.0 cartridges could not be inventoried, extracted or
reconstructed even though their file layout extends classic iNES.
Fix: the single iNES-family header parser now reads NES 2.0 alongside
classic iNES. It reports the 12-bit mapper, submapper, 12-bit and
exponent-multiplier PRG/CHR sizes, declared PRG/CHR RAM and NVRAM sizes,
CPU/PPU timing, console type with Vs. System and extended console codes,
miscellaneous ROM count and default expansion device in a "nes-2.0"
header variant; classic headers keep their exact serialization. Regions
add one prg.bin/chr.bin for exponent sizes and misc-rom.bin for the bytes
after CHR-ROM when miscellaneous ROMs are declared. Oversized
declarations (with exact totals, including exponent sizes beyond safe
integers), nonzero unused header bits, empty PRG-ROM and declared but
absent miscellaneous ROM bytes are refused through the existing format
error. Nested byte classification now admits NES 2.0 through the same
parser. The reader limitation, tool description, guide and skill
reference now state that UNIF remains unsupported and that RAM, timing
and console values are declarations.
Validation: new synthetic NES 2.0 unit cases fail on the base (15 of 24)
and pass after the change; focused boundary and acceptance iNES suites
(75 tests) pass, including NES 2.0 inventory, extraction, reconstruction
and compiled CLI inspection; npm run check:fast passes.
Refs morluto/rea#2072
* test(artifacts): extract an exponent-sized NES 2.0 ROM area
Review follow-up for NES 2.0 headers.
The exponent-multiplier case stopped at parseInesLayout, and the
extraction test used counted ROM units, so prg.bin and chr.bin from
an exponent-sized area never went through the reader or extraction.
A boundary case now builds a NES 2.0 file with a 2^10 * 3 byte PRG-ROM
area beside one counted 8 KiB CHR-ROM unit. It checks the header omits
the PRG unit count, the source offsets of prg.bin and chr/000.bin,
the verified reconstruction order, and that the extracted regions
match the original bytes exactly.
Tests: tests/boundary/filesystem/inesArtifact.test.ts passes (38).
* refactor(artifacts): read NES header bytes through one helper
The NES 2.0 declaration added a sixth raw Buffer read to
inesContainer.ts. On current main the architecture guard allows five
there, so the merged tree failed Static checks. iNES and NES 2.0
declarations and the format probe now read header bytes through one
headerByte helper. The file has one raw read, and its counted baseline
drops from 5 to 1 through --shrink-baselines.
Tests: inesContainer domain tests (24) and the NES boundary and
acceptance tests (76) pass. architecture-guards, format:check and
check:ci:fast pass on the branch merged with main.
* refactor(artifacts): report iNES header failures through ParseFailure
Review follow-up: the NES 2.0 declaration added plain-string failures.
The iNES-family parser now returns Result<_, ParseFailure> with its
kind and where it was found:
- malformed: a missing signature, a dirty legacy header, an empty
PRG-ROM area, reserved NES 2.0 bits or an invalid file extent;
- truncated: a short header, a short payload, or declared
miscellaneous ROM with no bytes;
- unsupported: UNIF or another header variant, with undecoded content.
The detail text is unchanged.
The format registry refuses with the detail, and the iNES reader and
root classifier translate the failure at their boundary into the
existing format ArtifactReaderFailure, with the ParseFailureError as
its cause.
Tests: the refusal table now asserts each failure's kind and format
as well as its detail. iNES domain and recognition tests, NES boundary
and acceptance tests (76), architecture-guards, format:check and
check:ci:fast pass on the branch merged with main.
* fix(artifacts): preserve NES header declarations and iNES evidence
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* fix(zstd): share exact-frame Zstandard decoding across ELF and OTA
Walk RFC 8878 frames once so ELF sections, Android OTA REPLACE_ZSTD, and GPU payloads reject truncated headers, blocks, checksums, and trailing bytes on every supported Node runtime. Bound that walk with the runtime zstd.max_frames setting.
* fix(zstd): keep frame output tight and report GPU frame-cap refusals
Copy each Node 22 frame off its decoder chunk before the next frame is decoded. Map a GPU zstd.max_frames refusal through the resource-limit contract instead of a provider failure.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): keep frame-cap refusals and bad seeds out of malformed results
Project zstd.max_frames through one resource-limit helper for ELF notes, DWARF, GPU, and artifact reads. An invalid REA_ZSTD_MAX_FRAMES seed stays a configuration failure, and frame-header tests cover content size, window, dictionary id, and RLE blocks.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): yield GPU frame decoding so cancellation can land
The frame-by-frame fallback awaits a caller pause before each data frame. GPU yields and checks the read signal there, so a many-frame payload does not finish before a disconnect is observed.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): advertise the frame cap and keep strict GPU decode cancellable
List every operation that enforces zstd.max_frames, including GPU, DWARF, and ELF notes. The strict sequence uses the async decoder and checks the caller signal again after it returns, and a single output buffer is not copied a second time.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): refresh analysis-setting schemas and GPU frame-cap projection
Regenerate the advertised input summaries for inspect_analysis_settings and update_analysis_settings. GPU inventory now throws the projected zstd.max_frames resource limit from payload decode and #retainFailure, so the adjustable setting survives the public failure.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* style(gpu): format the frame-cap projection throw
oxfmt keeps the zstd.max_frames throw in #retainFailure on one line so CI format:check matches the local formatter.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): yield after the last frame-by-frame GPU decode
The fallback returned success in the same turn as the final synchronous frame, so a queued abort was still invisible to the caller's signal check. Pause once more before that success, matching the strict sequence.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): yield ELF, OTA, and DWARF frame decoding on the caller signal
The synchronous frame loop ignored abort signals owned by inspect_elf_notes, inspect_dwarf_units, and Android OTA partition reads. Those callers now use the cooperative decoder and yield before Zstandard work, and 32-frame cancellations cover each path.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): observe cancellation during structural parsing
* fix(zstd): project section-name frame caps at the ELF directory boundary
readElfDirectoryFromBuffer now requires the caller's operation and throws the adjustable zstd.max_frames resource limit. Hardening, unwind, and the other directory consumers keep that typed refusal instead of an adapter or I/O error.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(zstd): preserve optional ELF evidence when frames are capped
* fix(zip): validate Zstandard members through frame completion (#12461)
fix(zip): require complete Zstandard member frames
* fix(elf): yield hardening section name decoding
* fix(elf): yield section names for unwind and export reads
* fix(zstd): yield ELF directory reads that already own a cancellation signal
Hardening, unwind, initializers, exports, kernel modules, debug link, and Android JNI now read section names through the cooperative directory when their caller has a signal. Readers with no signal stay synchronous.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(elf): share one initializer directory and retain its snapshot
* fix(android): reuse the admitted JNI ELF directory
* fix(elf): retain optional debug candidate evidence through cooperative decoding
* fix(zstd): yield ELF section names for Go, Rust, and IL2CPP
These inspections already own an abort signal. Their ELF directory read now uses the cooperative container decoder so a queued cancellation can land during a many-frame section-name table.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(elf): recognize compressed kernel modules before ELF decoding
The cooperative module reader decoded the bytes as ELF before the container check, so gzip, xz, and zstd modules became malformed images. The compression check now returns the unsupported-container report first.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* refactor(elf): classify each container once before reading it
* fix(il2cpp): preserve admission order during cooperative linking
* fix(elf): reuse section-name decoding in debug-link comparison (#12472)
* style(elf): format updated section-reader test calls
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(artifacts): preserve iNES shutdown ownership and I/O failures
* test(cli): publish complete doctor readiness before cancellation
* test(mcp): observe cleanup failures at their current delivery boundary
* fix(mcp): preserve workflow completion progress through delivery
* test(ci): assert current MCP and evidence ownership contracts
* test(setup): keep the Windows Kimi profile fixture on a supported profile
The Windows-only case at `clientConfigurationEnvironment.test.ts:226` wrote
`rea_mcp_input_schema_profile: "full"`. That profile was retired: the reader
now refuses it ("REA_MCP_INPUT_SCHEMA_PROFILE accepts only \"compact\" …"),
so `configureClientConfiguration` returned `failed/readback` before writing
and the case failed on every Windows run, including main's own
`Windows capability and package lane`.
The case has no Windows dependency — it passes an explicit `configPath` and
the Kimi write dialect is the same everywhere — so it now runs on every
platform, which is what let the stale value rot unnoticed. The fixture keeps
the lowercase explicit key the case is about, with the supported value.
Verified on `main` `d6bcfc10`: the same fixture driven through
`configureClientConfiguration(..., "win32")` on this host reproduced
`{"status":"failed","reason":"readback"}` with the retired value and now
returns `{"status":"configured"}` with `compact`. The file's 75 cases pass
here (66 run, 9 platform-conditioned skips) and `check:fast` passes.
* test(ci): restore verifier and MCP contract regressions
* test(captures): assert adapter-owned input issue field names
* fix(ghidra): avoid Java probes for missing installations
* test(capture): retain final cleanup progress assertions
* fix(artifacts): keep iNES shutdown ownership free of unrelated edits
The doctor readiness fixture and process-capture progress assertions
are not required by descriptor retirement or I/O failure precedence.
Restoring them, and the Ghidra installation test already merged in
#11732, leaves this change on the iNES reader, chunk reader, and
their regressions. The unused artifact chunk helper import is removed.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* test(artifacts): age the iNES header race before same-size rewrites
Identity checks observe mtime, and a same-size overwrite inside one
clock tick is indistinguishable from the original file. The admission
test then reports a format error instead of source integrity. Age the
fixture the same way the prefix race already does.
* test(go): assert truncated Mach-O command tables by typed failure
An unstored oversized command table is a truncated Mach-O load-command
parse, projected as invalid_format. The old message lock named a
sentence the parser no longer produces.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* test(artifacts): fold the paused iNES inventory close into the existing case
The standalone close test repeated the paused entries() refusal already
covered by the close/cancel pair. The borrowed-descriptor stat stays on
that close case.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(artifacts): preserve first iNES stream interruption
---------
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: g0at <50488370+g1at@users.noreply.github.com>
Co-authored-by: IvenKooLab <276572622@qq.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
* fix(esp): disclose partition entries outside the table checksum
* fix(esp): label the partition checksum offset origin
* fix(esp): count partition entries outside the table MD5
The coverage warning was only prose, and it presented the MD5 entry's
table-relative offset without a structured fact. Record
entriesAfterChecksum on the MD5 result, project it as
entries_after_checksum, and keep the warning as presentation.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(esp): accept saved flash inventories without the checksum count
A required entries_after_checksum rejected ESP flash Evidence written
before the field existed. Keep the count exactOptional so omission
stays unknown, and still emit it for new inventories.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(desktop): bind dconf profiles to selected database sources
* fix(desktop): resolve dconf before changing working directory
* fix(desktop): retain refused dconf lookup diagnostics
* fix(desktop): preserve execution-time dconf search fallback
* fix(desktop): keep host spawn failures outside dconf fallback
* fix(desktop): retain staged reader cleanup through command close
* test(kuna): await eviction boundary events explicitly
* test(kuna): bound lifecycle acknowledgements through shared owner
Cherry-picked shared follow-up from a5761c7545.
* fix(desktop): keep dconf sources independent of wrapper stdin
* test(desktop): restrict procfs command checks to Linux
* fix(desktop): own dconf wrapper cleanup before source retirement
* fix(desktop): retain dconf preparation inspection owners
* fix(desktop): classify dconf read failures by kind and errno
Record the failure kind, host errno, exit status, selected command, and
child stderr on DconfDump, and carry those facts to view_failure. Tests
assert the typed fields instead of error prose, including a PATH refusal
whose executable is not the last candidate.
* test(desktop): gate real dconf diagnostics on Linux
The real reader checks /proc file descriptors before launch, so macOS
reports descriptor-unavailable/ENOENT instead of launch-failed/EACCES.
Keep that launch refusal on Linux and cover the Evidence contract with
a mocked reader on every platform.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
* fix(node-sea): bound duplicate blob verification work
* test(mcp): observe cleanup failures at their current delivery boundary
* fix(mcp): preserve workflow completion progress through delivery
* test(setup): keep the Windows Kimi profile fixture on a supported profile
The Windows-only case at `clientConfigurationEnvironment.test.ts:226` wrote
`rea_mcp_input_schema_profile: "full"`. That profile was retired: the reader
now refuses it ("REA_MCP_INPUT_SCHEMA_PROFILE accepts only \"compact\" …"),
so `configureClientConfiguration` returned `failed/readback` before writing
and the case failed on every Windows run, including main's own
`Windows capability and package lane`.
The case has no Windows dependency — it passes an explicit `configPath` and
the Kimi write dialect is the same everywhere — so it now runs on every
platform, which is what let the stale value rot unnoticed. The fixture keeps
the lowercase explicit key the case is about, with the supported value.
Verified on `main` `d6bcfc10`: the same fixture driven through
`configureClientConfiguration(..., "win32")` on this host reproduced
`{"status":"failed","reason":"readback"}` with the retired value and now
returns `{"status":"configured"}` with `compact`. The file's 75 cases pass
here (66 run, 9 platform-conditioned skips) and `check:fast` passes.
* test(ci): restore verifier and MCP contract regressions
* test(captures): assert adapter-owned input issue field names
* fix(ghidra): avoid Java probes for missing installations
* test(ghidra): drop duplicate absent-installation coverage
Merging main reapplied the #11732 case beside the copy already on main.
Co-authored-by: morluto <morluto@users.noreply.github.com>
* test(node-sea): assert duplicate-blob refusal without stdout prose
The CLI coverage already checks the truncated code and limit details.
Co-authored-by: morluto <morluto@users.noreply.github.com>
---------
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: g0at <50488370+g1at@users.noreply.github.com>
Co-authored-by: IvenKooLab <276572622@qq.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
A LinkInfoHeaderSize below 0x1C no longer lowers the string-offset floor.
Reserved 0x1D..0x23 headers still end at their declared size, so ANSI
fields after that header stay readable.
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
Keep DTB and FIT observations when an admitted alignment gap contains
nonzero bytes. Retain one parser-owned diagnostic with the count and
first file offset.
Refs #10179.
Co-authored-by: Nianze Wu <wunianze666@gmail.com>