Commit Graph
4 Commits
Author SHA1 Message Date
morlutoandPhon 3fb17d72a9 fix(desktop): admit build export folders before running the in-computer export (#11307)
* fix(desktop): output-directory admission agrees with SafeOutputTree for #9291

* fix(desktop): admit build export and witness folders through planOutputTree

Main now owns new-or-empty folder admission in planOutputTree, so the
separate admitNewOrEmptyOutputDirectory check is superseded. Keep the
remaining parts of #9291 on that owner:

- export_build_environment plans the caller's directory before running
  export-desktop-application in the build computer.
- planOutputTree refuses a folder, or the nearest existing ancestor of an
  absent one, that the host cannot write, so check_build_task refuses it at
  the seed instead of after the recording ends.
- writeOutputTree creates missing parents through SafeOutputTree's
  createParents, which maps a file or denied parent to a destination
  refusal, instead of a raw mkdir before admission.

Restore main's withheld-copy test, which this design leaves unchanged.

* fix(desktop): require a readable parent where publication syncs it

SafeOutputTree.commit opens the output folder's parent read-only to sync
it, so a write-only parent passed admission and failed only at
publication. planOutputTree now also requires read access on that parent
when it already exists.

---------

Co-authored-by: Phon <twilyt1@proton.me>
2026-11-16 00:18:11 +08:00
gensokyo-devandgensokyo-dev 8296d81cd4 test(desktop): record that desktop exports refuse a file in the output parent path
planOutputTree admits the destination before writeOutputTree creates any
parents, so the parent-creation defect fixed for environment bundles does not
reach desktop exports. Keep that sibling comparison as a test.

Refs #7688

Co-Authored-By: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
2026-11-14 14:59:49 +01:00
morluto 12bf103367 fix(desktop): preserve cancellation after output publication (#10108)
* fix(desktop): preserve cancellation after output publication

* fix(desktop): retain cancellation in combined output failures
2026-11-11 09:01:07 -05:00
morlutoandCursor Agent 9f5f9c1289 fix(desktop): preserve capture evidence and output ownership (#9899)
* fix(desktop): retain capture identity and cleanup ownership

* fix(desktop): validate destinations and finish inputs before export

* fix(desktop): preserve package ownership and apt trust boundaries

* fix(sqlite): preserve observed facts and distinguish special real values

* fix(desktop): bind computer files to data-object metadata

* test(desktop): count the tagged negative-zero cell spelling

SQLite view cells encode negative zero as a real object so it stays
distinct from the text "-0". The byte budget follows that spelling.

* fix(desktop): keep unresolved discovered state directories

Canonicalizing an unreadable path or dangling symlink aborted capture
before the inventory could record that the path was unknown. Those
discovered directories now keep their absolute spelling in the scope.

* test(desktop): keep the capture scope suite within its line limit

The unresolved state-directory case lives beside the suite so the
existing callback stays within the lint limit.

* fix(desktop): retain cancellation through capture input cleanup

* fix(desktop): avoid reserved Pydantic settings properties

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-11 17:36:47 +08:00