* fix(artifacts): accept Android boot images without final page padding
The truncation check required the file to reach the page-aligned end
after the last component, so an image holding every declared byte but
omitting the trailing zero padding was refused as truncated, and the
message named the padded end. Bound truncation by the last declared
header or component byte instead, keep the page-aligned end for
locating an AVB footer, and check the AVB original image size against
the declared bytes.
Fixes#11854
* test(artifacts): check boot image declared ends against the fixture layout
Derive each expected end from the fixture layout instead of the
parser's dataEnd, so a declared structure dropped from the coverage
check fails the test.
---------
Co-authored-by: Anurag Singh <211784907+Anurag-5ingh@users.noreply.github.com>
Inspect local Maven/Gradle metadata as Evidence with bounded report/XML admission, preserved caller choices and owned cleanup.
Refs #8828; broader comparison and resolution work remains outside this change.
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Inspect supplied NuGet packages as local Evidence with bounded ZIP parsing, preserved caller choices and credential-safe metadata.
Fixes#8144
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Address all four PR review findings structurally:
- Isolate concurrent Doctor probes and host subsystems in child
ArtifactResourceScope instances tracked via resources.track() so a failed
cleanup on one probe cannot deadlock or abort sibling reads before close().
- Include tests/ JS/TS helper modules and fixture path literals in
throughHelpers() and named() so changes to JS fixtures such as
fakeHopperReplies.mjs reach transitive helper and socket tests.
- Extract generic createSharedMcpSession() and reuse it in lazyLocalToolsMcp()
to preserve retryable cleanup draining and startup-failure attribution.
- Replace test-scoped createTestTempDirectory() with a file-scoped workspace
in jsonInputStatus.test.ts so the shared isolated home persists across tests.
Record default catalog counts and digests in recordedCatalogDigests.js, reuse
the SHA-256-verified mcp-catalog.json in default rea mcp doctor runs, move
Windows existing-project Ghidra admission constants to GhidraAdmission, defer
BinaryTargetResolver and Kuna installation probes until needed, and join
independent Doctor host/provider/identity probes via settleConcurrent.
Statically loaded JS drops 7.03 MB -> 2.07 MB (-70.6%) for rea doctor/setup
(command_ms 440ms -> 207ms, -53.0%) and 5.71 MB -> 0.85 MB (-85.1%) for
rea mcp doctor.
Project retained Go and Rust dependency metadata as deterministic, bounded CycloneDX documents with parent provenance and explicit unknowns. Share current Evidence identity admission and canonical document-ceiling recovery.
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Add offline ELF dependency, search-path, symbol-version and import inspection with retained Evidence summaries and pages. Bound GNU-hash work and preserve cancellation, stable identity and caller-selected parameters across CLI/MCP.
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
* refactor(kernel): eliminate remaining record predicate copies and compose cleanup dependencies through shared owner
* fix(firmware,tests): remove unused cleanup import and align CI shard and CLI registration tests
* refactor(parsers): state duplicate-member policies and bring parser-json-parse to 0
* fix(domain): return duplicate members as a parseJsonWithDuplicatePolicy failure
* refactor(evm): name the worker request byte limit constant
* fix(adb): run adb commands under owned supervision and start the adb server explicitly
The adb version probe and device commands now run through runOwnedCommand
in their own process group, keeping adb's SIGTERM-first stop through the
termination policy. A device command's escaped descendants are swept with
its cleanup, and cleanup that fails stays owned by the provider, which
retries it before its next operation.
Device operations start the adb server with an explicit `adb start-server`
first. The server is an external shared service: REA may start it but never
stops it, so a device command never forks it into its own cleanup.
runOwnedCommand gains a byte-limited stdout collector: output beyond
maxStdoutBytes is an output-limit failure, like an exceeded diagnostic
budget, and the collected bytes are kept exactly for binary protocols such
as screencap. Ownership preparation that cannot start its own helper for
lack of host capacity is reported as the command's host-capacity launch
failure.
* fix(adb): preserve completed refusals, server startup facts, and lazy server start
* fix(adb): scope runtime-root command cleanup and preserve incomplete command cleanup
* fix(adb): preserve completed bugreports and staging directories across command cleanup failures
* fix(adb): preserve bugreport command cleanup across readback failures and project live cleanup resources
Migrate the remaining 2 direct AnalysisCancelledError constructions onto cancelledBy and the remaining 14 process-snapshot stdout/stderr copy sites onto capturedProviderOutput, burning down both architecture-guard baselines to zero.
* feat(errors): carry related parameters and operations and derive CLI flags and commands
* fix(cli,errors): preserve operation-selector flags in CLI hints and clarify snapshot load/save
* fix(cli): refuse csv and tsv formats on --llms, --llms-full, and --schema
* fix(cli): validate discovery row-format refusals at the shared output boundary
* refactor(mcp): route managed operations through the session auxiliary route
Refs #11674
* fix(mcp): preserve managed session factory for fixed sources and narrow port type
Run ordinary CLI commands through REA's registry, argv parser and result owner.
Remove Incur, the second admission parse, SDK error middleware, output capture
and redundant command traversal. Preserve explicit redaction, publication
receipts, incremental output, terminal notice eligibility and drain ownership.
Migrate fixtures to real registrations and retain the derived-source notices.
Validation includes unchanged public parity goldens, public and lifecycle
regressions, repaired fixture consumers, real TTY base comparisons, exports
beyond the engine string limit, four schema catalogs and final static/docs
checks. Native provider and optional validator coverage limits are in the PR.
Fixes#11654. Fixes#10583. Refs #11682, #11476 and #10511.
BREAKING CHANGE: Markdown argument diagnostics use REA's literal escaping,
table widths and token counts. Flag-shaped unknown MCP subcommands honor the
selected format. Completion --schema/--version routes use the canonical
REA-owned hook rather than the retired SDK generator. Refresh affected literal
snapshots and regenerate completion hooks with rea completions <shell>.
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
* test(mcp): observe cleanup failures at their current delivery boundary
* fix(mcp): preserve workflow completion progress through delivery
* test(setup): keep the Windows Kimi profile fixture on a supported profile
The Windows-only case at `clientConfigurationEnvironment.test.ts:226` wrote
`rea_mcp_input_schema_profile: "full"`. That profile was retired: the reader
now refuses it ("REA_MCP_INPUT_SCHEMA_PROFILE accepts only \"compact\" …"),
so `configureClientConfiguration` returned `failed/readback` before writing
and the case failed on every Windows run, including main's own
`Windows capability and package lane`.
The case has no Windows dependency — it passes an explicit `configPath` and
the Kimi write dialect is the same everywhere — so it now runs on every
platform, which is what let the stale value rot unnoticed. The fixture keeps
the lowercase explicit key the case is about, with the supported value.
Verified on `main` `d6bcfc10`: the same fixture driven through
`configureClientConfiguration(..., "win32")` on this host reproduced
`{"status":"failed","reason":"readback"}` with the retired value and now
returns `{"status":"configured"}` with `compact`. The file's 75 cases pass
here (66 run, 9 platform-conditioned skips) and `check:fast` passes.
* test(ci): restore verifier and MCP contract regressions
* test(captures): assert adapter-owned input issue field names
---------
Co-authored-by: g0at <50488370+g1at@users.noreply.github.com>
Co-authored-by: IvenKooLab <276572622@qq.com>
Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Read CLI catalogs and registrar ownership from the REA command records, type-check the catalog helper and consolidate registrar types. Preserve the generated catalogs, mapping and CLI parity.
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Own builtin refusal paths and Markdown schemas in REA. Reject retired per-command MCP before loading command registrars, preserve invoked identity, and apply token controls to the complete selected failure document.
BREAKING CHANGE: rea <command> --mcp is removed. Start REA's MCP server with rea mcp or rea --mcp.
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Move the last six bespoke Electron MCP registrations to named shared bindings, preserving admission, provider isolation, selected settings, Evidence and cleanup behavior. Remove the obsolete family module, redundant dependency bundle and final counted registration baseline.
Refs #11682 (D7).
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Hash and load an optional initial executable before GDB readiness, without running it. Preserve initial identity and completed hash diagnostics through cancellation and cleanup retry; share the file owner with Rizin.
Fixes#11581. Refs #11682.
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>