Commit Graph
706 Commits
Author SHA1 Message Date
morluto 68604b7e95 fix(elf): distinguish exhausted string tables from capped scans (#12693)
fix(elf): distinguish exact string-table ends from scan limits
2026-11-20 02:15:34 +00:00
morluto acd967c58a fix(elf): report the enforced kernel build config parser limit (#12679) 2026-11-20 02:02:48 +00:00
morluto 0fcbfe83dc fix(elf): retain readable build IDs beside compressed notes (#12674) 2026-11-20 02:02:45 +00:00
morluto c6f86cce57 fix(elf): preserve dynamic string diagnostic provenance (#12678)
* fix(elf): preserve DT_NEEDED diagnostic source offsets

* fix(elf): distinguish missing dynamic strings from invalid indices
2026-11-20 02:01:09 +00:00
morluto 2c7c858c5a refactor(native): share mapped ELF and FAT scalar readers (#12631) 2026-11-20 01:59:55 +00:00
morluto 46943787cb fix(macho): require exact legacy minimum-version command size (#12666) 2026-11-20 01:47:07 +00:00
morluto 273f048a55 fix(windows): report the enforced shortcut parser limit (#12661) 2026-11-20 01:38:27 +00:00
morluto 484bdc183a fix(elf): preserve truncated kernel config evidence at the inflate limit (#12653) 2026-11-20 01:36:11 +00:00
morluto 6596d294b9 refactor(macho): share selected fixup and magic field reads (#12637)
* refactor(macho): share selected fixup and magic field reads

* fix(macho): retain legacy weak and lazy bind streams
2026-11-20 01:34:45 +00:00
3cfe8480c5 fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits (#10189)
* fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits

`decodeCorePrpsinfo` assumed every ELFCLASS32 core carries the i386/ARM `struct elf_prpsinfo`:
16-bit `pr_uid`/`pr_gid` and a 124-byte descriptor.

`pr_uid` is `__kernel_uid_t`, and its width is an ABI property, not an ELF-class one. Only
`arch/x86/include/uapi/asm/posix_types_32.h` and its ARM/m68k/sparc counterparts narrow it to
`unsigned short`; everything else takes `asm-generic/posix_types.h`'s `unsigned int`, so MIPS o32,
PowerPC-32, s390 and `compat_elf_prpsinfo` (`include/asm-generic/compat.h`:
`typedef u32 __compat_uid_t`) write a 128-byte struct with every member after `pr_flag` four bytes
later.

Reading a 128-byte descriptor with the 124-byte offsets published wrong values rather than null.
Measured through `parseElfNotes`, with `uid 70000, gid 80000, pid 4242, fname mips-proc`:

    before: {"pid":80000,"ppid":4242,"pgrp":1,"sid":4242,"uid":4464,"gid":1,
             "filename":"\u{10}","psargs":""}
    after:  {"pid":4242,"ppid":1,"pgrp":4242,"sid":4242,"uid":70000,"gid":80000,
             "filename":"mips-proc","psargs":"./mips-proc --serve"}

`pid` came out of the middle of `gid` and the two text fields came from the wrong offsets
entirely.

The kernel writes `sizeof(*psinfo)` as the descriptor — `fs/binfmt_elf.c`:
`fill_note(&info->psinfo, PRPSINFO, sizeof(*psinfo), psinfo)` — so the declared length already
carries the distinction and no machine table is needed. The 32-bit id width is now
`descriptor.length >= 128 ? 4 : 2`, and `pr_pid`/`pr_fname`/`pr_psargs` are derived from it. The
124-byte and 136-byte decodes are unchanged; the second new case pins that.

`src/native/elf` and `src/domain/native` — 535 passing. Forcing the 16-bit layout fails the new case.

* test(elf): produce the 32-bit prpsinfo layout from the shared note builder

Review finding: the regression hand-encoded a second NT_PRPSINFO layout while `corePrpsinfoNote` is
the repository's producer for this format, so nothing else could represent the MIPS/PowerPC/s390
ABI and the two encodings could drift.

`corePrpsinfoNote` takes `idWidth: 2 | 4` now. It allocates 124 or 128 bytes from it, writes
`pr_uid`/`pr_gid` at that width, and derives `pr_pid` through `pr_psargs` from `8 + idWidth * 2`
instead of the fixed 12/28/44 offsets. The option is ignored for a 64-bit image, whose layout is
fixed at 136.

Both new cases build their descriptor through the producer, so the test no longer carries offsets
the fixture does not know about.

* test(elf): drop the duplicate 124-byte prpsinfo case

The previous commit's rewrite left the original hand-built 124-byte block in place, so the same
regression ran twice — once through `corePrpsinfoNote`, once with the offsets written out again.
Keeping both is exactly the drift the shared producer was supposed to end.

* fix(elf): preserve SuperH PRPSINFO decoding

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: wunianze666-netizen <wunianze666@gmail.com>
2026-11-20 01:23:27 +00:00
morluto a37fee0543 refactor(elf): project unwind limits from parser failures (#12644) 2026-11-20 01:19:20 +00:00
morluto 21dfefcfb2 refactor(il2cpp): share stored native image scalar reads (#12638)
refactor(il2cpp): share native registration scalar reads
2026-11-20 01:13:26 +00:00
morluto 6c7d69245e fix(crash): bound recorded core note source reads (#12634)
refactor(native): share recorded crash source reads
2026-11-20 01:11:57 +00:00
morluto d0ca65e524 refactor(elf): share fixed note descriptor reads (#12630) 2026-11-20 01:10:34 +00:00
morluto ba4205fe5e fix(swift): validate vtable bounds before slot capacity (#12627) 2026-11-20 01:08:31 +00:00
morluto b8e65d24af fix(windows): retain target uncertainty when ExtraData overruns (#12612) 2026-11-20 00:48:15 +00:00
RRFZ 18f102d692 refactor(elf): read core file and auxiliary words through BinaryReader (#12606) 2026-11-20 00:27:17 +00:00
Nianze Wuandmorluto 46f6d4638e fix(windows): check fixed Shell Link ExtraData sizes (#10361)
* fix(windows): check fixed Shell Link ExtraData sizes

* fix(windows): preserve unreadable shortcut target uncertainty

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 19:21:37 -05:00
morluto a611944533 fix(windows): report unexamined bytes in shortcut item lists (#12594) 2026-11-20 00:09:51 +00:00
morluto c8a783d7cf refactor(windows): share Shell Link location field reads (#12584) 2026-11-19 23:54:18 +00:00
RRFZandmorluto 6f3c016a5a refactor(native): read Mach-O initializer symbols and relocations with the image reader (#12571)
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 23:49:04 +00:00
morluto cddaef83ae refactor(elf): share fixed-width unwind field reads (#12574)
* refactor(elf): share fixed-width unwind field reads

* refactor(elf): share dynamic hash header word reads (#12577)

refactor(elf): share bounded hardening hash reads
2026-11-19 23:42:01 +00:00
RRFZ 9ed9d6c8a2 refactor(apple): share fixed-width reads across dyld chained fixups (#12560) 2026-11-19 22:59:05 +00:00
RRFZ 3e40979b42 refactor(native): share file-backed ELF and Mach-O initializer word reads (#12559) 2026-11-19 17:51:40 -05:00
RRFZ d51dd4a996 refactor(apple): read streamed Mach-O command fields through the shared word reader (#12552) 2026-11-19 17:37:18 -05:00
morluto 3f0f993233 fix(macho): share lazy dylib linkedit command facts (#12541) 2026-11-19 22:07:40 +00:00
RRFZ d5e5aaa062 refactor(elf): read module version CRCs through BinaryReader (#12530) 2026-11-19 16:59:01 -05:00
RRFZ 503379b953 refactor(pe): read TLS and load configuration fields through BinaryReader (#12533) 2026-11-19 16:56:22 -05:00
RRFZ 84731eefdf refactor(elf): read IKCONFIG gzip and boot fields through BinaryReader (#12525) 2026-11-19 15:59:21 -05:00
7fd50eb361 fix(zstd): share exact-frame Zstandard decoding across ELF and OTA (#12416)
* fix(zstd): share exact-frame Zstandard decoding across ELF and OTA

Walk RFC 8878 frames once so ELF sections, Android OTA REPLACE_ZSTD, and GPU payloads reject truncated headers, blocks, checksums, and trailing bytes on every supported Node runtime. Bound that walk with the runtime zstd.max_frames setting.

* fix(zstd): keep frame output tight and report GPU frame-cap refusals

Copy each Node 22 frame off its decoder chunk before the next frame is decoded. Map a GPU zstd.max_frames refusal through the resource-limit contract instead of a provider failure.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): keep frame-cap refusals and bad seeds out of malformed results

Project zstd.max_frames through one resource-limit helper for ELF notes, DWARF, GPU, and artifact reads. An invalid REA_ZSTD_MAX_FRAMES seed stays a configuration failure, and frame-header tests cover content size, window, dictionary id, and RLE blocks.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): yield GPU frame decoding so cancellation can land

The frame-by-frame fallback awaits a caller pause before each data frame. GPU yields and checks the read signal there, so a many-frame payload does not finish before a disconnect is observed.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): advertise the frame cap and keep strict GPU decode cancellable

List every operation that enforces zstd.max_frames, including GPU, DWARF, and ELF notes. The strict sequence uses the async decoder and checks the caller signal again after it returns, and a single output buffer is not copied a second time.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): refresh analysis-setting schemas and GPU frame-cap projection

Regenerate the advertised input summaries for inspect_analysis_settings and update_analysis_settings. GPU inventory now throws the projected zstd.max_frames resource limit from payload decode and #retainFailure, so the adjustable setting survives the public failure.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* style(gpu): format the frame-cap projection throw

oxfmt keeps the zstd.max_frames throw in #retainFailure on one line so CI format:check matches the local formatter.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): yield after the last frame-by-frame GPU decode

The fallback returned success in the same turn as the final synchronous frame, so a queued abort was still invisible to the caller's signal check. Pause once more before that success, matching the strict sequence.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): yield ELF, OTA, and DWARF frame decoding on the caller signal

The synchronous frame loop ignored abort signals owned by inspect_elf_notes, inspect_dwarf_units, and Android OTA partition reads. Those callers now use the cooperative decoder and yield before Zstandard work, and 32-frame cancellations cover each path.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): observe cancellation during structural parsing

* fix(zstd): project section-name frame caps at the ELF directory boundary

readElfDirectoryFromBuffer now requires the caller's operation and throws the adjustable zstd.max_frames resource limit. Hardening, unwind, and the other directory consumers keep that typed refusal instead of an adapter or I/O error.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(zstd): preserve optional ELF evidence when frames are capped

* fix(zip): validate Zstandard members through frame completion (#12461)

fix(zip): require complete Zstandard member frames

* fix(elf): yield hardening section name decoding

* fix(elf): yield section names for unwind and export reads

* fix(zstd): yield ELF directory reads that already own a cancellation signal

Hardening, unwind, initializers, exports, kernel modules, debug link, and Android JNI now read section names through the cooperative directory when their caller has a signal. Readers with no signal stay synchronous.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(elf): share one initializer directory and retain its snapshot

* fix(android): reuse the admitted JNI ELF directory

* fix(elf): retain optional debug candidate evidence through cooperative decoding

* fix(zstd): yield ELF section names for Go, Rust, and IL2CPP

These inspections already own an abort signal. Their ELF directory read now uses the cooperative container decoder so a queued cancellation can land during a many-frame section-name table.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(elf): recognize compressed kernel modules before ELF decoding

The cooperative module reader decoded the bytes as ELF before the container check, so gzip, xz, and zstd modules became malformed images. The compression check now returns the unsupported-container report first.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* refactor(elf): classify each container once before reading it

* fix(il2cpp): preserve admission order during cooperative linking

* fix(elf): reuse section-name decoding in debug-link comparison (#12472)

* style(elf): format updated section-reader test calls

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 19:45:26 +00:00
morluto 833916bb4a fix(macho): map high-backed segment bytes at their declared virtual range (#12479)
fix(macho): map high-backed segment file bytes at their declared virtual range
2026-11-19 19:13:47 +00:00
morluto f759193fa4 refactor(native): reuse Mach-O signature recognition for initializers (#12478) 2026-11-19 19:08:28 +00:00
吴佳浩Albenand吴佳浩 410b64ab1f refactor(native): read the format sniff magic through BinaryReader (#12473)
Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
2026-11-19 18:52:41 +00:00
吴佳浩Albenand吴佳浩 acc3fbb12a refactor(native): read recorded-crash fields through BinaryReader (#12464)
* refactor(pwndbg): read the mapping-table count through BinaryReader

* refactor(pwntools): read a recorded register through BinaryReader

---------

Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
2026-11-19 13:40:11 -05:00
吴佳浩Albenand吴佳浩 0356ea8cdd refactor(apple): read an ObjC binding slot through BinaryReader (#12466)
Co-authored-by: 吴佳浩 <wujiahao@supremind.com>
2026-11-19 13:39:56 -05:00
morluto 8349201627 fix(elf): report empty kernel module signature ranges as malformed (#12471) 2026-11-19 18:39:07 +00:00
morluto 5a62623cd1 fix(macho): validate symbol extents before the hardening scan limit (#12465)
fix(macho): validate hardening symbol extents before capacity
2026-11-19 18:23:37 +00:00
morluto a627952bd5 fix(native): preserve numeric Mach-O identities and CodeView path bytes (#12458) 2026-11-19 18:12:35 +00:00
morluto 0b12a6533b fix(elf): validate section-name backing before decode budget (#12449) 2026-11-19 18:03:03 +00:00
morluto 16e3263b10 fix(pe): bound TLS and export reads by declared section content (#12432)
* fix(pe): bound TLS template mappings by section content

* fix(pe): map export tables within declared section content (#12444)
2026-11-19 18:00:01 +00:00
morluto 49981ca709 fix(elf): share dynamic table framing and admission (#12445)
* fix(elf): share dynamic table row framing

* refactor(elf): reuse admitted dynamic ranges in hardening

* fix(elf): validate initializer table geometry before capacity

* refactor(elf): centralize strict dynamic directory admission
2026-11-19 17:56:16 +00:00
morluto 1ba93c8a1b refactor(elf): share fixed header declaration widths (#12391) 2026-11-19 15:59:06 +00:00
6a5d77bf21 fix(windows): floor LinkInfo string offsets at the mandatory header (#12403)
A LinkInfoHeaderSize below 0x1C no longer lowers the string-offset floor.
Reserved 0x1D..0x23 headers still end at their declared size, so ANSI
fields after that header stay readable.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 10:35:40 -05:00
morluto e9af636128 fix(macho): share marker-bearing dylib field decoding (#12400)
* fix(macho): share marker-bearing dylib field decoding

* fix(macho): retain legacy lazy dylib timestamps
2026-11-19 15:33:09 +00:00
morluto de9da86333 fix(windows): validate opaque shortcut block framing (#12401)
* fix(windows): check shortcut PropertyStore block size

* fix(windows): validate shortcut Shim block framing
2026-11-19 15:31:11 +00:00
morluto 205ab4a587 refactor(elf): share fixed symbol record widths (#12379) 2026-11-19 15:28:37 +00:00
morluto dd4be52a83 fix(windows): flag reserved shortcut LinkInfo header sizes (#12388)
fix(windows): report reserved LinkInfo header sizes
2026-11-19 15:22:03 +00:00
morluto cb9fce082d fix(elf): preserve compressed note storage through program aliases (#12390) 2026-11-19 15:20:25 +00:00
morluto a4c4366db2 fix(windows): report missing shortcut Darwin and Shim blocks (#12378)
* fix(windows): report missing shortcut Darwin and Shim blocks

* test(windows): accept declared Darwin and Shim blocks
2026-11-19 15:17:49 +00:00
Nianze WuandCursor Agent a4a633bae7 fix(windows): bound shortcut string offsets to structure data (#10416)
* fix(windows): reject shortcut paths into LinkInfo headers

* test(windows): cover shortcut suffix header offsets

* fix(windows): bound nested shortcut string offsets

* fix(windows): compare only complete shortcut targets

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 10:15:38 -05:00