* fix(process): settle an observed exit in progress before reporting a process present
An exiting process closes its sockets before it becomes a zombie. A
caller that reacts to the closed transport could read the captured
identity in that window and report it as present, so Hopper cleanup
retained the document and private runtime although the application had
exited.
Wait, within the existing cleanup verification grace, only while the
same identity is positively observed exiting.
Refs #10556
* refactor(process): reuse exit settlement when observing a bridge exit
Review follow-up for observeProcessStartIdentityExit.
The exit check added its own waiting loop beside
settleExitingProcessIdentities, with the same deadline, polling interval
and same-identity exiting check, so future exit-race fixes would need
two changes. The check now hands its first observation to the shared
settlement and keeps only the final result choice. The settlement and
its identity reader accept PID-only rows, the shape the host identity
reader already takes. One liveProcessIdentity helper maps absent and
exited identities for both observeProcessStartIdentity and the settled
result.
Behavior is unchanged: an exiting identity is re-read until it leaves
exit in progress or the cleanup grace ends; a replacement, absent or
zombie identity is exited, an unreadable one unverified, and one still
exiting at the deadline present.
Tests: src/process (850), the Hopper cleanup and session tests (15) and
20 Hopper boundary test files (114) pass. check:fast passes.
---------
Co-authored-by: Davmunrey <Davmunrey@users.noreply.github.com>
* fix(hopper): name the unconfirmed shutdown step in retained cleanup
When close_binary retains a Hopper document, the cleanup error lists the
retained resources but not why shutdown went unconfirmed. On Linux CI,
hopperClient.handshakeRecovery "recovers an application exit after the
first valid handshake occurs during cleanup" fails intermittently. The
vitest blob reports show only hopper-document and the runtime root
retained with authenticated_application "readable". From those facts we
cannot tell whether the shutdown request was not sent, failed, or was
sent while the application was still observed as present.
Record the shutdown request outcome (method, status, error tag and
provider state, or why it was not sent) and the final exit observation
of the authenticated application in the retained-document diagnostics.
Exit observation now reports a positively observed Linux exit in
progress (PF_EXITING before state Z) as "exiting", separate from
"present". Neither confirms exit. The flaky test asserts the projected
error, so a later failure prints these diagnostics in the CI log.
Refs #10556
* fix(hopper): retain fallback shutdown diagnostics
* test(hopper): retry cleanup after confirmed application exit
* fix(process): revalidate ownership before signaling
* fix(process): retain cleanup ownership until completion
* fix(process): keep omitted live descendants unresolved
A non-empty process table that omits a retained live PID cannot authorize a signal or certify cleanup. An empty table can still describe a token-verified owner.
* fix(process): read omitted Darwin run tokens by PID
A live identity that ps omitted was still validated through Darwin
environment(), which rejects any PID absent from a second process table.
Ask the native reader for that PID directly so the launch token can bind.
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Retain unresolved process identity and launch evidence through retryable cleanup. Share capture path normalization and preserve failed filesystem observations. Bound child output and drain Windows pipes without one-chunk throttling.
Reviewed fixes include #1628, #2632, #2644, #2784, #2928, #2931, #2965, #2992, and #3011.
Validation: 92 focused source tests passed; four platform-specific skips. Real Windows and Hopper lifecycle coverage was not rerun.
Add optional finalization_ms to keep observing a captured root after SIGTERM, record the actual finalizer exit and each signal attempt, and escalate once when needed. Bind the initial root identity to captured ownership and preserve observations through cleanup uncertainty.
Fixes#1253.
Co-authored-by: Mykola Dementiev <16836724+nikolay-dementiev@users.noreply.github.com>
Co-authored-by: N0zoM1z0 <161784452+N0zoM1z0@users.noreply.github.com>