* fix(electron): preserve scenario waits through renderer crashes
* fix(electron): retain action cancellation across final Inspector failure
* fix(electron): collect active state in a single Inspector call
Share the mcpServers upsert, create-table, empty-file, and uninstall cases
through jsonClientRegistrationContract. Trae and FreeBuff pass a location
resolver because their paths are not join(home, directory, filename).
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
* feat(uefi): add pure-TS UEFI firmware volume/FFS parser with inspect/extract tools
Add a dependency-free rea-uefi provider that maps AMI/Aptio flash images:
- inspect_uefi_firmware: aligned _FVH discovery, volume-relative FFS walking,
guided section/compression classification, conservative PSP-directory probing,
embedded-volume rescan and leftover-region classification; incremental SHA-256
and explicit integrity notes.
- extract_uefi_firmware: whole-image/volume/FFS-file/section extraction with
LZMA-custom/LZMAF86 and AMD-zlib decoding, SafeOutputTree staging, derivations
and extraction_gaps.
- UefiArtifactReader + 'uefi' format wiring across inventory/domain/contracts
so parsed volumes and extracted PE32/TE files hand off to deep-provider
analysis (open_binary -> Ghidra).
* feat(uefi): add inspect_uefi_nvram for AMI NVRAM variable stores
Add a pure-TypeScript tool that maps the vendor AMI NVRAM variable stores
(factory-default "StdDefaults" and peers) inside a flash image:
- scan the raw image for NVAR entry chains ("NVAR" + u16 total size +
u32 attribute 0x8[23]FFFFFF + state + NUL-terminated name + data),
- recurse into a container entry whose data is itself an NVAR chain, so the
StdDefaults setup variables surface as depth/parent_offset rows,
- report attributes, state, data range, SHA-256 and trailing padding per entry.
Verified against B550 AORUS Elite V2 FId: one StdDefaults store at 0x37090 with
the 11 expected nested variables (Setup, PlatformLang, AMITSESetup, XhciDID,
GcSensorVarName, PCI_COMMON, SioSetupData, UsbSupport, NetworkStackVar,
SecureBootSetup, Setup). Exposed as MCP tool and inspect-uefi-nvram CLI command.
* fix(uefi): address review on checksums, compression, guided sections, NVRAM bounds
- FFS file checksum: verify the two's-complement invariant (payload sum +
stored byte == 0 mod 256) instead of comparing sums, and encode the correct
complement in the fixture builder.
- Compression sections (type 0x01): use the 9-byte header and classify EFI
standard compression instead of 'none', so extraction reports a gap rather
than publishing compressed bytes as a raw section.
- GUID-defined sections: derive GUID/data-offset/attributes from the parsed
common header size (compact or extended) and reject out-of-range payload
offsets.
- AMI NVRAM: bound recursive chains to the enclosing container's data end and
report partial coverage when a valid nested chain is cut by max_depth.
* fix(uefi): bound decode memory, serialize operations, enforce deadline, mark truncation
- LZMA worker: enforce max_output_bytes while decoding through a bounded output
sink, so an oversized stream is rejected during expansion instead of after a
full decompression plus a second Buffer copy.
- Provider: serialize admitted operations (the promised single decode-worker
lane must not become one worker per overlapping call) and apply one
whole-request deadline that covers every decode stage, not a fresh per-stream
timer. close() drains the queue and the resource scope.
- Scan: track truncated sections of known type and report coverage partial
instead of complete when a section declares more bytes than are present.
* fix(uefi): cancellable queue, timeout surfacing, availability and reader omissions
- Queue: check the caller signal before enqueue and when a job reaches the head,
and race the queued promise against abort so a cancelled wait returns
immediately instead of blocking behind the active request.
- Deadline: track the internal deadline and return AnalysisTimeoutError instead
of the AnalysisCancelledError that runOwnedCommand reports for any external
abort, preserving the real failure reason for CLI/MCP callers.
- CapabilityInventory: treat inspect_uefi_nvram like the other bundled rea-uefi
tools so discovery does not demand Unblob for it.
- UefiArtifactReader: report image truncation through onOmission so inventory
coverage reflects the unread suffix even when no volume was found.
* fix(uefi): limit early cancellation to unstarted jobs and preserve timeout cleanup
- #raceWithAbort only returns early for jobs that have not started; once a
request is running, await it so worker cleanup and completed output are
preserved instead of being discarded by a bare cancellation.
- Reclassify a deadline-induced cancellation as AnalysisTimeoutError while
keeping its cause and cleanup observations, and never override a different
primary failure.
* docs(licenses): record UEFI decoder dependency notices
* fix(uefi): preserve stream provenance and bound firmware analysis
* feat(uefi): decode LZMAF86 guided sections
* fix(uefi): validate publication before commit and order decoder cleanup
* fix(uefi): preserve unsupported volumes and extraction gaps
---------
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
fix(tests): treat zombies as stopped in process liveness checks
Fixes#11819.
Killed descendants waiting to be reaped read as alive to
process.kill(pid, 0), so three boundary tests fail in containers
whose PID 1 does not reap orphans. The liveness checks now treat a
zombie as stopped, using the existing observePosixProcess helper
(ps -o stat=, comm-safe) with two small wrappers,
processHasStopped / processGroupHasStopped, swapped in at the three
call sites. Test-only change; production code untouched.
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Inspect local Maven/Gradle metadata as Evidence with bounded report/XML admission, preserved caller choices and owned cleanup.
Refs #8828; broader comparison and resolution work remains outside this change.
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Inspect supplied NuGet packages as local Evidence with bounded ZIP parsing, preserved caller choices and credential-safe metadata.
Fixes#8144
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
Address all four PR review findings structurally:
- Isolate concurrent Doctor probes and host subsystems in child
ArtifactResourceScope instances tracked via resources.track() so a failed
cleanup on one probe cannot deadlock or abort sibling reads before close().
- Include tests/ JS/TS helper modules and fixture path literals in
throughHelpers() and named() so changes to JS fixtures such as
fakeHopperReplies.mjs reach transitive helper and socket tests.
- Extract generic createSharedMcpSession() and reuse it in lazyLocalToolsMcp()
to preserve retryable cleanup draining and startup-failure attribution.
- Replace test-scoped createTestTempDirectory() with a file-scoped workspace
in jsonInputStatus.test.ts so the shared isolated home persists across tests.
Add offline ELF dependency, search-path, symbol-version and import inspection with retained Evidence summaries and pages. Bound GNU-hash work and preserve cancellation, stable identity and caller-selected parameters across CLI/MCP.
Assisted-by: Suika (gensokyo-skills:suika-scatter-gather-planning)
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
* fix(adb): run adb commands under owned supervision and start the adb server explicitly
The adb version probe and device commands now run through runOwnedCommand
in their own process group, keeping adb's SIGTERM-first stop through the
termination policy. A device command's escaped descendants are swept with
its cleanup, and cleanup that fails stays owned by the provider, which
retries it before its next operation.
Device operations start the adb server with an explicit `adb start-server`
first. The server is an external shared service: REA may start it but never
stops it, so a device command never forks it into its own cleanup.
runOwnedCommand gains a byte-limited stdout collector: output beyond
maxStdoutBytes is an output-limit failure, like an exceeded diagnostic
budget, and the collected bytes are kept exactly for binary protocols such
as screencap. Ownership preparation that cannot start its own helper for
lack of host capacity is reported as the command's host-capacity launch
failure.
* fix(adb): preserve completed refusals, server startup facts, and lazy server start
* fix(adb): scope runtime-root command cleanup and preserve incomplete command cleanup
* fix(adb): preserve completed bugreports and staging directories across command cleanup failures
* fix(adb): preserve bugreport command cleanup across readback failures and project live cleanup resources
Run ordinary CLI commands through REA's registry, argv parser and result owner.
Remove Incur, the second admission parse, SDK error middleware, output capture
and redundant command traversal. Preserve explicit redaction, publication
receipts, incremental output, terminal notice eligibility and drain ownership.
Migrate fixtures to real registrations and retain the derived-source notices.
Validation includes unchanged public parity goldens, public and lifecycle
regressions, repaired fixture consumers, real TTY base comparisons, exports
beyond the engine string limit, four schema catalogs and final static/docs
checks. Native provider and optional validator coverage limits are in the PR.
Fixes#11654. Fixes#10583. Refs #11682, #11476 and #10511.
BREAKING CHANGE: Markdown argument diagnostics use REA's literal escaping,
table widths and token counts. Flag-shaped unknown MCP subcommands honor the
selected format. Completion --schema/--version routes use the canonical
REA-owned hook rather than the retired SDK generator. Refresh affected literal
snapshots and regenerate completion hooks with rea completions <shell>.
Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
parseCliGlobalArguments replaces normalizeCliArguments, splitIncurBuiltinArguments and splitCliTimingArguments: it normalizes spaced output forms, routes the root --update alias, splits builtin switches and output values, and reads the timing global in one pass. The output-argument reader, the launcher's doctor path, lazy registration, the Amp scope guard, completions, mcp add, strict positionals and sensitive-value redaction read that record instead of scanning argv again. Only the incur hand-off adapter remains until dispatch moves to REA. Output is unchanged; the CLI parity goldens pass as recorded.
* test(cli): cover terminal stdout behaviour in the CLI parity goldens
* test(cli): run the terminal command as the owned process and relay its output live
* refactor(mcp): bind close_binary and reset_investigation through the shared table
* refactor(mcp): bind provider operations through the shared table (#11649)
* refactor(mcp): bind provider operations through the shared table
* fix(mcp): bind a provider operation only to the contract of the same name
* refactor(mcp): bind objdump and Rizin commands through the shared table (#11653)
* refactor(mcp): bind objdump and Rizin commands through the shared table
* test(rizin): keep the pre-admission Rizin checks under the mutation sweep
* refactor(mcp): bind the desktop build tools through the shared table
* test(lifecycle): cover browser-transport handshakes and cleanup retry
Close six provider lifecycle gaps: Electron CDP handshake, cleanup and retry; V8 inspector handshake; web-module-trace handshake and retry.
* test(lifecycle): assert retained cleanup finishes before the next acquisition
Hold the retried browser and Electron transport close and check that no replacement launch or connect starts until it completes. Track gated upgrade sockets in the fake CDP browser so close() destroys them.
* test(lifecycle): release held retry gates and join gated work on failure
Teardown for the resolver and Electron retry tests releases the held close and awaits the gated request even when an assertion fails while it is held.
* test(lifecycle): cover worker and tool launch, worker handshake, and decoder completion (#11512)
* test(lifecycle): cover worker and tool launch, worker handshake, and decoder completion
Close six provider lifecycle gaps: SQLite and JavaScript worker launch, JavaScript worker handshake, assetutil launch, and qlog and mitmproxy decoding through the owned decoder child.
* test(lifecycle): run the worker relaunch in a built project and check exits before close
The relaunch starts the built worker entry, so it moves to tests/boundary/javascript. The handshake tests now check that the stand-in child has exited when analyze() returns, before close() runs.
* test(lifecycle): cover in-process cancellation and PE certificate completion (#11524)
* test(lifecycle): cover in-process cancellation and PE certificate completion
Close six provider lifecycle gaps: caller cancellation for the managed, Harmony, JavaScript workflow, runtime reconciliation and V8 code cache providers, and PE certificate completion (an existing CLI/MCP regression). Two Apple application gaps remain (#11509).
* test(lifecycle): compare the whole retained V8 code cache observation
* test(javascript): hold the startup deadline clock until the stand-in worker is running
* test(javascript): restore real timers in a void teardown
* test(lifecycle): join the held Electron request on failure, refuse unmodeled Inspector commands, drop a wording assertion
* fix(apple): run assetutil under owned process supervision and retain unproven cleanup (#11586)
* fix(process): report a cancellation or deadline during refused final cleanup as that interruption
* fix(apple): prepare ownership before the assetutil deadline, keep per-stream allowances, join interrupted-cleanup tests
* fix(artifacts): classify assetutil launch failures through the shared launch owner
After #11615, owned-command launch failures are one launch-failed outcome
classified by the shared owner. The assetutil dialect keeps only its
unavailable report (launchUnavailable) and names its provider; host
capacity and E2BIG become resource constraints.
* fix(artifacts): keep a completed assetutil run's output on its cleanup-only report
When assetutil exits 0 but its process cleanup is unproven, the cleanup
error is the primary report. retainOwnedCommandCleanup now accepts the
completed run's captured output for such a caller, so CLI and MCP keep the
retained output beside the cleanup owner.
* fix(process): classify every launcher failure once by errno in the shared launch owner
* fix(process): keep the launch owner's syscall, cause and facts in RE and pwntools unavailable reports
Eleven tests were named "beyond the former ..." and pinned a value just above
a limit that no longer exists. Each now states and checks the current
contract:
- jsonShape: the caller's byte allowance is the only bound; a shape that fits
exactly is complete and one byte less is a capacity refusal.
- Hopper download: chunks arriving just inside the stall bound complete (the
trickle case already covers the total bound).
- Firmware: a selected analysis_timeout_ms above the default governs the owned
command, expressed from the default constant.
- Provider process output, CDP resources/timeline/WebMCP frames, Playwright
steps/artifacts/Electron waits, scenario diff and Bun ELF names: renamed to
the unbounded-count or exact-selection contract they check, with a note on
what bound (if any) still applies and where it is covered.
The six JavaScript analyzer tests with the same naming are left to their
workstream.
Refs #10515
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2)
The Evidence subject carries subject.identity (kind, sha256, format,
architecture, selection) and the Evidence ID commits to it, so raw/DOL
entry points and ESP flash offsets of the same bytes are different
subjects. Every record declares evidence_format: 2; revision 1 bundles,
standalone records and snapshots are refused with the recreate guidance.
binaryTargetIdentity is the one projection of an open target, used by
Evidence and snapshot comparison.
BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the
subject's target identity (subject.identity, including the raw/DOL entry
point or ESP flash offsets), and every record declares evidence_format: 2.
Evidence bundles, records and analysis snapshots from earlier releases are
refused; recreate the observations with this release.
* refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423)
Analysis views compare their parent's file identity (evidenceFileTarget)
and take path and digest from evidenceSubjectTarget instead of reading
the subject's digest, format and architecture members, which duplicate
subject.identity until they are removed. A counted guard
(evidence-subject-declaration-read) keeps new direct reads out and
records the 20 remaining files.
* fix(evidence): carry format refusals through Evidence readers and bind target selections
- safeParseEvidence/safeParseImmutableEvidence return the format refusal as
an expected failure; every consumer maps it to the one integrity refusal
with the recreate guidance. An unmarked object is an earlier record only
when it has every member records have always carried.
- ArtifactProvider inventory roots and provider subjects that name the
target's own bytes carry the target's selection (ESP flash offsets).
- Snapshot rows bind only Evidence whose identity, selection included,
matches the snapshot target.
- Entry-point selections use the raw-binary entry point form.
* fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent
- recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input
without an evidence_id is not Evidence (ok(undefined)); a record that names
one but fails authentication or is from another format revision is an
EvidenceIntegrityError carrying the recreate guidance, never undefined.
- Direct analysis retains that refusal as a secondary failure instead of
silently skipping source capture; cleanup projection, source-closure
annotation and the flutter, debugger and release-exposure recoveries use
the same owner (the last three previously read the unauthenticated schema).
- A desktop capture.json from an earlier format is refused with the recreate
guidance instead of "not desktop application capture Evidence".
* fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size
- The obligation ledger and reconstruction coverage examples named
evidence_format 1, which revision 2 refuses; they now use
EVIDENCE_FORMAT_REVISION.
- MCP delivery chose which unretained recovery to omit by a parsed-storage
lower bound clipped at the response budget. Once revision 2 subjects made
the source record's estimate cross the budget, both candidates tied at the
clip and the smaller source was omitted ahead of the larger completed
observation. Candidates are now ranked by serialized size, which is what
the budget counts.
* refactor(native): compare function snapshots by their Evidence target identity (#11450)
Function snapshots carry the subject's file target identity instead of the
duplicated subject declaration. Call paths and function comparisons compare
targets through sameTargetIdentity, so the same bytes opened at a different
raw entry point or ESP flash offset no longer count as one coordinate space:
build_call_path refuses the mix, and compare_functions no longer matches
entries by address across selections. Structural candidates and native
function matching read the architecture and digest through
evidenceFileTarget.
Refs #11417
* refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461)
Artifact comparison authenticates a summary against its retained inventory
through sameTargetIdentity and rebinds the alias with the whole target,
selection included, so a flash-selected inventory summary taken under an
alias path is no longer refused. WASM comparison, the analysis view
artifact projection and the inventory root check read the digest, format
and display path through the Evidence identity accessors.
Refs #11417
* refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470)
JavaScript application graphs, runtime reconciliation, managed inspection
and native verification sources, the record summary filter, the ledger's
residual-unknown target and bundle scope selection read the subject digest,
format and display path through evidenceFileTarget and
evidenceSubjectDisplay. No comparison changes: each reader matches one
record's facts against its own payload or a caller filter.
Refs #11417
* refactor(evidence)!: name the Evidence subject only by its target identity (#11497)
* refactor(evidence)!: name the Evidence subject only by its target identity
The subject keeps `identity` and the display facts `name` and `local_path`.
The duplicated `digest`, `format` and `architecture` members are removed; the
format-owned declaration now validates the identity itself. Readers the type
checker found move to the owner accessors; untyped reads in verify scripts,
the efficiency harness and test matchers move to `subject.identity`. The
`evidence-subject-declaration-read` text guard and its baseline are deleted.
Fixes#11473
Refs #11417
BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or
`architecture`; read `subject.identity.sha256`, `subject.identity.format` and
`subject.identity.architecture`. A record that still carries them is refused.
* test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID
* test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures
* feat(evidence)!: give every Evidence record an explicit subject identity (#11536)
* feat(evidence)!: give every Evidence record an explicit subject identity
A producer that cannot name a file passes an `unknown` target identity
with a closed reason (derived-from-linked-evidence, not-observed,
unsupported-subject) instead of no subject. The subject is non-null;
unknown subjects have no display facts. The generic missing-subject
limitation and `subjectUnavailableReason` are removed; producer-specific
explanations are ordinary limitations. Comparison identity requires the
derived unknown, and null-subject consumers ask the owner accessors.
Refs #11417
BREAKING CHANGE: every Evidence record has a subject. A record without a
file target names `subject.identity` `{ "kind": "unknown", "reason": … }`
with `name` and `local_path` null, instead of `subject: null` and the
limitation "Artifact identity is unavailable for this observation.".
Their Evidence IDs change.
* fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject
The verification scripts are not type-checked, so five createEvidence
callers still passed undefined (or a missing first target) after the subject
became required. They now pass unknownTarget("not-observed").
A managed application graph chose the first present input subject. Every
subject is now present, so an unknown artifact subject hid a file subject on
the member or boundary Evidence. The graph now takes the first input subject
that names a file.
* test(evidence): assert the subject kind instead of a presence the type now guarantees
Every Evidence record has a subject after this change, so test guards and
assertions that checked it for null always passed. Each now checks that the
fixture subject names a file, or is removed where a later fileIdentity,
fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null
assertions on Evidence subjects are removed; analysis-view inputs, whose
subject is optional, keep an undefined check.
* test(evidence): expect the Evidence subject format under its identity
Two boundary tests still matched subject.format, which slice 2e moved into
subject.identity. toMatchObject is not type-checked against the Evidence
shape, so they failed only when run (the signature test on macOS).
* refactor(contracts): move the CLI command name owner into src/contracts
* refactor(contracts): own catalog identity in contracts and server identity in process (#11435)
* refactor(contracts): move catalog identity into contracts and server identity into process
* refactor(contracts): own the advertised MCP schema presentation in contracts
* test(mcp): import the advertised presentation from contracts in toolSchemaValidity
* test(release): expect the catalog identity at its contracts path in the canary
* test(mcp): import the catalog identity from contracts in syntheticContractSurfaces
* refactor(contracts): import CLI command names from contracts in the capability conformance test
* test(lifecycle): map every registered provider to its lifecycle regressions or explicit gaps
* test(lifecycle): track the web module and source-map processes and resolve test files against the repository URL
* test(lifecycle): record gaps where named tests did not exercise the claimed stage
* test(lifecycle): cover objdump cleanup and command-provider cleanup retry (#11487)
Close five provider lifecycle gaps: objdump cleanup and retry, sigrok and tshark process cleanup retry, and WABT retry (an existing literal-titled regression).