Commit Graph
191 Commits
Author SHA1 Message Date
8c7977f174 fix(native)!: require separate inspection for plists outside bundles (#9754)
* fix(native): record inspected plist bytes and refuse files outside the bundle

An open app session keeps the executable as the Evidence subject for
inspect_plist, same as the other bundle-resource tools, but the result had
no digest of the plist bytes and any absolute path was sealed under that
subject. Record source_sha256 for the bytes read, and refuse a selection
that resolves outside the opened bundle.

Fixes #9479

* fix(native)!: scope plist selection to the opened bundle

BREAKING CHANGE: To inspect a plist outside an opened app bundle or resource root, open the plist as a separate target.

* fix(native): report plist snapshot filesystem effects

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 21:35:17 -05:00
morluto 2245d25aaa fix(harmony): match manifests at exact archive root paths (#12700) 2026-11-19 21:22:18 -05:00
morluto cf64e4ce3c fix(nuget): respect OPC part-name equivalence (#12691)
fix(nuget): preserve ambiguous OPC manifest identity
2026-11-20 02:16:52 +00:00
morluto 8b60f3f25f fix(nuget): reject invalid manifest relationship target modes (#12684)
fix(nuget): require an internal OPC manifest mode
2026-11-20 02:08:39 +00:00
morluto 0fcbfe83dc fix(elf): retain readable build IDs beside compressed notes (#12674) 2026-11-20 02:02:45 +00:00
morluto 13613a0476 docs: group guides by task and consolidate verification links 2026-11-19 20:47:23 -05:00
morlutoandCursor Agent e532d746f0 docs(limits): refresh the limit inventory and state the runtime-setting rule (#12655)
* docs(limits): refresh the limit inventory and state the runtime-setting rule

Recompute the inventory from ANALYSIS_SETTINGS and the numeric-limit
check, and make a hardcoded limit a runtime setting unless a fixed
ceiling has a stated format, protocol, or representation reason.

* docs(limits): distinguish runtime settings from per-call overrides

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-20 01:43:07 +00:00
吴佳浩Albenandmorluto ea4baaf6de fix(v8): read the code cache header size from the container (#10279)
* fix(v8): read the code cache header size from the container

V8 sizes the header with `kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` and
`kUnalignedHeaderSize` is 28, so the header is padded *after* its words: a 64-bit producer writes
32 header bytes and a 32-bit one writes 28. The reader pinned 32 and required the declared payload
to equal `bytes.length - 32`, so every container from a 32-bit producer failed as "truncated or
corrupt".

Measured here on Node 24.22.1 (V8 in x64): take a real cache and drop the four alignment bytes at
offset 28. V8 loads it unchanged — `cachedDataRejected === false` — while the reader refused it:

    before: Header declares a 392-byte payload but 388 bytes follow the 32-byte header
    after:  ACCEPT header_bytes=28 words=7 payload.offset=28

The payload-length word sits at byte 20 in both layouts, so the declared length already states how
much trailing padding the container carries. The header size is derived from it now: `28` and `32`
are admitted, the reported word table covers exactly the header the container holds (7 or 8 words),
and the schema requires that table to agree with `header_bytes`.

Nothing is loosened. A header that is neither 28 nor 32 bytes is still `malformed`, and the
16 existing cases pass unchanged — dropping only the derivation back to the constant fails exactly
the new narrow-header case.

`src/v8` — 26 passing. `npm run lint` and `tsc --noEmit` clean.

* fix(v8): refuse a wide cache that is only four bytes short

A review finding on the previous commit, and a real one: deriving the header size from the declared
payload length makes a 32-byte-header container truncated by four bytes resolve to 28, because
`bytes.length - declaredPayload` loses exactly those four bytes. The reader then accepted a
truncated cache and read its payload one word long.

The wide header's last word is `POINTER_SIZE_ALIGN` padding that V8 leaves zero, and a narrow
container has payload where that word sits. Measured on Node 24.22.1 across six different sources:
the padding word is always `0x00000000` and the first payload word is always non-zero. So the zero
word is the only evidence that separates the two, and it is now required to be non-zero for the
28-byte layout:

| container | before this commit | after |
| --- | --- | --- |
| real 32-byte header | accept | accept, `header_bytes=32` |
| real 28-byte header | accept | accept, `header_bytes=28` |
| 32-byte header truncated by 4 | **accept** | refused as `malformed` |

The guide also described one pinned 32-byte header; it now describes both layouts, how the size is
resolved, and why an ambiguous container is refused.

`src/v8` — 27 passing. Removing the guard accepts the truncated container again.

* fix(v8): read the padding word through the header accessor

A Static checks finding: `verify/architecture-guards.mjs` counts raw Buffer reads in parser folders
and allows only a shrinking baseline, and the previous commit added one:

```
raw Buffer or DataView numeric read (use BinaryReader ...); new copies are not allowed:
  src/v8/V8CodeCacheParser.ts: 2 (baseline 1)
```

The read is the narrow-header discriminator — the alignment word a 64-bit producer leaves zero at
offset 28. It now goes through the file's existing `field(index)` accessor instead of calling
`bytes.readUInt32LE` directly, so the count returns to the baseline while the check itself is
unchanged: `field(7)` is byte 28, and `V8_CODE_CACHE_NARROW_HEADER_BYTES / 4` spells that index.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 68 passing. `tsc --noEmit` 0 errors.
Setting the condition to `false` fails "refuses a wide container that is only four bytes short",
so the check is still load-bearing.

* fix(v8): ground the narrow-header rule in the producer, and test the word table

Two review findings.

**The rule was stated as measurement, not as format.** The previous comment justified the zero-word
discriminator with "measured on Node 24.22.1 every real payload begins with a non-zero word", which
makes support for other producers depend on one host. The producer zeroes that padding rather than
copying payload over it: `SerializedData::AllocateWithPayload` in `src/snapshot/snapshot-data.cc`
runs `std::fill_n(data_, header_size, 0)` before writing any header word, and
`kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` in `src/snapshot/code-serializer.h` puts the
four padding bytes inside `header_size`. So a zero word at byte 28 is a fact about the producer, not
about one Node build.

The refusal is now worded as the reservation it is: a narrow container whose payload happened to
begin with four zero bytes would match the same test, and no reading of the header alone separates
the two cases. The message says both readings instead of asserting corruption.

**The word-table rule had no test that could fail.** `header.fields.length * 4 === header.header_bytes`
cannot disagree on a parsed container — the parser derives both from `payloadOffset` — so it is only
reachable through the schema, which is what a stored or projected report also goes through. The new
case builds four reports directly: seven words with 32 bytes and eight words with 28 are refused on
`header.fields`, while the two consistent pairs are accepted. Setting the rule to `false` fails it
with `7 words / 32 bytes: expected true to be false`.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 69 passing. `tsc --noEmit` 0 errors, `npm run lint` 0 errors.

* refactor(v8): share decoded code cache header words

* fix(v8): validate narrow header evidence without assuming runtime compatibility

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-20 01:41:01 +00:00
morluto d68f6207cd fix(nuget): recognize license types case-insensitively (#12643) 2026-11-20 01:20:01 +00:00
morluto 5664a6fbd4 docs: clarify parser coverage and verification ownership 2026-11-19 19:42:28 -05:00
Nianze Wuandmorluto 46f6d4638e fix(windows): check fixed Shell Link ExtraData sizes (#10361)
* fix(windows): check fixed Shell Link ExtraData sizes

* fix(windows): preserve unreadable shortcut target uncertainty

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 19:21:37 -05:00
RRFZ 0fcace1ad1 fix(nuget): select publisher metadata from the first eligible leaf (#12603) 2026-11-19 19:20:10 -05:00
morluto 57d1d7ca5e fix(uefi): preserve parser coverage and source evidence (#12539)
* fix(uefi): report malformed volume extension metadata

* fix(uefi): preserve parser coverage and source evidence

* fix(uefi): bound inventory and tighten parser framing

* refactor(uefi): reuse shared byte formatting in diagnostics

* fix(uefi): accept extended sections at the compact size marker
2026-11-19 22:34:06 +00:00
morluto 9d0502bc51 fix(uefi): share inspection and extraction scan limits (#12538)
* fix(uefi): share inspection and extraction scan limits

* test(uefi): prove extraction honors the FFS file limit
2026-11-19 22:05:16 +00:00
morluto 745869e707 fix(uefi): account for FFS alignment bytes (#12532) 2026-11-19 21:41:42 +00:00
bartman081523andmorluto d380dc2409 feat(uefi): add pure-TypeScript UEFI firmware analysis tools (#12342)
* feat(uefi): add pure-TS UEFI firmware volume/FFS parser with inspect/extract tools

Add a dependency-free rea-uefi provider that maps AMI/Aptio flash images:
- inspect_uefi_firmware: aligned _FVH discovery, volume-relative FFS walking,
  guided section/compression classification, conservative PSP-directory probing,
  embedded-volume rescan and leftover-region classification; incremental SHA-256
  and explicit integrity notes.
- extract_uefi_firmware: whole-image/volume/FFS-file/section extraction with
  LZMA-custom/LZMAF86 and AMD-zlib decoding, SafeOutputTree staging, derivations
  and extraction_gaps.
- UefiArtifactReader + 'uefi' format wiring across inventory/domain/contracts
  so parsed volumes and extracted PE32/TE files hand off to deep-provider
  analysis (open_binary -> Ghidra).

* feat(uefi): add inspect_uefi_nvram for AMI NVRAM variable stores

Add a pure-TypeScript tool that maps the vendor AMI NVRAM variable stores
(factory-default "StdDefaults" and peers) inside a flash image:
- scan the raw image for NVAR entry chains ("NVAR" + u16 total size +
  u32 attribute 0x8[23]FFFFFF + state + NUL-terminated name + data),
- recurse into a container entry whose data is itself an NVAR chain, so the
  StdDefaults setup variables surface as depth/parent_offset rows,
- report attributes, state, data range, SHA-256 and trailing padding per entry.

Verified against B550 AORUS Elite V2 FId: one StdDefaults store at 0x37090 with
the 11 expected nested variables (Setup, PlatformLang, AMITSESetup, XhciDID,
GcSensorVarName, PCI_COMMON, SioSetupData, UsbSupport, NetworkStackVar,
SecureBootSetup, Setup). Exposed as MCP tool and inspect-uefi-nvram CLI command.

* fix(uefi): address review on checksums, compression, guided sections, NVRAM bounds

- FFS file checksum: verify the two's-complement invariant (payload sum +
  stored byte == 0 mod 256) instead of comparing sums, and encode the correct
  complement in the fixture builder.
- Compression sections (type 0x01): use the 9-byte header and classify EFI
  standard compression instead of 'none', so extraction reports a gap rather
  than publishing compressed bytes as a raw section.
- GUID-defined sections: derive GUID/data-offset/attributes from the parsed
  common header size (compact or extended) and reject out-of-range payload
  offsets.
- AMI NVRAM: bound recursive chains to the enclosing container's data end and
  report partial coverage when a valid nested chain is cut by max_depth.

* fix(uefi): bound decode memory, serialize operations, enforce deadline, mark truncation

- LZMA worker: enforce max_output_bytes while decoding through a bounded output
  sink, so an oversized stream is rejected during expansion instead of after a
  full decompression plus a second Buffer copy.
- Provider: serialize admitted operations (the promised single decode-worker
  lane must not become one worker per overlapping call) and apply one
  whole-request deadline that covers every decode stage, not a fresh per-stream
  timer. close() drains the queue and the resource scope.
- Scan: track truncated sections of known type and report coverage partial
  instead of complete when a section declares more bytes than are present.

* fix(uefi): cancellable queue, timeout surfacing, availability and reader omissions

- Queue: check the caller signal before enqueue and when a job reaches the head,
  and race the queued promise against abort so a cancelled wait returns
  immediately instead of blocking behind the active request.
- Deadline: track the internal deadline and return AnalysisTimeoutError instead
  of the AnalysisCancelledError that runOwnedCommand reports for any external
  abort, preserving the real failure reason for CLI/MCP callers.
- CapabilityInventory: treat inspect_uefi_nvram like the other bundled rea-uefi
  tools so discovery does not demand Unblob for it.
- UefiArtifactReader: report image truncation through onOmission so inventory
  coverage reflects the unread suffix even when no volume was found.

* fix(uefi): limit early cancellation to unstarted jobs and preserve timeout cleanup

- #raceWithAbort only returns early for jobs that have not started; once a
  request is running, await it so worker cleanup and completed output are
  preserved instead of being discarded by a bare cancellation.
- Reclassify a deadline-induced cancellation as AnalysisTimeoutError while
  keeping its cause and cleanup observations, and never override a different
  primary failure.

* docs(licenses): record UEFI decoder dependency notices

* fix(uefi): preserve stream provenance and bound firmware analysis

* feat(uefi): decode LZMAF86 guided sections

* fix(uefi): validate publication before commit and order decoder cleanup

* fix(uefi): preserve unsupported volumes and extraction gaps

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 21:19:35 +00:00
morluto 3dfd7c2f0d fix(elf): preserve unprefixed Kconfig hex values (#12516) 2026-11-19 20:53:49 +00:00
morluto 1ec32721af test(pe): pin stored resource name ordering (#12518) 2026-11-19 20:45:29 +00:00
morluto 77d2c62d4d fix(nuget): require the OPC namespace for manifest relationships (#12492) 2026-11-19 19:45:53 +00:00
morlutoandStefano Rizzello 673bd049b7 fix(flutter): inspect unified Dart AOT snapshot profiles (#12480)
* fix(flutter): inspect unified Dart AOT snapshot profiles

Port the unified Dart SDK layout from #3662 and resolve profiles from one dynamic-symbol inventory and the physical snapshot headers. Refs #3629.

Co-authored-by: Stefano Rizzello <rizzellostefano@gmail.com>

* fix(flutter): retain valid pools beside malformed snapshot exports

---------

Co-authored-by: Stefano Rizzello <rizzellostefano@gmail.com>
2026-11-19 19:22:54 +00:00
morlutoandCursor Agent 7df462cbfa feat(managed): retain unresolved definition coordinates (#12462)
* feat(managed): retain unresolved definition coordinates

* fix(managed): describe unresolved definition scope in summaries

* test(managed): isolate the selected coordinate fixture

* test(managed): use owned member scope guidance

* test(managed): use historical evidence for unknown method scope

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 19:03:27 +00:00
morluto 82fa175d2f fix(managed): refuse empty field definition identities (#12467) 2026-11-19 18:27:36 +00:00
morluto a627952bd5 fix(native): preserve numeric Mach-O identities and CodeView path bytes (#12458) 2026-11-19 18:12:35 +00:00
morluto 2837de5159 fix(har): retain Playwright 1.64.1 bracketed IPv6 addresses (#12456) 2026-11-19 18:04:38 +00:00
morluto 16e3263b10 fix(pe): bound TLS and export reads by declared section content (#12432)
* fix(pe): bound TLS template mappings by section content

* fix(pe): map export tables within declared section content (#12444)
2026-11-19 18:00:01 +00:00
morluto 4377c1a392 fix(managed): keep empty definition names out of member identity (#12448) 2026-11-19 17:51:46 +00:00
morluto 760478c5e9 fix(managed): retain Module identity when its name is unreadable (#12441)
fix(managed): retain module identity when its name is malformed
2026-11-19 17:47:18 +00:00
morluto 7cc7bda6e3 fix(android): validate OTA manifest and signature extents before capacity (#12431)
fix(android-ota): admit complete manifest and signature extents before limits
2026-11-19 17:22:55 +00:00
6a5d77bf21 fix(windows): floor LinkInfo string offsets at the mandatory header (#12403)
A LinkInfoHeaderSize below 0x1C no longer lowers the string-offset floor.
Reserved 0x1D..0x23 headers still end at their declared size, so ANSI
fields after that header stay readable.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-11-19 10:35:40 -05:00
morluto de9da86333 fix(windows): validate opaque shortcut block framing (#12401)
* fix(windows): check shortcut PropertyStore block size

* fix(windows): validate shortcut Shim block framing
2026-11-19 15:31:11 +00:00
morluto dd4be52a83 fix(windows): flag reserved shortcut LinkInfo header sizes (#12388)
fix(windows): report reserved LinkInfo header sizes
2026-11-19 15:22:03 +00:00
morluto a4c4366db2 fix(windows): report missing shortcut Darwin and Shim blocks (#12378)
* fix(windows): report missing shortcut Darwin and Shim blocks

* test(windows): accept declared Darwin and Shim blocks
2026-11-19 15:17:49 +00:00
Nianze WuandCursor Agent a4a633bae7 fix(windows): bound shortcut string offsets to structure data (#10416)
* fix(windows): reject shortcut paths into LinkInfo headers

* test(windows): cover shortcut suffix header offsets

* fix(windows): bound nested shortcut string offsets

* fix(windows): compare only complete shortcut targets

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 10:15:38 -05:00
a44ff73676 fix(apple): bound bundle Info.plist reads before decoding (#12279)
* fix(apple): bound bundle Info.plist reads before decoding

* refactor(apple): report plist input limits through shared failures

* fix(apple): retain bundle plist descriptors through target cleanup

* test(apple): verify Hopper retries bundle plist cleanup

* fix(apple): preserve typed cancellation through bundle plist cleanup

* fix(apple): preserve plist read failure through late cancellation

* fix(apple): preserve cancellation during plist close retry

* docs(apple): document bundle plist admission policy

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 13:41:40 +00:00
morluto 14aca264ea fix(windows): report out-of-spec shortcut StringData counts (#12352) 2026-11-19 13:33:05 +00:00
morluto f175382ed7 fix(plist): carry keyed archive parser limit facts into errors (#12324)
fix(apple): expose keyed archive parser limits in errors
2026-11-19 12:51:06 +00:00
morluto 39d20dce3d fix(pe): report the enforced resource parser limit (#12328) 2026-11-19 12:49:07 +00:00
morluto c5709b8697 fix(capture): validate PNG headers at the shared boundary (#12310)
fix(screenshot): validate IHDR encoding fields at capture
2026-11-19 12:38:50 +00:00
morluto cffff06ee7 fix(apple): bound FAT disambiguation to plausible JVM classes (#12316) 2026-11-19 07:28:34 -05:00
e91ddc89f9 fix(android-ota): require both payload signature fields (#12273)
* fix(android-ota): require both payload signature fields

* refactor(android-ota): share validated payload signature range

---------

Co-authored-by: ShuaixinHuang <197200901+ShuaixinHuang@users.noreply.github.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 12:15:06 +00:00
morluto c0d7e440de fix(sbom): preserve local Go modules without a Package URL namespace (#12293)
fix(sbom): require a namespace for Go Package URLs
2026-11-19 11:53:41 +00:00
ShuaixinHuang 9600b3ac7a fix(sbom): retain source-host artifact file names (#12230)
* fix(sbom): preserve backslashes in POSIX artifact names

* test(sbom): preserve fixture drive and recorded file name
2026-11-19 06:35:08 -05:00
morluto b406649be0 fix(managed): require unique Module rows with ambiguous string heaps (#12277)
Apply the Module row cardinality check before interpreting either the nil or nonzero name index in a conflicting #Strings layout.
2026-11-19 11:19:07 +00:00
morluto 1230afc030 fix(web): honor the captured JavaScript language (#12278) 2026-11-19 11:19:04 +00:00
Oke Iyanuoluwa Enoch 41db934de8 fix(native): let plutil decide XML plists REA's reader refuses (#12251)
CoreFoundation reads some XML plists that strict XML rejects, such as
documents with a double hyphen in a comment or a control character in a
string. inspect_plist refused them although plutil -lint accepts them,
and the outcome depended on how file(1) described the bytes.

When REA's XML reader refuses a document's syntax, inspection now takes
the existing plutil conversion route. The result keeps format xml and a
limitation names REA's reason. A document plutil also rejects stays
refused with its diagnostic, and plist structure errors in well-formed
XML are still refused without conversion.

Fixes #12234
2026-11-19 06:15:08 -05:00
hhangandhhang 7419328ea7 fix(android): accept R8 mapping separator spacing (#12247)
Co-authored-by: hhang <169027046+xu91102@users.noreply.github.com>
2026-11-19 06:09:37 -05:00
morluto a4bf59f661 fix(managed): preserve Module identity with an unresolved name (#12265)
Admit exact string heap aliases and retain independent Module row facts for distinct declarations. Bind the optional partial row to the same scope checks as named Module Evidence.
2026-11-19 06:08:59 -05:00
morluto 519547d022 fix(web): verify worker script import identity (#12264) 2026-11-19 06:07:48 -05:00
morluto fe6c9bcf66 fix(javascript): share TypeScript suffix grammar across parsers (#12257)
* fix(javascript): share TypeScript suffix grammar across parsers

* docs(javascript): explain explicit TypeScript suffix diagnostics

* fix(javascript): retain explicit-suffix assertions as complete
2026-11-19 08:56:52 +00:00
morluto ae8fb57ef0 fix(managed): preserve duplicate GUID stream ambiguity (#12217)
* fix(managed): preserve duplicate GUID stream ambiguity

* fix(managed): preserve ambiguous metadata stream declarations (#12226)

Use one stream declaration owner for heap and table diagnostics. Keep user strings and row-layout uncertainty separate from independent PE/CLI observations.

* test(managed): separate heap entries from cache behavior

* fix(managed): preserve duplicate blob heap ambiguity (#12258)

Resolve #Blob in the shared stream layout. Preserve nil references and independent facts without emitting unsupported keys, signatures or hashes.
2026-11-19 03:49:34 -05:00