Commit Graph
5631 Commits
Author SHA1 Message Date
morlutoandCursor Agent bb8e6833eb test: assert structured recovery facts instead of recovery wording in tests/ (#12723)
Drop recovery-sentence locks when a structured field or the owning
formatter already carries the fact, and own this batch's per-test
temporary directories through createTestTempDirectory. Keep setting
names, caller data, and prose that has no structured carrier.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 23:03:53 -05:00
morluto 847c2d5253 test(desktop): check cleanup of both concurrent reader leases 2026-11-19 22:15:56 -05:00
morluto 9d3bf82c6a test(desktop): require a verdict for every regenerated check 2026-11-19 22:12:53 -05:00
morluto e1e24543e4 test: prove retained facts and remove preinstall source greps 2026-11-19 22:12:19 -05:00
morluto 6bb2ad90ac test: harden verifier assertions and prune duplicate checks 2026-11-19 22:09:03 -05:00
morluto f3734d90e7 test(ci): repair stale coverage expectations on main 2026-11-19 22:09:03 -05:00
RRFZ af0d9ed45a test(uninstall): cover Windows purge without POSIX cache assumptions (#12696) 2026-11-19 22:04:23 -05:00
morluto e53c1a17fc fix(gpu): validate standalone PTX encoding during discovery (#12707) 2026-11-19 21:44:06 -05:00
8c7977f174 fix(native)!: require separate inspection for plists outside bundles (#9754)
* fix(native): record inspected plist bytes and refuse files outside the bundle

An open app session keeps the executable as the Evidence subject for
inspect_plist, same as the other bundle-resource tools, but the result had
no digest of the plist bytes and any absolute path was sealed under that
subject. Record source_sha256 for the bytes read, and refuse a selection
that resolves outside the opened bundle.

Fixes #9479

* fix(native)!: scope plist selection to the opened bundle

BREAKING CHANGE: To inspect a plist outside an opened app bundle or resource root, open the plist as a separate target.

* fix(native): report plist snapshot filesystem effects

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 21:35:17 -05:00
morluto c0ee832a30 fix(javascript): honor outer lexical order through standalone blocks (#12701)
fix(javascript): carry lexical timing through standalone blocks
2026-11-19 21:24:20 -05:00
morluto 2245d25aaa fix(harmony): match manifests at exact archive root paths (#12700) 2026-11-19 21:22:18 -05:00
morluto ea26a4a46c fix(elf): retain mapped leading GNU symbol version slots (#12685)
* fix(elf): retain mapped leading GNU symbol version slots

* fix(elf): report short version tables during admission
2026-11-20 02:19:55 +00:00
morluto 68604b7e95 fix(elf): distinguish exhausted string tables from capped scans (#12693)
fix(elf): distinguish exact string-table ends from scan limits
2026-11-20 02:15:34 +00:00
morluto ddd31b0289 fix(javascript): preserve uncertainty before lexical initialization (#12682)
* fix(javascript): preserve uncertainty before lexical initialization

* fix(javascript): respect lexical declarator initialization order
2026-11-20 02:13:04 +00:00
morluto acd967c58a fix(elf): report the enforced kernel build config parser limit (#12679) 2026-11-20 02:02:48 +00:00
morluto 0fcbfe83dc fix(elf): retain readable build IDs beside compressed notes (#12674) 2026-11-20 02:02:45 +00:00
morluto 9c95d0ded3 fix(gradle): preserve variant identity in metadata evidence (#12677)
* fix(gradle): preserve unique variant identity

* test(gradle): cover unnamed variants and whitespace identity
2026-11-20 02:01:27 +00:00
morluto c6f86cce57 fix(elf): preserve dynamic string diagnostic provenance (#12678)
* fix(elf): preserve DT_NEEDED diagnostic source offsets

* fix(elf): distinguish missing dynamic strings from invalid indices
2026-11-20 02:01:09 +00:00
morluto a5f19cbaf6 fix(javascript): preserve uncertainty after immutable pattern targets (#12673)
* fix(javascript): preserve uncertainty after immutable pattern targets

* fix(javascript): retain self-name assignment rules in patterns
2026-11-20 02:01:05 +00:00
morluto bd887a96be refactor(apk): project signing block pair limits from the parser (#12670)
* refactor(apk): project the signing-block pair limit from the parser

* test(apk): compare the pair refusal with the parser-owned reason
2026-11-20 01:58:07 +00:00
morluto 0ab693fe81 fix(maven): match declarations in the project namespace (#12672) 2026-11-20 01:54:59 +00:00
RRFZandmorluto 070d6420ec test(platform): skip POSIX host-path premises on Windows (#12664)
* test(platform): skip POSIX host-path premises on Windows

* test(inspector): retain Windows target listing coverage

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 20:53:15 -05:00
RRFZ 25f6adffdc test(setup): keep literal Hermes profiles distinct from named homes (#12658) 2026-11-19 20:52:32 -05:00
morluto a3df11ebf5 refactor(apk): project the v1 directory entry limit from the parser (#12665)
* refactor(apk): project the v1 directory entry limit from the parser

* test(apk): compare v1 refusal with the parser-owned reason
2026-11-20 01:51:02 +00:00
morlutoandCursor Agent e21efd7664 fix(limits): drop never-landed limits from the numeric-limit verifier (#12669)
REQUIRED_RUNTIME_LIMITS still named three limits whose PRs never merged.
The checker skipped a required name absent from source, so the stale
entries passed. Remove them and fail that case with a typed result that
names the limit.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-20 01:50:02 +00:00
morluto 46943787cb fix(macho): require exact legacy minimum-version command size (#12666) 2026-11-20 01:47:07 +00:00
RRFZ 308a5b2f06 test(providers): give Windows a drive-rooted configured launcher (#12626)
* test(apktool): give Windows a drive-rooted authored launcher

The apktool unit and CLI boundary tests configure REA_APKTOOL_COMMAND
as /authored/apktool, /opt/apktool/apktool or /nonexistent/apktool.
On win32 hosts REA admits a configured launcher only when it is drive-
or UNC-rooted, so 17 cases there failed with the absolute-path refusal
before reaching the behavior they test. On Windows they now use the
same paths under C:\; other hosts keep the original strings.

* test(adb): give Windows a drive-rooted missing adb in the CLI refusals

The two "/nonexistent/adb names the host requirement" cases hit the
same win32 absolute-path refusal as the apktool launcher cases before
reaching the not-found check. On Windows they now use C:\nonexistent\adb.
2026-11-19 20:47:04 -05:00
morlutoandCursor Agent e5b91f60ef docs: correct a moved LZ4 path and a nonexistent script example (#12651)
Keep the audited-base citation of src/gpu/Lz4Block.ts and record the
current src/compression/Lz4Block.ts location. Point the obligation-ledger
verifier example at an existing MCP cancellation test.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-19 20:46:12 -05:00
吴佳浩Albenandmorluto ea4baaf6de fix(v8): read the code cache header size from the container (#10279)
* fix(v8): read the code cache header size from the container

V8 sizes the header with `kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` and
`kUnalignedHeaderSize` is 28, so the header is padded *after* its words: a 64-bit producer writes
32 header bytes and a 32-bit one writes 28. The reader pinned 32 and required the declared payload
to equal `bytes.length - 32`, so every container from a 32-bit producer failed as "truncated or
corrupt".

Measured here on Node 24.22.1 (V8 in x64): take a real cache and drop the four alignment bytes at
offset 28. V8 loads it unchanged — `cachedDataRejected === false` — while the reader refused it:

    before: Header declares a 392-byte payload but 388 bytes follow the 32-byte header
    after:  ACCEPT header_bytes=28 words=7 payload.offset=28

The payload-length word sits at byte 20 in both layouts, so the declared length already states how
much trailing padding the container carries. The header size is derived from it now: `28` and `32`
are admitted, the reported word table covers exactly the header the container holds (7 or 8 words),
and the schema requires that table to agree with `header_bytes`.

Nothing is loosened. A header that is neither 28 nor 32 bytes is still `malformed`, and the
16 existing cases pass unchanged — dropping only the derivation back to the constant fails exactly
the new narrow-header case.

`src/v8` — 26 passing. `npm run lint` and `tsc --noEmit` clean.

* fix(v8): refuse a wide cache that is only four bytes short

A review finding on the previous commit, and a real one: deriving the header size from the declared
payload length makes a 32-byte-header container truncated by four bytes resolve to 28, because
`bytes.length - declaredPayload` loses exactly those four bytes. The reader then accepted a
truncated cache and read its payload one word long.

The wide header's last word is `POINTER_SIZE_ALIGN` padding that V8 leaves zero, and a narrow
container has payload where that word sits. Measured on Node 24.22.1 across six different sources:
the padding word is always `0x00000000` and the first payload word is always non-zero. So the zero
word is the only evidence that separates the two, and it is now required to be non-zero for the
28-byte layout:

| container | before this commit | after |
| --- | --- | --- |
| real 32-byte header | accept | accept, `header_bytes=32` |
| real 28-byte header | accept | accept, `header_bytes=28` |
| 32-byte header truncated by 4 | **accept** | refused as `malformed` |

The guide also described one pinned 32-byte header; it now describes both layouts, how the size is
resolved, and why an ambiguous container is refused.

`src/v8` — 27 passing. Removing the guard accepts the truncated container again.

* fix(v8): read the padding word through the header accessor

A Static checks finding: `verify/architecture-guards.mjs` counts raw Buffer reads in parser folders
and allows only a shrinking baseline, and the previous commit added one:

```
raw Buffer or DataView numeric read (use BinaryReader ...); new copies are not allowed:
  src/v8/V8CodeCacheParser.ts: 2 (baseline 1)
```

The read is the narrow-header discriminator — the alignment word a 64-bit producer leaves zero at
offset 28. It now goes through the file's existing `field(index)` accessor instead of calling
`bytes.readUInt32LE` directly, so the count returns to the baseline while the check itself is
unchanged: `field(7)` is byte 28, and `V8_CODE_CACHE_NARROW_HEADER_BYTES / 4` spells that index.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 68 passing. `tsc --noEmit` 0 errors.
Setting the condition to `false` fails "refuses a wide container that is only four bytes short",
so the check is still load-bearing.

* fix(v8): ground the narrow-header rule in the producer, and test the word table

Two review findings.

**The rule was stated as measurement, not as format.** The previous comment justified the zero-word
discriminator with "measured on Node 24.22.1 every real payload begins with a non-zero word", which
makes support for other producers depend on one host. The producer zeroes that padding rather than
copying payload over it: `SerializedData::AllocateWithPayload` in `src/snapshot/snapshot-data.cc`
runs `std::fill_n(data_, header_size, 0)` before writing any header word, and
`kHeaderSize = POINTER_SIZE_ALIGN(kUnalignedHeaderSize)` in `src/snapshot/code-serializer.h` puts the
four padding bytes inside `header_size`. So a zero word at byte 28 is a fact about the producer, not
about one Node build.

The refusal is now worded as the reservation it is: a narrow container whose payload happened to
begin with four zero bytes would match the same test, and no reading of the header alone separates
the two cases. The message says both readings instead of asserting corruption.

**The word-table rule had no test that could fail.** `header.fields.length * 4 === header.header_bytes`
cannot disagree on a parsed container — the parser derives both from `payloadOffset` — so it is only
reachable through the schema, which is what a stored or projected report also goes through. The new
case builds four reports directly: seven words with 32 bytes and eight words with 28 are refused on
`header.fields`, while the two consistent pairs are accepted. Setting the rule to `false` fails it
with `7 words / 32 bytes: expected true to be false`.

`node scripts/verify/architecture-guards.mjs` — passed across 2 843 source files.
`src/v8` + `tests/boundary/rust` — 69 passing. `tsc --noEmit` 0 errors, `npm run lint` 0 errors.

* refactor(v8): share decoded code cache header words

* fix(v8): validate narrow header evidence without assuming runtime compatibility

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-20 01:41:01 +00:00
morluto fd2bc88d53 fix(javascript): retain effects only from reachable first defaults (#12659) 2026-11-20 01:40:30 +00:00
morluto 2a6786168a refactor(apk): project scheme limits from the parser (#12662)
* refactor(apk): project scheme limits from the parser

* fix(apk): establish scheme record framing before capacity
2026-11-20 01:38:54 +00:00
morluto 273f048a55 fix(windows): report the enforced shortcut parser limit (#12661) 2026-11-20 01:38:27 +00:00
morluto 484bdc183a fix(elf): preserve truncated kernel config evidence at the inflate limit (#12653) 2026-11-20 01:36:11 +00:00
morluto ed336bd31c fix(ghidra): retain DOS images with order-dependent fixups (#12649) 2026-11-20 01:29:50 +00:00
3cfe8480c5 fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits (#10189)
* fix(elf): decode a 32-bit prpsinfo whose ABI gives pr_uid 32 bits

`decodeCorePrpsinfo` assumed every ELFCLASS32 core carries the i386/ARM `struct elf_prpsinfo`:
16-bit `pr_uid`/`pr_gid` and a 124-byte descriptor.

`pr_uid` is `__kernel_uid_t`, and its width is an ABI property, not an ELF-class one. Only
`arch/x86/include/uapi/asm/posix_types_32.h` and its ARM/m68k/sparc counterparts narrow it to
`unsigned short`; everything else takes `asm-generic/posix_types.h`'s `unsigned int`, so MIPS o32,
PowerPC-32, s390 and `compat_elf_prpsinfo` (`include/asm-generic/compat.h`:
`typedef u32 __compat_uid_t`) write a 128-byte struct with every member after `pr_flag` four bytes
later.

Reading a 128-byte descriptor with the 124-byte offsets published wrong values rather than null.
Measured through `parseElfNotes`, with `uid 70000, gid 80000, pid 4242, fname mips-proc`:

    before: {"pid":80000,"ppid":4242,"pgrp":1,"sid":4242,"uid":4464,"gid":1,
             "filename":"\u{10}","psargs":""}
    after:  {"pid":4242,"ppid":1,"pgrp":4242,"sid":4242,"uid":70000,"gid":80000,
             "filename":"mips-proc","psargs":"./mips-proc --serve"}

`pid` came out of the middle of `gid` and the two text fields came from the wrong offsets
entirely.

The kernel writes `sizeof(*psinfo)` as the descriptor — `fs/binfmt_elf.c`:
`fill_note(&info->psinfo, PRPSINFO, sizeof(*psinfo), psinfo)` — so the declared length already
carries the distinction and no machine table is needed. The 32-bit id width is now
`descriptor.length >= 128 ? 4 : 2`, and `pr_pid`/`pr_fname`/`pr_psargs` are derived from it. The
124-byte and 136-byte decodes are unchanged; the second new case pins that.

`src/native/elf` and `src/domain/native` — 535 passing. Forcing the 16-bit layout fails the new case.

* test(elf): produce the 32-bit prpsinfo layout from the shared note builder

Review finding: the regression hand-encoded a second NT_PRPSINFO layout while `corePrpsinfoNote` is
the repository's producer for this format, so nothing else could represent the MIPS/PowerPC/s390
ABI and the two encodings could drift.

`corePrpsinfoNote` takes `idWidth: 2 | 4` now. It allocates 124 or 128 bytes from it, writes
`pr_uid`/`pr_gid` at that width, and derives `pr_pid` through `pr_psargs` from `8 + idWidth * 2`
instead of the fixed 12/28/44 offsets. The option is ignored for a 64-bit image, whose layout is
fixed at 136.

Both new cases build their descriptor through the producer, so the test no longer carries offsets
the fixture does not know about.

* test(elf): drop the duplicate 124-byte prpsinfo case

The previous commit's rewrite left the original hand-built 124-byte block in place, so the same
regression ran twice — once through `corePrpsinfoNote`, once with the offsets written out again.
Keeping both is exactly the drift the shared producer was supposed to end.

* fix(elf): preserve SuperH PRPSINFO decoding

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
Co-authored-by: wunianze666-netizen <wunianze666@gmail.com>
2026-11-20 01:23:27 +00:00
morluto 78fdc7ecf7 fix(gradle): disclose unfamiliar metadata revisions (#12648) 2026-11-20 01:22:36 +00:00
morluto 17ada289ac fix(javascript): retain original nested iterator acquisitions (#12645) 2026-11-20 01:20:59 +00:00
morluto d68f6207cd fix(nuget): recognize license types case-insensitively (#12643) 2026-11-20 01:20:01 +00:00
morluto 939dd19efe fix(gpu): report the enforced parser limit (#12646) 2026-11-20 01:19:45 +00:00
morluto 21dfefcfb2 refactor(il2cpp): share stored native image scalar reads (#12638)
refactor(il2cpp): share native registration scalar reads
2026-11-20 01:13:26 +00:00
morluto b2c19952e9 test(firmware): scope directory sync cancellation to POSIX (#12636) 2026-11-20 01:07:15 +00:00
ShuaixinHuangandShuaixinHuang e40b735954 fix(ci): skip unused translation indexes during runner provisioning (#12609)
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
2026-11-20 01:04:23 +00:00
RRFZ 22ead365e7 refactor(providers): share firmware and Flutter cleanup aggregation (#12618)
* refactor(providers): share firmware and Flutter cleanup aggregation

* test(firmware): check both cleanup failure records through retry
2026-11-20 01:03:56 +00:00
morluto ba2d70d71e fix(javascript): retain numeric reads from projected arrays (#12624) 2026-11-20 01:01:22 +00:00
morluto e9ecf900d2 fix(uefi): enforce volume dialect for large FFS files (#12614)
* fix(uefi): enforce volume dialect for large FFS files

* fix(uefi): retain siblings after interrupted FFS2 headers
2026-11-20 00:57:48 +00:00
morluto c1de510702 fix(javascript): retain read proof across inactive destructuring defaults (#12613)
fix(javascript): retain destructuring proof across inactive defaults
2026-11-20 00:48:03 +00:00
ShuaixinHuangandShuaixinHuang d405115e41 fix(ci): make recorded crash APT refresh bounded and observable (#12607)
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
2026-11-20 00:36:28 +00:00
ShuaixinHuangandShuaixinHuang e36e5d46e8 fix(ci): budget the binary layout cross-toolchain download (#12605)
Co-authored-by: ShuaixinHuang <ShuaixinHuang@users.noreply.github.com>
2026-11-20 00:29:28 +00:00
Vinícius Andrade 524a0906c7 fix(uefi): recognize the PI firmware file system 3 GUID (#12602)
* fix(uefi): recognize the PI firmware file system 3 GUID

FFS3_FILE_SYSTEM_GUID held 54731207-5c41-4cbd-b5e5-cd26d80770b1, which
is not a published file-system GUID. The PI Specification and EDK II
define EFI_FIRMWARE_FILE_SYSTEM3_GUID as
5473c07a-3dcb-4dca-bd6f-1e9689e7349a, so a real FFS3 volume was
classified as an unsupported file system: its files were not walked and
flash admission did not count it.

Use the published value. The opaque-volume acceptance case built its
walked volume from the same literal and now declares the published GUID.

* test(uefi): pin the FFS3 GUID to its published raw bytes

Every FFS3 fixture was built from FFS3_FILE_SYSTEM_GUID itself, so the
tests followed whatever value the constant held. Check the constant
against the sixteen bytes EDK II defines for
EFI_FIRMWARE_FILE_SYSTEM3_GUID, as the FFS2 case does for its GUID.
2026-11-19 19:23:16 -05:00
Nianze Wuandmorluto 46f6d4638e fix(windows): check fixed Shell Link ExtraData sizes (#10361)
* fix(windows): check fixed Shell Link ExtraData sizes

* fix(windows): preserve unreadable shortcut target uncertainty

---------

Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
2026-11-19 19:21:37 -05:00