2 Commits

Include renames

Author	SHA1	Message	Date
4 people	92a9591a41	refactor(pcap): give TShark selection and version admission one owner (#3407) ... * refactor(pcap): give TShark selection and version admission one owner The pcap and packet-capture families wrapped the same caller-supplied TShark with diverging rules. inspect_pcap_* accepted an absolute REA_TSHARK_COMMAND or tshark from PATH, while inspect_packet_* and the server availability policy required an absolute REA_TSHARK_COMMAND and parsed the version banner with a separate regex. PcapConfiguration now owns the rule: selectWiresharkTool selects an absolute environment path or the bare name on PATH and refuses relative values; locateWiresharkTool resolves a PATH selection to the first absolute PATH entry holding an executable file; parseWiresharkVersion admits Wireshark 4.x banners for both providers. TsharkCaptureProvider and the session availability policy consume these facts instead of reinterpreting REA_TSHARK_COMMAND, so all four tools accept and refuse the same configurations. inspect_packet_* still resolves, hashes and rechecks the located executable, and records selection_source in its tool Evidence. Host support and resource bounds are unchanged; unifying them is the next milestone in #3403. Refs #3403 * fix(pcap): execute the TShark the shared locator selects resolvePcapTools still returned bare tool names for PATH selections, so the operating system could run a tool from a relative PATH entry while the packet tools skipped that entry and selected a different install. On POSIX hosts, resolve PATH selections through locateWiresharkTool and run that absolute executable, failing with the existing tshark_missing or capinfos_missing code when no absolute PATH entry holds the tool. Both selections are validated before PATH is consulted, so a relative environment value still reports its own configuration error. Windows keeps PATH/PATHEXT resolution in the process launcher. Refs #3403 * chore: restore main's copies of files the merge hook reformatted The pre-commit oxlint --fix touched two files this PR does not change; keep them identical to main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(pcap): share selected tool identity verification * perf(pcap): retain compact executable identity * fix(pcap): report missing selected tools clearly * fix(pcap): read historical capture evidence * fix(pcap): preserve executable read failures * test(pcap): cover version refusal and packet-tool availability selection Address review follow-ups on the shared TShark owner: - Send a 3.x TShark banner and a non-Wireshark banner through the packet provider, pinning the capability-unavailable reason for each and that only the version probe ran before refusal. - Cover the session availability rule for inspect_packet_capture over MCP: a PATH-only install and an absolute REA_TSHARK_COMMAND are available on Linux, a relative REA_TSHARK_COMMAND is refused even when PATH holds TShark, and no absolute PATH entry reports provider_missing. - Rename the locator test's missing absolute PATH entry so it no longer shadows node:path relative. Refs #3403 * fix(pcap): name the configured path when a selected tool is missing Resolving the selected executable before launch replaced the runner's "Cannot run selected tool <path>" refusal with a message that kept the configured path only in diagnostics, so the public CLI no longer told the caller which REA_TSHARK_COMMAND or REA_CAPINFOS_COMMAND value to fix and the pcap CLI boundary test failed. Include the configured command in the capability-unavailable message and assert it there. Refs #3403 * test(captures): give the late-cancellation fixture a TShark selection source The service fixture added on main in 719d56ebf predates the required tool.selection_source field, so its report failed output validation before reaching the late-cancellation path the test covers. Refs #3403 * fix(pcap): report a probe's pending cleanup when a post-run check fails When a tool probe returned with its owned process still awaiting cleanup, a failed post-run executable re-read or identity check threw before run() reported that cleanup. Probes have no snapshot to carry it, so callers saw an ordinary error with cleanupIncomplete false while the provider kept the process and refused the next request. After the command returns, combine such a failure with the probe's ProviderCleanupError (cancellation and other command failures keep their own cleanup outcome). Classify request failures through one analysisFailure owner shared by run() and executeAdmitted(), and let the availability probe rethrow any cleanup-incomplete failure instead of reporting the tool unavailable. Refs #3403 * fix(pcap): keep a failed executable re-read's cleanup live with the probe's The combined post-run failure was bound only to the probe's pending process cleanup. When the executable re-read had also failed to close its file, the classified failure owned that cleanup, but the combined error's live cleanupResources omitted the file and could clear cleanupIncomplete once the process stopped. Bind both the classified failure and the probe cleanup as dependencies. Refs #3403 --------- Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>	2026-10-23 02:34:14 +08:00
morluto	f6905719c3	fix(browser): bound capture work and preserve observation gaps ... Own service-worker CDP registrations and retry failed teardown. Admit redaction and network metadata against remaining capture capacity, retain explicit omission reasons, and preserve source URL, redirect ancestry, caller-selected content, and historical capture values. Forward CLI cancellation through provider cleanup. Reviewed fixes: #2263, #2637, #2767, #2845, #2859, #2863, #2872, #2874, #2876, #2879, #2955, #2957, #2961, #3033. Validation: 25 current event/network source tests passed; earlier focused browser lanes passed 201 source tests and 176 boundary tests with two skips, plus 35 Python tests. Real browser/Windows lanes were not rerun. Playwright allocation before admission remains unbounded by these retention limits.	2026-10-14 08:31:29 +08:00