mirror of
https://github.com/morluto/rea.git
synced 2026-10-27 18:05:45 +00:00
* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
197 lines
6.4 KiB
TypeScript
197 lines
6.4 KiB
TypeScript
import { chmod, mkdtemp, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join, resolve } from "node:path";
|
|
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
|
|
import { RizinDebugSessionManager } from "../../../src/rizin/RizinDebugSessionManager.js";
|
|
import {
|
|
createRizinTestManager,
|
|
rizinTestInferiorTty,
|
|
} from "./RizinTestInferiorTty.js";
|
|
|
|
describe.skipIf(process.platform === "win32")(
|
|
"persistent Rizin debugger session manager",
|
|
() => {
|
|
let directory: string | undefined;
|
|
const managers: Array<{ closeAll(): Promise<void> }> = [];
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(
|
|
managers
|
|
.splice(0)
|
|
.map((manager) => manager.closeAll().catch(() => undefined)),
|
|
);
|
|
if (directory !== undefined)
|
|
await rm(directory, { recursive: true, force: true });
|
|
directory = undefined;
|
|
});
|
|
|
|
it("uses an absolute target path and waits for Rizin's completion marker", async () => {
|
|
directory = await mkdtemp(join(tmpdir(), "rea-rizin-manager-"));
|
|
const provider = join(directory, "fake-rizin.mjs");
|
|
const argsFile = join(directory, "args.json");
|
|
await writeFile(
|
|
provider,
|
|
`#!/usr/bin/env node
|
|
const fs = await import("node:fs");
|
|
fs.writeFileSync(${JSON.stringify(argsFile)}, JSON.stringify(process.argv.slice(2)));
|
|
process.stdout.write("\\0");
|
|
let input = "";
|
|
let stalled = false;
|
|
process.stdin.setEncoding("utf8");
|
|
process.stdin.on("data", (chunk) => {
|
|
input += chunk;
|
|
for (;;) {
|
|
const boundary = input.indexOf("\\n");
|
|
if (boundary < 0) break;
|
|
const line = input.slice(0, boundary);
|
|
input = input.slice(boundary + 1);
|
|
if (line === "dr") process.stdout.write("backend-event\\0rax=0x1234\\0");
|
|
else if (line === "olj") process.stdout.write("[]\\0");
|
|
else if (line.startsWith("!echo ")) process.stdout.write(line.slice(6) + "\\n\\0");
|
|
}
|
|
});
|
|
`,
|
|
);
|
|
await chmod(provider, 0o700);
|
|
const manager = createRizinTestManager({
|
|
REA_RIZIN_COMMAND: provider,
|
|
});
|
|
managers.push(manager);
|
|
|
|
const started = await manager.start({
|
|
path: "-target.bin",
|
|
inferior_tty: await rizinTestInferiorTty(),
|
|
backend: "test-backend",
|
|
});
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
const providerArgs = await import("node:fs/promises").then(
|
|
({ readFile }) => readFile(argsFile, "utf8"),
|
|
);
|
|
expect(JSON.parse(providerArgs)).toEqual([
|
|
"-N",
|
|
"-0",
|
|
"-d",
|
|
"-R",
|
|
`stdout=${await rizinTestInferiorTty()}`,
|
|
"-R",
|
|
`stderr=${await rizinTestInferiorTty()}`,
|
|
"-e",
|
|
"dbg.exitkills=false",
|
|
"-D",
|
|
"test-backend",
|
|
resolve("-target.bin"),
|
|
]);
|
|
|
|
const result = await manager.execute(started.value.session_id, "dr");
|
|
expect(result.ok).toBe(true);
|
|
if (result.ok) {
|
|
expect(result.value.result.output).toBe("backend-event\nrax=0x1234");
|
|
expect(result.value.result.output_scope).toBe(
|
|
"command_and_interleaved_session_output",
|
|
);
|
|
expect(result.value.result.backend).toBe("test-backend");
|
|
}
|
|
expect((await manager.close(started.value.session_id)).ok).toBe(true);
|
|
expect(manager.status(started.value.session_id)).toBeUndefined();
|
|
});
|
|
|
|
it("stops and invalidates a Rizin session after its completion-marker timeout", async () => {
|
|
directory = await mkdtemp(join(tmpdir(), "rea-rizin-timeout-"));
|
|
const provider = join(directory, "fake-rizin-stall.mjs");
|
|
await writeFile(
|
|
provider,
|
|
`#!/usr/bin/env node
|
|
process.stdout.write("\\0");
|
|
let input = "";
|
|
let stalled = false;
|
|
process.stdin.setEncoding("utf8");
|
|
process.stdin.on("data", (chunk) => {
|
|
input += chunk;
|
|
for (;;) {
|
|
const boundary = input.indexOf("\\n");
|
|
if (boundary < 0) break;
|
|
const line = input.slice(0, boundary);
|
|
input = input.slice(boundary + 1);
|
|
if (line === "dr") process.stdout.write("rax=0x1234\\0");
|
|
else if (line === "slow") {
|
|
stalled = true;
|
|
process.stdout.write("partial-timeout\\0");
|
|
}
|
|
else if (line.startsWith("!echo ") && !stalled) process.stdout.write(line.slice(6) + "\\n\\0");
|
|
}
|
|
});
|
|
`,
|
|
);
|
|
await chmod(provider, 0o700);
|
|
const manager = createRizinTestManager(
|
|
{ REA_RIZIN_COMMAND: provider },
|
|
{ frameTimeoutMs: 50 },
|
|
);
|
|
managers.push(manager);
|
|
|
|
const started = await manager.start({
|
|
path: "/tmp/fixture.bin",
|
|
inferior_tty: await rizinTestInferiorTty(),
|
|
});
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
const timedOut = await manager.execute(started.value.session_id, "slow");
|
|
expect(timedOut.ok).toBe(true);
|
|
if (timedOut.ok) {
|
|
expect(timedOut.value.result).toMatchObject({
|
|
output: "partial-timeout",
|
|
output_truncated: true,
|
|
completion_status: "unknown",
|
|
});
|
|
expect(timedOut.value.evidence.limitations.join(" ")).toContain(
|
|
"timed out",
|
|
);
|
|
}
|
|
expect(manager.status(started.value.session_id)?.state).toBe("closed");
|
|
expect((await manager.execute(started.value.session_id, "dr")).ok).toBe(
|
|
false,
|
|
);
|
|
expect((await manager.close(started.value.session_id)).ok).toBe(true);
|
|
});
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"stops Rizin when empty unsolicited NUL frames exhaust the bounded queue",
|
|
async () => {
|
|
const directory = await mkdtemp(join(tmpdir(), "rea-rizin-empty-frames-"));
|
|
const provider = join(directory, "fake-rizin-empty.mjs");
|
|
const manager = createRizinTestManager({
|
|
REA_RIZIN_COMMAND: provider,
|
|
});
|
|
try {
|
|
await writeFile(
|
|
provider,
|
|
`#!/usr/bin/env node
|
|
process.stdout.write("\\0");
|
|
setTimeout(() => process.stdout.write("\\0".repeat(5000)), 10);
|
|
process.stdin.resume();
|
|
`,
|
|
);
|
|
await chmod(provider, 0o700);
|
|
|
|
const started = await manager.start({
|
|
path: "/tmp/fixture.bin",
|
|
inferior_tty: await rizinTestInferiorTty(),
|
|
});
|
|
expect(started.ok).toBe(true);
|
|
if (!started.ok) return;
|
|
await new Promise((resolveDelay) => setTimeout(resolveDelay, 100));
|
|
|
|
expect(manager.status(started.value.session_id)?.state).toBe("closed");
|
|
expect((await manager.close(started.value.session_id)).ok).toBe(true);
|
|
} finally {
|
|
await manager.closeAll().catch(() => undefined);
|
|
await rm(directory, { recursive: true, force: true });
|
|
}
|
|
},
|
|
);
|