mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
* feat(snapshots)!: persist the target identity as the snapshot target
The snapshot target is now `{ kind, identity }`, where `identity` is the
FileTargetIdentity that `binaryTargetIdentity` produces and `kind` is the
binary kind query IDs commit to. The per-format target projection and
`snapshotTargetIdentity` are deleted; the schema checks the format's
selection, architecture and kind instead of keeping one union arm per format.
Entry execution subjects use the Evidence subject shape (file or explicit
unknown), so a snapshot entry commits to the same identity, including the
selection, as its Evidence record. Workflow entries take the subject of the
workflow's own Evidence. Replay no longer re-derives the selection from the
open target.
`FileTargetSelection` gains `universal-slice` (`offset`, `size`, and the FAT
`cpu_type`/`cpu_subtype` when target admission supplied the FAT table, else
null). `binaryTargetIdentity` produces it for `mach-o-universal` targets, so
Evidence and snapshots for different slices of one container no longer share
an identity.
Refs #11417
BREAKING CHANGE: analysis snapshot files change shape: `target` is
`{ kind, identity: { kind: "file", sha256, format, architecture, selection } }`
and entry `execution.subject` is the Evidence subject
(`{ identity, name, local_path }`, never null). Snapshot binding mismatch
details report `target.snapshot`/`target.selected` in the same shape. Evidence
IDs of universal Mach-O targets change because their subject identity now
carries the selected slice. Recreate saved snapshots and Evidence bundles of
universal Mach-O targets.
* docs(evidence): name the universal Mach-O slice selection in the subject contract
* fix(snapshots): read the snapshot target identity in the Ghidra verification scripts
The real Ghidra snapshot checks (lifecycle, RISC-V, MIPS, PowerPC) read
snapshot.target.sha256 and .architecture, which moved under
snapshot.target.identity, so they would fail after saving a valid snapshot.
* feat(evidence)!: name live browser page Evidence by its page URL (#11559)
Browser page observations (inspect_web_page, analyze_web_bundle,
observe_web_session, discover_webmcp_tools, capture_web_screenshot,
observe_web_execution, inspect_web_event_listeners) named an unknown
(`not-observed`) subject although the provider reports the page URL.
`TargetIdentity` gains a `url` kind: the reported URL with userinfo removed
and its origin (`null` for an opaque origin). The schema refuses a URL that
carries userinfo or an origin the URL does not have.
`browserUrlTargetIdentity` in the browser URL owner builds it from the
provider's reported URL; a withheld or unparseable URL stays unknown
(`not-observed`). Target lists and comparisons still name no single
document. Analysis views keep their parent's URL subject, as they already
keep a file subject.
BREAKING CHANGE: Evidence IDs of live browser page observations and their
analysis views change, and their subject is
`{ "kind": "url", "url", "origin" }` with `name` and `local_path` null.
Recreate stored Evidence for these tools. This lands inside Evidence format
revision 2 under the release hold (#11417); no `evidence_format` bump.
189 lines
6.2 KiB
JavaScript
189 lines
6.2 KiB
JavaScript
import {
|
|
requireMcpEvidenceBundle,
|
|
requireMcpToolError,
|
|
requireMcpLifecycleResult,
|
|
requireMcpEvidenceResult,
|
|
} from "./mcp-verifier-results.mjs";
|
|
import assert from "node:assert/strict";
|
|
import { execFile } from "node:child_process";
|
|
import { randomUUID } from "node:crypto";
|
|
import { writeFile, rm } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { promisify } from "node:util";
|
|
import { parseBinaryTarget } from "../../dist/application/BinaryTargetResolver.js";
|
|
import { createAnalysisProfile } from "../../dist/domain/analysisProfile.js";
|
|
import {
|
|
createAnalysisSnapshotEntry,
|
|
parseAnalysisSnapshot,
|
|
serializeAnalysisSnapshot,
|
|
snapshotBinding,
|
|
snapshotTarget,
|
|
} from "../../dist/domain/analysisSnapshot.js";
|
|
import { createEvidence } from "../../dist/domain/evidence.js";
|
|
import { createEvidenceBundle } from "../../dist/domain/evidenceBundle.js";
|
|
|
|
/** Reject a valid older snapshot whose instruction-only collector omitted a real edge. */
|
|
export async function verifyLegacyGhidraReferenceSnapshot(
|
|
client,
|
|
{ target, procedure, omittedEdge, entrypoint, env },
|
|
) {
|
|
const bundle = requireMcpEvidenceBundle(
|
|
await client.callTool({
|
|
name: "get_evidence_bundle",
|
|
arguments: {},
|
|
}),
|
|
);
|
|
const observed = bundle.records.find(
|
|
(record) =>
|
|
record.operation === "analyze_function" &&
|
|
record.parameters.procedure === procedure,
|
|
);
|
|
assert.ok(observed);
|
|
// A snapshot from an earlier bridge: same profile, another producer digest.
|
|
const { producer } = observed.analysis_profile.parameters;
|
|
assert.match(
|
|
producer?.sources_sha256 ?? "",
|
|
/^[0-9a-f]{64}$/u,
|
|
"The producer identity must participate in snapshot identity",
|
|
);
|
|
const legacyProfile = createAnalysisProfile(observed.provider, {
|
|
...observed.analysis_profile.parameters,
|
|
producer: { ...producer, sources_sha256: "0".repeat(64) },
|
|
});
|
|
assert.notEqual(legacyProfile.digest, observed.analysis_profile.digest);
|
|
const parsed = await parseBinaryTarget(target.path, {
|
|
cwd: process.cwd(),
|
|
hostArchitecture: process.arch,
|
|
});
|
|
if (!parsed.ok) throw parsed.error;
|
|
const nativeTarget = parsed.value;
|
|
const result = structuredClone(observed.normalized_result);
|
|
// Reconstruct the observed pre-fix omission; all other data
|
|
// comes from the real provider and the file has a fully valid Evidence binding.
|
|
result.incoming_references = result.incoming_references.filter(
|
|
(edge) =>
|
|
edge.source_address !== omittedEdge.source_address ||
|
|
edge.target_address !== omittedEdge.target_address,
|
|
);
|
|
assert.equal(
|
|
result.incoming_references.length,
|
|
observed.normalized_result.incoming_references.length - 1,
|
|
);
|
|
const evidence = createEvidence(nativeTarget, observed.provider, {
|
|
operation: observed.operation,
|
|
parameters: observed.parameters,
|
|
result,
|
|
rawResult: result,
|
|
analysisProfile: legacyProfile,
|
|
limitations: observed.limitations,
|
|
locations: observed.locations,
|
|
});
|
|
const binding = snapshotBinding(legacyProfile);
|
|
const identity = snapshotTarget(nativeTarget);
|
|
const snapshot = parseAnalysisSnapshot({
|
|
target: identity,
|
|
binding,
|
|
entries: [
|
|
createAnalysisSnapshotEntry({
|
|
target: identity,
|
|
binding,
|
|
operation: observed.operation,
|
|
parameters: observed.parameters,
|
|
execution: {
|
|
result,
|
|
rawResult: result,
|
|
provider: observed.provider,
|
|
analysisProfile: legacyProfile,
|
|
limitations: observed.limitations,
|
|
locations: observed.locations,
|
|
subject: evidence.subject,
|
|
},
|
|
}),
|
|
],
|
|
workflow_entries: [],
|
|
evidence_bundle: createEvidenceBundle([evidence]),
|
|
});
|
|
assert.equal(
|
|
snapshot.entries.length,
|
|
1,
|
|
"The legacy query must remain valid and replayable under its own profile",
|
|
);
|
|
const path = join(env.TMPDIR, `legacy-reference-${randomUUID()}.json`);
|
|
await writeFile(path, serializeAnalysisSnapshot(snapshot), { flag: "wx" });
|
|
try {
|
|
const session = requireMcpLifecycleResult(
|
|
await client.callTool({ name: "binary_session", arguments: {} }),
|
|
"binary_session",
|
|
);
|
|
const reply = await client.callTool({
|
|
name: "open_binary",
|
|
arguments: {
|
|
path: target.path,
|
|
provider_id: "ghidra",
|
|
snapshot_path: path,
|
|
},
|
|
});
|
|
assert.equal(reply.isError, true);
|
|
const mcpRejection = requireMcpToolError(reply);
|
|
assert.equal(mcpRejection.code, "evidence_integrity_mismatch");
|
|
assert.deepEqual(mcpRejection.details.binding_mismatch.profile_digest, {
|
|
snapshot: legacyProfile.digest,
|
|
selected: observed.analysis_profile.digest,
|
|
});
|
|
assert.match(mcpRejection.remediation.action, /fresh snapshot/u);
|
|
assert.deepEqual(
|
|
requireMcpLifecycleResult(
|
|
await client.callTool({ name: "binary_session", arguments: {} }),
|
|
"binary_session",
|
|
),
|
|
session,
|
|
"A rejected snapshot must preserve the selected session",
|
|
);
|
|
const retained = requireMcpEvidenceResult(
|
|
await client.callTool({
|
|
name: "analyze_function",
|
|
arguments: { procedure, detail: "complete" },
|
|
}),
|
|
"analyze_function",
|
|
);
|
|
assert.ok(
|
|
retained.incoming_references.some(
|
|
(edge) =>
|
|
edge.source_address === omittedEdge.source_address &&
|
|
edge.target_address === omittedEdge.target_address,
|
|
),
|
|
"A rejected legacy snapshot must not replace complete live analysis",
|
|
);
|
|
await assert.rejects(
|
|
promisify(execFile)(
|
|
process.execPath,
|
|
[
|
|
entrypoint,
|
|
"function",
|
|
target.path,
|
|
procedure,
|
|
"--provider",
|
|
"ghidra",
|
|
"--snapshot",
|
|
path,
|
|
"--json",
|
|
],
|
|
{ env, timeout: 240000, maxBuffer: 72 * 1024 * 1024 },
|
|
),
|
|
(error) => {
|
|
assert.equal(error.code, 1);
|
|
const rejection = JSON.parse(error.stdout);
|
|
assert.equal(rejection.code, "evidence_integrity_mismatch");
|
|
assert.equal(rejection.details.reason, mcpRejection.details.reason);
|
|
assert.equal(
|
|
rejection.remediation.action,
|
|
mcpRejection.remediation.action,
|
|
);
|
|
return true;
|
|
},
|
|
);
|
|
} finally {
|
|
await rm(path);
|
|
}
|
|
}
|