mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 19:53:50 +00:00
* feat(evidence)!: name the Evidence subject by its target identity (format revision 2) The Evidence subject carries subject.identity (kind, sha256, format, architecture, selection) and the Evidence ID commits to it, so raw/DOL entry points and ESP flash offsets of the same bytes are different subjects. Every record declares evidence_format: 2; revision 1 bundles, standalone records and snapshots are refused with the recreate guidance. binaryTargetIdentity is the one projection of an open target, used by Evidence and snapshot comparison. BREAKING CHANGE: Evidence format revision 2. Evidence IDs commit to the subject's target identity (subject.identity, including the raw/DOL entry point or ESP flash offsets), and every record declares evidence_format: 2. Evidence bundles, records and analysis snapshots from earlier releases are refused; recreate the observations with this release. * refactor(analysis-view): read parent subjects through the Evidence identity accessors (#11423) Analysis views compare their parent's file identity (evidenceFileTarget) and take path and digest from evidenceSubjectTarget instead of reading the subject's digest, format and architecture members, which duplicate subject.identity until they are removed. A counted guard (evidence-subject-declaration-read) keeps new direct reads out and records the 20 remaining files. * fix(evidence): carry format refusals through Evidence readers and bind target selections - safeParseEvidence/safeParseImmutableEvidence return the format refusal as an expected failure; every consumer maps it to the one integrity refusal with the recreate guidance. An unmarked object is an earlier record only when it has every member records have always carried. - ArtifactProvider inventory roots and provider subjects that name the target's own bytes carry the target's selection (ESP flash offsets). - Snapshot rows bind only Evidence whose identity, selection included, matches the snapshot target. - Entry-point selections use the raw-binary entry point form. * fix(evidence): refuse unauthenticated or earlier-format records instead of reading them as absent - recognizeEvidence (evidenceValidation) replaces tryParseEvidence: input without an evidence_id is not Evidence (ok(undefined)); a record that names one but fails authentication or is from another format revision is an EvidenceIntegrityError carrying the recreate guidance, never undefined. - Direct analysis retains that refusal as a secondary failure instead of silently skipping source capture; cleanup projection, source-closure annotation and the flutter, debugger and release-exposure recoveries use the same owner (the last three previously read the unauthenticated schema). - A desktop capture.json from an earlier format is refused with the recreate guidance instead of "not desktop application capture Evidence". * fix(evidence): advertise revision 2 ledger examples and rank delivery omissions by serialized size - The obligation ledger and reconstruction coverage examples named evidence_format 1, which revision 2 refuses; they now use EVIDENCE_FORMAT_REVISION. - MCP delivery chose which unretained recovery to omit by a parsed-storage lower bound clipped at the response budget. Once revision 2 subjects made the source record's estimate cross the budget, both candidates tied at the clip and the smaller source was omitted ahead of the larger completed observation. Candidates are now ranked by serialized size, which is what the budget counts. * refactor(native): compare function snapshots by their Evidence target identity (#11450) Function snapshots carry the subject's file target identity instead of the duplicated subject declaration. Call paths and function comparisons compare targets through sameTargetIdentity, so the same bytes opened at a different raw entry point or ESP flash offset no longer count as one coordinate space: build_call_path refuses the mix, and compare_functions no longer matches entries by address across selections. Structural candidates and native function matching read the architecture and digest through evidenceFileTarget. Refs #11417 * refactor(artifacts): compare artifact and WASM summaries by their Evidence target identity (#11461) Artifact comparison authenticates a summary against its retained inventory through sameTargetIdentity and rebinds the alias with the whole target, selection included, so a flash-selected inventory summary taken under an alias path is no longer refused. WASM comparison, the analysis view artifact projection and the inventory root check read the digest, format and display path through the Evidence identity accessors. Refs #11417 * refactor(evidence): read record subjects through the identity accessors in JS, managed, ledger and bundle readers (#11470) JavaScript application graphs, runtime reconciliation, managed inspection and native verification sources, the record summary filter, the ledger's residual-unknown target and bundle scope selection read the subject digest, format and display path through evidenceFileTarget and evidenceSubjectDisplay. No comparison changes: each reader matches one record's facts against its own payload or a caller filter. Refs #11417 * refactor(evidence)!: name the Evidence subject only by its target identity (#11497) * refactor(evidence)!: name the Evidence subject only by its target identity The subject keeps `identity` and the display facts `name` and `local_path`. The duplicated `digest`, `format` and `architecture` members are removed; the format-owned declaration now validates the identity itself. Readers the type checker found move to the owner accessors; untyped reads in verify scripts, the efficiency harness and test matchers move to `subject.identity`. The `evidence-subject-declaration-read` text guard and its baseline are deleted. Fixes #11473 Refs #11417 BREAKING CHANGE: the Evidence subject no longer has `digest`, `format` or `architecture`; read `subject.identity.sha256`, `subject.identity.format` and `subject.identity.architecture`. A record that still carries them is refused. * test(evidence): give the Flutter verifier fixture the identity subject and check the DOL declaration without the ID * test(evidence): drop the removed subject members from the declaration matrix and tamper fixtures * feat(evidence)!: give every Evidence record an explicit subject identity (#11536) * feat(evidence)!: give every Evidence record an explicit subject identity A producer that cannot name a file passes an `unknown` target identity with a closed reason (derived-from-linked-evidence, not-observed, unsupported-subject) instead of no subject. The subject is non-null; unknown subjects have no display facts. The generic missing-subject limitation and `subjectUnavailableReason` are removed; producer-specific explanations are ordinary limitations. Comparison identity requires the derived unknown, and null-subject consumers ask the owner accessors. Refs #11417 BREAKING CHANGE: every Evidence record has a subject. A record without a file target names `subject.identity` `{ "kind": "unknown", "reason": … }` with `name` and `local_path` null, instead of `subject: null` and the limitation "Artifact identity is unavailable for this observation.". Their Evidence IDs change. * fix(evidence): name explicit unknown subjects in JavaScript callers and keep a managed graph's file subject The verification scripts are not type-checked, so five createEvidence callers still passed undefined (or a missing first target) after the subject became required. They now pass unknownTarget("not-observed"). A managed application graph chose the first present input subject. Every subject is now present, so an unknown artifact subject hid a file subject on the member or boundary Evidence. The graph now takes the first input subject that names a file. * test(evidence): assert the subject kind instead of a presence the type now guarantees Every Evidence record has a subject after this change, so test guards and assertions that checked it for null always passed. Each now checks that the fixture subject names a file, or is removed where a later fileIdentity, fileSubjectTarget or fileSubjectDisplay call already requires that. Non-null assertions on Evidence subjects are removed; analysis-view inputs, whose subject is optional, keep an undefined check. * test(evidence): expect the Evidence subject format under its identity Two boundary tests still matched subject.format, which slice 2e moved into subject.identity. toMatchObject is not type-checked against the Evidence shape, so they failed only when run (the signature test on macOS).
150 lines
6.0 KiB
TypeScript
150 lines
6.0 KiB
TypeScript
import { readArtifactInspectionSources } from "../domain/artifactInspection.js";
|
|
import type { AnalysisError } from "../domain/analysisErrorBase.js";
|
|
import type { Evidence } from "../domain/evidence.js";
|
|
import { recognizeEvidence } from "../domain/evidenceValidation.js";
|
|
import { jsonValueByteLength } from "../domain/jsonValueByteLength.js";
|
|
import { err, ok, type Result } from "../domain/result.js";
|
|
|
|
/** Resolve the embedded publication closure without reinterpreting it in delivery adapters. */
|
|
export const analysisEvidenceSources = (
|
|
complete: Evidence,
|
|
): Result<Evidence[], AnalysisError> => {
|
|
const embedded =
|
|
complete.operation === "inspect_artifact"
|
|
? readArtifactInspectionSources(complete.normalized_result)
|
|
: ok([]);
|
|
if (!embedded.ok)
|
|
return err(embedded.error.retainPartialObservation(complete));
|
|
return ok([...embedded.value, complete]);
|
|
};
|
|
|
|
/** Matches the diagnostics allowance retained for other finalized one-shot work. */
|
|
const SOURCE_CLOSURE_INLINE_BYTES = 64 * 1024;
|
|
/** Identities beyond this stay counted; direct links remain on the observation. */
|
|
const SOURCE_CLOSURE_LISTED_OMISSIONS = 64;
|
|
const SOURCE_CLOSURE_RECOVERY =
|
|
"No bundle was written and this invocation retains nothing after exit. Keep any records shown here, or run the operation again after following remediation; that is a new observation and may differ.";
|
|
|
|
/** What a failed one-shot delivery holds for one record its observation cites. */
|
|
export type SourceClosureOmission = {
|
|
readonly evidence_id: string;
|
|
/**
|
|
* `not_captured`: this invocation holds no such record, so none can be shown.
|
|
* `not_inlined`: captured, but not part of this bounded failure response.
|
|
*/
|
|
readonly reason: "not_captured" | "not_inlined";
|
|
};
|
|
|
|
/** Bounded failure handoff for a completed observation whose bundle never committed. */
|
|
export type UndeliveredSourceClosure = {
|
|
readonly publication: "not_published";
|
|
/** The embedded source list was read and every cited record is in `records` or the observation. */
|
|
readonly complete: boolean;
|
|
/** The embedded producer source list could not be read, so closure remains unknown. */
|
|
readonly collection_failure?: string;
|
|
readonly records: Evidence[];
|
|
readonly omitted_count: number;
|
|
readonly omitted: SourceClosureOmission[];
|
|
readonly recovery: string;
|
|
};
|
|
|
|
/** The closure state is unknown because examining it failed. */
|
|
export type UnavailableSourceClosure = {
|
|
readonly publication: "not_published";
|
|
readonly complete: false;
|
|
readonly collection_failure: string;
|
|
readonly recovery: string;
|
|
};
|
|
|
|
const collectSourceClosure = (
|
|
observation: Evidence,
|
|
captured: readonly Evidence[],
|
|
options: { readonly inlineRecords: boolean },
|
|
): UndeliveredSourceClosure | undefined => {
|
|
const inspection = analysisEvidenceSources(observation);
|
|
const embedded = new Map(
|
|
(inspection.ok ? inspection.value : []).map((record) => [
|
|
record.evidence_id,
|
|
record,
|
|
]),
|
|
);
|
|
const held = new Map(captured.map((record) => [record.evidence_id, record]));
|
|
// Set iteration reaches entries added while it runs, which makes this a
|
|
// deduplicating breadth-first queue: directly cited records spend the
|
|
// allowance first, and each link costs one lookup however often it repeats.
|
|
const closure = new Set([observation.evidence_id]);
|
|
for (const evidenceId of observation.evidence_links) closure.add(evidenceId);
|
|
for (const evidenceId of held.keys()) closure.add(evidenceId);
|
|
const records: Evidence[] = [];
|
|
const omitted: SourceClosureOmission[] = [];
|
|
let omittedCount = 0;
|
|
let inlineBytes = options.inlineRecords ? SOURCE_CLOSURE_INLINE_BYTES : 0;
|
|
const omit = (
|
|
evidenceId: string,
|
|
reason: SourceClosureOmission["reason"],
|
|
) => {
|
|
omittedCount += 1;
|
|
if (omitted.length < SOURCE_CLOSURE_LISTED_OMISSIONS)
|
|
omitted.push({ evidence_id: evidenceId, reason });
|
|
};
|
|
for (const evidenceId of closure) {
|
|
if (evidenceId === observation.evidence_id) continue;
|
|
const inObservation = embedded.get(evidenceId);
|
|
const record = inObservation ?? held.get(evidenceId);
|
|
if (record === undefined) {
|
|
omit(evidenceId, "not_captured");
|
|
continue;
|
|
}
|
|
for (const link of record.evidence_links) closure.add(link);
|
|
if (inObservation !== undefined) continue;
|
|
const bytes = jsonValueByteLength(record, inlineBytes);
|
|
if (bytes > inlineBytes) {
|
|
omit(evidenceId, "not_inlined");
|
|
continue;
|
|
}
|
|
records.push(record);
|
|
inlineBytes -= bytes;
|
|
}
|
|
if (closure.size === 1 && inspection.ok) return undefined;
|
|
return {
|
|
publication: "not_published",
|
|
complete: inspection.ok && omittedCount === 0,
|
|
...(inspection.ok ? {} : { collection_failure: inspection.error.name }),
|
|
records,
|
|
omitted_count: omittedCount,
|
|
omitted,
|
|
recovery: SOURCE_CLOSURE_RECOVERY,
|
|
};
|
|
};
|
|
|
|
/**
|
|
* Describe the source closure of a completed observation after delivery failed
|
|
* before commit. Only already captured records are reported, so an unresolved
|
|
* link stays an explicit omission and its own ancestors remain unknown.
|
|
*
|
|
* This annotates a failure that must reach the caller, so it never throws. If
|
|
* examining the closure fails, the state is reported as unknown, naming only
|
|
* the bounded error type rather than a message that could quote analyzed data.
|
|
*/
|
|
export const undeliveredSourceClosure = (
|
|
partialObservation: unknown,
|
|
captured: readonly Evidence[],
|
|
options: { readonly inlineRecords: boolean },
|
|
): UndeliveredSourceClosure | UnavailableSourceClosure | undefined => {
|
|
try {
|
|
const observation = recognizeEvidence(partialObservation);
|
|
// A record that fails authentication cannot select which sources it
|
|
// cites; the failure carrying it is reported unchanged.
|
|
return !observation.ok || observation.value === undefined
|
|
? undefined
|
|
: collectSourceClosure(observation.value, captured, options);
|
|
} catch (cause: unknown) {
|
|
return {
|
|
publication: "not_published",
|
|
complete: false,
|
|
collection_failure: cause instanceof Error ? cause.name : "unknown",
|
|
recovery: SOURCE_CLOSURE_RECOVERY,
|
|
};
|
|
}
|
|
};
|