Files
reverse-engineering-anything/src/browser/CdpPageCaptureScripts.test.ts
T
0155b89953 fix(browser): name web-bundle budgets and recover web deadlines (#6036)
* fix(browser): name web-bundle budgets and recover web deadlines

Name the existing heap, per-script, and total web-bundle phases, and reject a per-script deadline above the total. Promote capture, CDP command, source-map decode, and source-map fetch deadlines at today's defaults. Name DevTools timeoutMs, and state that discovery, cleanup grace, byte budgets, and Electron hook retention have no runtime override.

Refs #5910

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): apply selected web deadlines to the owning phase

Keep HTTP and browser-socket discovery on the fixed discovery deadline so a
short command_timeout_ms starts at the handshake. Apply scenario
command_timeout_ms to launch startup and the primary connect session, and
keep service-worker restoration on the fixed 5000 ms grace. Omit
command_timeout_ms from recovery text when the operation does not accept it.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): retain scenario commands that finish after their deadline

A timed-out scenario command stays owned so cleanup can close a late
browser or context and restore a mutation that lands after the deadline.
Child storage replies use that deadline, scenario recovery names
command_timeout_ms in the capture JSON, and the session test connection
implements beginCleanupGrace.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): keep child command timeouts as the public failure

A nested command such as Page.enable that is delivered but never answered
was stored as protocol_error, hiding the command name, selected deadline,
and recovery. Store the typed timeout and assert that public error.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): keep runtime cleanup on the fixed grace

Switch runtime restoration to the cleanup grace before the first send so a
short command_timeout_ms cannot fail an otherwise successful observation.
Stop advertising command_timeout_ms on list_browser_targets, which never
bounds a post-discovery command.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* test(browser): prove a short command deadline cannot fail runtime cleanup

Drive restoration through the runtime fixture. A cleanup command that
outlives command_timeout_ms still succeeds, and a stalled restoration
names the fixed 5000 ms grace.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): name the effective source-map decode deadline

codecBudgetLimitation reported a fixed 20-second deadline after a
caller selected decode_timeout_ms. Result and Evidence limitations
now name that effective millisecond deadline.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): separate handshake and target-attach deadlines

A browser-level Target.attachToTarget no longer shares the WebSocket
handshake budget. Blocked service-worker attachment keeps discovery on
its fixed deadline and applies command_timeout_ms to the later handshake
and attach.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): name the web-bundle resource each runtime exhausts

Bun ignores the V8 old-space flag. A Windows Job reports the process
commit limit, and other Bun hosts no longer suggest raising max_heap_mb.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): cite the browser-socket discovery message budget

WebSocket discovery enforces the 64 MiB protocol budget. Timeout
recovery no longer advertises the 8 MiB HTTP document budget.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): bound the blocked service-worker check before discovery

The first registration check has its own fixed 10s deadline. Discovery,
handshake, and Target.attachToTarget stay on their separate deadlines.

Co-authored-by: morluto <morluto@users.noreply.github.com>

* fix(browser): name the operand that stopped web-bundle admission

Host heap pressure no longer claims the fixed result budget is exhausted.
A Windows Bun allocation before the commit limit still names that limit.

Co-authored-by: morluto <morluto@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: morluto <morluto@users.noreply.github.com>
2026-10-22 05:47:38 +08:00

211 lines
6.6 KiB
TypeScript

import { expect, it, vi } from "vitest";
import { AnalysisCancelledError } from "../domain/analysisErrorCore.js";
import { inspectWebPageInputSchema } from "../domain/browserObservation.js";
import { CdpCaptureEvents } from "./CdpCaptureEvents.js";
import type { CdpConnection } from "./CdpConnection.js";
import {
CDP_SCRIPT_SOURCE_BYTES_OMISSION_REASON,
CDP_SCRIPT_SOURCE_DEADLINE_OMISSION_REASON,
} from "./CdpScriptSourceBudget.js";
import { captureScripts } from "./CdpPageCaptureScripts.js";
import type { CaptureContext } from "./CdpPageCapture.js";
import type { CapturedScript } from "./CdpCaptureEventTypes.js";
const script = (scriptId: string): CapturedScript => ({
scriptId,
rawUrl: `https://example.test/${scriptId}.js`,
url: `https://example.test/${scriptId}.js`,
origin: "https://example.test",
hash: scriptId,
length: null,
isModule: false,
language: "JavaScript",
sourceMapUrl: null,
sourceMapRawUrl: null,
executionContextKey: null,
frameId: null,
});
const capture = async (
sources: Readonly<Record<string, string>>,
includeScriptSources = true,
signal?: AbortSignal,
) => {
const input = inspectWebPageInputSchema.parse({
cdp_endpoint: "http://127.0.0.1:9222",
target_id: "page-1",
allowed_origins: ["https://example.test"],
observation_ms: 0,
include_script_sources: includeScriptSources,
});
const events = new CdpCaptureEvents(input, new Set(input.allowed_origins));
for (const id of Object.keys(sources)) events.scripts.set(id, script(id));
const send = vi.fn(async (method: string, params: unknown) => {
if (method !== "Debugger.getScriptSource")
throw new Error(`Unexpected CDP command: ${method}`);
const scriptId = (params as { scriptId: string }).scriptId;
return { scriptSource: sources[scriptId] };
});
const context = {
connection: { send } as unknown as CdpConnection,
sessionId: undefined,
operation: "inspect_web_page",
discovery: undefined,
target: undefined,
input,
...(signal === undefined ? {} : { signal }),
} as unknown as CaptureContext;
const result = await captureScripts({
context,
events,
rawResources: [],
resources: [],
frameIds: new Set(),
});
return { result, events, send };
};
it("admits a prefix and fitting suffix around an oversized script source", async () => {
const prefix = "p".repeat(16 * 1024 * 1024);
const oversized = "o".repeat(17 * 1024 * 1024);
const suffix = "s".repeat(1024 * 1024);
const { result, events } = await capture({ prefix, oversized, suffix });
const byId = new Map(
result.inventory.items.map((item) => [item.cdp_hash, item.source]),
);
expect(byId.get("prefix")).toMatchObject({ included: true });
expect(byId.get("oversized")).toEqual({
included: false,
reason: CDP_SCRIPT_SOURCE_BYTES_OMISSION_REASON,
});
expect(byId.get("suffix")).toMatchObject({ included: true });
expect(events.completeness.snapshot().excluded).toContainEqual({
section: "script_sources",
reason: "resource_budget_exhausted",
count: 1,
});
});
it("preserves the caller cancellation reason when a source read is pending", async () => {
const controller = new AbortController();
const reason = new AnalysisCancelledError("inspect_web_page");
const input = inspectWebPageInputSchema.parse({
cdp_endpoint: "http://127.0.0.1:9222",
target_id: "page-1",
allowed_origins: ["https://example.test"],
observation_ms: 0,
include_script_sources: true,
});
const events = new CdpCaptureEvents(input, new Set(input.allowed_origins));
events.scripts.set("first", script("first"));
const context = {
connection: {
send: async () => {
controller.abort(reason);
throw new AnalysisCancelledError("inspect_web_page");
},
} as unknown as CdpConnection,
sessionId: undefined,
operation: "inspect_web_page",
discovery: undefined,
target: undefined,
input,
signal: controller.signal,
} as unknown as CaptureContext;
await expect(
captureScripts({
context,
events,
rawResources: [],
resources: [],
frameIds: new Set(),
}),
).rejects.toMatchObject({ _tag: "AnalysisCancelledError", cause: reason });
});
it("stops source reads at the shared collection deadline and retains metadata", async () => {
vi.useFakeTimers();
try {
const input = inspectWebPageInputSchema.parse({
cdp_endpoint: "http://127.0.0.1:9222",
target_id: "page-1",
allowed_origins: ["https://example.test"],
observation_ms: 0,
include_script_sources: true,
});
const events = new CdpCaptureEvents(input, new Set(input.allowed_origins));
events.scripts.set("first", script("first"));
events.scripts.set("second", script("second"));
const send = vi.fn(
(
_method: string,
_params: unknown,
_sessionId: string | undefined,
signal?: AbortSignal,
) =>
new Promise((_resolve, reject) => {
signal?.addEventListener(
"abort",
() => reject(new AnalysisCancelledError("inspect_web_page")),
{ once: true },
);
}),
);
const context = {
connection: { send } as unknown as CdpConnection,
sessionId: undefined,
operation: "inspect_web_page",
discovery: undefined,
target: undefined,
input,
} as unknown as CaptureContext;
const pending = captureScripts({
context,
events,
rawResources: [],
resources: [],
frameIds: new Set(),
});
await vi.advanceTimersByTimeAsync(20_000);
const result = await pending;
expect(send).toHaveBeenCalledTimes(1);
expect(result.inventory.items.map((item) => item.source)).toEqual([
{
included: false,
reason: CDP_SCRIPT_SOURCE_DEADLINE_OMISSION_REASON,
},
{
included: false,
reason: CDP_SCRIPT_SOURCE_DEADLINE_OMISSION_REASON,
},
]);
expect(events.completeness.snapshot().excluded).toContainEqual({
section: "script_sources",
reason: "resource_budget_exhausted",
count: 2,
});
} finally {
vi.useRealTimers();
}
});
it("leaves source-off capture unchanged and does not issue source reads", async () => {
const { result, events, send } = await capture({ first: "unused" }, false);
expect(send).not.toHaveBeenCalled();
expect(result.inventory.items[0]?.source).toEqual({
included: false,
reason: "source capture was not selected",
});
expect(events.completeness.snapshot().excluded).toContainEqual({
section: "script_sources",
reason: "not_approved",
count: 1,
});
});