Files
reverse-engineering-anything/src/application/Doctor.lifecycle.test.ts
T
morluto cc2e18a265 fix(ghidra): own Java prerequisite probes through final cleanup
Replace synchronous Java execution with bounded owned commands. Keep task-scoped readiness observations fresh across later tasks, defer target client prerequisites behind a closeable owner, and join doctor cancellation and cleanup.

Preserve completed physical failures across late cancellation, exact cleanup dependencies and partial observations. Admit target/profile inputs before probing and return typed factory failures instead of unavailable client wrappers.

Validation: 405 focused tests across 24 files, 2 explicit skips; 109 provider/doctor controls rerun after final admission refinement; check:fast and docs:check. Controlled macOS Java-shaped commands and public CLI/MCP workflows; no new JVM/Ghidra or Windows/Linux lifecycle verification.

Measured warm public doctor baseline/candidate: elapsed 0.447/1.223s, CPU 0.624/1.237s, sampled family RSS 379/529MB, reply tokens 3133/3133. Ownership adds cost; no performance improvement claimed. True cold, whole-agent and MCP costs unmeasured.

Refs #4561. Remaining installation file admission tracked in #4672.
2026-10-17 11:29:03 +08:00

134 lines
3.8 KiB
TypeScript

import { expect, it } from "vitest";
import { AnalysisError } from "../domain/analysisErrorBase.js";
import { ProviderAdapterError } from "../domain/providerAdapterError.js";
import { createDoctorHostFixture } from "./Doctor.fixture.js";
import { runDoctorOwned, systemDoctorHost } from "./Doctor.js";
it("joins a late provider inspection and retries only its unresolved cleanup owners", async () => {
let enter!: (signal: AbortSignal) => void;
const entered = new Promise<AbortSignal>((resolve) => {
enter = resolve;
});
let handOff!: () => void;
const handoff = new Promise<void>((resolve) => {
handOff = resolve;
});
let finish!: () => void;
const finishing = new Promise<void>((resolve) => {
finish = resolve;
});
let denied = true;
let closed = false;
const closes = { successful: 0, refused: 0 };
const host = systemDoctorHost({
environment: {},
providerInspections: async (owner, signal) => {
enter(signal);
await handoff;
owner.retain(
{
close: async () => {
closes.successful++;
await finishing;
},
},
"successful-prerequisite",
);
owner.retain(
{
close: async () => {
closes.refused++;
if (denied) throw new Error("controlled cleanup refusal");
},
},
"refused-prerequisite",
);
return [];
},
});
const inspection = host.providerInspections!();
const signal = await entered;
const closing = host.close!().then(
() => {
closed = true;
return undefined;
},
(cause: unknown) => {
closed = true;
return cause;
},
);
try {
expect(signal.aborted).toBe(true);
expect(closed).toBe(false);
handOff();
await inspection;
expect(closed).toBe(false);
finish();
const failure = await closing;
if (!(failure instanceof AnalysisError))
throw new Error("Expected attributed cleanup failure");
expect(failure.cleanupResources).toEqual(["refused-prerequisite"]);
expect(failure.cleanupIncomplete).toBe(true);
expect(closes).toEqual({ successful: 1, refused: 1 });
denied = false;
await host.close!();
expect(failure.cleanupIncomplete).toBe(false);
expect(closes).toEqual({ successful: 1, refused: 2 });
await expect(host.providerInspections!()).rejects.toThrow(
"scope is closed",
);
} finally {
denied = false;
handOff();
finish();
await inspection;
await closing;
await host.close!();
}
});
it("retains a completed healthy report when cancellation arrives during final cleanup", async () => {
const controller = new AbortController();
const reason = { request: "cancel final doctor cleanup" };
await expect(
runDoctorOwned(
undefined,
createDoctorHostFixture({
signal: controller.signal,
close: async () => {
controller.abort(reason);
return undefined;
},
}),
),
).rejects.toMatchObject({
_tag: "AnalysisCancelledError",
cause: reason,
diagnostics: { doctor_report: { healthy: true } },
});
});
it("preserves an inspection-authored physical failure when final cleanup also observes cancellation", async () => {
const controller = new AbortController();
const physical = new ProviderAdapterError("ghidra", "doctor", {
diagnostics: { reason: "controlled inspection fault" },
});
await expect(
runDoctorOwned(
undefined,
createDoctorHostFixture({
signal: controller.signal,
providerInspections: async () => {
throw physical;
},
close: async () => {
controller.abort(physical);
return undefined;
},
}),
),
).rejects.toBe(physical);
expect(physical.cause).toBeUndefined();
});