mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 11:43:20 +00:00
* test(architecture): fail on a stale layer baseline and document the declared layers verify:module-boundaries reported a layer baseline entry whose imports were gone but still passed, so main kept process -> artifacts at 20 after it fell to 17 and a later change could add three imports back unnoticed. A stale entry now fails like growth; --shrink-layer-baseline lowers it in the change that removes the imports. The architecture map and CONTRIBUTING name scripts/lib/module-layers.mjs as the per-directory layer declaration. * test(architecture): refuse to lower the layer baseline after an inspection failure A file that cannot be parsed contributes no imports, so a shrink run would record counts that fail as growth once the file is fixed. Whole-command tests cover stale rejection, shrinking, refused growth and the inspection failure. * refactor(ports): move the progress, work-scope and inspection-scope ports to src/ports (#11214) * refactor(ports): move the progress, work-scope and inspection-scope ports to src/ports Pure move with git mv and import specifier updates. * test(architecture): declare the ports layer and lower the layer baseline src/ports sits between the foundation and the providers. Moving the three ports removes 11 provider -> application imports. * refactor(ports): move AnalysisProvider to src/ports (#11217) * refactor(ports): move AnalysisProvider to src/ports Pure move with git mv and import specifier updates in its importers, the built-fixture path, the CI scope glob and the lint-rule test spellings. * test(architecture): lower the layer baseline after moving AnalysisProvider * refactor(ports): move the per-feature provider ports to src/ports (#11226) * refactor(ports): move the per-feature provider ports to src/ports Pure move with git mv and import specifier updates: the 47 *Port.ts and *Ports.ts files that providers implement, plus OptionalObservationProviders, which only composes the observation ports. * test(architecture): lower the layer baseline after moving the feature ports * refactor(providers): move closeAnalysisClient and the Frida session input errors to their owners (#11233) * refactor(providers): move closeAnalysisClient to src/providers and the Frida session input errors to src/frida Pure move with git mv and import specifier updates. * test(architecture): drop the application-providers and application-frida cycles from the layer baseline * fix(ci): keep provider lanes selecting the ports moved to src/ports Each lane glob that matched a moved port under src/application gains its src/ports counterpart; the change-scope test pins one moved port per lane. * refactor(domain): declare the localPath host exception and read HOST_PLATFORM there (#11256) absoluteLocalPathStringSchema decides which paths are absolute on the running host, so it reads HOST_PLATFORM instead of process.platform. Domain may not import outside domain/contracts; module-layers now declares LAYER_EXCEPTIONS, exact file-to-file imports with a reason, and both the layer count and the pure-layer boundary skip only that import. Any other domain -> platform import still fails. * refactor(ports): move the doctor check and provider inspection types to src/ports (#11246) * refactor(ports): move the doctor check and provider inspection types to src/ports Declaration move from application/Doctor.ts (unchanged text) and import updates; no re-export from Doctor.ts. * test(architecture): lower the layer baseline after moving the doctor provider types * refactor(ports): move the packet capture and signal recording ports to src/ports (#11249) * refactor(ports): move the packet capture and signal recording ports to src/ports Declaration move (unchanged text) out of the two application services, with import updates. * test(architecture): lower the layer baseline after moving the capture and signal ports * refactor(domain): move the analysis error projection schema from contracts to domain (#11251) * refactor(domain): move the analysis error projection schema from contracts to domain Declaration move (unchanged text) of the projection schemas that domain modules embed; contracts/errorSchemas.ts keeps the CLI envelope and the published JSON Schema. Import updates only. * test(architecture): drop the contracts-domain cycle from the layer baseline * refactor(ports): drop the imports the moved capture, signal and doctor types left behind Also give the packet capture and signal recording lanes the new port paths, with change-scope cases. * refactor(resources): add src/resources and move AnalysisCleanupLease and ArtifactReader there (#11259) * refactor(resources): move AnalysisCleanupLease to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist paths the verifier scripts load). * refactor(resources): declare src/resources as a foundation unit src/resources owns the shared analysis resource modules that process, windows and providers hold; AnalysisCleanupLease is the first. Its tests join the adapters project, the apk signature lane selects it beside src/artifacts, and the layer baseline drops the process and windows imports of the lease. * test(ci): pin the apk signature lane on the moved cleanup lease * refactor(resources): move ArtifactReader to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist path a verifier script loads). * test(architecture): lower the layer baseline after moving ArtifactReader windows no longer imports src/artifacts; process -> artifacts 11 -> 9. The CI lanes that selected src/artifacts/ArtifactReader.ts select its new path, pinned in the change-scope test. * refactor(resources): move ArtifactResourceScope to src/resources (#11265) * refactor(artifacts): name the output tree and private root capabilities the resource scope releases ArtifactResourceScope typed its output-tree and private-runtime-root owners with SafeOutputTree (src/artifacts) and PrivateRuntimeRoot (src/process). It only calls rollback() and close(), so it now declares those capabilities itself and names neither unit, which lets it move to src/resources without a resources <-> process cycle. The withheld-export test narrows to SafeOutputTree where it reads the published flag. * refactor(resources): move ArtifactResourceScope to src/resources Pure move: git mv plus import specifier rewrites (source, tests, the dist paths verifier scripts load, and the FIFO probe's module-relative URL). * test(architecture): lower the layer baseline after moving ArtifactResourceScope process -> artifacts 9 -> 5, and the artifacts <-> dotnet mutual pair is gone. The sqlite and agentenv lanes select the scope at its new path, pinned in the change-scope test. * refactor(resources): move ArtifactFileOperation to src/resources (#11269) * refactor(resources): move ArtifactFileOperation to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist paths verifier scripts load). * test(architecture): lower the layer baseline after moving ArtifactFileOperation process -> artifacts 5 -> 1. * refactor(resources): move readStableArtifact to src/resources (#11271) * refactor(resources): move readStableArtifact to src/resources Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving readStableArtifact process no longer imports src/artifacts: process -> artifacts 1 -> 0 and the artifacts <-> process mutual pair is gone. The seven lanes that selected readStableArtifact select its new path, pinned in the change-scope test; the architecture map lists what src/resources owns. * refactor(hopper): take Linux launcher verification from composition through a port (#11278) The Hopper launcher imported inspectLinuxHopperLauncher and retryLinuxHopperPublisherCleanup from src/application (the two hopper -> application imports). src/ports/LinuxHopperLauncherVerification.ts now names that capability; src/application/LinuxHopper.ts provides LINUX_HOPPER_LAUNCHER_VERIFICATION, binary composition passes it to HopperProvider, and the provider hands it to the launcher. A launcher built without one refuses a Linux demo launch with reason verification_unavailable before running the launcher. Layer baseline: hopper -> application 2 -> 0. * refactor(config): move Hopper launcher discovery to a src/hopperPaths foundation unit (#11292) * refactor(hopper): move the launcher discovery and macOS Hopper paths to src/hopperPaths Pure move: git mv plus import specifier rewrites. * refactor(hopper): declare src/hopperPaths as a foundation unit with the Linux launcher candidates Hopper install paths and launcher discovery are pure path facts that the Hopper provider, doctor and setup all read. Declare src/hopperPaths in the foundation layer, add it to the adapters test project, the architecture map and the package-baseline CI lane, and move the Linux launcher candidates out of src/application/LinuxHopper.ts into src/hopperPaths/LinuxHopperPaths.ts so discovery no longer imports application code. * refactor(config): leave Hopper launcher discovery to the Hopper provider parseConfig resolved an unset HOPPER_LAUNCHER_PATH by probing the filesystem through application-owned discovery, so config imported application (config -> application 2, application <-> config cycle) and read process.platform ambiently. AppConfig.hopperLauncherPath is now the caller's HOPPER_LAUNCHER_PATH unchanged (string | undefined). src/hopperPaths/HopperLauncherDiscovery.ts owns the selection (selectedHopperLauncherPath: the configured spelling, else discovery from the caller environment's home on the provider's platform); HopperProvider and the two real-Hopper verifiers read it. Discovery tests move from config.test.ts to src/hopperPaths; a provider test covers discovery from the provider's own platform and home. Module layers: config -> application 2 -> 0; application <-> config removed. Architecture guards: ambient platform reads in parseConfig.ts 2 -> 0. * refactor(providers): move owned-process prerequisite availability out of application (#11294) * refactor(providers): move the owned-process prerequisite availability mapping to src/providers Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving owned-process availability android -> application 1 -> 0; apktool -> application 1 -> 0. * refactor(process): move the regular-file read owner out of application (#11299) * refactor(process): move the regular-file read owner from src/application to src/process Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving the regular-file read owner desktop -> application 5 -> 4; dotnet -> application 2 -> 1. The agentenv lane listed src/application/RegularFileRead.ts. At its new path it is a src/process/ shared boundary: fast qualification selects the code and runtime checks (and the single owning lane, web_source_map, via src/process/**), and full qualification selects every lane, as for every other src/process/ module. A second owner entry would only suppress the web_source_map selection, so the agentenv entry is removed, not renamed. * refactor(resources): give atomic text writes their own owner (#11302) * refactor(resources): give atomic text writes their own owner in src/resources src/application/JsonFiles.ts owned both JSON input reads and the atomic text write (writeTextFile / writeTextParts and their staged-output publication). The write side depends only on domain, filesystem and resource owners, but il2cpp's Ghidra seed writer had to import application to reach it (il2cpp -> application). Move the write side verbatim to src/resources/TextFileWrite.ts (TextWriteCancellation, writeTextFile, writeTextParts and their private staging, publication and failure classification helpers). JsonFiles keeps the JSON read owner and reads the shared errno-to-reason classifier (fileAccessFailureReason) from the write owner instead of a copy. Importers (il2cpp seed writer, evidence bundle files, desktop build solves, analysis snapshot files and four boundary tests) read the new path; no re-export is left in JsonFiles. * test(architecture): lower the layer baseline after moving the text write owner il2cpp -> application 1 -> 0. * refactor(ports): move the desktop build host contract to src/ports (#11303) * refactor(domain): move the setup cancellation check from src/application to src/domain Pure move: git mv plus import specifier rewrites. * refactor(ports): move the desktop build host contract to src/ports The desktop provider implements doctor's desktop build facts reader and setup's desktop build host, but the contract it implements lived in application (DesktopBuildDoctor, SetupDesktopBuild, Doctor's clientRegistrations signature, ClientRegistrationEnvironment's setting types), so desktop imported application four times and the two units were a recorded mutual pair. src/ports/DesktopBuildHost.ts now holds that contract, moved verbatim: DesktopBuildCommand, DesktopBuildFacts, DesktopBuildFactsInput, DesktopBuildSetupFacts, DesktopBuildSetupHost, RecordedProviderSettings and OwnedProviderSetting. Two names are new: DesktopBuildRegistration, the registration facts the host reads (client, command and the recorded-settings names; client registration status satisfies it), and DesktopBuildRegistrationReader, which replaces DoctorHost["clientRegistrations"] in the setup host. The facts input's registration reader returns DesktopBuildRegistration instead of the full application status; the setup facts' settings are spelled Readonly<Record<string, string>> (SetupProviderEnvironment's definition). Application imports the types from the port; no re-export is left. * test(architecture): lower the layer baseline after the desktop build host port desktop -> application 4 -> 0; the application <-> desktop mutual pair is gone. * refactor(domain): define the resolved app bundle resource root beside its schema (#11304) * refactor(domain): define the resolved app bundle resource root beside its provenance schema ResolvedAppBundleResourceRoot (an app directory's resource-only identity) is a pure type over BundleResourceRoot's layout, but it lived in src/application/AppBundleExecutable.ts, so the native and artifact providers that receive it imported application. Move the interface verbatim to src/domain/apple/bundleResourceRoot.ts, which owns BundleResourceRoot, and point its eight readers there (native macOS provider and plist source, artifact provider, binary composition, and the binary session, status, port and bundle-resource session). The resolver that produces it stays in application. * test(architecture): lower the layer baseline after moving the resource root type native -> application 2 -> 0; artifacts -> application 2 -> 1 (the artifact provider still constructs BundleResourceSession). * refactor(config): move the pwntools input bound parser to src/config (#11306) * refactor(config): move the pwntools input bound parser from src/native to src/config Pure move: git mv plus import specifier rewrites, and the module path in docs/design/rea-limit-inventory.md (table realigned by oxfmt). * test(architecture): lower the layer baseline after moving the pwntools input bound config -> native 1 -> 0. The binary_layout and recorded_crash lanes, which select src/native/pwntools/**, also select src/config/pwntoolsInputLimit*.ts; ciChangeScope.test.ts pins both. * refactor(filesystem): move REA cache directory helpers out of config (#11309) * refactor(filesystem): move the REA cache directory and lexical directory helpers from src/config to src/filesystem Pure move: git mv plus import specifier rewrites. * test(architecture): drop the config and filesystem cycle from the layer baseline config no longer imports filesystem; filesystem still reads the Windows ChangeTime settle budget from config. * refactor(windows): break the process and windows import cycle (#11317) * refactor(domain): move the runtime-control and private-runtime-root refusals from src/process to src/domain Pure move: git mv plus import specifier rewrites (including the dist path scripts/verify-windows-native.mjs loads). * refactor(windows): type Job Object cleanup by what a Windows job reports WindowsOwnedProcess.cleanup() returned process-ownership's ProcessCleanupResult, so src/windows imported src/process for a type while process imports windows to supervise Windows trees. A Job Object stop only ever reports settled-and-signalled or a reason it did not settle; name that subset WindowsJobCleanupResult in windows. It stays assignable to ProcessCleanupResult, so the process supervisor reads it unchanged. * test(architecture): drop the process and windows cycle from the layer baseline * test(architecture): ratchet cross-provider imports and imports past a provider entry (#11386) * test(architecture): ratchet cross-provider imports and imports past a provider entry A provider folder may import the domain, contracts, foundation and ports layers, the shared provider core (src/providers) and its own files; an import of another provider folder is a recorded exception. Application, composition and the CLI/MCP adapters reach a provider only through src/<provider>/index.ts. verify:module-boundaries counts both kinds of import per unit pair in the layer baseline (crossProvider, providerEntry); like the upward counts they may only shrink, and a pair missing from the baseline fails. * refactor(resources): move StableArtifactFailure and StableArtifactObservation into src/resources (#11387) * refactor(resources): move StableArtifactFailure and StableArtifactObservation into src/resources Providers project stable-read failures through StableArtifactFailure next to the other shared provider toolkit owners (ArtifactReader, ArtifactResourceScope, ArtifactFileOperation, AnalysisCleanupLease, readStableArtifact) that already live in src/resources. Under src/artifacts it made every provider that reads a stable artifact import the artifacts provider. Pure move: git mv plus import specifier and baseline updates; the layer baseline drops the provider-boundary counts the move removes. * refactor(resources): reach the shared provider toolkit through src/resources/index.ts (#11390) * refactor(resources): import the shared provider toolkit through src/resources/index.ts Adds src/resources/index.ts, which exports the toolkit names that production code outside src/resources uses, and rewrites those importers (420 files) to import from it, merging each importer's toolkit imports into one declaration. Mechanical: import declarations only. * test(architecture): reach src/resources only through its entry file verify:module-boundaries now counts any production import of a src/resources file other than src/resources/index.ts, from any unit, with the imports past a provider entry. The count is renamed from providerEntry to entry ("import past the entry file"); it may only shrink, and src/resources starts at zero. * test(architecture): cover provider boundary counts through the verifier command * refactor(resources): move the safe output tree and artifact path owners into src/resources (#11398) * refactor(resources): move the safe output tree and artifact path owners into src/resources SafeOutputTree (with its admission, creation failure, readback, cleanup and identity files), StreamBytes, ArtifactPaths and readArtifactFileChunks depend only on domain, filesystem, platform and the toolkit, and browser, firmware, ghidra, javascript, android and apktool use them to publish outputs. Under src/artifacts every such provider imported the artifacts provider. Pure move: git mv, importers moved onto src/resources/index.ts (names added to the entry), the moved files import toolkit modules directly, path keys in the CI scopes and guard baseline follow the move, and the layer baseline drops the removed imports. * test(architecture): give the shared provider core its own layer below the providers (#11401) src/providers (deferred client owners and failure attribution) now imports only domain, ports, process, filesystem and the resources toolkit. Declaring it as the providerCore layer, between ports and providers, makes any import from it into a provider folder an upward import that verify:module-boundaries rejects, and lets every unit in the providers layer be a provider folder. * test(architecture): declare each provider's entry files instead of a provider barrel (#11407) * chore: ignore the source map parser move (#11348) in blame * test(architecture): declare inspector's use of the browser CDP client as a provider dependency (#11420)
1070 lines
37 KiB
TypeScript
1070 lines
37 KiB
TypeScript
import { publishCliAnalysisEvidence } from "../../src/cli/analysisEvidenceDelivery.js";
|
|
import { projectCliAnalysisResult } from "../../src/cli/projectCliAnalysisResult.js";
|
|
import {
|
|
mkdir,
|
|
open,
|
|
readFile,
|
|
readdir,
|
|
stat,
|
|
writeFile,
|
|
} from "node:fs/promises";
|
|
import { basename, dirname, join } from "node:path";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
import { createPackageWithOptions } from "@electron/asar";
|
|
import { createArtifactBinarySession } from "../../src/composition/binary.js";
|
|
import {
|
|
runDirectAnalysis,
|
|
runManagedProviderExecution,
|
|
runProviderAnalysis,
|
|
} from "../../src/application/DirectAnalysis.js";
|
|
import type { DirectAnalysisDependencies } from "../../src/application/DirectAnalysisDependencies.js";
|
|
import { parseConfig } from "../../src/config/parseConfig.js";
|
|
import { analysisCliErrorEnvelopeSchema } from "../../src/contracts/errorSchemas.js";
|
|
import type { AnalysisError } from "../../src/domain/analysisErrorBase.js";
|
|
import {
|
|
AnalysisCancelledError,
|
|
AnalysisInputError,
|
|
AnalysisTimeoutError,
|
|
} from "../../src/domain/analysisErrorCore.js";
|
|
import {
|
|
projectAnalysisError,
|
|
projectAnalysisErrorWithoutCapturedOutput,
|
|
} from "../../src/domain/analysisErrorProjection.js";
|
|
import {
|
|
createEvidence,
|
|
parseEvidence,
|
|
type Evidence,
|
|
} from "../../src/domain/evidence.js";
|
|
import { jsonObjectSchema } from "../../src/domain/jsonValue.js";
|
|
import { artifactInspectionResultSchema } from "../../src/domain/artifactInspection.js";
|
|
import { ProviderCleanupError } from "../../src/domain/providerCleanupError.js";
|
|
import { ghidraFunctionDossier } from "../../src/domain/ghidraValues.fixture.js";
|
|
import {
|
|
createAnalysisProfile,
|
|
type AnalysisProfileCommitment,
|
|
} from "../../src/domain/analysisProfile.js";
|
|
import { OwnedStagedOutput } from "../../src/filesystem/OwnedStagedOutput.js";
|
|
import { readAnalysisSnapshot } from "../../src/application/binary/AnalysisSnapshotFiles.js";
|
|
import { EvidenceFileError } from "../../src/domain/evidenceErrors.js";
|
|
import { err, ok } from "../../src/domain/result.js";
|
|
import { isCliOperationFailure } from "../../src/cliLogging.js";
|
|
import { observed } from "../fixtures/analysisExecution.js";
|
|
import {
|
|
createBinarySessionTargets,
|
|
createTestBinarySession,
|
|
createTestProviderRouter,
|
|
} from "../fixtures/binarySession.js";
|
|
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
|
|
import { BinarySession } from "../../src/application/binary/BinarySession.js";
|
|
import { InvestigationRecords } from "../../src/application/investigation/InvestigationRecords.js";
|
|
import { AnalysisCleanupLease } from "../../src/resources/AnalysisCleanupLease.js";
|
|
|
|
const cleanupError = new ProviderCleanupError(
|
|
"fixture",
|
|
["fixture-provider-process"],
|
|
{ reason: "process exit could not be confirmed" },
|
|
{ remediationAction: "Close the retained fixture process before retrying." },
|
|
);
|
|
|
|
const primaryError = new AnalysisTimeoutError("read_bytes", 100, {
|
|
capturedOutput: {
|
|
stdout: "retained observation",
|
|
stderr: "",
|
|
truncated: false,
|
|
},
|
|
});
|
|
|
|
const factories = (
|
|
options: {
|
|
readonly profile?: AnalysisProfileCommitment;
|
|
readonly executionError?: AnalysisError;
|
|
readonly thrownExecution?: Error;
|
|
readonly cleanupError?: AnalysisError;
|
|
readonly thrownCleanup?: Error;
|
|
readonly onClose?: () => void;
|
|
} = {},
|
|
) => {
|
|
const profile = options.profile;
|
|
const session = createTestBinarySession(
|
|
() => ({
|
|
execute: async (operation) => {
|
|
if (operation === "health") return observed(null);
|
|
if (options.thrownExecution !== undefined)
|
|
throw options.thrownExecution;
|
|
return options.executionError === undefined
|
|
? observed(
|
|
operation === "analyze_function"
|
|
? ghidraFunctionDossier()
|
|
: { operation, observation: "retained result" },
|
|
)
|
|
: err(options.executionError);
|
|
},
|
|
close: async () => {
|
|
if (options.thrownCleanup !== undefined) throw options.thrownCleanup;
|
|
options.onClose?.();
|
|
return options.cleanupError === undefined
|
|
? ok(null)
|
|
: err(options.cleanupError);
|
|
},
|
|
}),
|
|
profile === undefined
|
|
? {}
|
|
: { resolveAnalysisProfile: async () => ok({ profile }) },
|
|
);
|
|
const dependencies: DirectAnalysisDependencies = {
|
|
readConfiguration: () => parseConfig({}),
|
|
createBinarySession: () => session,
|
|
createArtifactBinarySession: () => session,
|
|
createNativeDispatchBinarySession: () => session,
|
|
createNativeBinarySession: () => session,
|
|
createManagedBinarySession: () => session,
|
|
};
|
|
return { dependencies, session };
|
|
};
|
|
|
|
it("rejects malformed one-shot operation inputs before creating a session", async () => {
|
|
const { dependencies, session } = factories();
|
|
const create = vi.fn(() => session);
|
|
const guarded = {
|
|
...dependencies,
|
|
createBinarySession: create,
|
|
createNativeBinarySession: create,
|
|
createArtifactBinarySession: create,
|
|
createManagedBinarySession: create,
|
|
};
|
|
for (const result of [
|
|
await runDirectAnalysis(guarded, "/missing", "inspect_native_instruction", {
|
|
address: "",
|
|
}),
|
|
await runDirectAnalysis(guarded, "/missing", "annotate_native_function", {
|
|
procedure: "main",
|
|
}),
|
|
await runDirectAnalysis(guarded, "/missing", "trace_feature", {
|
|
query: "",
|
|
}),
|
|
await runDirectAnalysis(guarded, "/missing", "analyze_function", {
|
|
procedure: "",
|
|
}),
|
|
await runDirectAnalysis(guarded, "/missing", "inspect_native_api", {
|
|
procedure: "",
|
|
}),
|
|
await runProviderAnalysis(guarded, "/missing", "observe_native_calls", {
|
|
breakpoints: [],
|
|
}),
|
|
await runProviderAnalysis(guarded, "/missing", "inspect_asset_catalog", {
|
|
limit: -1,
|
|
}),
|
|
]) {
|
|
expect(result.ok).toBe(false);
|
|
if (!result.ok)
|
|
expect(result.error).toMatchObject({ code: "invalid_request" });
|
|
}
|
|
const managed = await runManagedProviderExecution(
|
|
guarded,
|
|
"/missing",
|
|
"inspect_managed_members",
|
|
undefined,
|
|
{ type_names: ["Duplicate", "Duplicate"] },
|
|
);
|
|
expect(managed.ok).toBe(false);
|
|
if (!managed.ok)
|
|
expect(projectAnalysisError(managed.error)).toMatchObject({
|
|
code: "invalid_request",
|
|
});
|
|
expect(create).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it.each([false, true])(
|
|
"retains actual artifact sources and caller path after final-close cancellation (cleanup fails: %s)",
|
|
async (closeFails) => {
|
|
const root = await createTestTempDirectory("rea-artifact-final-close-");
|
|
const source = join(root, "source");
|
|
const archive = join(root, "fixture.asar");
|
|
await mkdir(source);
|
|
await writeFile(join(source, "main.js"), "console.log('retained');\n");
|
|
await createPackageWithOptions(source, archive, {});
|
|
const session = await createArtifactBinarySession({});
|
|
const nativeClose = session.close.bind(session);
|
|
const controller = new AbortController();
|
|
const reason = {
|
|
request: "cancel during actual artifact session final close",
|
|
};
|
|
let completed: Evidence | undefined;
|
|
const close = vi
|
|
.spyOn(session, "close")
|
|
.mockImplementationOnce(async () => {
|
|
completed = session
|
|
.exportEvidenceBundle()
|
|
.records.find(
|
|
({ operation, caller_input_path }) =>
|
|
operation === "inspect_artifact" && caller_input_path === archive,
|
|
);
|
|
controller.abort(reason);
|
|
// A controlled refusal retains the actual static session for finally
|
|
// cleanup; successful cleanup runs its native owner here.
|
|
return closeFails ? err(cleanupError) : nativeClose();
|
|
});
|
|
const unexpectedSession = () => {
|
|
throw new Error("Artifact one-shot must select its static session");
|
|
};
|
|
const dependencies: DirectAnalysisDependencies = {
|
|
readConfiguration: () => parseConfig({}),
|
|
createArtifactBinarySession: () => session,
|
|
createBinarySession: unexpectedSession,
|
|
createNativeDispatchBinarySession: unexpectedSession,
|
|
createNativeBinarySession: unexpectedSession,
|
|
createManagedBinarySession: unexpectedSession,
|
|
};
|
|
try {
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runProviderAnalysis(
|
|
dependencies,
|
|
archive,
|
|
"inspect_artifact",
|
|
{},
|
|
undefined,
|
|
controller.signal,
|
|
).then(projectCliAnalysisResult),
|
|
);
|
|
expect(result.code).toBe(closeFails ? "cleanup_incomplete" : "cancelled");
|
|
expect(result.category).toBe("cancelled");
|
|
expect(completed).toBeDefined();
|
|
const details = jsonObjectSchema.parse(result.details);
|
|
const partial = parseEvidence(details.partial_observation);
|
|
expect(partial).toEqual(completed);
|
|
expect(partial.operation).toBe("inspect_artifact");
|
|
expect(partial.caller_input_path).toBe(archive);
|
|
expect(partial.subject?.local_path).toBe(archive);
|
|
const inspection = artifactInspectionResultSchema.parse(
|
|
partial.normalized_result,
|
|
);
|
|
expect(inspection.subject.root_format).toBe("asar");
|
|
expect(partial.evidence_links).toEqual(inspection.evidence_links);
|
|
expect(partial.evidence_links).toEqual(
|
|
inspection.substeps.map(({ evidence }) => evidence.evidence_id),
|
|
);
|
|
expect(inspection.substeps[0]?.evidence.normalized_result).toMatchObject({
|
|
occurrences: expect.arrayContaining([
|
|
expect.objectContaining({ logical_path: "main.js" }),
|
|
]),
|
|
});
|
|
if (closeFails)
|
|
expect(details.cleanup_error).toEqual(
|
|
projectAnalysisError(cleanupError),
|
|
);
|
|
else expect(result.details).not.toHaveProperty("cleanup_error");
|
|
expect((await readdir(root)).sort()).toEqual(["fixture.asar", "source"]);
|
|
} finally {
|
|
close.mockRestore();
|
|
const closed = await nativeClose();
|
|
if (!closed.ok) throw closed.error;
|
|
}
|
|
},
|
|
);
|
|
|
|
it("retains both execution and final-close resources in one-shot failures", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const executionError = new AnalysisTimeoutError("read_bytes", 100, {
|
|
capturedOutput: {
|
|
stdout: "execution observation",
|
|
stderr: "",
|
|
truncated: false,
|
|
},
|
|
cleanup: {
|
|
reason: "execution worker remains",
|
|
resources: ["execution-worker", "shared-owner"],
|
|
},
|
|
});
|
|
const closeError = new ProviderCleanupError(
|
|
"fixture",
|
|
["session-owner", "shared-owner"],
|
|
{ reason: "session remains" },
|
|
);
|
|
const { dependencies } = factories({
|
|
executionError,
|
|
cleanupError: closeError,
|
|
});
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
length: 1,
|
|
}).then(projectCliAnalysisResult),
|
|
);
|
|
expect(result).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
details: {
|
|
resources: ["execution-worker", "shared-owner", "session-owner"],
|
|
execution_failure: "provider_timeout",
|
|
captured_output: executionError.capturedOutput,
|
|
cleanup_error: projectAnalysisError(closeError),
|
|
},
|
|
});
|
|
});
|
|
|
|
it.each([false, true])(
|
|
"binds the exact caller path to provider failure Evidence (session cleanup fails: %s)",
|
|
async (closeFails) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const callerPath = `${dirname(path)}/./${basename(path)}`;
|
|
const original = createEvidence(
|
|
{ path, sha256: "a".repeat(64), format: "mach-o", architecture: "arm64" },
|
|
{ id: "fixture", name: "Fixture", version: null },
|
|
{ operation: "read_bytes", parameters: {}, result: { byte: 42 } },
|
|
);
|
|
const failure = new AnalysisCancelledError("read_bytes", {
|
|
partialObservation: original,
|
|
});
|
|
const { dependencies } = factories({
|
|
executionError: failure,
|
|
...(closeFails ? { cleanupError } : {}),
|
|
});
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runDirectAnalysis(dependencies, callerPath, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult),
|
|
);
|
|
const observation = parseEvidence(
|
|
jsonObjectSchema.parse(result.details).partial_observation,
|
|
);
|
|
expect(observation.caller_input_path).toBe(callerPath);
|
|
expect(observation.subject?.local_path).toBe(path);
|
|
expect(observation.evidence_id).toBe(original.evidence_id);
|
|
expect(observation.normalized_result).toEqual({ byte: 42 });
|
|
expect(original.caller_input_path).toBeUndefined();
|
|
},
|
|
);
|
|
|
|
it("preserves the caller path on an authenticated record refused by the ledger", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const callerPath = `${dirname(path)}/./${basename(path)}`;
|
|
const records = new InvestigationRecords({ maximumRepresentationBytes: 0 });
|
|
const session = new BinarySession(
|
|
createTestProviderRouter(
|
|
() => ({
|
|
execute: async (operation) =>
|
|
observed(operation === "health" ? null : { byte: 42 }),
|
|
close: async () => ok(null),
|
|
}),
|
|
{
|
|
resolveAnalysisProfile: async () =>
|
|
ok({
|
|
profile: createAnalysisProfile(
|
|
{
|
|
id: "fixture",
|
|
name: "Fixture analysis provider",
|
|
version: "1",
|
|
},
|
|
{ fixture: true },
|
|
),
|
|
}),
|
|
},
|
|
),
|
|
records,
|
|
);
|
|
const createSession = () => session;
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runDirectAnalysis(
|
|
{
|
|
readConfiguration: () => parseConfig({}),
|
|
createBinarySession: createSession,
|
|
createArtifactBinarySession: createSession,
|
|
createNativeDispatchBinarySession: createSession,
|
|
createNativeBinarySession: createSession,
|
|
createManagedBinarySession: createSession,
|
|
},
|
|
callerPath,
|
|
"read_bytes",
|
|
{ address: "0x100", document: "fixture" },
|
|
).then(projectCliAnalysisResult),
|
|
);
|
|
expect(result.code).toBe("resource_constraint");
|
|
const partial = jsonObjectSchema.parse(
|
|
jsonObjectSchema.parse(result.details).partial_observation,
|
|
);
|
|
expect(partial.kind).toBe("unretained-evidence");
|
|
const evidence = parseEvidence(partial.evidence);
|
|
expect(evidence.caller_input_path).toBe(callerPath);
|
|
expect(evidence.subject?.local_path).toBe(path);
|
|
expect(evidence.normalized_result).toEqual({ byte: 42 });
|
|
expect(records.statistics().evidenceRecords).toBe(0);
|
|
});
|
|
|
|
describe("one-shot finalization cancellation", () => {
|
|
it.each(["read_bytes", "analyze_function"] as const)(
|
|
"retains completed %s Evidence when cancellation arrives during final close",
|
|
async (tool) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const parameters =
|
|
tool === "analyze_function"
|
|
? { procedure: "fixture" }
|
|
: { address: "0x1000" };
|
|
const original = parseEvidence(
|
|
await runDirectAnalysis(
|
|
factories().dependencies,
|
|
path,
|
|
tool,
|
|
parameters,
|
|
).then(projectCliAnalysisResult),
|
|
);
|
|
const controller = new AbortController();
|
|
const reason = { request: "cancel during native close" };
|
|
const { dependencies, session } = factories({
|
|
onClose: () => controller.abort(reason),
|
|
});
|
|
const result = await runDirectAnalysis(
|
|
dependencies,
|
|
path,
|
|
tool,
|
|
parameters,
|
|
{ signal: controller.signal },
|
|
).then(projectCliAnalysisResult);
|
|
expect(result).toEqual({
|
|
error: "Analysis failed",
|
|
...projectAnalysisError(
|
|
new AnalysisCancelledError(tool, {
|
|
cause: reason,
|
|
partialObservation: original,
|
|
}),
|
|
),
|
|
});
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
},
|
|
);
|
|
|
|
it.each([false, true])(
|
|
"preserves the execution failure during close cancellation (cleanup fails: %s)",
|
|
async (closeFails) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const controller = new AbortController();
|
|
const failure = new AnalysisTimeoutError("read_bytes", 100, {
|
|
capturedOutput: primaryError.capturedOutput,
|
|
});
|
|
const { dependencies } = factories({
|
|
executionError: failure,
|
|
onClose: () => controller.abort({ later: true }),
|
|
...(closeFails ? { cleanupError } : {}),
|
|
});
|
|
const result = await runDirectAnalysis(
|
|
dependencies,
|
|
path,
|
|
"read_bytes",
|
|
{ address: "0x1000" },
|
|
{ signal: controller.signal },
|
|
).then(projectCliAnalysisResult);
|
|
expect(result).toMatchObject({
|
|
code: closeFails ? "cleanup_incomplete" : "provider_timeout",
|
|
message: projectAnalysisError(failure).message,
|
|
details: {
|
|
captured_output: failure.capturedOutput,
|
|
...(closeFails
|
|
? { cleanup_error: projectAnalysisError(cleanupError) }
|
|
: {}),
|
|
},
|
|
});
|
|
},
|
|
);
|
|
|
|
it("retains completed Evidence and cancellation alongside unsuccessful cleanup", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const controller = new AbortController();
|
|
const { dependencies } = factories({
|
|
cleanupError,
|
|
onClose: () => controller.abort({ during: "close" }),
|
|
});
|
|
const result = await runDirectAnalysis(
|
|
dependencies,
|
|
path,
|
|
"read_bytes",
|
|
{ address: "0x1000" },
|
|
{ signal: controller.signal },
|
|
).then(projectCliAnalysisResult);
|
|
expect(result).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
category: "cancelled",
|
|
details: {
|
|
execution_failure: "cancelled",
|
|
resources: ["fixture-provider-process"],
|
|
partial_observation: {
|
|
operation: "read_bytes",
|
|
normalized_result: { observation: "retained result" },
|
|
},
|
|
cleanup_error: projectAnalysisError(cleanupError),
|
|
},
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("snapshot publication finalization", () => {
|
|
it.each([
|
|
"success",
|
|
"cancel",
|
|
"recovered-write-cancel",
|
|
"close-failure",
|
|
"cancel-close-failure",
|
|
] as const)(
|
|
"retains the actual snapshot publication through finalization: %s",
|
|
async (mode) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const snapshotPath = join(dirname(path), "snapshot.json");
|
|
const controller = new AbortController();
|
|
const profile = createAnalysisProfile(
|
|
{ id: "fixture", name: "Fixture analysis provider", version: "1" },
|
|
{ fixture: true },
|
|
);
|
|
const cancelled = mode.includes("cancel");
|
|
const { dependencies, session } = factories({
|
|
profile,
|
|
onClose: () => {
|
|
if (cancelled) controller.abort({ during: "snapshot finalization" });
|
|
},
|
|
...(mode.includes("close-failure") ? { cleanupError } : {}),
|
|
});
|
|
const stagingCleanup =
|
|
mode === "recovered-write-cancel"
|
|
? vi
|
|
.spyOn(OwnedStagedOutput.prototype, "close")
|
|
.mockRejectedValueOnce(
|
|
new Error("transient staging cleanup failure"),
|
|
)
|
|
: undefined;
|
|
try {
|
|
const result = await runDirectAnalysis(
|
|
dependencies,
|
|
path,
|
|
"read_bytes",
|
|
{ address: "0x1000" },
|
|
{ signal: controller.signal, snapshotPath },
|
|
).then(projectCliAnalysisResult);
|
|
const loaded = await readAnalysisSnapshot(snapshotPath);
|
|
if (!loaded.ok) throw loaded.error;
|
|
const evidence = loaded.value.evidence_bundle.records.find(
|
|
(record) => record.operation === "read_bytes",
|
|
);
|
|
expect(evidence).toBeDefined();
|
|
const receipt = {
|
|
path: snapshotPath,
|
|
bytes: (await stat(snapshotPath)).size,
|
|
};
|
|
expect((await readFile(snapshotPath)).byteLength).toBe(receipt.bytes);
|
|
if (mode === "success") expect(result).toEqual(evidence);
|
|
else {
|
|
const failure = analysisCliErrorEnvelopeSchema.parse(result);
|
|
expect(failure.code).toBe(
|
|
mode.includes("close-failure") ? "cleanup_incomplete" : "cancelled",
|
|
);
|
|
expect(failure.details).toMatchObject({
|
|
partial_observation: evidence,
|
|
diagnostics: { analysis_snapshot: receipt },
|
|
});
|
|
}
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
expect((await readdir(dirname(path))).toSorted()).toEqual([
|
|
"first.hop",
|
|
"second.hop",
|
|
"snapshot.json",
|
|
]);
|
|
if (stagingCleanup !== undefined)
|
|
expect(stagingCleanup).toHaveBeenCalledTimes(2);
|
|
} finally {
|
|
stagingCleanup?.mockRestore();
|
|
}
|
|
},
|
|
);
|
|
|
|
it("preserves a snapshot write failure over later cancellation without a publication receipt", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const controller = new AbortController();
|
|
const profile = createAnalysisProfile(
|
|
{ id: "fixture", name: "Fixture analysis provider", version: "1" },
|
|
{ fixture: true },
|
|
);
|
|
const { dependencies, session } = factories({
|
|
profile,
|
|
onClose: () => controller.abort({ later: true }),
|
|
});
|
|
const failure = new EvidenceFileError("write", "io", {
|
|
path: join(dirname(path), "failed.json"),
|
|
});
|
|
const write = vi
|
|
.spyOn(session, "writeAnalysisSnapshot")
|
|
.mockResolvedValue(err(failure));
|
|
try {
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runDirectAnalysis(
|
|
dependencies,
|
|
path,
|
|
"read_bytes",
|
|
{ address: "0x1000" },
|
|
{ signal: controller.signal, snapshotPath: failure.path },
|
|
).then(projectCliAnalysisResult),
|
|
);
|
|
expect(result.code).toBe(projectAnalysisError(failure).code);
|
|
expect(result.details).toMatchObject({
|
|
partial_observation: { operation: "read_bytes" },
|
|
});
|
|
expect(result.details).not.toHaveProperty(
|
|
"diagnostics.analysis_snapshot",
|
|
);
|
|
expect(await readdir(dirname(path))).not.toContain("failed.json");
|
|
} finally {
|
|
write.mockRestore();
|
|
}
|
|
});
|
|
});
|
|
|
|
it.each([false, true])(
|
|
"retains original cleanup diagnostics when final close fails: %s",
|
|
async (closeFails) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const executionError = new AnalysisTimeoutError("read_bytes", 100, {
|
|
cleanup: {
|
|
reason: "snapshot removal failed during execution",
|
|
resources: ["primary-snapshot"],
|
|
},
|
|
capturedOutput: primaryError.capturedOutput,
|
|
});
|
|
const primary = projectAnalysisError(executionError);
|
|
const { dependencies } = factories({
|
|
executionError,
|
|
...(closeFails ? { cleanupError } : {}),
|
|
});
|
|
const result = analysisCliErrorEnvelopeSchema.parse(
|
|
await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult),
|
|
);
|
|
expect(result).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
details: {
|
|
...primary.details,
|
|
...(closeFails
|
|
? {
|
|
resources: ["primary-snapshot", "fixture-provider-process"],
|
|
cleanup_error: projectAnalysisError(cleanupError),
|
|
}
|
|
: {}),
|
|
},
|
|
});
|
|
expect(JSON.stringify(result).match(/retained observation/g)).toHaveLength(
|
|
1,
|
|
);
|
|
if (!closeFails) expect(result.details).not.toHaveProperty("cleanup_error");
|
|
},
|
|
);
|
|
|
|
describe("one-shot analysis cleanup outcomes", () => {
|
|
it("retains successful evidence and reports CLI failure when close fails", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies, session } = factories({ cleanupError });
|
|
const result = await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult);
|
|
expect(result).toMatchObject({
|
|
error: "Analysis failed",
|
|
code: "cleanup_incomplete",
|
|
details: {
|
|
resources: ["fixture-provider-process"],
|
|
partial_observation: {
|
|
operation: "read_bytes",
|
|
subject: { local_path: path },
|
|
normalized_result: { observation: "retained result" },
|
|
raw_result: null,
|
|
},
|
|
},
|
|
});
|
|
expect(isCliOperationFailure(result)).toBe(true);
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
});
|
|
|
|
it("preserves primary failure diagnostics alongside an unsuccessful close", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies } = factories({
|
|
executionError: primaryError,
|
|
cleanupError,
|
|
});
|
|
const primary = projectAnalysisError(primaryError);
|
|
const result = await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult);
|
|
const callerError = analysisCliErrorEnvelopeSchema.parse(result);
|
|
expect(callerError).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
category: primary.category,
|
|
message: primary.message,
|
|
remediation: {
|
|
action: "Close the retained fixture process before retrying.",
|
|
},
|
|
details: {
|
|
execution_failure: primary.code,
|
|
captured_output: primary.details?.captured_output,
|
|
cleanup_error: projectAnalysisError(cleanupError),
|
|
},
|
|
});
|
|
expect(callerError.details).not.toHaveProperty("primary_error");
|
|
expect(
|
|
JSON.stringify(callerError).match(/retained observation/g),
|
|
).toHaveLength(1);
|
|
expect(isCliOperationFailure(result)).toBe(true);
|
|
});
|
|
|
|
it("reports provider close rejection with the successful observation", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies } = factories({
|
|
thrownCleanup: new Error("unexpected close rejection"),
|
|
});
|
|
const result = await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult);
|
|
expect(result).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
details: {
|
|
resources: ["provider-client"],
|
|
diagnostics: { reason: "provider client close rejected unexpectedly" },
|
|
partial_observation: {
|
|
normalized_result: { observation: "retained result" },
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("retains both unexpected execution failure and cleanup failure", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const thrownExecution = new Error("unexpected execution rejection");
|
|
const { dependencies } = factories({ thrownExecution, cleanupError });
|
|
await expect(
|
|
runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult),
|
|
).rejects.toMatchObject({
|
|
cause: thrownExecution,
|
|
errors: [thrownExecution, cleanupError],
|
|
});
|
|
});
|
|
|
|
it("keeps successful evidence unchanged after confirmed cleanup", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies, session } = factories();
|
|
const result = await runDirectAnalysis(dependencies, path, "read_bytes", {
|
|
address: "0x1000",
|
|
}).then(projectCliAnalysisResult);
|
|
expect(parseEvidence(result)).toMatchObject({
|
|
operation: "read_bytes",
|
|
normalized_result: { observation: "retained result" },
|
|
});
|
|
expect(isCliOperationFailure(result)).toBe(false);
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
it.each(["complete", "summary"] as const)(
|
|
"retains completed Evidence when cancellation arrives during managed close before %s delivery",
|
|
async (detail) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const files = (await readdir(dirname(path))).sort();
|
|
const original = parseEvidence(
|
|
await runProviderAnalysis(
|
|
factories().dependencies,
|
|
path,
|
|
"inspect_managed_members",
|
|
{},
|
|
).then(projectCliAnalysisResult),
|
|
);
|
|
const controller = new AbortController();
|
|
const reason = new Error("cancel during managed close");
|
|
const { dependencies, session } = factories({
|
|
onClose: () => controller.abort(reason),
|
|
});
|
|
const analysis = await runProviderAnalysis(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_members",
|
|
{},
|
|
undefined,
|
|
controller.signal,
|
|
);
|
|
// The CLI delivery receives the cancelled run and publishes nothing.
|
|
const result =
|
|
detail === "summary"
|
|
? await publishCliAnalysisEvidence(analysis, {
|
|
operation: "inspect_managed_members",
|
|
signal: controller.signal,
|
|
detail,
|
|
evidenceOutput: join(dirname(path), "bundle.json"),
|
|
})
|
|
: projectCliAnalysisResult(analysis);
|
|
expect(result).toEqual({
|
|
error: "Analysis failed",
|
|
...projectAnalysisError(
|
|
new AnalysisCancelledError("inspect_managed_members", {
|
|
cause: reason,
|
|
partialObservation: original,
|
|
}),
|
|
),
|
|
});
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
expect((await readdir(dirname(path))).sort()).toEqual(files);
|
|
},
|
|
);
|
|
|
|
it("preserves a managed provider failure when cancellation arrives during close", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const controller = new AbortController();
|
|
const reason = new Error("later cancellation");
|
|
const failure = new AnalysisInputError("inspect_managed_members", undefined, [
|
|
{ path: ["path"], reason: "invalid_format" },
|
|
]);
|
|
const { dependencies, session } = factories({
|
|
executionError: failure,
|
|
onClose: () => controller.abort(reason),
|
|
});
|
|
const result = await runProviderAnalysis(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_members",
|
|
{},
|
|
undefined,
|
|
controller.signal,
|
|
).then(projectCliAnalysisResult);
|
|
expect(result).toEqual({
|
|
error: "Analysis failed",
|
|
...projectAnalysisError(failure),
|
|
});
|
|
expect(
|
|
failure.secondaryFailures.some(
|
|
(secondary) =>
|
|
secondary instanceof AnalysisCancelledError &&
|
|
secondary.cause === reason,
|
|
),
|
|
).toBe(true);
|
|
expect(session.activeTarget()).toBeUndefined();
|
|
});
|
|
|
|
describe("managed one-shot cleanup outcomes", () => {
|
|
it("returns a managed cleanup error retaining the complete successful execution", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies } = factories({ cleanupError });
|
|
const result = await runManagedProviderExecution(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_artifact",
|
|
);
|
|
expect(result.ok).toBe(false);
|
|
if (result.ok) return;
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
remediation: {
|
|
action: "Close the retained fixture process before retrying.",
|
|
},
|
|
details: {
|
|
resources: ["fixture-provider-process"],
|
|
diagnostics: {
|
|
cleanup_error: projectAnalysisError(cleanupError),
|
|
partial_observation: {
|
|
result: {
|
|
operation: "inspect_managed_artifact",
|
|
observation: "retained result",
|
|
},
|
|
rawResult: null,
|
|
provider: { id: "fixture" },
|
|
},
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("retains the typed managed primary error when close also fails", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies } = factories({
|
|
executionError: primaryError,
|
|
cleanupError,
|
|
});
|
|
const result = await runManagedProviderExecution(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_artifact",
|
|
);
|
|
expect(result.ok).toBe(false);
|
|
if (result.ok) return;
|
|
expect(result.error.cause).toBeInstanceOf(AggregateError);
|
|
expect(result.error.cause).toMatchObject({
|
|
cause: primaryError,
|
|
errors: [primaryError, cleanupError],
|
|
});
|
|
const projected = projectAnalysisError(result.error);
|
|
expect(projected).toMatchObject({
|
|
code: "cleanup_incomplete",
|
|
details: {
|
|
captured_output: primaryError.capturedOutput,
|
|
diagnostics: {
|
|
primary_error:
|
|
projectAnalysisErrorWithoutCapturedOutput(primaryError),
|
|
cleanup_error: projectAnalysisError(cleanupError),
|
|
},
|
|
},
|
|
});
|
|
expect(projected).not.toHaveProperty(
|
|
"details.diagnostics.primary_error.details.captured_output",
|
|
);
|
|
expect(
|
|
JSON.stringify(projected).split("retained observation"),
|
|
).toHaveLength(2);
|
|
});
|
|
|
|
it("exposes managed cleanup failure to the CLI error classifier", async () => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const { dependencies } = factories({ cleanupError });
|
|
const result = await runProviderAnalysis(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_artifact",
|
|
{},
|
|
).then(projectCliAnalysisResult);
|
|
expect(isCliOperationFailure(result)).toBe(true);
|
|
expect(result).toMatchObject({
|
|
error: "Analysis failed",
|
|
code: "cleanup_incomplete",
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("managed one-shot cleanup retry ownership", () => {
|
|
it.each(["success", "timeout", "independent primary"] as const)(
|
|
"follows exact cleanup completion after a %s outcome",
|
|
async (mode) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const resource = join(dirname(path), "retained-descriptor");
|
|
const handle = await open(resource, "w+");
|
|
const cleanup = new ProviderCleanupError("fixture", [resource], {
|
|
reason: "controlled first close refusal",
|
|
});
|
|
let attempts = 0;
|
|
const lease = new AnalysisCleanupLease(async () => {
|
|
if (++attempts === 1) throw new Error("first close refused");
|
|
await handle.close();
|
|
}, [resource]);
|
|
lease.bindCleanupError(cleanup);
|
|
const primaryResource = join(dirname(path), "primary-descriptor");
|
|
const primaryHandle =
|
|
mode === "independent primary"
|
|
? await open(primaryResource, "w+")
|
|
: undefined;
|
|
const primary =
|
|
mode === "success"
|
|
? undefined
|
|
: new AnalysisTimeoutError("inspect_managed_members", 100, {
|
|
capturedOutput: {
|
|
stdout: "retained timeout observation",
|
|
stderr: "",
|
|
truncated: false,
|
|
},
|
|
...(primaryHandle === undefined
|
|
? {}
|
|
: {
|
|
cleanup: {
|
|
reason: "independent primary cleanup",
|
|
resources: [primaryResource],
|
|
},
|
|
}),
|
|
});
|
|
const primaryLease =
|
|
primaryHandle === undefined
|
|
? undefined
|
|
: new AnalysisCleanupLease(
|
|
() => primaryHandle.close(),
|
|
[primaryResource],
|
|
);
|
|
if (primary !== undefined) primaryLease?.bindCleanupError(primary);
|
|
const session = createTestBinarySession(() => ({
|
|
execute: async (operation) =>
|
|
operation === "health"
|
|
? observed(null)
|
|
: primary === undefined
|
|
? observed({ retained: true })
|
|
: err(primary),
|
|
close: async () => {
|
|
try {
|
|
await lease.release();
|
|
return ok(null);
|
|
} catch {
|
|
return err(cleanup);
|
|
}
|
|
},
|
|
}));
|
|
try {
|
|
const result = await runManagedProviderExecution(
|
|
{ createManagedBinarySession: () => session },
|
|
path,
|
|
"inspect_managed_members",
|
|
);
|
|
if (result.ok) throw new Error("Expected retained cleanup failure");
|
|
expect(projectAnalysisError(result.error).code).toBe(
|
|
"cleanup_incomplete",
|
|
);
|
|
expect(handle.fd).toBeGreaterThanOrEqual(0);
|
|
expect(await session.close()).toMatchObject({ ok: true });
|
|
expect(handle.fd).toBe(-1);
|
|
expect(cleanup.cleanupIncomplete).toBe(false);
|
|
if (primaryLease !== undefined) {
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(result.error.cleanupResources).toEqual([primaryResource]);
|
|
expect(primaryHandle?.fd).toBeGreaterThanOrEqual(0);
|
|
await primaryLease.release();
|
|
}
|
|
expect(result.error.cleanupIncomplete).toBe(false);
|
|
const projected = projectAnalysisError(result.error);
|
|
if (primary === undefined)
|
|
expect(projected).toMatchObject({
|
|
details: {
|
|
diagnostics: {
|
|
partial_observation: { result: { retained: true } },
|
|
},
|
|
},
|
|
});
|
|
else
|
|
expect(projected).toMatchObject({
|
|
code: "provider_timeout",
|
|
details: {
|
|
captured_output: { stdout: "retained timeout observation" },
|
|
},
|
|
});
|
|
} finally {
|
|
await session.close();
|
|
await lease.release();
|
|
await primaryLease?.release();
|
|
await handle.close();
|
|
await primaryHandle?.close();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.each([false, true])(
|
|
"keeps rejected cleanup without a live completion owner unknown (primary failure: %s)",
|
|
async (primaryFailure) => {
|
|
const [path] = await createBinarySessionTargets();
|
|
const unowned = new AnalysisInputError("close_binary");
|
|
const { dependencies } = factories({
|
|
...(primaryFailure
|
|
? {
|
|
executionError: new AnalysisTimeoutError(
|
|
"inspect_managed_members",
|
|
100,
|
|
),
|
|
}
|
|
: {}),
|
|
cleanupError: unowned,
|
|
});
|
|
const result = await runManagedProviderExecution(
|
|
dependencies,
|
|
path,
|
|
"inspect_managed_members",
|
|
);
|
|
if (result.ok) throw new Error("Expected cleanup rejection");
|
|
expect(unowned.cleanupIncomplete).toBe(false);
|
|
expect(result.error.cleanupIncomplete).toBe(true);
|
|
expect(projectAnalysisError(result.error).code).toBe(
|
|
"cleanup_incomplete",
|
|
);
|
|
},
|
|
);
|
|
});
|