mirror of
https://github.com/morluto/rea.git
synced 2026-11-19 13:12:26 +00:00
* refactor(errors): compose multi-part provider cleanup failures through one owner CdpBrowserProvider, CdpElectronProvider, FridaInstrumentationManager and PlaywrightBrowserScenarioProvider each built the same composite by hand: a ProviderCleanupError listing the parts' resources, an AggregateError cause, and bindCleanupDependencies over the parts. providerCleanupErrorFromFailures in src/domain/analysisErrorCleanup.ts now owns that composition. `causes` keeps non-AnalysisError failures in the aggregate cause without making them own completion, as the CDP providers did; `message` keeps the aggregate messages Frida and Playwright used. Tests: helper unit tests, new close-composition tests for both CDP providers, and a Playwright test with two failed cleanup retries. They pass on the base revision and on this change, and fail when the helper drops the dependency binding, the extra causes or the message. Lowers the cleanup-dependency-binding baseline to 43 files / 73 sites. Refs #11859 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * style(test): format the Playwright cleanup test with oxfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(errors): assert cleanup composition facts instead of reason prose Follows docs/development/testing.md: the close-composition tests now check provider, operation, resources, aggregate causes and completion, not the explanatory reason or aggregate message. A harmless wording change passes; a lost binding, lost cause or wrong operation still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Anant Mandanka <anant.mandanka@renaissancejewel.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
42 lines
1.7 KiB
JSON
42 lines
1.7 KiB
JSON
{
|
|
"src/application/JsonFiles.ts": 1,
|
|
"src/application/SetupCleanupOwner.ts": 2,
|
|
"src/application/binary/AnalysisProviderRegistry.ts": 2,
|
|
"src/application/binary/CompositeProvider.ts": 1,
|
|
"src/application/closeOwnedWebResources.ts": 1,
|
|
"src/application/desktop/DesktopApplicationExport.ts": 2,
|
|
"src/application/frida/FridaInstrumentationService.ts": 2,
|
|
"src/application/releaseExposure/ReleaseExposureService.ts": 1,
|
|
"src/browser/PlaywrightBrowserScenarioProvider.ts": 1,
|
|
"src/browser/WebSourceMapFetcher.ts": 2,
|
|
"src/cli/desktopCaptureCommands.ts": 1,
|
|
"src/cutter/CutterBridgeClient.ts": 1,
|
|
"src/desktop/ScreenJudgeProcess.ts": 1,
|
|
"src/domain/explicitSensitiveFailure.ts": 1,
|
|
"src/evm/EvmoleInterfaceProvider.ts": 3,
|
|
"src/firmware/FirmwareProvider.ts": 1,
|
|
"src/flutter/FlutterBuildProvider.ts": 1,
|
|
"src/gdb/GdbSessionManager.ts": 2,
|
|
"src/hopper/BridgeLauncher.ts": 3,
|
|
"src/hopper/HopperAnalysisProfile.ts": 1,
|
|
"src/hopper/HopperImageCopy.ts": 1,
|
|
"src/ida/IdaSessionClient.ts": 1,
|
|
"src/inspector/V8InspectorProvider.ts": 1,
|
|
"src/javascript/sourceMaps/SourceMapCommand.ts": 4,
|
|
"src/jeb/JebMcpConnectionOwner.ts": 1,
|
|
"src/jeb/JebProvider.ts": 1,
|
|
"src/kuna/KunaProjectCache.ts": 1,
|
|
"src/kuna/KunaSessionClient.ts": 1,
|
|
"src/kuna/KunaTargetCommands.ts": 1,
|
|
"src/native/LldbCallTracer.ts": 3,
|
|
"src/native/NativeCommandAnalysisError.ts": 1,
|
|
"src/native/NativeMacOSProvider.ts": 2,
|
|
"src/pcap/PcapProvider.ts": 5,
|
|
"src/pcap/PcapSnapshot.ts": 1,
|
|
"src/process/ArtifactAnalysisResources.ts": 1,
|
|
"src/process/OwnedDebuggerSessionRegistry.ts": 1,
|
|
"src/process/capture/ProcessCaptureError.ts": 3,
|
|
"src/providers/AnalysisClientFailure.ts": 1,
|
|
"src/sqlite/SqliteDatabaseProvider.ts": 8
|
|
}
|