Files
reverse-engineering-anything/tests/boundary/providers/RizinDebugSessionCoverage.fixtures.ts
T
4aa51bfe19 fix(reverse): reconcile cleanup ownership and mutation diagnostics (#2799)
* feat(process): add owned debugger shutdown lifecycle

* feat(reverse): add local inspection commands

* feat(gdb): add persistent debugger integration

* feat(cutter): add Cutter bridge integration

* test(reverse): enforce complete integration coverage

* fix(process): preserve debugger shutdown ownership

* fix(reverse): retain evidence across interrupted commands

* fix(gdb): honor captured provider environment

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* fix(server): snapshot provider environment at creation

* fix(reverse): close review gaps with complete coverage

* fix(reverse): address inspection review findings

* fix(gdb): bound sessions and retain cleanup ownership

* fix(ci): require reverse-tools quality lane

* fix(process): unref inherited debugger output pipes

* fix(reverse): address remaining PR 1960 findings

* fix(gdb): address remaining PR 1961 findings

* fix(reverse): account for unrestricted provider execution

* fix(process): retain debugger ownership until safe shutdown

* fix(process): preserve replacement debugger sessions

* fix(reverse): preserve admission and output provenance

* fix(process): retain exited debugger until output settles

* fix(mcp): bound provider admission and debugger cleanup

* fix(reverse): preserve failure provenance and classify E2BIG

* fix(gdb): preserve startup cleanup and detach safety

* fix(process): retain debugger ownership after detach failure

* fix(reverse): preserve mutation and failure provenance

* fix(gdb): address debugger review findings

* fix(reverse): rebind sessions after external mutation

* fix(process): cap debugger output after exit

* fix(gdb): protect one-shot detach verification

* feat(debugger): add reverse tool coverage gate

* test(debugger): cover integrated failure paths

* fix(gdb): bound and preserve session observations

* fix(gdb): address review regressions

* style: format merged integration files

* fix(reverse): preserve session and output evidence

* refactor(gdb): share repeated test and partial result setup

* fix(gdb): invalidate TTY proof for Python aliases

* fix(reverse): retain failure output byte counts

* test(process): synchronize late debugger output

* fix(gdb): invalidate TTY proof for wrapped commands

* fix(gdb): recognize wit command abbreviation

* test(reverse): wait for cancelled descendant readiness

* test(reverse): bound descendant cancellation cleanup

* style(reverse): format integration tests and adapters

* style: format reverse engineering integration files

* test(reverse): remove duplicate environment harness

* test(gdb): share session startup assertions

* fix(gdb): invalidate output proof for command abbreviations

* test(reverse): share composition edge case scenarios

* fix(ci): recognize verification and mutation tool entries

* test(rizin): cover successful fake inferior detach

* test(cli): align full output failure envelope

* test(cli): isolate reverse command lifecycle service

* test(process): share debugger output fixture setup

* fix(binary): preserve high-bit Windows signature bytes

* style(binary): format Windows signature parser

* test(mcp): preserve call coverage in unchanged comparison

* fix(ci): include reverse tools Vitest configs in lint cache

* fix(mcp): preserve target content on delivery errors

* ci: align duplication ceiling with expanded suite

* test(reverse): allow signal admission mutants

* fix(reverse): bound retained cleanup failures to process owners

* fix(test): replace drifting mutation ranges with owned selectors

* fix(reverse): admit persistent commands and retain cleanup ownership

* fix(cutter): recover timed-out commands from exact receipts

* fix(cutter): reject unsupported bridge request kinds

* fix(ci): repair client format and shared verification fixtures

* fix(native): preserve debugger cleanup ownership and bridge authentication

* test(native): retain diagnostics without perfect coverage requirements

* chore(licenses): refresh locked dependency inventory and notices

* fix(test): exclude transient command locks from mutation sandboxes

* fix(gdb): admit only platforms with safe detach verification

* fix(cutter): retain bounded completion receipts until acknowledgement

* fix(cutter): acknowledge commands rejected before UI dispatch

* test(reverse): fail cancellation checks before fixture teardown

* test(gdb): clean up the retained broken-stdin fixture owner

* docs(test): clarify focused provider verification scope

* fix(rizin): retain close cleanup failures

* fix(gdb): wait for inferior stop and bound MI buffering

* fix(cutter): retain failed receipt acknowledgements

* fix(rizin): return retained session identity on rebind failure

* fix(gdb): preserve startup cancellation and lossy status

* fix(rizin): retain launch provenance and assemble frames once

* fix(cutter): recover receipts across callers and bound discovery

* docs: describe debugger evidence and bridge recovery

* fix(process): keep cleanup incomplete while writers remain

Stopping a debugger no longer reports success when inherited output
streams stay open, so BinarySession cannot reopen a binary a child is
still changing. Concurrent Cutter cleanup retries share one receipt
acknowledgement instead of treating a consumed receipt as failure.

* fix(debuggers): recover cleanup with captured process identities

* fix(analysis): retire sessions after unrestricted commands

* fix(cli): preserve completed evidence after cleanup recovery

* fix(cutter): bound frame collection and coalesce cleanup

* fix(windows): resolve selected provider paths absolutely

* fix(gdb): report decoding loss in failed startup evidence

* fix(rizin): scope decoding loss to collected command frames

* test(mcp): cover snapshot retirement in reverse tools CI

---------

Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com>
Co-authored-by: REA Maintainers <noreply@github.com>
Co-authored-by: OpenAI Codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 04:47:34 +08:00

246 lines
7.7 KiB
TypeScript

import { chmod, mkdtemp, rm, writeFile } from "node:fs/promises";
import { EventEmitter } from "node:events";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { PassThrough, Writable } from "node:stream";
import { RizinDebugSessionManager } from "../../../src/rizin/RizinDebugSessionManager.js";
import {
createRizinTestManager,
rizinTestInferiorTty,
} from "./RizinTestInferiorTty.js";
import { stopOwnedDebuggerProcess } from "../../../src/process/ownedDebuggerSession.js";
import type {
ProviderProcessHandle,
SpawnedOwnedProviderProcess,
} from "../../../src/process/ProviderProcess.js";
interface InjectedProcessControl {
output(chunk: Buffer | string): void;
stdinError(): void;
closeStdin(): void;
exitLeader(signal?: NodeJS.Signals): void;
closeOutput(): void;
exit(signal?: NodeJS.Signals): void;
}
type InjectedSpawnProcess = NonNullable<
NonNullable<
ConstructorParameters<typeof RizinDebugSessionManager>[1]
>["spawnProcess"]
>;
export const incompleteStop: typeof stopOwnedDebuggerProcess = async (
session,
name,
) => {
await stopOwnedDebuggerProcess(session, name);
return { status: "incomplete", reason: "injected stop uncertainty" };
};
export const abortOnCheck = (targetCheck: number): AbortSignal => {
let checks = 0;
let aborted = false;
type Listener = Parameters<AbortSignal["addEventListener"]>[1];
const listeners = new Set<Listener>();
return {
get aborted() {
checks += 1;
if (checks >= targetCheck) aborted = true;
return aborted;
},
addEventListener: (
_type: Parameters<AbortSignal["addEventListener"]>[0],
listener: Listener,
) => {
if (listener !== null) listeners.add(listener);
},
removeEventListener: (
_type: Parameters<AbortSignal["removeEventListener"]>[0],
listener: Parameters<AbortSignal["removeEventListener"]>[1],
) => {
if (listener !== null) listeners.delete(listener);
},
dispatchEvent: () => true,
onabort: null,
reason: undefined,
throwIfAborted: () => undefined,
} as AbortSignal;
};
export const createInjectedProcess = (
options: {
readonly stdin?:
| "normal"
| "null"
| "destroyed"
| "throws"
| "throws-opaque"
| "write-error";
readonly onWrite?: (text: string, control: InjectedProcessControl) => void;
readonly startup?: (control: InjectedProcessControl) => void;
readonly beforeSpawnReturns?: () => void;
readonly spawnError?: unknown;
} = {},
): {
readonly spawnProcess: InjectedSpawnProcess;
readonly control: InjectedProcessControl;
} => {
const stdout = new PassThrough();
const stderr = new PassThrough();
let exitCode: number | null = null;
let signalCode: NodeJS.Signals | null = null;
const processHandle = new EventEmitter() as EventEmitter & {
pid: number;
stdout: PassThrough;
stdin: Writable | null;
stderr: PassThrough;
exitCode: number | null;
signalCode: NodeJS.Signals | null;
kill(signal?: NodeJS.Signals | number): boolean;
};
processHandle.pid = process.pid;
processHandle.stdout = stdout;
processHandle.stderr = stderr;
processHandle.exitCode = exitCode;
processHandle.signalCode = signalCode;
const control: InjectedProcessControl = {
output: (chunk) => stdout.emit("data", Buffer.from(chunk)),
stdinError: () => stdin?.emit("error", new Error("injected stdin error")),
closeStdin: () => stdin?.destroy(),
exitLeader: (signal = "SIGTERM") => {
exitCode = null;
signalCode = signal;
processHandle.exitCode = exitCode;
processHandle.signalCode = signalCode;
processHandle.emit("exit", exitCode, signalCode);
},
closeOutput: () => {
stdout.destroy();
stderr.destroy();
processHandle.emit("close", exitCode, signalCode);
},
exit: (signal = "SIGTERM") => {
control.exitLeader(signal);
control.closeOutput();
},
};
const stdin =
options.stdin === "null"
? null
: new Writable({
write(chunk, _encoding, callback) {
options.onWrite?.(Buffer.from(chunk).toString("utf8"), control);
callback(
options.stdin === "write-error"
? new Error("injected write callback failure")
: undefined,
);
},
});
if (stdin !== null) {
if (options.stdin === "destroyed")
Object.defineProperty(stdin, "destroyed", { value: true });
if (options.stdin === "throws" || options.stdin === "throws-opaque")
stdin.write = (() => {
if (options.stdin === "throws-opaque")
throw "injected opaque write failure";
throw new Error("injected synchronous write failure");
}) as typeof stdin.write;
processHandle.stdin = stdin;
} else processHandle.stdin = null;
processHandle.kill = (signal = "SIGTERM") => {
if (exitCode !== null || signalCode !== null) return false;
control.exit(typeof signal === "string" ? signal : "SIGTERM");
return true;
};
const spawnProcess: InjectedSpawnProcess = async (spawnOptions) => {
options.beforeSpawnReturns?.();
if (options.spawnError !== undefined) throw options.spawnError;
setImmediate(() => {
if (options.startup !== undefined) options.startup(control);
else control.output(Buffer.from([0]));
});
return {
process: processHandle as unknown as ProviderProcessHandle,
ownership: {
runId: spawnOptions.runId,
leaderPid: process.pid,
processGroupId: process.pid,
expectedParentPid: process.pid,
},
} satisfies SpawnedOwnedProviderProcess;
};
return { spawnProcess, control };
};
export const createRizinCoverageHarness = () => {
let directory: string | undefined;
const managers: RizinDebugSessionManager[] = [];
const track = (manager: RizinDebugSessionManager): void => {
managers.push(manager);
};
const makeProvider = async (
body: string,
shebang = "#!/usr/bin/env node",
): Promise<string> => {
directory = await mkdtemp(join(tmpdir(), "rea-rizin-coverage-"));
const provider = join(directory, "fake-rizin.mjs");
await writeFile(provider, `${shebang}\n${body}\n`);
await chmod(provider, 0o700);
return provider;
};
const start = async (
provider: string,
options: ConstructorParameters<typeof RizinDebugSessionManager>[1] = {},
): Promise<{ manager: RizinDebugSessionManager; sessionId: string }> => {
const manager = createRizinTestManager(
{ REA_RIZIN_COMMAND: provider },
options,
);
track(manager);
const result = await manager.start({
path: "/tmp/coverage-target",
inferior_tty: await rizinTestInferiorTty(),
});
if (!result.ok) throw result.error;
return { manager, sessionId: result.value.session_id };
};
const startInjected = async (
spawnProcess: InjectedSpawnProcess,
options: ConstructorParameters<typeof RizinDebugSessionManager>[1] = {},
) => {
const manager = createRizinTestManager(
{ REA_RIZIN_COMMAND: "injected-rizin" },
{ ...options, spawnProcess },
);
track(manager);
const started = await manager.start({
path: "/tmp/injected",
inferior_tty: await rizinTestInferiorTty(),
});
return { manager, started };
};
const cleanup = async (): Promise<void> => {
await Promise.all(
managers
.splice(0)
.map((manager) => manager.closeAll().catch(() => undefined)),
);
if (directory !== undefined)
await rm(directory, { recursive: true, force: true });
directory = undefined;
};
const missingProviderPath = (): string => join(directory!, "does-not-exist");
return {
cleanup,
makeProvider,
missingProviderPath,
start,
startInjected,
track,
};
};