Files
reverse-engineering-anything/src/cli/captureCommands.ts
T
morlutoandCursor Agent 5c2917266d fix(inputs): validate command admission and preserve valid MCP requests (#9901)
* fix(cli): validate named inputs before target admission

* fix(mcp): preserve valid inputs when advertised schema references widen

* test(inputs): reach session behavior with admitted inputs

One-shot admission now rejects incomplete requests before a session exists. Lifecycle tests supply the required fields, and unknown arguments are rejected before provider issues are retained.

* fix(cli): preserve Electron fuse path spelling

Anchor relative fuse paths without stripping dot segments, and let an empty path reach the operation so it still reports invalid_request.

* fix(cli): reject outline-depth unless detail is summary

The advertised schema already required detail summary whenever outline-depth
was present. The parser still applied the full default and accepted that
combination, so its output failed the same schema. Parsing now rejects it
before the command runs.

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-11-11 00:43:30 -05:00

161 lines
5.6 KiB
TypeScript

import { projectCliAnalysisResult } from "./projectCliAnalysisResult.js";
import { inspectPacketFieldsInputSchema } from "../domain/captures/packetFields.js";
import { z } from "incur";
import type { PacketCaptureService } from "../application/captures/PacketCaptureService.js";
import { createPacketCaptureService } from "../composition/captures.js";
import {
packetCaptureOptionsSchema,
packetCaptureSelectorBudgetIssue,
withinPacketCaptureSelectorBudget,
} from "../domain/captures/packetCapture.js";
import { CLI_COMMANDS } from "../cliCommandNames.js";
import { logCliCommand } from "../cliLogging.js";
import type { Logger } from "pino";
import type { CliInstance } from "./types.js";
import { withCommandCancellation } from "./commandCancellation.js";
import { finishAnalysisCommand } from "./finishAnalysisCommand.js";
import { finishCliEvidenceCommand } from "./cliEvidenceCallerPath.js";
import { cliDecimalField, cliDecimalShape } from "./options.js";
import { localPathStringSchema } from "../domain/localPath.js";
import { absoluteCallerPath } from "../filesystem/callerPath.js";
import { producerLimitsOption } from "./producerLimitsOption.js";
export const registerCaptureCommands = (
cli: CliInstance,
logger: Logger,
environment: Readonly<NodeJS.ProcessEnv>,
service: Pick<
PacketCaptureService,
"inspect" | "inspectFields" | "close"
> = createPacketCaptureService(environment),
): void => {
const { producer_limits: discoveryLimits, ...discoveryShape } =
inspectPacketFieldsInputSchema.shape;
const { producer_limits: selectedLimits, ...selectedShape } =
packetCaptureOptionsSchema.shape;
cli.command(CLI_COMMANDS.inspectPacketFields, {
description: "Search installed TShark protocol and field definitions",
options: z
.object({
...cliDecimalShape(discoveryShape),
producerLimits: producerLimitsOption(discoveryLimits.unwrap()),
limit: cliDecimalField(
z
.number()
.int()
.positive()
.max(Number.MAX_SAFE_INTEGER)
.optional()
.describe("Maximum matching records to return; defaults to 50"),
),
all: z
.boolean()
.default(false)
.describe("Return all remaining matches within resource limits"),
})
.superRefine((options, context) => {
if (options.all && options.limit !== undefined)
context.addIssue({
code: "custom",
path: ["all"],
message: "all and limit are mutually exclusive",
});
})
.meta({
not: {
required: ["all", "limit"],
properties: { all: { const: true } },
},
}),
run: ({ options: { all, producerLimits, ...options } }) =>
withCommandCancellation((signal) =>
logCliCommand(logger, CLI_COMMANDS.inspectPacketFields, async () =>
finishAnalysisCommand(
() =>
service.inspectFields(
{
...options,
...(producerLimits === undefined
? {}
: { producer_limits: producerLimits }),
...(all ? { limit: null } : {}),
},
{ signal },
),
service,
"tshark-capture",
"inspect_packet_fields",
signal,
).then(projectCliAnalysisResult),
),
),
});
cli.command(CLI_COMMANDS.inspectPacketCapture, {
description:
"Inspect an existing packet capture with caller-supplied TShark",
args: z.object({
path: localPathStringSchema.describe("Local packet capture"),
}),
options: z
.object({
...cliDecimalShape(selectedShape),
producerLimits: producerLimitsOption(selectedLimits.unwrap()),
match_limit: cliDecimalField(
z
.number()
.int()
.positive()
.optional()
.describe("Returned matching frames per page; default 50"),
),
all_matches: z
.boolean()
.default(false)
.describe(
"Return all remaining matching frames instead of a bounded page",
),
})
.superRefine((options, context) => {
if (options.all_matches && options.match_limit !== undefined)
context.addIssue({
code: "custom",
path: ["all_matches"],
message: "all_matches and match_limit are mutually exclusive",
});
})
.refine(
withinPacketCaptureSelectorBudget,
packetCaptureSelectorBudgetIssue,
)
.meta({
not: {
required: ["all_matches", "match_limit"],
properties: { all_matches: { const: true } },
},
}),
run: ({ args, options: { all_matches, producerLimits, ...options } }) =>
withCommandCancellation((signal) =>
logCliCommand(logger, CLI_COMMANDS.inspectPacketCapture, async () => {
return finishCliEvidenceCommand(
args.path,
() =>
service.inspect(
{
...options,
...(producerLimits === undefined
? {}
: { producer_limits: producerLimits }),
...(all_matches ? { match_limit: null } : {}),
path: absoluteCallerPath(args.path),
},
{ signal },
),
service,
"tshark-capture",
"inspect_packet_capture",
signal,
).then(projectCliAnalysisResult);
}),
),
});
};