mirror of
https://github.com/morluto/rea.git
synced 2026-11-16 11:43:20 +00:00
* test(architecture): fail on a stale layer baseline and document the declared layers verify:module-boundaries reported a layer baseline entry whose imports were gone but still passed, so main kept process -> artifacts at 20 after it fell to 17 and a later change could add three imports back unnoticed. A stale entry now fails like growth; --shrink-layer-baseline lowers it in the change that removes the imports. The architecture map and CONTRIBUTING name scripts/lib/module-layers.mjs as the per-directory layer declaration. * test(architecture): refuse to lower the layer baseline after an inspection failure A file that cannot be parsed contributes no imports, so a shrink run would record counts that fail as growth once the file is fixed. Whole-command tests cover stale rejection, shrinking, refused growth and the inspection failure. * refactor(ports): move the progress, work-scope and inspection-scope ports to src/ports (#11214) * refactor(ports): move the progress, work-scope and inspection-scope ports to src/ports Pure move with git mv and import specifier updates. * test(architecture): declare the ports layer and lower the layer baseline src/ports sits between the foundation and the providers. Moving the three ports removes 11 provider -> application imports. * refactor(ports): move AnalysisProvider to src/ports (#11217) * refactor(ports): move AnalysisProvider to src/ports Pure move with git mv and import specifier updates in its importers, the built-fixture path, the CI scope glob and the lint-rule test spellings. * test(architecture): lower the layer baseline after moving AnalysisProvider * refactor(ports): move the per-feature provider ports to src/ports (#11226) * refactor(ports): move the per-feature provider ports to src/ports Pure move with git mv and import specifier updates: the 47 *Port.ts and *Ports.ts files that providers implement, plus OptionalObservationProviders, which only composes the observation ports. * test(architecture): lower the layer baseline after moving the feature ports * refactor(providers): move closeAnalysisClient and the Frida session input errors to their owners (#11233) * refactor(providers): move closeAnalysisClient to src/providers and the Frida session input errors to src/frida Pure move with git mv and import specifier updates. * test(architecture): drop the application-providers and application-frida cycles from the layer baseline * fix(ci): keep provider lanes selecting the ports moved to src/ports Each lane glob that matched a moved port under src/application gains its src/ports counterpart; the change-scope test pins one moved port per lane. * refactor(domain): declare the localPath host exception and read HOST_PLATFORM there (#11256) absoluteLocalPathStringSchema decides which paths are absolute on the running host, so it reads HOST_PLATFORM instead of process.platform. Domain may not import outside domain/contracts; module-layers now declares LAYER_EXCEPTIONS, exact file-to-file imports with a reason, and both the layer count and the pure-layer boundary skip only that import. Any other domain -> platform import still fails. * refactor(ports): move the doctor check and provider inspection types to src/ports (#11246) * refactor(ports): move the doctor check and provider inspection types to src/ports Declaration move from application/Doctor.ts (unchanged text) and import updates; no re-export from Doctor.ts. * test(architecture): lower the layer baseline after moving the doctor provider types * refactor(ports): move the packet capture and signal recording ports to src/ports (#11249) * refactor(ports): move the packet capture and signal recording ports to src/ports Declaration move (unchanged text) out of the two application services, with import updates. * test(architecture): lower the layer baseline after moving the capture and signal ports * refactor(domain): move the analysis error projection schema from contracts to domain (#11251) * refactor(domain): move the analysis error projection schema from contracts to domain Declaration move (unchanged text) of the projection schemas that domain modules embed; contracts/errorSchemas.ts keeps the CLI envelope and the published JSON Schema. Import updates only. * test(architecture): drop the contracts-domain cycle from the layer baseline * refactor(ports): drop the imports the moved capture, signal and doctor types left behind Also give the packet capture and signal recording lanes the new port paths, with change-scope cases. * refactor(resources): add src/resources and move AnalysisCleanupLease and ArtifactReader there (#11259) * refactor(resources): move AnalysisCleanupLease to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist paths the verifier scripts load). * refactor(resources): declare src/resources as a foundation unit src/resources owns the shared analysis resource modules that process, windows and providers hold; AnalysisCleanupLease is the first. Its tests join the adapters project, the apk signature lane selects it beside src/artifacts, and the layer baseline drops the process and windows imports of the lease. * test(ci): pin the apk signature lane on the moved cleanup lease * refactor(resources): move ArtifactReader to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist path a verifier script loads). * test(architecture): lower the layer baseline after moving ArtifactReader windows no longer imports src/artifacts; process -> artifacts 11 -> 9. The CI lanes that selected src/artifacts/ArtifactReader.ts select its new path, pinned in the change-scope test. * refactor(resources): move ArtifactResourceScope to src/resources (#11265) * refactor(artifacts): name the output tree and private root capabilities the resource scope releases ArtifactResourceScope typed its output-tree and private-runtime-root owners with SafeOutputTree (src/artifacts) and PrivateRuntimeRoot (src/process). It only calls rollback() and close(), so it now declares those capabilities itself and names neither unit, which lets it move to src/resources without a resources <-> process cycle. The withheld-export test narrows to SafeOutputTree where it reads the published flag. * refactor(resources): move ArtifactResourceScope to src/resources Pure move: git mv plus import specifier rewrites (source, tests, the dist paths verifier scripts load, and the FIFO probe's module-relative URL). * test(architecture): lower the layer baseline after moving ArtifactResourceScope process -> artifacts 9 -> 5, and the artifacts <-> dotnet mutual pair is gone. The sqlite and agentenv lanes select the scope at its new path, pinned in the change-scope test. * refactor(resources): move ArtifactFileOperation to src/resources (#11269) * refactor(resources): move ArtifactFileOperation to src/resources Pure move: git mv plus import specifier rewrites (source, tests, and the dist paths verifier scripts load). * test(architecture): lower the layer baseline after moving ArtifactFileOperation process -> artifacts 5 -> 1. * refactor(resources): move readStableArtifact to src/resources (#11271) * refactor(resources): move readStableArtifact to src/resources Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving readStableArtifact process no longer imports src/artifacts: process -> artifacts 1 -> 0 and the artifacts <-> process mutual pair is gone. The seven lanes that selected readStableArtifact select its new path, pinned in the change-scope test; the architecture map lists what src/resources owns. * refactor(hopper): take Linux launcher verification from composition through a port (#11278) The Hopper launcher imported inspectLinuxHopperLauncher and retryLinuxHopperPublisherCleanup from src/application (the two hopper -> application imports). src/ports/LinuxHopperLauncherVerification.ts now names that capability; src/application/LinuxHopper.ts provides LINUX_HOPPER_LAUNCHER_VERIFICATION, binary composition passes it to HopperProvider, and the provider hands it to the launcher. A launcher built without one refuses a Linux demo launch with reason verification_unavailable before running the launcher. Layer baseline: hopper -> application 2 -> 0. * refactor(config): move Hopper launcher discovery to a src/hopperPaths foundation unit (#11292) * refactor(hopper): move the launcher discovery and macOS Hopper paths to src/hopperPaths Pure move: git mv plus import specifier rewrites. * refactor(hopper): declare src/hopperPaths as a foundation unit with the Linux launcher candidates Hopper install paths and launcher discovery are pure path facts that the Hopper provider, doctor and setup all read. Declare src/hopperPaths in the foundation layer, add it to the adapters test project, the architecture map and the package-baseline CI lane, and move the Linux launcher candidates out of src/application/LinuxHopper.ts into src/hopperPaths/LinuxHopperPaths.ts so discovery no longer imports application code. * refactor(config): leave Hopper launcher discovery to the Hopper provider parseConfig resolved an unset HOPPER_LAUNCHER_PATH by probing the filesystem through application-owned discovery, so config imported application (config -> application 2, application <-> config cycle) and read process.platform ambiently. AppConfig.hopperLauncherPath is now the caller's HOPPER_LAUNCHER_PATH unchanged (string | undefined). src/hopperPaths/HopperLauncherDiscovery.ts owns the selection (selectedHopperLauncherPath: the configured spelling, else discovery from the caller environment's home on the provider's platform); HopperProvider and the two real-Hopper verifiers read it. Discovery tests move from config.test.ts to src/hopperPaths; a provider test covers discovery from the provider's own platform and home. Module layers: config -> application 2 -> 0; application <-> config removed. Architecture guards: ambient platform reads in parseConfig.ts 2 -> 0. * refactor(providers): move owned-process prerequisite availability out of application (#11294) * refactor(providers): move the owned-process prerequisite availability mapping to src/providers Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving owned-process availability android -> application 1 -> 0; apktool -> application 1 -> 0. * refactor(process): move the regular-file read owner out of application (#11299) * refactor(process): move the regular-file read owner from src/application to src/process Pure move: git mv plus import specifier rewrites. * test(architecture): lower the layer baseline after moving the regular-file read owner desktop -> application 5 -> 4; dotnet -> application 2 -> 1. The agentenv lane listed src/application/RegularFileRead.ts. At its new path it is a src/process/ shared boundary: fast qualification selects the code and runtime checks (and the single owning lane, web_source_map, via src/process/**), and full qualification selects every lane, as for every other src/process/ module. A second owner entry would only suppress the web_source_map selection, so the agentenv entry is removed, not renamed. * refactor(resources): give atomic text writes their own owner (#11302) * refactor(resources): give atomic text writes their own owner in src/resources src/application/JsonFiles.ts owned both JSON input reads and the atomic text write (writeTextFile / writeTextParts and their staged-output publication). The write side depends only on domain, filesystem and resource owners, but il2cpp's Ghidra seed writer had to import application to reach it (il2cpp -> application). Move the write side verbatim to src/resources/TextFileWrite.ts (TextWriteCancellation, writeTextFile, writeTextParts and their private staging, publication and failure classification helpers). JsonFiles keeps the JSON read owner and reads the shared errno-to-reason classifier (fileAccessFailureReason) from the write owner instead of a copy. Importers (il2cpp seed writer, evidence bundle files, desktop build solves, analysis snapshot files and four boundary tests) read the new path; no re-export is left in JsonFiles. * test(architecture): lower the layer baseline after moving the text write owner il2cpp -> application 1 -> 0. * refactor(ports): move the desktop build host contract to src/ports (#11303) * refactor(domain): move the setup cancellation check from src/application to src/domain Pure move: git mv plus import specifier rewrites. * refactor(ports): move the desktop build host contract to src/ports The desktop provider implements doctor's desktop build facts reader and setup's desktop build host, but the contract it implements lived in application (DesktopBuildDoctor, SetupDesktopBuild, Doctor's clientRegistrations signature, ClientRegistrationEnvironment's setting types), so desktop imported application four times and the two units were a recorded mutual pair. src/ports/DesktopBuildHost.ts now holds that contract, moved verbatim: DesktopBuildCommand, DesktopBuildFacts, DesktopBuildFactsInput, DesktopBuildSetupFacts, DesktopBuildSetupHost, RecordedProviderSettings and OwnedProviderSetting. Two names are new: DesktopBuildRegistration, the registration facts the host reads (client, command and the recorded-settings names; client registration status satisfies it), and DesktopBuildRegistrationReader, which replaces DoctorHost["clientRegistrations"] in the setup host. The facts input's registration reader returns DesktopBuildRegistration instead of the full application status; the setup facts' settings are spelled Readonly<Record<string, string>> (SetupProviderEnvironment's definition). Application imports the types from the port; no re-export is left. * test(architecture): lower the layer baseline after the desktop build host port desktop -> application 4 -> 0; the application <-> desktop mutual pair is gone. * refactor(domain): define the resolved app bundle resource root beside its schema (#11304) * refactor(domain): define the resolved app bundle resource root beside its provenance schema ResolvedAppBundleResourceRoot (an app directory's resource-only identity) is a pure type over BundleResourceRoot's layout, but it lived in src/application/AppBundleExecutable.ts, so the native and artifact providers that receive it imported application. Move the interface verbatim to src/domain/apple/bundleResourceRoot.ts, which owns BundleResourceRoot, and point its eight readers there (native macOS provider and plist source, artifact provider, binary composition, and the binary session, status, port and bundle-resource session). The resolver that produces it stays in application. * test(architecture): lower the layer baseline after moving the resource root type native -> application 2 -> 0; artifacts -> application 2 -> 1 (the artifact provider still constructs BundleResourceSession). * refactor(config): move the pwntools input bound parser to src/config (#11306) * refactor(config): move the pwntools input bound parser from src/native to src/config Pure move: git mv plus import specifier rewrites, and the module path in docs/design/rea-limit-inventory.md (table realigned by oxfmt). * test(architecture): lower the layer baseline after moving the pwntools input bound config -> native 1 -> 0. The binary_layout and recorded_crash lanes, which select src/native/pwntools/**, also select src/config/pwntoolsInputLimit*.ts; ciChangeScope.test.ts pins both. * refactor(filesystem): move REA cache directory helpers out of config (#11309) * refactor(filesystem): move the REA cache directory and lexical directory helpers from src/config to src/filesystem Pure move: git mv plus import specifier rewrites. * test(architecture): drop the config and filesystem cycle from the layer baseline config no longer imports filesystem; filesystem still reads the Windows ChangeTime settle budget from config. * refactor(windows): break the process and windows import cycle (#11317) * refactor(domain): move the runtime-control and private-runtime-root refusals from src/process to src/domain Pure move: git mv plus import specifier rewrites (including the dist path scripts/verify-windows-native.mjs loads). * refactor(windows): type Job Object cleanup by what a Windows job reports WindowsOwnedProcess.cleanup() returned process-ownership's ProcessCleanupResult, so src/windows imported src/process for a type while process imports windows to supervise Windows trees. A Job Object stop only ever reports settled-and-signalled or a reason it did not settle; name that subset WindowsJobCleanupResult in windows. It stays assignable to ProcessCleanupResult, so the process supervisor reads it unchanged. * test(architecture): drop the process and windows cycle from the layer baseline * test(architecture): ratchet cross-provider imports and imports past a provider entry (#11386) * test(architecture): ratchet cross-provider imports and imports past a provider entry A provider folder may import the domain, contracts, foundation and ports layers, the shared provider core (src/providers) and its own files; an import of another provider folder is a recorded exception. Application, composition and the CLI/MCP adapters reach a provider only through src/<provider>/index.ts. verify:module-boundaries counts both kinds of import per unit pair in the layer baseline (crossProvider, providerEntry); like the upward counts they may only shrink, and a pair missing from the baseline fails. * refactor(resources): move StableArtifactFailure and StableArtifactObservation into src/resources (#11387) * refactor(resources): move StableArtifactFailure and StableArtifactObservation into src/resources Providers project stable-read failures through StableArtifactFailure next to the other shared provider toolkit owners (ArtifactReader, ArtifactResourceScope, ArtifactFileOperation, AnalysisCleanupLease, readStableArtifact) that already live in src/resources. Under src/artifacts it made every provider that reads a stable artifact import the artifacts provider. Pure move: git mv plus import specifier and baseline updates; the layer baseline drops the provider-boundary counts the move removes. * refactor(resources): reach the shared provider toolkit through src/resources/index.ts (#11390) * refactor(resources): import the shared provider toolkit through src/resources/index.ts Adds src/resources/index.ts, which exports the toolkit names that production code outside src/resources uses, and rewrites those importers (420 files) to import from it, merging each importer's toolkit imports into one declaration. Mechanical: import declarations only. * test(architecture): reach src/resources only through its entry file verify:module-boundaries now counts any production import of a src/resources file other than src/resources/index.ts, from any unit, with the imports past a provider entry. The count is renamed from providerEntry to entry ("import past the entry file"); it may only shrink, and src/resources starts at zero. * test(architecture): cover provider boundary counts through the verifier command * refactor(resources): move the safe output tree and artifact path owners into src/resources (#11398) * refactor(resources): move the safe output tree and artifact path owners into src/resources SafeOutputTree (with its admission, creation failure, readback, cleanup and identity files), StreamBytes, ArtifactPaths and readArtifactFileChunks depend only on domain, filesystem, platform and the toolkit, and browser, firmware, ghidra, javascript, android and apktool use them to publish outputs. Under src/artifacts every such provider imported the artifacts provider. Pure move: git mv, importers moved onto src/resources/index.ts (names added to the entry), the moved files import toolkit modules directly, path keys in the CI scopes and guard baseline follow the move, and the layer baseline drops the removed imports. * test(architecture): give the shared provider core its own layer below the providers (#11401) src/providers (deferred client owners and failure attribution) now imports only domain, ports, process, filesystem and the resources toolkit. Declaring it as the providerCore layer, between ports and providers, makes any import from it into a provider folder an upward import that verify:module-boundaries rejects, and lets every unit in the providers layer be a provider folder. * test(architecture): declare each provider's entry files instead of a provider barrel (#11407) * chore: ignore the source map parser move (#11348) in blame * test(architecture): declare inspector's use of the browser CDP client as a provider dependency (#11420)
1597 lines
55 KiB
TypeScript
1597 lines
55 KiB
TypeScript
import { open, readFile, type FileHandle } from "node:fs/promises";
|
|
import { createHash } from "node:crypto";
|
|
import { join } from "node:path";
|
|
|
|
import { afterEach, expect, it, onTestFinished, vi } from "vitest";
|
|
|
|
const state = vi.hoisted(() => ({
|
|
readbackFailed: false,
|
|
failReadback: true,
|
|
rejectPublicationClose: false,
|
|
publicationCloseFailure: undefined as unknown,
|
|
publicationHandles: [] as FileHandle[],
|
|
beforePublicationOpen: undefined as
|
|
| ((path: string) => Promise<void>)
|
|
| undefined,
|
|
rejectPublicationMode: false,
|
|
rejectStageRemoval: false,
|
|
beforeFirstPublication: undefined as (() => Promise<void>) | undefined,
|
|
afterPublication: undefined as ((path: string) => Promise<void>) | undefined,
|
|
rejectRestore: false,
|
|
removeCopiedRecovery: false,
|
|
afterBackupCopy: undefined as
|
|
| ((source: string, destination: string) => Promise<void>)
|
|
| undefined,
|
|
initialCleanupFailure: undefined as unknown,
|
|
readbackCleanupFailure: undefined as unknown,
|
|
}));
|
|
|
|
afterEach(() => {
|
|
state.readbackFailed = false;
|
|
state.failReadback = true;
|
|
state.rejectPublicationClose = false;
|
|
state.publicationCloseFailure = undefined;
|
|
state.publicationHandles = [];
|
|
state.beforePublicationOpen = undefined;
|
|
state.rejectPublicationMode = false;
|
|
state.rejectStageRemoval = false;
|
|
state.afterPublication = undefined;
|
|
state.beforeFirstPublication = undefined;
|
|
state.rejectRestore = false;
|
|
state.removeCopiedRecovery = false;
|
|
state.afterBackupCopy = undefined;
|
|
state.initialCleanupFailure = undefined;
|
|
state.readbackCleanupFailure = undefined;
|
|
});
|
|
|
|
vi.mock("node:fs/promises", async (importOriginal) => {
|
|
const original = await importOriginal<typeof import("node:fs/promises")>();
|
|
return {
|
|
...original,
|
|
open: async (...arguments_: Parameters<typeof original.open>) => {
|
|
const writable =
|
|
typeof arguments_[1] === "number" && (arguments_[1] & 3) === 2;
|
|
if (writable && typeof arguments_[0] === "string")
|
|
await state.beforePublicationOpen?.(arguments_[0]);
|
|
const handle = await original.open(...arguments_);
|
|
if (typeof arguments_[1] === "number" && (arguments_[1] & 3) === 2) {
|
|
state.publicationHandles.push(handle);
|
|
const write = handle.write.bind(handle);
|
|
handle.write = ((...values: Parameters<typeof handle.write>) => {
|
|
if (state.rejectRestore && state.readbackFailed)
|
|
return Promise.reject(new Error("injected restore write failure"));
|
|
return write(...values);
|
|
}) as typeof handle.write;
|
|
const chmod = handle.chmod.bind(handle);
|
|
handle.chmod = async (mode) => {
|
|
if (state.rejectPublicationMode && mode === 0o400)
|
|
throw new Error("staging mode preparation denied");
|
|
await chmod(mode);
|
|
};
|
|
const close = handle.close.bind(handle);
|
|
handle.close = async () => {
|
|
if (state.rejectPublicationClose)
|
|
throw (
|
|
state.publicationCloseFailure ??
|
|
new Error("injected publication close failure")
|
|
);
|
|
await close();
|
|
};
|
|
}
|
|
return handle;
|
|
},
|
|
rmdir: async (...values: Parameters<typeof original.rmdir>) => {
|
|
if (
|
|
state.rejectStageRemoval &&
|
|
String(values[0]).includes(".rea-config-")
|
|
)
|
|
throw new Error("injected staging directory removal failure");
|
|
return original.rmdir(...values);
|
|
},
|
|
rename: async (...values: Parameters<typeof original.rename>) => {
|
|
const result = await original.rename(...values);
|
|
state.readbackFailed = true;
|
|
await state.afterPublication?.(String(values[1]));
|
|
return result;
|
|
},
|
|
link: async (...values: Parameters<typeof original.link>) => {
|
|
await state.beforeFirstPublication?.();
|
|
const result = await original.link(...values);
|
|
state.readbackFailed = true;
|
|
await state.afterPublication?.(String(values[1]));
|
|
return result;
|
|
},
|
|
copyFile: async (
|
|
...arguments_: Parameters<typeof original.copyFile>
|
|
): Promise<void> => {
|
|
await original.copyFile(...arguments_);
|
|
const source = arguments_[0];
|
|
const destination = arguments_[1];
|
|
if (typeof source === "string" && typeof destination === "string")
|
|
await state.afterBackupCopy?.(source, destination);
|
|
if (
|
|
state.removeCopiedRecovery &&
|
|
typeof destination === "string" &&
|
|
destination.endsWith(".recovery")
|
|
)
|
|
await original.rm(destination);
|
|
},
|
|
};
|
|
});
|
|
|
|
vi.mock("../../src/process/RegularFileRead.js", async (importOriginal) => {
|
|
const original =
|
|
await importOriginal<
|
|
typeof import("../../src/process/RegularFileRead.js")
|
|
>();
|
|
return {
|
|
...original,
|
|
readRegularFileText: (
|
|
...arguments_: Parameters<typeof original.readRegularFileText>
|
|
) =>
|
|
state.initialCleanupFailure !== undefined
|
|
? Promise.reject(state.initialCleanupFailure)
|
|
: state.readbackFailed && state.readbackCleanupFailure !== undefined
|
|
? Promise.reject(state.readbackCleanupFailure)
|
|
: state.readbackFailed && state.failReadback
|
|
? Promise.reject(new Error("injected readback failure"))
|
|
: original.readRegularFileText(...arguments_),
|
|
};
|
|
});
|
|
|
|
import { ClientConfigurationPublication } from "../../src/application/ClientConfigurationPublication.js";
|
|
import {
|
|
configureClientConfiguration,
|
|
ClientConfigurationCleanupRollbackFailure,
|
|
} from "../../src/application/SetupClientConfiguration.js";
|
|
import { RegularFileReadFailure } from "../../src/process/RegularFileRead.js";
|
|
import { retryClientConfigurationCleanup } from "../../src/application/ClientConfigurationCleanup.js";
|
|
import { ArtifactResourceScope } from "../../src/resources/ArtifactResourceScope.js";
|
|
import { RegularFileCleanupFailure } from "../../src/filesystem/OwnedRegularFile.js";
|
|
import { OwnedFileHandle } from "../../src/filesystem/OwnedFileHandle.js";
|
|
import type { DoctorHost } from "../../src/application/Doctor.js";
|
|
import { systemSetupHost } from "../../src/application/SetupHost.js";
|
|
import { AnalysisError } from "../../src/domain/analysisErrorBase.js";
|
|
import { systemUninstallHost } from "../../src/application/Uninstall.js";
|
|
import { ConfigurationError } from "../../src/domain/configurationErrors.js";
|
|
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
|
|
import { createDeferred } from "../fixtures/binarySession.js";
|
|
import { awaitAcknowledgement } from "../fixtures/lifecycleAcknowledgement.js";
|
|
import { supportedClientRegistrationProfile } from "../../src/application/SupportedClients.js";
|
|
|
|
const ownReadHandle = async (path: string) => {
|
|
const owner = new OwnedFileHandle(await open(path, "r"));
|
|
onTestFinished(() => owner.close());
|
|
return owner;
|
|
};
|
|
|
|
it("reports a failed config rollback and retains its backup path", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.initialCleanupFailure = undefined;
|
|
state.readbackCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-rollback-");
|
|
const path = join(root, "client.json");
|
|
const original = '{"keep":true}\n';
|
|
await import("node:fs/promises").then(({ writeFile }) =>
|
|
writeFile(path, original),
|
|
);
|
|
state.rejectRestore = true;
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
|
|
expect(result).toEqual({
|
|
status: "failed",
|
|
reason: "rollback",
|
|
backupPath: `${path}.rea.backup`,
|
|
failure: {
|
|
kind: "restore",
|
|
path,
|
|
detail: "injected restore write failure",
|
|
},
|
|
});
|
|
expect(await readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
expect(JSON.parse(await readFile(path, "utf8"))).toMatchObject({
|
|
mcpServers: { rea: { command: "rea", args: ["mcp"] } },
|
|
});
|
|
});
|
|
|
|
it("preserves the first backup and reports a verified backup of the current original", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.initialCleanupFailure = undefined;
|
|
state.readbackCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-stale-backup-");
|
|
const path = join(root, "client.json");
|
|
const firstOriginal = '{"keep":"first"}\n';
|
|
const currentOriginal = '{"keep":"current"}\n';
|
|
await import("node:fs/promises").then(async ({ writeFile }) => {
|
|
await writeFile(path, currentOriginal);
|
|
await writeFile(`${path}.rea.backup`, firstOriginal);
|
|
});
|
|
state.rejectRestore = true;
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
state.rejectRestore = false;
|
|
|
|
const recoveryPath = `${path}.rea.backup.${createHash("sha256")
|
|
.update(currentOriginal, "utf8")
|
|
.digest("hex")}.recovery`;
|
|
expect(result).toMatchObject({
|
|
status: "failed",
|
|
reason: "rollback",
|
|
backupPath: recoveryPath,
|
|
failure: {
|
|
kind: "restore",
|
|
path,
|
|
detail: "injected restore write failure",
|
|
},
|
|
});
|
|
expect(await readFile(`${path}.rea.backup`, "utf8")).toBe(firstOriginal);
|
|
expect(await readFile(recoveryPath, "utf8")).toBe(currentOriginal);
|
|
});
|
|
|
|
it("does not write config when a recovery copy disappears before verification", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.removeCopiedRecovery = false;
|
|
state.initialCleanupFailure = undefined;
|
|
state.readbackCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-vanished-recovery-");
|
|
const path = join(root, "client.json");
|
|
const firstOriginal = '{"keep":"first"}\n';
|
|
const currentOriginal = '{"keep":"current"}\n';
|
|
await import("node:fs/promises").then(async ({ writeFile }) => {
|
|
await writeFile(path, currentOriginal);
|
|
await writeFile(`${path}.rea.backup`, firstOriginal);
|
|
});
|
|
state.removeCopiedRecovery = true;
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
state.removeCopiedRecovery = false;
|
|
|
|
expect(result).toEqual({ status: "failed", reason: "backup" });
|
|
expect(await readFile(path, "utf8")).toBe(currentOriginal);
|
|
expect(await readFile(`${path}.rea.backup`, "utf8")).toBe(firstOriginal);
|
|
});
|
|
|
|
it("does not roll back or remove config when its initial read cleanup fails", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.readbackCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-initial-cleanup-");
|
|
const path = join(root, "client.json");
|
|
const original = '{"keep":true}\n';
|
|
await import("node:fs/promises").then(({ writeFile }) =>
|
|
writeFile(path, original),
|
|
);
|
|
const failure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner: await ownReadHandle(path),
|
|
outcome: { kind: "completed", value: original },
|
|
cleanupCause: new Error("injected initial close failure"),
|
|
});
|
|
state.initialCleanupFailure = failure;
|
|
|
|
await expect(
|
|
configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
),
|
|
).rejects.toBe(failure);
|
|
expect(await readFile(path, "utf8")).toBe(original);
|
|
});
|
|
|
|
it("retains first-run configuration for manual recovery without deleting by pathname", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.initialCleanupFailure = undefined;
|
|
state.readbackCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-first-run-rollback-");
|
|
const path = join(root, "client.json");
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
|
|
expect(result).toMatchObject({
|
|
status: "failed",
|
|
reason: "rollback",
|
|
failure: {
|
|
kind: "restore",
|
|
path,
|
|
detail:
|
|
"First-run configuration recovery requires manual removal; pathname deletion cannot prove ownership",
|
|
},
|
|
});
|
|
expect(result).not.toHaveProperty("backupPath");
|
|
expect(JSON.parse(await readFile(path, "utf8"))).toMatchObject({
|
|
mcpServers: { rea: { command: "rea", args: ["mcp"] } },
|
|
});
|
|
});
|
|
|
|
it("retains readback cleanup ownership when rollback also fails", async () => {
|
|
state.readbackFailed = false;
|
|
state.rejectRestore = false;
|
|
state.initialCleanupFailure = undefined;
|
|
const root = await createTestTempDirectory("rea-config-readback-cleanup-");
|
|
const path = join(root, "client.json");
|
|
const original = '{"keep":true}\n';
|
|
await import("node:fs/promises").then(({ writeFile }) =>
|
|
writeFile(path, original),
|
|
);
|
|
const owner = await ownReadHandle(path);
|
|
const cleanupFailure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner,
|
|
outcome: { kind: "completed", value: "" },
|
|
cleanupCause: new Error("injected readback close failure"),
|
|
});
|
|
state.readbackCleanupFailure = cleanupFailure;
|
|
state.rejectRestore = true;
|
|
|
|
const host = systemSetupHost(
|
|
{ platform: "linux", homeDirectory: root } as DoctorHost,
|
|
{ HOME: root },
|
|
);
|
|
let caught: unknown;
|
|
try {
|
|
await host.configureClient(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
} catch (cause: unknown) {
|
|
caught = cause;
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
|
|
if (!(caught instanceof ConfigurationError)) throw caught;
|
|
expect(caught.message).toContain("injected restore write failure");
|
|
expect(caught.message).toContain(`${path}.rea.backup`);
|
|
const cleanupOwnerError = caught.cause;
|
|
if (!(cleanupOwnerError instanceof RegularFileCleanupFailure))
|
|
throw new Error("Configuration failure lost its read owner");
|
|
expect(cleanupOwnerError).toMatchObject({
|
|
path,
|
|
outcome: { kind: "completed", value: "" },
|
|
cleanupCause: expect.any(AggregateError),
|
|
});
|
|
expect(cleanupOwnerError.owner).toBe(owner);
|
|
expect(await readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
});
|
|
|
|
it.each(["existing", "first-run"] as const)(
|
|
"retains a replacement symlink and its target when %s readback fails",
|
|
async (kind) => {
|
|
const root = await createTestTempDirectory("rea-config-replaced-rollback-");
|
|
const path = join(root, "client.json");
|
|
const replacement = join(root, "replacement.json");
|
|
const original = '{"keep":"original"}\n';
|
|
const foreign = '{"keep":"replacement"}\n';
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(replacement, foreign);
|
|
if (kind === "existing") await fs.writeFile(path, original);
|
|
state.afterPublication = async (publishedPath) => {
|
|
await fs.unlink(publishedPath);
|
|
await fs.symlink(replacement, publishedPath);
|
|
};
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
|
|
expect(await fs.readFile(replacement, "utf8")).toBe(foreign);
|
|
expect((await fs.lstat(path)).isSymbolicLink()).toBe(true);
|
|
expect(result).toMatchObject({ status: "failed", reason: "conflict" });
|
|
if (kind === "existing")
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
},
|
|
);
|
|
|
|
it("retains a replacement regular file when readback fails", async () => {
|
|
const root = await createTestTempDirectory("rea-config-replaced-file-");
|
|
const path = join(root, "client.json");
|
|
const replacement = join(root, "replacement.json");
|
|
const original = '{"keep":"original"}\n';
|
|
const foreign = '{"keep":"replacement"}\n';
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(path, original);
|
|
await fs.writeFile(replacement, foreign);
|
|
state.afterPublication = (publishedPath) =>
|
|
fs.rename(replacement, publishedPath);
|
|
|
|
const result = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
);
|
|
|
|
expect(await fs.readFile(path, "utf8")).toBe(foreign);
|
|
expect(result).toMatchObject({ status: "failed", reason: "conflict" });
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
});
|
|
|
|
it("retains and retries both readback and publication descriptors after mixed close failures", async () => {
|
|
const root = await createTestTempDirectory("rea-config-two-close-owners-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(path, '{"keep":true}\n');
|
|
const readOwner = await ownReadHandle(path);
|
|
const closeRead = readOwner.handle.close.bind(readOwner.handle);
|
|
let rejectReadClose = true;
|
|
readOwner.handle.close = async () => {
|
|
if (rejectReadClose) throw new Error("injected readback close failure");
|
|
await closeRead();
|
|
};
|
|
state.readbackCleanupFailure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner: readOwner,
|
|
outcome: { kind: "completed", value: "" },
|
|
cleanupCause: new Error("injected readback close failure"),
|
|
});
|
|
state.rejectPublicationClose = true;
|
|
const host = systemSetupHost(
|
|
{ platform: "linux", homeDirectory: root } as DoctorHost,
|
|
{ HOME: root },
|
|
);
|
|
try {
|
|
await expect(
|
|
host.configureClient(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
),
|
|
).rejects.toBeInstanceOf(ConfigurationError);
|
|
expect(state.publicationHandles).toHaveLength(1);
|
|
expect(readOwner.handle.fd).toBeGreaterThanOrEqual(0);
|
|
expect(state.publicationHandles[0]!.fd).toBeGreaterThanOrEqual(0);
|
|
rejectReadClose = false;
|
|
state.rejectPublicationClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(readOwner.handle.fd).toBe(-1);
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
} finally {
|
|
rejectReadClose = false;
|
|
state.rejectPublicationClose = false;
|
|
await host.close?.();
|
|
await readOwner.close();
|
|
for (const handle of state.publicationHandles)
|
|
if (handle.fd >= 0) await handle.close();
|
|
}
|
|
});
|
|
|
|
it("rejects a replaced publication even when the replacement passes registration readback", async () => {
|
|
const root = await createTestTempDirectory("rea-config-valid-replacement-");
|
|
const path = join(root, "client.json");
|
|
const replacement = join(root, "replacement.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original = '{"keep":true}\n';
|
|
await fs.writeFile(path, original);
|
|
let foreign = "";
|
|
state.failReadback = false;
|
|
state.afterPublication = async (publishedPath) => {
|
|
foreign = await fs.readFile(publishedPath, "utf8");
|
|
await fs.writeFile(replacement, foreign);
|
|
await fs.rename(replacement, publishedPath);
|
|
};
|
|
expect(
|
|
await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
),
|
|
).toMatchObject({ status: "failed", reason: "conflict" });
|
|
expect(await fs.readFile(path, "utf8")).toBe(foreign);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
});
|
|
|
|
it("retains concurrent edits to the published inode rather than overwriting them", async () => {
|
|
const root = await createTestTempDirectory("rea-config-inode-edit-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original = '{"keep":true}\n';
|
|
const edited = '{"keep":"concurrent edit"}\n';
|
|
await fs.writeFile(path, original);
|
|
state.afterPublication = (publishedPath) =>
|
|
fs.writeFile(publishedPath, edited);
|
|
expect(
|
|
await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
),
|
|
).toMatchObject({ status: "failed", reason: "conflict" });
|
|
expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
});
|
|
|
|
it("does not adopt a descriptor named by an opaque publication close rejection", async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-config-close-cause-ownership-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const unrelated = join(root, "unrelated.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(path, '{"keep":true}\n');
|
|
await fs.writeFile(unrelated, "unrelated");
|
|
const foreignOwner = await ownReadHandle(unrelated);
|
|
state.failReadback = false;
|
|
state.rejectPublicationClose = true;
|
|
state.publicationCloseFailure = new RegularFileCleanupFailure({
|
|
path: unrelated,
|
|
owner: foreignOwner,
|
|
outcome: { kind: "completed", value: "unrelated" },
|
|
cleanupCause: new Error("opaque close rejection"),
|
|
});
|
|
const host = systemSetupHost(
|
|
{ platform: "linux", homeDirectory: root } as DoctorHost,
|
|
{ HOME: root },
|
|
);
|
|
try {
|
|
await expect(
|
|
host.configureClient(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
),
|
|
).rejects.toBeInstanceOf(ConfigurationError);
|
|
state.rejectPublicationClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
expect(foreignOwner.handle.fd).toBeGreaterThanOrEqual(0);
|
|
} finally {
|
|
state.rejectPublicationClose = false;
|
|
await host.close?.();
|
|
await foreignOwner.close();
|
|
for (const handle of state.publicationHandles)
|
|
if (handle.fd >= 0) await handle.close();
|
|
}
|
|
});
|
|
|
|
it.each(["symlink", "regular", "valid-readback"] as const)(
|
|
"uninstall retains a %s replacement instead of restoring through its name",
|
|
async (kind) => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-replaced-rollback-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const replacement = join(root, "replacement.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":"original"}\n';
|
|
const foreign = '{"keep":"replacement"}\n';
|
|
await fs.writeFile(path, original);
|
|
await fs.writeFile(replacement, foreign);
|
|
state.failReadback = kind !== "valid-readback";
|
|
state.afterPublication = async (publishedPath) => {
|
|
state.afterPublication = undefined;
|
|
if (kind === "symlink") {
|
|
await fs.unlink(publishedPath);
|
|
await fs.symlink(replacement, publishedPath);
|
|
} else await fs.rename(replacement, publishedPath);
|
|
};
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
const result = await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
expect(await fs.readFile(path, "utf8")).toBe(foreign);
|
|
if (kind === "symlink") {
|
|
expect((await fs.lstat(path)).isSymbolicLink()).toBe(true);
|
|
expect(await fs.readFile(replacement, "utf8")).toBe(foreign);
|
|
}
|
|
expect(result.status).toBe("failed");
|
|
expect(result.detail).not.toContain("The original was restored");
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
},
|
|
);
|
|
|
|
it("uninstall retains concurrent edits to the published inode and reports failure", async () => {
|
|
const root = await createTestTempDirectory("rea-uninstall-inode-edit-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":"original"}\n';
|
|
const edited = '{"keep":"concurrent edit"}\n';
|
|
await fs.writeFile(path, original);
|
|
state.failReadback = false;
|
|
state.afterPublication = async (publishedPath) => {
|
|
state.afterPublication = undefined;
|
|
const before = await fs.stat(publishedPath);
|
|
await fs.writeFile(publishedPath, edited);
|
|
expect((await fs.stat(publishedPath)).ino).toBe(before.ino);
|
|
};
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
const result = await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
expect(result.status).toBe("failed");
|
|
expect(result.detail).not.toContain("The original was restored");
|
|
expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
});
|
|
|
|
it("uninstall retains both readback and publication owners until cleanup retry", async () => {
|
|
const root = await createTestTempDirectory("rea-uninstall-two-close-owners-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(
|
|
path,
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n',
|
|
);
|
|
const readOwner = await ownReadHandle(path);
|
|
const closeRead = readOwner.handle.close.bind(readOwner.handle);
|
|
let rejectReadClose = true;
|
|
readOwner.handle.close = async () => {
|
|
if (rejectReadClose) throw new Error("injected readback close failure");
|
|
await closeRead();
|
|
};
|
|
state.readbackCleanupFailure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner: readOwner,
|
|
outcome: { kind: "completed", value: "" },
|
|
cleanupCause: new Error("readback close failed"),
|
|
});
|
|
state.rejectPublicationClose = true;
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
const result = await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
expect(result.status).toBe("failed");
|
|
expect(state.publicationHandles).toHaveLength(1);
|
|
expect(readOwner.handle.fd).toBeGreaterThanOrEqual(0);
|
|
expect(state.publicationHandles[0]!.fd).toBeGreaterThanOrEqual(0);
|
|
rejectReadClose = false;
|
|
state.rejectPublicationClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(readOwner.handle.fd).toBe(-1);
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
} finally {
|
|
rejectReadClose = false;
|
|
state.rejectPublicationClose = false;
|
|
await host.close?.();
|
|
await readOwner.close();
|
|
for (const handle of state.publicationHandles)
|
|
if (handle.fd >= 0) await handle.close();
|
|
}
|
|
});
|
|
|
|
it("uninstall retains the exact owner of a failed initial config read", async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-initial-read-owner-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original = '{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n';
|
|
await fs.writeFile(path, original);
|
|
const owner = await ownReadHandle(path);
|
|
const close = owner.handle.close.bind(owner.handle);
|
|
let rejectClose = true;
|
|
owner.handle.close = async () => {
|
|
if (rejectClose) throw new Error("initial close denied");
|
|
await close();
|
|
};
|
|
state.initialCleanupFailure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner,
|
|
outcome: { kind: "completed", value: original },
|
|
cleanupCause: new Error("initial close denied"),
|
|
});
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
expect(
|
|
await host.inspectClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
}),
|
|
).toMatchObject({ status: "failed" });
|
|
expect(state.publicationHandles).toHaveLength(0);
|
|
expect(owner.handle.fd).toBeGreaterThanOrEqual(0);
|
|
rejectClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(owner.handle.fd).toBe(-1);
|
|
expect(await fs.readFile(path, "utf8")).toBe(original);
|
|
await expect(fs.readFile(`${path}.rea.backup`)).rejects.toMatchObject({
|
|
code: "ENOENT",
|
|
});
|
|
} finally {
|
|
rejectClose = false;
|
|
await host.close?.();
|
|
await owner.close();
|
|
}
|
|
});
|
|
|
|
it("uninstall close joins a publication already admitted by its host", async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-close-publication-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(
|
|
path,
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n',
|
|
);
|
|
const arrived = createDeferred<void>();
|
|
const release = createDeferred<void>();
|
|
state.afterPublication = async () => {
|
|
arrived.resolve();
|
|
await release.promise;
|
|
};
|
|
const host = systemUninstallHost(root);
|
|
const removal = host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
let closed = false;
|
|
let closing: ReturnType<NonNullable<typeof host.close>> | undefined;
|
|
try {
|
|
await awaitAcknowledgement(
|
|
arrived.promise,
|
|
removal,
|
|
"configuration publication",
|
|
);
|
|
closing = host.close?.().then((result) => {
|
|
closed = true;
|
|
return result;
|
|
});
|
|
await new Promise<void>((resolve) => setImmediate(resolve));
|
|
expect(closed).toBe(false);
|
|
expect(state.publicationHandles[0]!.fd).toBeGreaterThanOrEqual(0);
|
|
} finally {
|
|
release.resolve();
|
|
await Promise.allSettled([removal, ...(closing ? [closing] : [])]);
|
|
await host.close?.();
|
|
}
|
|
expect((await removal).status).toBe("failed");
|
|
expect(await closing).toBeUndefined();
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
await expect(
|
|
host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
}),
|
|
).rejects.toThrow("closed");
|
|
});
|
|
|
|
it("preserves physical read origin through failed readback cleanup and rollback", async () => {
|
|
const root = await createTestTempDirectory("rea-config-physical-rollback-");
|
|
const path = join(root, "client.json");
|
|
const other = join(root, "foreign.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(path, '{"keep":true}\n');
|
|
await fs.writeFile(other, "foreign bytes");
|
|
const owned = await ownReadHandle(path);
|
|
const foreign = await ownReadHandle(other);
|
|
const opaque = new RegularFileCleanupFailure({
|
|
path: other,
|
|
owner: foreign,
|
|
outcome: { kind: "completed", value: "foreign bytes" },
|
|
cleanupCause: new Error("foreign cleanup-shaped physical rejection"),
|
|
});
|
|
const physical = new RegularFileReadFailure(opaque);
|
|
const close = owned.handle.close.bind(owned.handle);
|
|
let denyClose = true;
|
|
owned.handle.close = async () => {
|
|
if (denyClose) throw new Error("readback close denied");
|
|
await close();
|
|
};
|
|
state.readbackCleanupFailure = new RegularFileCleanupFailure({
|
|
path,
|
|
owner: owned,
|
|
outcome: { kind: "failed", cause: opaque },
|
|
operationFailure: physical,
|
|
cleanupCause: new Error("readback close denied"),
|
|
});
|
|
state.rejectRestore = true;
|
|
const resources = new ArtifactResourceScope();
|
|
try {
|
|
const failure: unknown = await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
).catch((cause: unknown) => cause);
|
|
expect(failure).toBeInstanceOf(ClientConfigurationCleanupRollbackFailure);
|
|
if (!(failure instanceof ClientConfigurationCleanupRollbackFailure))
|
|
throw new Error("Expected failed readback cleanup and rollback");
|
|
expect(failure.operationFailure).toBe(physical);
|
|
expect(failure.outcome).toEqual({ kind: "failed", cause: opaque });
|
|
expect(failure.configurationFailure).toMatchObject({
|
|
status: "failed",
|
|
reason: "rollback",
|
|
failure: { kind: "restore", detail: "injected restore write failure" },
|
|
});
|
|
const retried = await retryClientConfigurationCleanup(failure, resources);
|
|
expect(retried.primary).toBe(opaque);
|
|
expect(retried.failures).toHaveLength(1);
|
|
expect(retried.cleanup?.resources).toEqual([path]);
|
|
expect(owned.handle.fd).toBeGreaterThanOrEqual(0);
|
|
expect(foreign.handle.fd).toBeGreaterThanOrEqual(0);
|
|
denyClose = false;
|
|
await resources.close();
|
|
expect(owned.handle.fd).toBe(-1);
|
|
expect(foreign.handle.fd).toBeGreaterThanOrEqual(0);
|
|
expect(await fs.readFile(other, "utf8")).toBe("foreign bytes");
|
|
} finally {
|
|
denyClose = false;
|
|
await resources.close();
|
|
await owned.close();
|
|
}
|
|
});
|
|
|
|
it("cleanup retry never adopts an opaque cancellation reason as another owner", async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-cleanup-cancellation-authority-",
|
|
);
|
|
const path = join(root, "owned.json");
|
|
const other = join(root, "other.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(path, "owned");
|
|
await fs.writeFile(other, "other");
|
|
const owned = await ownReadHandle(path);
|
|
const foreign = await ownReadHandle(other);
|
|
const opaque = new RegularFileCleanupFailure({
|
|
path: other,
|
|
owner: foreign,
|
|
outcome: { kind: "completed", value: "other" },
|
|
cleanupCause: new Error("opaque reason"),
|
|
});
|
|
const { RegularFileOperationCancelled } =
|
|
await import("../../src/filesystem/RegularFile.js");
|
|
const { ArtifactResourceScope } =
|
|
await import("../../src/resources/ArtifactResourceScope.js");
|
|
const { retryRegularFileCleanupFailures } =
|
|
await import("../../src/process/RegularFileRead.js");
|
|
const resources = new ArtifactResourceScope();
|
|
const outcome = await retryRegularFileCleanupFailures(
|
|
new RegularFileCleanupFailure({
|
|
path,
|
|
owner: owned,
|
|
outcome: {
|
|
kind: "failed",
|
|
cause: new RegularFileOperationCancelled(opaque),
|
|
},
|
|
cleanupCause: new Error("owned close failed"),
|
|
}),
|
|
resources,
|
|
);
|
|
expect(outcome.primary).toBe(opaque);
|
|
expect(outcome.failures).toHaveLength(1);
|
|
expect(owned.handle.fd).toBe(-1);
|
|
await resources.close();
|
|
expect(foreign.handle.fd).toBeGreaterThanOrEqual(0);
|
|
});
|
|
|
|
it("uninstall progresses when a peer leaves a denied-close descriptor pending", async () => {
|
|
const root = await createTestTempDirectory("rea-uninstall-peer-cleanup-");
|
|
const path = join(root, "client.json");
|
|
const other = join(root, "other.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(
|
|
path,
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n',
|
|
);
|
|
await fs.writeFile(other, "{}");
|
|
const owner = await ownReadHandle(other);
|
|
const close = owner.handle.close.bind(owner.handle);
|
|
let rejectClose = true;
|
|
owner.handle.close = async () => {
|
|
if (rejectClose) throw new Error("peer close denied");
|
|
await close();
|
|
};
|
|
const arrived = createDeferred<void>();
|
|
const release = createDeferred<void>();
|
|
state.failReadback = false;
|
|
state.afterPublication = async () => {
|
|
arrived.resolve();
|
|
await release.promise;
|
|
};
|
|
const host = systemUninstallHost(root);
|
|
const removal = host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
let timeout: ReturnType<typeof setTimeout> | undefined;
|
|
try {
|
|
await awaitAcknowledgement(
|
|
arrived.promise,
|
|
removal,
|
|
"configuration publication",
|
|
);
|
|
state.initialCleanupFailure = new RegularFileCleanupFailure({
|
|
path: other,
|
|
owner,
|
|
outcome: { kind: "completed", value: "{}" },
|
|
cleanupCause: new Error("peer close denied"),
|
|
});
|
|
expect(
|
|
await host.inspectClient({
|
|
name: "other",
|
|
// Source-only peer actor models Cursor JSON registration.
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: other,
|
|
format: "json",
|
|
}),
|
|
).toMatchObject({ status: "failed" });
|
|
state.initialCleanupFailure = undefined;
|
|
release.resolve();
|
|
const result = await Promise.race([
|
|
removal,
|
|
new Promise<never>((_resolve, reject) => {
|
|
timeout = setTimeout(
|
|
() =>
|
|
reject(
|
|
new Error("configuration admission deadlocked with file cleanup"),
|
|
),
|
|
5000,
|
|
);
|
|
}),
|
|
]);
|
|
expect(result.status).toBe("failed");
|
|
expect(owner.handle.fd).toBeGreaterThanOrEqual(0);
|
|
rejectClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(owner.handle.fd).toBe(-1);
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
} finally {
|
|
if (timeout !== undefined) clearTimeout(timeout);
|
|
state.initialCleanupFailure = undefined;
|
|
rejectClose = false;
|
|
release.resolve();
|
|
await owner.close();
|
|
for (const handle of state.publicationHandles)
|
|
if (handle.fd >= 0) await handle.close();
|
|
}
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32" || process.getuid?.() === 0)(
|
|
"exclusive staging refuses a preexisting entry without changing its permissions",
|
|
async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-staging-exclusive-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const foreign = join(root, "foreign.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n';
|
|
await fs.writeFile(path, original);
|
|
await fs.chmod(path, 0o400);
|
|
await fs.writeFile(foreign, "foreign");
|
|
await fs.chmod(foreign, 0o640);
|
|
let inserted: string | undefined;
|
|
state.beforePublicationOpen = async (stagedPath) => {
|
|
state.beforePublicationOpen = undefined;
|
|
inserted = stagedPath;
|
|
await fs.link(foreign, stagedPath);
|
|
};
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
expect(
|
|
(
|
|
await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
})
|
|
).status,
|
|
).toBe("failed");
|
|
expect(await fs.readFile(foreign, "utf8")).toBe("foreign");
|
|
expect((await fs.lstat(foreign)).mode & 0o777).toBe(0o640);
|
|
expect(await fs.readFile(path, "utf8")).toBe(original);
|
|
expect((await fs.lstat(path)).mode & 0o777).toBe(0o400);
|
|
expect(state.publicationHandles).toHaveLength(0);
|
|
expect(await host.close?.()).toBeInstanceOf(AnalysisError);
|
|
} finally {
|
|
if (inserted !== undefined) await fs.unlink(inserted);
|
|
await host.close?.();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32" || process.getuid?.() === 0)(
|
|
"uninstall retains the private stage after mode preparation and descriptor cleanup fail",
|
|
async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-staging-mode-retry-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}}}\n';
|
|
await fs.writeFile(path, original);
|
|
await fs.chmod(path, 0o400);
|
|
state.rejectPublicationMode = true;
|
|
state.rejectPublicationClose = true;
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
expect(
|
|
(
|
|
await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
})
|
|
).status,
|
|
).toBe("failed");
|
|
expect(state.publicationHandles).toHaveLength(1);
|
|
expect(state.publicationHandles[0]!.fd).toBeGreaterThanOrEqual(0);
|
|
expect(await host.close?.()).toBeInstanceOf(AnalysisError);
|
|
state.rejectPublicationMode = false;
|
|
state.rejectPublicationClose = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
expect(await fs.readFile(path, "utf8")).toBe(original);
|
|
expect((await fs.lstat(path)).mode & 0o777).toBe(0o400);
|
|
} finally {
|
|
state.rejectPublicationMode = false;
|
|
state.rejectPublicationClose = false;
|
|
await host.close?.();
|
|
for (const handle of state.publicationHandles)
|
|
if (handle.fd >= 0) await handle.close();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.skipIf(process.platform === "win32" || process.getuid?.() === 0)(
|
|
"uninstall restores a read-only configuration through its retained writable descriptor",
|
|
async () => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-uninstall-readonly-restore-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":true}\n';
|
|
await fs.writeFile(path, original);
|
|
await fs.chmod(path, 0o400);
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
const result = await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
expect(result.status).toBe("failed");
|
|
expect(result.detail).toContain("The original was restored");
|
|
expect(await fs.readFile(path, "utf8")).toBe(original);
|
|
expect((await fs.lstat(path)).mode & 0o777).toBe(0o400);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
},
|
|
);
|
|
|
|
it.each(["setup", "uninstall"] as const)(
|
|
"%s refuses a configuration symlink inserted after backup without overwriting its target",
|
|
async (operation) => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-config-prepublication-symlink-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const foreign = join(root, "foreign.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
operation === "setup"
|
|
? '{"keep":"original"}\n'
|
|
: '{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":"original"}\n';
|
|
const unrelated = '{"keep":"foreign"}\n';
|
|
await fs.writeFile(path, original);
|
|
await fs.writeFile(foreign, unrelated);
|
|
state.failReadback = false;
|
|
state.afterBackupCopy = async (source) => {
|
|
state.afterBackupCopy = undefined;
|
|
await fs.unlink(source);
|
|
await fs.symlink(foreign, source);
|
|
};
|
|
if (operation === "setup") {
|
|
expect(
|
|
(
|
|
await configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["rea", "mcp"],
|
|
)
|
|
).status,
|
|
).toBe("failed");
|
|
} else {
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
expect(
|
|
(
|
|
await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
})
|
|
).status,
|
|
).toBe("failed");
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
}
|
|
expect(await fs.readFile(foreign, "utf8")).toBe(unrelated);
|
|
expect((await fs.lstat(path)).isSymbolicLink()).toBe(true);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
},
|
|
);
|
|
|
|
const runConfigurationChange = async (
|
|
operation: "setup" | "uninstall",
|
|
root: string,
|
|
path: string,
|
|
) => {
|
|
if (operation === "setup")
|
|
return configureClientConfiguration(
|
|
{
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
},
|
|
{},
|
|
["new-rea", "mcp"],
|
|
);
|
|
const host = systemUninstallHost(root);
|
|
try {
|
|
return await host.removeClient({
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json",
|
|
});
|
|
} finally {
|
|
await host.close?.();
|
|
}
|
|
};
|
|
|
|
it.each([
|
|
["setup", "edit"],
|
|
["uninstall", "edit"],
|
|
["setup", "delete"],
|
|
["uninstall", "delete"],
|
|
] as const)(
|
|
"%s preserves a configuration %s after backup",
|
|
async (operation, change) => {
|
|
const root = await createTestTempDirectory("rea-config-backup-change-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":true}\n';
|
|
const edited = '{"changed":"by client"}\n';
|
|
await fs.writeFile(path, original);
|
|
state.failReadback = false;
|
|
state.afterBackupCopy = async (source) => {
|
|
state.afterBackupCopy = undefined;
|
|
if (change === "edit") await fs.writeFile(source, edited);
|
|
else await fs.unlink(source);
|
|
};
|
|
expect((await runConfigurationChange(operation, root, path)).status).toBe(
|
|
"failed",
|
|
);
|
|
if (change === "edit") expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
else await expect(fs.lstat(path)).rejects.toMatchObject({ code: "ENOENT" });
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) =>
|
|
name.startsWith(".rea-config-"),
|
|
),
|
|
).toEqual([]);
|
|
},
|
|
);
|
|
|
|
it.each(["setup", "uninstall"] as const)(
|
|
"%s refuses an input changed during staging",
|
|
async (operation) => {
|
|
const root = await createTestTempDirectory("rea-config-staging-change-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":true}\n';
|
|
const edited = '{"changed":"during staging"}\n';
|
|
await fs.writeFile(path, original);
|
|
state.failReadback = false;
|
|
state.beforePublicationOpen = async () => {
|
|
state.beforePublicationOpen = undefined;
|
|
await fs.writeFile(path, edited);
|
|
};
|
|
expect((await runConfigurationChange(operation, root, path)).status).toBe(
|
|
"failed",
|
|
);
|
|
expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
expect(await fs.readFile(`${path}.rea.backup`, "utf8")).toBe(original);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) =>
|
|
name.startsWith(".rea-config-"),
|
|
),
|
|
).toEqual([]);
|
|
},
|
|
);
|
|
|
|
it("first-run setup preserves a destination created during staging", async () => {
|
|
const root = await createTestTempDirectory("rea-config-first-conflict-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const edited = '{"created":"by client"}\n';
|
|
state.failReadback = false;
|
|
state.beforePublicationOpen = async () => {
|
|
state.beforePublicationOpen = undefined;
|
|
await fs.writeFile(path, edited);
|
|
};
|
|
expect((await runConfigurationChange("setup", root, path)).status).toBe(
|
|
"failed",
|
|
);
|
|
expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) => name.startsWith(".rea-config-")),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it.each(["setup", "uninstall"] as const)(
|
|
"%s retains staging directory cleanup for host retry",
|
|
async (operation) => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-config-staging-directory-retry-",
|
|
);
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
await fs.writeFile(
|
|
path,
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":true}\n',
|
|
);
|
|
state.failReadback = false;
|
|
state.rejectStageRemoval = true;
|
|
const host =
|
|
operation === "setup"
|
|
? systemSetupHost(
|
|
{ platform: "linux", homeDirectory: root } as DoctorHost,
|
|
{ HOME: root },
|
|
)
|
|
: systemUninstallHost(root);
|
|
try {
|
|
const client = {
|
|
name: "cursor",
|
|
registrationProfile: supportedClientRegistrationProfile("cursor"),
|
|
configPath: path,
|
|
format: "json" as const,
|
|
};
|
|
if (operation === "setup") {
|
|
await expect(
|
|
(host as ReturnType<typeof systemSetupHost>).configureClient(
|
|
client,
|
|
{},
|
|
["new-rea", "mcp"],
|
|
),
|
|
).rejects.toThrow();
|
|
} else {
|
|
expect(
|
|
(
|
|
await (host as ReturnType<typeof systemUninstallHost>).removeClient(
|
|
client,
|
|
)
|
|
).status,
|
|
).toBe("failed");
|
|
}
|
|
const cleanupFailure = await host.close?.();
|
|
expect(cleanupFailure).toBeInstanceOf(AnalysisError);
|
|
const retainedRoots = (await fs.readdir(root))
|
|
.filter((name) => name.startsWith(".rea-config-"))
|
|
.map((name) => join(root, name));
|
|
expect((cleanupFailure as AnalysisError).cleanupResources).toEqual(
|
|
retainedRoots,
|
|
);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) =>
|
|
name.startsWith(".rea-config-"),
|
|
),
|
|
).toHaveLength(1);
|
|
state.rejectStageRemoval = false;
|
|
expect(await host.close?.()).toBeUndefined();
|
|
if (cleanupFailure instanceof AnalysisError)
|
|
expect(cleanupFailure.cleanupIncomplete).toBe(false);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) =>
|
|
name.startsWith(".rea-config-"),
|
|
),
|
|
).toEqual([]);
|
|
expect(state.publicationHandles[0]!.fd).toBe(-1);
|
|
} finally {
|
|
state.rejectStageRemoval = false;
|
|
await host.close?.();
|
|
}
|
|
},
|
|
);
|
|
|
|
it("first-run publication exclusively refuses a destination created after its final check", async () => {
|
|
const root = await createTestTempDirectory("rea-config-exclusive-link-");
|
|
const path = join(root, "client.json");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const edited = '{"created":"after final check"}\n';
|
|
state.beforeFirstPublication = async () => {
|
|
await fs.writeFile(path, edited);
|
|
};
|
|
await expect(
|
|
ClientConfigurationPublication.write(path, "{}", undefined),
|
|
).rejects.toMatchObject({ code: "EEXIST" });
|
|
expect(await fs.readFile(path, "utf8")).toBe(edited);
|
|
expect(
|
|
(await fs.readdir(root)).filter((name) => name.startsWith(".rea-config-")),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it("publication keeps its selected canonical parent when a directory symlink is retargeted", async () => {
|
|
const root = await createTestTempDirectory("rea-config-parent-selection-");
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const selected = join(root, "selected");
|
|
const foreign = join(root, "foreign");
|
|
const alias = join(root, "alias");
|
|
await fs.mkdir(selected);
|
|
await fs.mkdir(foreign);
|
|
await fs.symlink(selected, alias, "dir");
|
|
const original = '{"original":true}\n';
|
|
const unrelated = '{"foreign":true}\n';
|
|
await fs.writeFile(join(selected, "client.json"), original);
|
|
await fs.writeFile(join(foreign, "client.json"), unrelated);
|
|
state.beforePublicationOpen = async () => {
|
|
state.beforePublicationOpen = undefined;
|
|
await fs.unlink(alias);
|
|
await fs.symlink(foreign, alias, "dir");
|
|
};
|
|
const publication = await ClientConfigurationPublication.write(
|
|
join(alias, "client.json"),
|
|
"{}",
|
|
original,
|
|
);
|
|
await publication.verify(async () =>
|
|
publication.assertCurrent(await fs.readFile(publication.path, "utf8")),
|
|
);
|
|
expect(await fs.readFile(join(selected, "client.json"), "utf8")).toBe("{}");
|
|
expect(await fs.readFile(join(foreign, "client.json"), "utf8")).toBe(
|
|
unrelated,
|
|
);
|
|
expect(
|
|
(await fs.readdir(selected)).filter((name) =>
|
|
name.startsWith(".rea-config-"),
|
|
),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it.each(["setup", "uninstall"] as const)(
|
|
"%s reads back the selected canonical parent after its alias is retargeted",
|
|
async (operation) => {
|
|
const root = await createTestTempDirectory(
|
|
"rea-config-adapter-parent-selection-",
|
|
);
|
|
const fs =
|
|
await vi.importActual<typeof import("node:fs/promises")>(
|
|
"node:fs/promises",
|
|
);
|
|
const selected = join(root, "selected");
|
|
const foreign = join(root, "foreign");
|
|
const alias = join(root, "alias");
|
|
await fs.mkdir(selected);
|
|
await fs.mkdir(foreign);
|
|
await fs.symlink(selected, alias, "dir");
|
|
const original =
|
|
'{"mcpServers":{"rea":{"command":"rea","args":["mcp"]}},"keep":true}\n';
|
|
const unrelated = '{"foreign":true}\n';
|
|
await fs.writeFile(join(selected, "client.json"), original);
|
|
await fs.writeFile(join(foreign, "client.json"), unrelated);
|
|
state.failReadback = false;
|
|
state.beforePublicationOpen = async () => {
|
|
state.beforePublicationOpen = undefined;
|
|
await fs.unlink(alias);
|
|
await fs.symlink(foreign, alias, "dir");
|
|
};
|
|
expect(
|
|
(
|
|
await runConfigurationChange(
|
|
operation,
|
|
root,
|
|
join(alias, "client.json"),
|
|
)
|
|
).status,
|
|
).toBe(operation === "setup" ? "configured" : "removed");
|
|
expect(
|
|
JSON.parse(await fs.readFile(join(selected, "client.json"), "utf8")),
|
|
).toMatchObject({ keep: true });
|
|
expect(await fs.readFile(join(foreign, "client.json"), "utf8")).toBe(
|
|
unrelated,
|
|
);
|
|
expect(
|
|
await fs.readFile(join(selected, "client.json.rea.backup"), "utf8"),
|
|
).toBe(original);
|
|
},
|
|
);
|