Files
reverse-engineering-anything/src/application/wasm/WasmArtifactService.ts
T
morluto 6c35d74a7d refactor: centralize input validation and schema interpretation
Migrate twelve application service files to the existing provider input owner,
preserving schema causes, cancellation precedence, caller selection, and
retained Evidence. Keep flows with distinct error policies separate.

Replace the DeepSeek verifier's recursive object scan with schema-position
traversal using the canonical keyword and local-reference owners. Literal
pattern fields no longer cause false regex failures; patternProperties keys
are checked alongside actual pattern constraints in native regex modes.

Validation: 271 focused workflow/service tests and six verifier regressions
passed; static checks, discovery, and actual Node source-loader smoke passed.
The baseline scanner reproduced the new regressions. Installed DeepSeek client
execution was not run.
2026-10-26 17:05:05 +08:00

86 lines
2.9 KiB
TypeScript

import type { AnalysisSettingsReader } from "../../domain/analysisSettings.js";
import type { ExecutionOptions } from "../AnalysisProvider.js";
import { createAnalysisExecutionEvidence } from "../../domain/analysisObservation.js";
import type { WasmArtifactPort } from "./WasmArtifactPort.js";
import type { AnalysisError } from "../../domain/analysisErrorBase.js";
import { AnalysisOutputError } from "../../domain/analysisErrorCore.js";
import type { Evidence } from "../../domain/evidence.js";
import {
inspectWasmArtifactInputSchema,
wasmArtifactSchema,
wasmArtifactMatchesSubject,
DEFAULT_WASM_COMMAND_TIMEOUT_MS,
} from "../../domain/wasm/wasmArtifact.js";
import { err, type Result } from "../../domain/result.js";
import {
completeProviderEvidence,
parseProviderOperationInput,
} from "../ProviderOperationExecution.js";
const OPERATION = "inspect_wasm_artifact";
/** Shared artifact validation and typed inline Evidence for CLI/MCP. */
export class WasmArtifactService {
constructor(
readonly provider: WasmArtifactPort,
readonly settings?: AnalysisSettingsReader,
) {}
/** Join provider cleanup during shutdown or an explicit retry. */
close(): Promise<void> {
return this.provider.close();
}
/** Preserve exact selected artifact identity and validated upstream observations. */
async inspect(
rawInput: unknown,
options?: ExecutionOptions,
): Promise<Result<Evidence, AnalysisError>> {
const input = parseProviderOperationInput(
OPERATION,
rawInput,
inspectWasmArtifactInputSchema,
options?.signal,
);
if (!input.ok) return input;
const timeout =
input.value.command_timeout_ms ??
this.settings?.().overrides["wasm.command_timeout_ms"] ??
DEFAULT_WASM_COMMAND_TIMEOUT_MS;
const inspected = await this.provider.inspect(input.value, {
...options,
commandTimeoutMs: timeout,
});
if (!inspected.ok) return inspected;
const execution = inspected.value;
const report = wasmArtifactSchema.safeParse(execution.result);
if (
!report.success ||
report.data.artifact.path !== input.value.path ||
report.data.tool_profile.timeout_ms !== timeout ||
!wasmArtifactMatchesSubject(report.data.artifact, execution.subject) ||
JSON.stringify(report.data.glue.map((item) => item.artifact.path)) !==
JSON.stringify(input.value.glue_paths) ||
JSON.stringify(report.data.candidates.map((item) => item.path)) !==
JSON.stringify([
...new Set([input.value.path, ...input.value.candidate_paths]),
])
)
return err(
new AnalysisOutputError(
OPERATION,
"WABT adapter returned malformed data or changed the selected artifact identity.",
),
);
return completeProviderEvidence(
createAnalysisExecutionEvidence(
OPERATION,
input.value,
{ ...execution, result: report.data },
"observed",
),
options?.signal,
);
}
}