Files
reverse-engineering-anything/tests/evaluation/budgetArithmeticGuard.test.ts
T
morluto 332dea76a6 fix(native): keep unreported value-flow and archive coverage unknown, and exempt generation caps by reason marker (#11288)
* fix(native): keep unreported value-flow truncation and archive decode coverage unknown

* test(verify): count multiline optional-fact defaults and pin the guard's exclusions

* fix(domain): keep unknown counts and costs unknown in comparison and coverage summaries (#11325)

* fix(domain): keep unknown counts and costs unknown in comparison and coverage summaries

* refactor(verify): exempt legitimate optional-fact defaults with a reasoned marker (#11355)

* refactor(verify): exempt legitimate optional-fact defaults with a reasoned marker

The optional-fact-default guard counted request defaults and absence that
is modelled elsewhere as hidden unknowns. A comment
`// optional-fact-default: <reason>` on the default's line or the line
before now exempts it; the guard reads unstripped source for the marker and
ignores matches inside comment lines.

Marked: the two evidence paging offsets and four Swift literal reads whose
absence swiftLiteralCoverage reports. Removed instead of marked: jsdiff 9
types Change.count as required, so its two `?? 0` defaults were dead; the
evidence link traversal now carries retained records, so it no longer
re-looks them up behind `?? []`. Baseline 31 -> 22.

* fix(verify): blank comment spans instead of skipping comment-led lines in the optional-fact guard

Skipping a match whose line starts like a comment hid live code after a
leading block comment and counted defaults inside a block comment without
leading stars. The counter now blanks comment text (keeping offsets and line
breaks, skipping string literals) and matches the blanked code, while
exemption markers are still read from the original lines.

* refactor(domain): mark optional-fact defaults whose absence is not an observation (#11389)

* refactor(domain): mark optional-fact defaults whose absence is not an observation

Per-site review of the remaining optional-fact-default entries. Each marked
default is a caller option (trace ignore_fields, environment rules), a list
whose producer omits the empty case (unknown_size_frames, the schema's
min-1 representation_node_ids), caveat text whose completeness another field
carries (call diagnostics, unresolved calls, semantic resource limits), or
absence that already turns the result unknown (Wasm interface inventory,
WebMCP discovery, managed ExportedType rows, legacy integrity mismatch IDs).

Left counted: webCaptureDiff redirects (2; the CDP producer always records
them, so absence is a legacy record that should compare as unknown, not
as no redirects) and HopperCallerReconciliation (2; index-miss semantics not
yet verified). Baseline 22 -> 4.

* fix(browser): compare redirects as unknown when a capture predates redirect recording (#11402)

* fix(browser): compare redirects as unknown when a capture predates redirect recording

The CDP producer records every request's redirect chain, empty when there was none; a record without one predates redirect recording (#986). Comparing it against a current capture reported the network dimension as unchanged, treating the missing chain as "no redirects". Redirects are now compared only when both captures recorded them, and the network dimension is otherwise unknown with a reason; proven membership changes are still reported.

* refactor(hopper): interpret a caller-index miss once at the lookup (#11403)

The forward index holds observations from the examined procedures only, and relationship coverage stays unknown with the scan facts as its reason. A miss therefore adds no callers without showing there are none; the lookup now says so once instead of four optional reads defaulting at each site. The optional-fact-default baseline is now empty.

* docs(javascript): state why an omitted representation list adds no nodes

* fix(verify): count optional-fact defaults from parsed TypeScript, not comment-blanked text

The guard blanked comments with a hand-written scanner and matched a regular expression on the rest, so a default quoted in a string counted and a regular expression holding /* hid the code after it. It now walks the TypeScript syntax tree for property reads defaulted with ?? 0, ?? [] or ?? false, and reads exemption markers only from comment trivia.

* fix(verify): tokenize optional-fact defaults without a compiler and count chained defaults

* fix(verify): match whole optional-fact default expressions across calls and operators

* fix(verify): count optional-fact defaults in template substitutions and after postfix updates, and tie markers to their own expression

* refactor(verify): exempt generation and sample caps from the constant-maximum-slice guard by reason marker (#11454)

* refactor(verify): exempt generation and sample caps from the constant-maximum-slice guard by reason marker

* fix(verify): read reason markers only from real line comments

* fix(verify): read reason markers from the shared source tokenizer

* fix(verify): read a regular expression after a control head as a statement start

The shared tokenizer treated every closing parenthesis as the end of an operand,
so in `if (ready) /[/*]/.test(v)` it read `/[` as division and `/*` inside the
regex as a block comment, hiding the rest of the file from the marker-aware
guards. Parentheses are now tracked: the `)` closing an if/while/for/with head
allows a regular expression, while a call's `)` still means division.

* fix(verify): keep a keyword-named member call out of control-head detection

`policy.if(ready) / (…)` was read as an if-statement head, so the division was
taken for a regular expression and the denominator's optional-fact default was
not counted. A control keyword after `.` or `?.` is a member call.

* refactor(verify): exempt budget-arithmetic cursors and tallies by a not-an-allowance marker (#11493)

* refactor(verify): exempt budget-arithmetic cursors and tallies by a not-an-allowance marker

The budget-arithmetic guard cannot tell a scan cursor, an observed total, a
string being assembled or a tail buffer's retained length from an allowance
when each is compared with a limit. A field declaration marked
`// not-an-allowance: <reason>` (read through the shared reason-marker scan)
is no longer counted. The four remaining sites carry a marker, so the
baseline is empty and removed.

* refactor(verify): exempt detail levels, lifecycle states and domain vocabularies from the completeness-enum guard by reason marker (#11510)

A zod enum containing "complete" is counted as a local coverage vocabulary. Eleven
are not coverage: a caller-chosen detail level, how far a command or session
ran, and format states (GPU decode depth, WASM name section, SQLite column
details). They now carry `// detail-level:`, `// lifecycle-state:` or
`// domain-vocabulary:` with a reason, read through the shared reason-marker
scan (which gains an optional predicate for the matches a guard counts).
local-completeness-enum: 22 -> 11 on this branch.

* fix(verify): bind a not-an-allowance marker to its own class field

Exemptions were a file-wide set of names, so a marked tally in one class hid an
unmarked allowance with the same name in another, and a marked object property
could exempt a class field. Markers now exempt only a member declaration (at
class member depth) of the top-level class that contains it, and the named-
allowance count is taken per class so the same scoping applies to it.

* fix(artifacts): keep main's resources import in the Deno standalone reader after merging main

* fix(verify): start an expression after a template substitution and a non-member keyword, and accept any marker reason

The shared tokenizer read the `/` after `${` as division, so a regular
expression holding `/*` in a substitution hid the rest of the file from
every tokenizer-based guard, and it treated property names such as
`row.return` as keywords. Tokens now record whether template text opens a
substitution and whether a name is an expression keyword (not after `.` or
`?.`), and the regular-expression rule and the optional-fact-default operand
rule read those facts. The optional-fact-default guard reads markers through
reason-marker's isReasonMarker, so any non-empty reason exempts, as for the
other reason markers.

* fix(verify): blank comments with the shared tokenizer before matching architecture guards (#11573)

* fix(verify): blank comments with the shared tokenizer before matching architecture guards

The guards stripped comments with a regular expression that took a `/*`
inside a string, template or regular expression for a comment opener and
deleted code up to the next `*/`. src/flutter/FlutterBuildProvider.ts's
"lib/*/libapp.so" text hid four --pool-policy remediation strings from
cli-option-text-outside-cli. blankComments in source-tokens.mjs now owns
comment removal for the architecture guards and the reason-marker scan: it
blanks comment tokens in place (newlines kept) and keeps strings, templates
and regular expressions. The scan behind it retains only the last tokens it
reads, and whitespace runs are skipped at once.

The cli-option-text-outside-cli baseline records FlutterBuildProvider.ts at
its true count of 4; no other baseline changed.

Fixes #11477

* fix(verify): read a regular expression after a statement block and keep comment offsets for wide characters

The tokenizer now records whether each `{` opens a statement block or an
object literal (from the token before it) and marks the `}` that closes a
block, after which a statement, and so a regular expression, can start; an
object literal's `}` still ends an operand. blankComments replaces each run
of comment text with one space per UTF-16 unit, so a surrogate pair no longer
shifts later offsets.

* chore(verify): drop the Flutter CLI-text baseline entry now that main names no option there
2026-11-16 07:40:30 +08:00

211 lines
5.8 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { budgetArithmeticCount } from "../../scripts/verify/budget-arithmetic-guard.mjs";
it("counts arithmetic on fields named for an allowance", () => {
expect(budgetArithmeticCount("this.#remainingBytes -= size;")).toBe(1);
expect(budgetArithmeticCount("this.retained += size;")).toBe(1);
expect(budgetArithmeticCount("this.#arenaWriteOffset += size;")).toBe(0);
});
it("counts hand-checked fields inside a hand-written Budget class", () => {
const cuda = [
"export class CudaMetadataBudget {",
" #visits = 0;",
" #readBytes = 0;",
" visit(): void {",
" if (++this.#visits > 262144) throw failure();",
" }",
" read(size: number): void {",
" if (size > LIMIT - this.#readBytes) throw failure();",
" this.#readBytes += size;",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(cuda)).toBe(2);
});
it("ignores unchecked tallies and fields not compared with a limit", () => {
const tallies = [
"class ProtobufBudget {",
" async checkpoint(): Promise<void> {",
" if (++this.#work % 256 === 0) await yieldTurn();",
" this.#transient += bytes;",
" const done = () => this.#transient;",
" }",
"}",
"class Reader {",
" read(size: number): void {",
" this.#observed += size;",
" if (this.#observed > this.#previous) this.#grew = true;",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(tallies)).toBe(0);
});
it("counts a field outside Budget classes compared with a limit once", () => {
const reader = [
"class Reader {",
" read(size: number): void {",
" if (this.#bytes + size > LIMIT) throw failure();",
" this.#bytes += size;",
" }",
" key(size: number): void {",
" this.#keyBytes += size;",
" if (this.#keyBytes > this.input.max_file_bytes) throw failure();",
" this.#keyBytes += 1;",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(reader)).toBe(2);
});
it("counts the same field name separately in each class", () => {
const readers = [
"class First {",
" read(size: number): void {",
" if (this.#bytes + size > LIMIT) throw failure();",
" this.#bytes += size;",
" }",
"}",
"class SecondBudget {",
" #bytes = 0;",
" observe(size: number): void {",
" this.#bytes += size;",
" }",
"}",
"class Third {",
" read(size: number): void {",
" this.#bytes += size;",
" if (this.#bytes > LIMIT) throw failure();",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(readers)).toBe(2);
});
it.each([
"CAPACITY",
"FACT_ALLOWANCE",
"FACT_BUDGET",
"MAX_BYTES",
"byteLimit",
])("counts a field compared with %s", (limit) => {
const reader = [
"class Reader {",
" read(size: number): void {",
" this.#facts += size;",
` if (this.#facts > ${limit}) throw failure();`,
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(reader)).toBe(1);
});
describe("not-an-allowance markers", () => {
const reader = (declaration: readonly string[]) =>
[
"class Reader {",
...declaration,
" read(size: number): void {",
" this.#seen += size;",
" if (this.#seen > LIMIT) this.#cut = true;",
" this.#remainingBytes -= size;",
" }",
"}",
].join("\n");
// The marker comments hold no field arithmetic, so the raw source serves as
// the comment-stripped content too.
const count = (source: string) => budgetArithmeticCount(source, { source });
it("exempts a field whose declaration carries a reasoned marker", () => {
expect(
count(
reader([
" // not-an-allowance: observed total, compared only to report a cut.",
" #seen = 0;",
]),
),
).toBe(1);
expect(
count(
reader([
" #seen = 0; // not-an-allowance: observed total for the cut flag.",
]),
),
).toBe(1);
});
it("exempts a named allowance field only by its own marker", () => {
expect(
count(
reader([
" #seen = 0;",
" // not-an-allowance: write cursor named for history.",
" #remainingBytes = 0;",
]),
),
).toBe(1);
});
it.each([
[[" // not-an-allowance:", " #seen = 0;"]],
[[" // generation-cap: another guard's marker.", " #seen = 0;"]],
[
[
" /* not-an-allowance: block comments are not markers. */",
" #seen = 0;",
],
],
[
[
" // not-an-allowance: separated by code.",
" #other = 0;",
" #seen = 0;",
],
],
])("does not exempt %j", (declaration) => {
expect(count(reader(declaration))).toBe(2);
});
});
it("binds a marker to its own class field", () => {
const source = [
"class Tally {",
" // not-an-allowance: observed total for the truncation flag.",
" #bytes = 0;",
" read(size: number): void {",
" this.#bytes += size;",
" if (this.#bytes > LIMIT) this.#cut = true;",
" }",
"}",
"class Allowance {",
" #bytes = 0;",
" read(size: number): void {",
" this.#bytes += size;",
" if (this.#bytes > LIMIT) throw failure();",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(source, { source })).toBe(1);
});
it("does not exempt a class field through a marked object property", () => {
const source = [
"class Reader {",
" bytes = 0;",
" options(): object {",
" return {",
" // not-an-allowance: an option, not the field.",
" bytes: 0,",
" };",
" }",
" read(size: number): void {",
" this.bytes += size;",
" if (this.bytes > LIMIT) throw failure();",
" }",
"}",
].join("\n");
expect(budgetArithmeticCount(source, { source })).toBe(1);
});