mirror of
https://github.com/morluto/rea.git
synced 2026-11-07 07:16:13 +00:00
all-black-493
62c8b3da1b
* feat(browser): attach passive tools to browsers without HTTP discovery Accept a literal loopback browser WebSocket, ws://127.0.0.1:PORT/devtools/browser/ID, as the cdp_endpoint of the six passive browser tools. Discovery then reads Browser.getVersion and Target.getTargets over that socket, and the target session adopts the same socket, so a browser that asks for consent per connection prompts once per call. The socket identifier gates access, so Evidence records the endpoint as ws://127.0.0.1:PORT/devtools/browser/[REDACTED], and runtime reconciliation accepts that recorded form. HTTP endpoints and their Evidence are unchanged. Electron, web runtime, scenario and Inspector endpoints stay HTTP-only. Refs #2288 * test(browser): match browser-socket captures against HTTP discovery Check in the real Chrome lane that DevToolsActivePort names the same browser socket as /json/version, and that inspecting the selected page through that socket leaves DOM structure and scripts unchanged compared with an inspection through HTTP discovery. Refs #2288 * fix(browser): bound browser-socket handshake and report discovery timeouts Run the browser-socket WebSocket handshake and both discovery commands under one discovery deadline, so a port that accepts the connection but never completes the upgrade times out instead of waiting forever. Report a reached deadline as a timeout without carrying the internal abort as its cause, so CLI and MCP project provider_timeout rather than cancelled. Caller cancellation is still reported as cancelled. Refs #2288
84 lines
2.9 KiB
TypeScript
84 lines
2.9 KiB
TypeScript
import { createServer } from "node:http";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import { CdpBrowserProvider } from "../../../src/browser/CdpBrowserProvider.js";
|
|
import { listBrowserTargetsInputSchema } from "../../../src/domain/browserObservation.js";
|
|
|
|
describe("CDP target inventory", () => {
|
|
it("returns every allowed target within the bounded discovery payload", async () => {
|
|
let port = 0;
|
|
const targets = Array.from({ length: 1_101 }, (_, index) => {
|
|
const id = `target-${String(index).padStart(4, "0")}`;
|
|
return {
|
|
id,
|
|
type: "page",
|
|
title: `Page ${String(index)}`,
|
|
url: `https://allowed.example/page/${String(index)}`,
|
|
...(index === 0 ? {} : { attached: index === 1 ? false : true }),
|
|
webSocketDebuggerUrl: `ws://127.0.0.1:${String(port)}/devtools/page/${id}`,
|
|
};
|
|
});
|
|
const server = createServer((request, response) => {
|
|
response.setHeader("content-type", "application/json");
|
|
if (request.url === "/json/version") {
|
|
response.end(
|
|
JSON.stringify({
|
|
Browser: "Chrome/1",
|
|
"Protocol-Version": "1.3",
|
|
"User-Agent": "Chrome",
|
|
"V8-Version": "1",
|
|
"WebKit-Version": "1",
|
|
webSocketDebuggerUrl: `ws://127.0.0.1:${String(port)}/devtools/browser/browser`,
|
|
}),
|
|
);
|
|
return;
|
|
}
|
|
if (request.url === "/json/list") {
|
|
response.end(JSON.stringify(targets));
|
|
return;
|
|
}
|
|
response.writeHead(404).end();
|
|
});
|
|
|
|
try {
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.once("error", reject);
|
|
server.listen(0, "127.0.0.1", resolve);
|
|
});
|
|
const address = server.address();
|
|
if (address === null || typeof address === "string")
|
|
throw new TypeError("Expected a TCP listener address");
|
|
port = address.port;
|
|
const endpoint = `http://127.0.0.1:${String(port)}`;
|
|
|
|
const result = await new CdpBrowserProvider().listTargets(
|
|
listBrowserTargetsInputSchema.parse({
|
|
cdp_endpoint: endpoint,
|
|
allowed_origins: ["https://allowed.example"],
|
|
}),
|
|
);
|
|
|
|
if (!result.ok) throw result.error;
|
|
expect(result.value.targets).toHaveLength(targets.length);
|
|
expect(result.value.targets[0]?.target_id).toBe("target-0000");
|
|
expect(result.value.targets.at(-1)?.target_id).toBe("target-1100");
|
|
expect(
|
|
result.value.targets.slice(0, 3).map(({ attached }) => attached),
|
|
).toEqual([null, false, true]);
|
|
expect(
|
|
result.value.limitations.some((item) =>
|
|
item.includes("attachment state"),
|
|
),
|
|
).toBe(true);
|
|
} finally {
|
|
if (server.listening)
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.close((error) =>
|
|
error === undefined ? resolve() : reject(error),
|
|
);
|
|
});
|
|
}
|
|
});
|
|
});
|